Skip to content

Support create materialized view with bitmap or hll - #3651

Merged
EmmyMiao87 merged 2 commits into
apache:masterfrom
HangyuanLiu:create_mv
May 25, 2020
Merged

Support create materialized view with bitmap or hll#3651
EmmyMiao87 merged 2 commits into
apache:masterfrom
HangyuanLiu:create_mv

Conversation

@HangyuanLiu

@HangyuanLiuHangyuanLiu commented May 21, 2020

Copy link
Copy Markdown
Contributor

For #3344

@HangyuanLiu

HangyuanLiu commented May 21, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

For Review , add UT later

@HangyuanLiuHangyuanLiu self-assigned this May 21, 2020
@HangyuanLiuHangyuanLiu added area/materialized-view Issues or PRs related to materialized view kind/feature Categorizes issue or PR as related to a new feature. labels May 21, 2020
morningman
morningman requested changes May 21, 2020
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And by the way, when the bitmap and hll types are not yet supported on the BE side, should these new operations be prohibited first?

Comment threadfe/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java Outdated
Comment threadfe/src/main/java/org/apache/doris/analysis/CreateMaterializedViewStmt.java
Comment threadfe/src/main/java/org/apache/doris/catalog/Column.java Outdated
Comment threadfe/src/main/java/org/apache/doris/catalog/Column.java Outdated
Comment threadfe/src/main/java/org/apache/doris/catalog/Column.java Outdated
Comment threadfe/src/main/java/org/apache/doris/analysis/CreateMaterializedViewStmt.java Outdated
Preconditions.checkState(functionCallExpr.getChildren().size() == 1);
Expr functionChild0 = functionCallExpr.getChild(0);

if (functionName.equalsIgnoreCase("bitmap_union") || functionName.equalsIgnoreCase("hll_union")) {

@morningmanmorningmanMay 21, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need an extensible framework to handle the expression part of the materialized view more elegantly, rather than simply judging a few functions.
This can prepare for more complex expressions later.

@HangyuanLiuHangyuanLiuMay 22, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you. But schema change and expression compute logical is non-universal. so we can only support few function now.

EmmyMiao87
EmmyMiao87 requested changes May 22, 2020
View reviewed changes
Comment threadfe/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java
} else {
throw new DdlException("The define expr of column is only support bitmap_union or hll_union");
}
newMVColumn.setIsKey(false);

@EmmyMiao87EmmyMiao87May 22, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The isKey has been set.

@HangyuanLiuHangyuanLiuMay 22, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the aggregate function is computed for the original column, it should be not key whether the original column is a key column or a value column

Comment threadfe/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java Outdated
Comment threadfe/src/main/java/org/apache/doris/analysis/CreateMaterializedViewStmt.java Outdated
Comment threadfe/src/main/java/org/apache/doris/analysis/CreateMaterializedViewStmt.java Outdated
Comment threadfe/src/main/java/org/apache/doris/catalog/Column.java Outdated
Comment threadfe/src/main/java/org/apache/doris/catalog/Column.java Outdated
Comment threadfe/src/main/java/org/apache/doris/catalog/Column.java Outdated
Comment threadfe/src/main/java/org/apache/doris/common/FeMetaVersion.java Outdated
@EmmyMiao87

EmmyMiao87 commented May 22, 2020

Copy link
Copy Markdown
Contributor

The commit msg is too short.

morningman
morningman approved these changes May 25, 2020
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EmmyMiao87EmmyMiao87 linked an issue May 25, 2020 that may be closed by this pull request
[Proposal] Materialized View 2.0 #3344
Closed
@EmmyMiao87
EmmyMiao87 merged commit 2608f83 into apache:masterMay 25, 2020
@EmmyMiao87EmmyMiao87 mentioned this pull request Sep 1, 2020
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningmanmorningmanmorningman approved these changes
@EmmyMiao87EmmyMiao87EmmyMiao87 approved these changes

Assignees

@HangyuanLiuHangyuanLiu

Labels

area/materialized-viewIssues or PRs related to materialized viewkind/featureCategorizes issue or PR as related to a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Proposal] Materialized View 2.0

3 participants

@HangyuanLiu@EmmyMiao87@morningman