Skip to content

Modify hll_hash function return type to HLL - #3656

Merged
imay merged 2 commits into
apache:masterfrom
HangyuanLiu:hll_union
May 24, 2020
Merged

Modify hll_hash function return type to HLL#3656
imay merged 2 commits into
apache:masterfrom
HangyuanLiu:hll_union

Conversation

@HangyuanLiu

Copy link
Copy Markdown
Contributor

1、Modify hll_hash function return type to HLL
2、Make HLL_RAW_AGG is alias of HLL_UNION
For #3652

@imayimay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imayimay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fail to compile BE, you should make this script work when there is HLL type

@HangyuanLiuHangyuanLiu self-assigned this May 22, 2020
@HangyuanLiuHangyuanLiu added area/sql/function Issues or PRs related to the SQL functions kind/feature Categorizes issue or PR as related to a new feature. labels May 22, 2020

@imayimay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imayimay added the approved Indicates a PR has been approved by one committer. label May 23, 2020
@imay
imay merged commit 838c1e9 into apache:masterMay 24, 2020
@HangyuanLiu
HangyuanLiu deleted the hll_union branch May 30, 2020 12:53
BiteTheDDDDt pushed a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Feb 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.area/sql/functionIssues or PRs related to the SQL functionskind/featureCategorizes issue or PR as related to a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@HangyuanLiu@imay