Skip to content

[fix] (regression test) Fix unstable regression test - #36563

Merged
qidaye merged 8 commits into
apache:masterfrom
csun5285:fix_compaction_test
Aug 5, 2024
Merged

[fix] (regression test) Fix unstable regression test#36563
qidaye merged 8 commits into
apache:masterfrom
csun5285:fix_compaction_test

Conversation

@csun5285

@csun5285csun5285 commented Jun 19, 2024

Copy link
Copy Markdown
Contributor

Proposed changes

  1. Fix BUG, when multiple cases concurrently modify the BE config 'disable_auto_compaction' to false, then true, and back to false.
  2. remove unused code.
  3. fix unstable single compaction test

Issue Number: close #xxx

@doris-robot

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@csun5285

Copy link
Copy Markdown
ContributorAuthor

run buildall

airborne12
airborne12 previously approved these changes Jun 20, 2024

@airborne12airborne12 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jun 20, 2024
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@csun5285

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Jun 20, 2024
@csun5285
csun5285force-pushed the fix_compaction_test branch from 5d3b3fb to 5bfecc3CompareJuly 18, 2024 15:23
@csun5285

Copy link
Copy Markdown
ContributorAuthor

run buildall

@csun5285csun5285 changed the title [fix] (regression test) Fix the errors caused by changing the BE config: disable_auto_compaction[fix] (regression test) Fix unstable regression testJul 18, 2024
@csun5285

Copy link
Copy Markdown
ContributorAuthor

run buildall

@csun5285

Copy link
Copy Markdown
ContributorAuthor

run buildall

@airborne12airborne12 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 5, 2024
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@qidaye
qidaye merged commit 1190ae2 into apache:masterAug 5, 2024
dataroaring pushed a commit that referenced this pull request Aug 8, 2024
## Proposed changes
1. Fix BUG, when multiple cases concurrently modify the BE config
'disable_auto_compaction' to false, then true, and back to false.
2. remove unused code.
3. fix fault injection
airborne12 pushed a commit that referenced this pull request Aug 9, 2024
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
## Proposed changes
1. Fix BUG, when multiple cases concurrently modify the BE config
'disable_auto_compaction' to false, then true, and back to false.
2. remove unused code.
3. fix fault injection
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.6-mergeddev/3.0.1-mergedreviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@csun5285@doris-robot@airborne12@qidaye@dataroaring