Skip to content

[Fix] Fix typos in class name - #36663

Merged
wangbo merged 1 commit into
apache:masterfrom
wangbo:0621_fix_typo
Jun 24, 2024
Merged

[Fix] Fix typos in class name#36663
wangbo merged 1 commit into
apache:masterfrom
wangbo:0621_fix_typo

Conversation

@wangbo

@wangbowangbo commented Jun 21, 2024

Copy link
Copy Markdown
Contributor

Proposed changes

1 Fix typos in class name.
2 use correct return Status.

@doris-robot

doris-robot commented Jun 21, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@wangbo

wangbo commented Jun 21, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

BiteTheDDDDt
BiteTheDDDDt previously approved these changes Jun 21, 2024
View reviewed changes
@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jun 21, 2024
@github-actions

github-actionsBot commented Jun 21, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Jun 21, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@wangbo
1 fix class name typo
42afd2f
2 use correct return status
@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Jun 21, 2024
github-actions[bot]
github-actionsBot reviewed Jun 21, 2024
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadbe/src/runtime/runtime_query_statistics_mgr.cpp
}

void RuntimeQueryStatiticsMgr::report_runtime_query_statistics() {
void RuntimeQueryStatisticsMgr::report_runtime_query_statistics() {

@github-actionsgithub-actionsBotJun 21, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: function 'report_runtime_query_statistics' exceeds recommended size/complexity thresholds [readability-function-size]

voidRuntimeQueryStatisticsMgr::report_runtime_query_statistics() {
^
Additional context

be/src/runtime/runtime_query_statistics_mgr.cpp:341: 117 lines including whitespace and comments (threshold 80)

voidRuntimeQueryStatisticsMgr::report_runtime_query_statistics() {
^

HappenLee
HappenLee approved these changes Jun 21, 2024
View reviewed changes

@HappenLeeHappenLee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangbo

wangbo commented Jun 21, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Jun 21, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jun 21, 2024
@doris-robot

doris-robot commented Jun 21, 2024

Copy link
Copy Markdown
TPC-H: Total hot run time: 39864 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 42afd2f9e25a901487d9a5eb7a3c1c99109ce741, data reload: false
------ Round 1 ----------------------------------
q1	17608	4387	4290	4290
q2	2020	188	195	188
q3	10465	1160	1171	1160
q4	10194	792	732	732
q5	7454	2679	2645	2645
q6	221	134	134	134
q7	993	604	601	601
q8	9209	2089	2075	2075
q9	8802	6464	6502	6464
q10	8905	3700	3740	3700
q11	477	244	234	234
q12	506	237	226	226
q13	17983	2992	2987	2987
q14	260	210	210	210
q15	517	466	468	466
q16	512	390	390	390
q17	985	617	726	617
q18	8188	7456	7449	7449
q19	3786	1481	1443	1443
q20	655	311	328	311
q21	4982	3197	3202	3197
q22	395	345	350	345
Total cold run time: 115117 ms
Total hot run time: 39864 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4394	4239	4245	4239
q2	384	293	269	269
q3	2971	2696	2864	2696
q4	2004	1690	1726	1690
q5	5600	5555	5584	5555
q6	228	130	135	130
q7	2194	1802	1860	1802
q8	3300	3454	3410	3410
q9	8705	8723	8866	8723
q10	4032	3939	3712	3712
q11	585	493	485	485
q12	788	665	661	661
q13	16976	3165	3211	3165
q14	305	271	263	263
q15	539	480	498	480
q16	482	431	427	427
q17	1820	1498	1468	1468
q18	7986	8043	7777	7777
q19	1856	1663	1628	1628
q20	3054	1914	1894	1894
q21	5125	4966	4865	4865
q22	650	571	575	571
Total cold run time: 73978 ms
Total hot run time: 55910 ms

@doris-robot

doris-robot commented Jun 21, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.47% (9008/24699)
Line Coverage: 28.02% (73892/263736)
Region Coverage: 27.50% (38385/139592)
Branch Coverage: 24.19% (19564/80860)
Coverage Report: http://coverage.selectdb-in.cc/coverage/42afd2f9e25a901487d9a5eb7a3c1c99109ce741_42afd2f9e25a901487d9a5eb7a3c1c99109ce741/report/index.html

@doris-robot

doris-robot commented Jun 21, 2024

Copy link
Copy Markdown
TPC-DS: Total hot run time: 171308 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 42afd2f9e25a901487d9a5eb7a3c1c99109ce741, data reload: false
query1	948	383	375	375
query2	6606	2352	2467	2352
query3	6638	203	214	203
query4	19416	17592	17545	17545
query5	3596	465	461	461
query6	242	156	156	156
query7	4589	309	292	292
query8	317	302	280	280
query9	8508	2428	2393	2393
query10	588	278	300	278
query11	10745	10197	10165	10165
query12	116	83	89	83
query13	1639	356	355	355
query14	9627	6775	7188	6775
query15	225	191	187	187
query16	7259	262	254	254
query17	1499	535	514	514
query18	1907	279	271	271
query19	195	159	159	159
query20	95	85	84	84
query21	213	130	127	127
query22	4445	4173	4270	4173
query23	33798	33739	33758	33739
query24	11323	2875	2873	2873
query25	634	420	368	368
query26	1199	156	153	153
query27	2471	327	321	321
query28	7288	2174	2180	2174
query29	947	653	623	623
query30	262	165	160	160
query31	975	799	758	758
query32	98	55	54	54
query33	770	284	281	281
query34	1090	497	503	497
query35	754	644	643	643
query36	1150	988	987	987
query37	170	77	76	76
query38	2915	2799	2820	2799
query39	880	799	804	799
query40	209	133	128	128
query41	56	54	55	54
query42	108	103	109	103
query43	607	543	539	539
query44	1171	728	730	728
query45	195	167	162	162
query46	1065	699	703	699
query47	1888	1782	1744	1744
query48	388	308	293	293
query49	847	389	390	389
query50	760	379	386	379
query51	6971	6818	6798	6798
query52	101	91	91	91
query53	358	287	293	287
query54	872	453	432	432
query55	72	71	72	71
query56	292	260	257	257
query57	1140	1045	1085	1045
query58	259	228	242	228
query59	3394	3078	3235	3078
query60	306	266	280	266
query61	117	118	116	116
query62	598	460	452	452
query63	318	290	291	290
query64	8906	2263	1751	1751
query65	3198	3094	3057	3057
query66	788	324	325	324
query67	15514	14934	15047	14934
query68	4534	530	521	521
query69	515	383	345	345
query70	1118	1150	1116	1116
query71	381	268	263	263
query72	7056	5604	2759	2759
query73	736	316	314	314
query74	5899	5459	5448	5448
query75	3329	2632	2648	2632
query76	2418	925	890	890
query77	456	294	286	286
query78	10640	9845	9768	9768
query79	1711	515	504	504
query80	2439	465	454	454
query81	573	215	223	215
query82	1054	100	100	100
query83	320	165	162	162
query84	262	87	84	84
query85	1122	285	270	270
query86	391	317	294	294
query87	3251	3059	3095	3059
query88	2994	2356	2338	2338
query89	483	376	368	368
query90	1665	182	180	180
query91	127	100	99	99
query92	57	48	50	48
query93	1428	500	494	494
query94	1054	191	186	186
query95	392	311	314	311
query96	578	262	264	262
query97	3249	3033	3079	3033
query98	219	213	192	192
query99	1211	864	831	831
Total cold run time: 268297 ms
Total hot run time: 171308 ms

@doris-robot

doris-robot commented Jun 21, 2024

Copy link
Copy Markdown
ClickBench: Total hot run time: 30.3 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 42afd2f9e25a901487d9a5eb7a3c1c99109ce741, data reload: false
query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.66	0.08	0.09
query5	0.49	0.47	0.48
query6	1.12	0.73	0.73
query7	0.02	0.02	0.01
query8	0.05	0.05	0.04
query9	0.55	0.50	0.49
query10	0.54	0.53	0.53
query11	0.16	0.11	0.11
query12	0.14	0.12	0.11
query13	0.60	0.58	0.61
query14	0.82	0.78	0.76
query15	0.84	0.80	0.80
query16	0.36	0.37	0.38
query17	0.93	0.94	0.99
query18	0.22	0.24	0.24
query19	1.81	1.72	1.72
query20	0.01	0.01	0.01
query21	15.41	0.66	0.66
query22	3.87	7.85	1.73
query23	18.25	1.31	1.20
query24	2.00	0.26	0.23
query25	0.15	0.08	0.08
query26	0.28	0.17	0.18
query27	0.08	0.08	0.07
query28	13.24	1.03	1.00
query29	12.63	3.32	3.30
query30	0.26	0.07	0.05
query31	2.85	0.38	0.38
query32	3.26	0.47	0.46
query33	2.86	2.91	2.92
query34	16.91	4.40	4.41
query35	4.53	4.47	4.50
query36	0.66	0.46	0.46
query37	0.20	0.15	0.16
query38	0.16	0.15	0.15
query39	0.04	0.04	0.04
query40	0.17	0.15	0.14
query41	0.10	0.06	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 108.69 s
Total hot run time: 30.3 s

xinyiZzz
xinyiZzz approved these changes Jun 24, 2024
View reviewed changes

@xinyiZzzxinyiZzz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangbo
wangbo merged commit fc1e51f into apache:masterJun 24, 2024
dataroaring pushed a commit that referenced this pull request Jun 26, 2024
@wangbo@dataroaring
[Fix] Fix typos in class name (#36663)
70d6020
## Proposed changes
1 Fix typos in class name.
2 use correct return Status.
wangbo added a commit to wangbo/incubator-doris that referenced this pull request Oct 25, 2024
@wangbo
[Fix] Fix typos in class name (apache#36663)
b31f120
1 Fix typos in class name.
2 use correct return Status.
wangbo added a commit to wangbo/incubator-doris that referenced this pull request Oct 25, 2024
@wangbo
[Fix] Fix typos in class name (apache#36663)
dc1da65
1 Fix typos in class name.
2 use correct return Status.
wangbo added a commit to wangbo/incubator-doris that referenced this pull request Oct 25, 2024
@wangbo
[Fix] Fix typos in class name (apache#36663)
824d4a5
1 Fix typos in class name.
2 use correct return Status.
@wangbowangbo mentioned this pull request Oct 25, 2024
Merged
yiguolei pushed a commit that referenced this pull request Oct 25, 2024
@wangbo
[pick]support cgroup v2 (#42465)
9eef393
## Proposed changes
pick #39991#39374#36663
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@wangbo@HappenLee
[Fix] Fix typos in class name (apache#36663)
02a1b18
## Proposed changes
1 Fix typos in class name.
2 use correct return Status.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments
@HappenLeeHappenLeeHappenLee approved these changes
@xinyiZzzxinyiZzzxinyiZzz approved these changes
@BiteTheDDDDtBiteTheDDDDtBiteTheDDDDt left review comments

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.7-mergeddev/3.0.0-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@wangbo@doris-robot@BiteTheDDDDt@HappenLee@xinyiZzz@wm1581066@dataroaring