Skip to content

[Bug] Fix bug that runningTxnNum does not equal to the real running txn num - #3674

Merged
morningman merged 1 commit into
apache:masterfrom
morningman:running_txn_bug
May 25, 2020
Merged

[Bug] Fix bug that runningTxnNum does not equal to the real running txn num#3674
morningman merged 1 commit into
apache:masterfrom
morningman:running_txn_bug

Conversation

@morningman

@morningmanmorningman commented May 23, 2020

Copy link
Copy Markdown
Contributor

This is because the logic for modifying the number of txn running is wrong.

Because we did not persist the previous status(preStatus) of a transaction.
Therefore, when replaying the metadata log, we cannot decide whether to modify
the runningTxnNum value based on preStatus. This info is lost.

Fix#3673

…xn num.
This is because the logic for modifying the number of things running is wrong.
Because we did not persist the previous status(preStatus) of a transaction.
Therefore, when replaying the metadata log, we cannot decide whether to modify
the `runningTxnNum` value based on `preStatus`. This info is lost.
@morningmanmorningman added kind/fix Categorizes issue or PR as related to a bug. area/load Issues or PRs related to all kinds of load labels May 23, 2020
@morningmanmorningman self-assigned this May 23, 2020

@kangkaisenkangkaisen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@morningmanmorningman added the approved Indicates a PR has been approved by one committer. label May 25, 2020
@morningman
morningman merged commit ec955b8 into apache:masterMay 25, 2020
acelyc111 pushed a commit to acelyc111/incubator-doris that referenced this pull request Jan 20, 2021
…xn num. (apache#3674)
This is because the logic for modifying the number of things running is wrong.
Because we did not persist the previous status(preStatus) of a transaction.
Therefore, when replaying the metadata log, we cannot decide whether to modify
the `runningTxnNum` value based on `preStatus`. This info is lost.
BiteTheDDDDt pushed a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Feb 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.area/loadIssues or PRs related to all kinds of loadkind/fixCategorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] running txn number does not equals to the real running txn number.

2 participants

@morningman@kangkaisen