Skip to content

[fix](mtmv) Fix union rewrite by materialized view regression test instability - #36770

Merged
morrySnow merged 1 commit into
apache:masterfrom
seawinde:fix_union_regression_test_hit_random
Jun 25, 2024
Merged

[fix](mtmv) Fix union rewrite by materialized view regression test instability#36770
morrySnow merged 1 commit into
apache:masterfrom
seawinde:fix_union_regression_test_hit_random

Conversation

@seawinde

Copy link
Copy Markdown
Member

Proposed changes

When union rewrite by materialized view, the final plan chosen by CBO is instability.
So the regression test only check mv is rewritten successful or not, doesn't check is chosen by CBO or not.
Optimize to make sure chosen by CBO would be anther pr to fix this thoroughly。

@doris-robot

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@seawinde

Copy link
Copy Markdown
MemberAuthor

run buildall

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jun 24, 2024
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@zfr9527zfr9527 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morrySnow
morrySnow merged commit 19e2126 into apache:masterJun 25, 2024
dataroaring pushed a commit that referenced this pull request Jun 26, 2024
…stability (#36770)
When union rewrite by materialized view, the final plan chosen by CBO is
instability.
So the regression test only check mv is rewritten successful or not,
doesn't check is chosen by CBO or not.
Optimize to make sure chosen by CBO would be anther pr to fix this
thoroughly。
seawinde added a commit to seawinde/doris that referenced this pull request Jul 11, 2024
…stability (apache#36770)
When union rewrite by materialized view, the final plan chosen by CBO is
instability.
So the regression test only check mv is rewritten successful or not,
doesn't check is chosen by CBO or not.
Optimize to make sure chosen by CBO would be anther pr to fix this
thoroughly。
morrySnow pushed a commit that referenced this pull request Jul 12, 2024
cherry-pick from master
pr: #36318
commitId: c199947
pr: #36111
commitId: 35ebef6
pr: #36175
commitId: 4c8e66b
pr: #36414
commitId: 5e009b5
pr: #36770
commitId: 19e2126
pr: #36567
commitId: 3da8351
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
…stability (apache#36770)
When union rewrite by materialized view, the final plan chosen by CBO is
instability.
So the regression test only check mv is rewritten successful or not,
doesn't check is chosen by CBO or not.
Optimize to make sure chosen by CBO would be anther pr to fix this
thoroughly。
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.5-mergeddev/3.0.0-mergedreviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@seawinde@doris-robot@zfr9527@morrySnow@dataroaring