Uh oh!
There was an error while loading. Please reload this page.
[feat](job)Internal job cancellation immediately and the strong association with the STARTS parameter - #36805
Conversation
doris-robot
commented
Jun 25, 2024
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
…iation with the STARTS parameter For internal tasks, such as MTMV, the start time may already be set, or the time may be adjusted immediately.
082863c to
d298cb4CompareCalvinKirs
commented
Jun 26, 2024
run buildall |
doris-robot
commented
Jun 26, 2024
TPC-H: Total hot run time: 40447 ms |
doris-robot
commented
Jun 26, 2024
TPC-DS: Total hot run time: 174849 ms |
doris-robot
commented
Jun 26, 2024
ClickBench: Total hot run time: 30.7 s |
| if (startsTimeStamp.equalsIgnoreCase(CURRENT_TIMESTAMP_STRING)) { | ||
| jobExecutionConfiguration.setImmediate(true); | ||
| //To avoid immediate re-scheduling, set the start time of the timer 100ms before the current time. | ||
| timerDefinition.setStartTimeMs(System.currentTimeMillis() - 100L); |
There was a problem hiding this comment.
what will happen if not set startTimemMs?
There was a problem hiding this comment.
The syntax for Create Job doesn't immediately schedule the job. For a one-time schedule, setting the start time to CURRENT_TIMESTAMP achieves immediate scheduling. Therefore, we still need to set the startTime parameter; otherwise, the job query will lack a start time.
| schedulerInstantJob(job, TaskType.SCHEDULED, null); | ||
| } | ||
| } | ||
| if (job.getJobConfig().isImmediate() && JobExecuteType.ONE_TIME.equals(job.getJobConfig().getExecuteType())) { |
There was a problem hiding this comment.
why JobExecuteType == ONE_TIME ,can not setLatestSchedulerTimeMs(System.currentTimeMillis())?
There was a problem hiding this comment.
This variable is not persistent, so for a one-time, immediately scheduled task, there's no need to set it.
PR approved by anyone and no changes requested. |
CalvinKirs
commented
Jun 27, 2024
run buildall |
doris-robot
commented
Jun 27, 2024
TPC-H: Total hot run time: 40034 ms |
doris-robot
commented
Jun 27, 2024
TPC-DS: Total hot run time: 173127 ms |
doris-robot
commented
Jun 27, 2024
ClickBench: Total hot run time: 30.48 s |
CalvinKirs
commented
Jul 1, 2024
run buildall |
doris-robot
commented
Jul 1, 2024
TPC-H: Total hot run time: 39467 ms |
doris-robot
commented
Jul 1, 2024
TPC-DS: Total hot run time: 173614 ms |
doris-robot
commented
Jul 1, 2024
ClickBench: Total hot run time: 30.55 s |
CalvinKirs
commented
Jul 2, 2024
run buildall |
doris-robot
commented
Jul 2, 2024
TPC-H: Total hot run time: 39815 ms |
doris-robot
commented
Jul 2, 2024
TPC-DS: Total hot run time: 173584 ms |
doris-robot
commented
Jul 2, 2024
ClickBench: Total hot run time: 31.26 s |
CalvinKirs
commented
Jul 3, 2024
run external |
PR approved by at least one committer and no changes requested. |
…iation with the STARTS parameter (#36805) ## Proposed changes For internal tasks, such as MTMV, the start time may already be set, or the time may be adjusted immediately. <!--Describe your changes.-->
…iation with the STARTS parameter (apache#36805) ## Proposed changes For internal tasks, such as MTMV, the start time may already be set, or the time may be adjusted immediately. <!--Describe your changes.--> (cherry picked from commit 904a6c0)
…iation with the STARTS parameter (apache#36805) ## Proposed changes For internal tasks, such as MTMV, the start time may already be set, or the time may be adjusted immediately. <!--Describe your changes.--> (cherry picked from commit 904a6c0)
extends: #36805 Previously, if the user set immediate execution, the current time would replace the user's set start time
extends: apache#36805 Previously, if the user set immediate execution, the current time would replace the user's set start time
…iation with the STARTS parameter (#36805) (#38110) … ## Proposed changes For internal tasks, such as MTMV, the start time may already be set, or the time may be adjusted immediately. <!--Describe your changes.--> (cherry picked from commit 904a6c0) ## Proposed changes Issue Number: close#36805 <!--Describe your changes.-->
extends: #36805 Previously, if the user set immediate execution, the current time would replace the user's set start time
…iation with the STARTS parameter (apache#36805) ## Proposed changes For internal tasks, such as MTMV, the start time may already be set, or the time may be adjusted immediately. <!--Describe your changes.-->
extends: apache#36805 Previously, if the user set immediate execution, the current time would replace the user's set start time
Proposed changes
For internal tasks, such as MTMV, the start time may already be set, or the time may be adjusted immediately.