Uh oh!
There was an error while loading. Please reload this page.
[chore][fe] Get meta returns dropped partitions in binlog manager - #37196
Merged
Conversation
w41ter
requested review from
CalvinKirs, dataroaring and morningman
as code ownersJuly 3, 2024 03:51
doris-robot
commented
Jul 3, 2024
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
w41ter
commented
Jul 3, 2024
ContributorAuthor
run buildall |
w41terforce-pushed
the
filter_drop_partitions
branch
from
July 3, 2024 03:55
7ffe8b4 to
8419362Comparew41ter
commented
Jul 3, 2024
ContributorAuthor
run buildall |
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
doris-robot
commented
Jul 3, 2024
TPC-H: Total hot run time: 39966 ms |
doris-robot
commented
Jul 3, 2024
TPC-DS: Total hot run time: 175063 ms |
doris-robot
commented
Jul 3, 2024
ClickBench: Total hot run time: 30.53 s |
w41terforce-pushed
the
filter_drop_partitions
branch
from
July 3, 2024 06:21
8419362 to
6078596Comparew41ter
commented
Jul 3, 2024
ContributorAuthor
run buildall |
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
doris-robot
commented
Jul 3, 2024
TPC-H: Total hot run time: 40823 ms |
doris-robot
commented
Jul 3, 2024
TPC-DS: Total hot run time: 174373 ms |
doris-robot
commented
Jul 3, 2024
ClickBench: Total hot run time: 30.88 s |
w41terforce-pushed
the
filter_drop_partitions
branch
from
July 3, 2024 11:41
6078596 to
1cc6ecaComparew41ter
commented
Jul 3, 2024
ContributorAuthor
run buildall |
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
doris-robot
commented
Jul 3, 2024
TPC-H: Total hot run time: 40051 ms |
doris-robot
commented
Jul 3, 2024
TPC-DS: Total hot run time: 173604 ms |
doris-robot
commented
Jul 3, 2024
ClickBench: Total hot run time: 30.14 s |
Contributor
PR approved by at least one committer and no changes requested. |
dataroaring pushed a commit
that referenced
this pull request
Jul 5, 2024
This branch was missed in the PR #37196
dataroaring pushed a commit
that referenced
this pull request
Jul 15, 2024
This branch was missed in the PR #37196
dataroaring pushed a commit
that referenced
this pull request
Jul 17, 2024
The CCR syncer needs to know the distribution of tables, partitions, indexes, and replicas when synchronizing binlogs. If a partition is deleted before the binlog synchronization is complete, the CCR syncer cannot continue synchronizing. This PR will record the deleted partitions and include them in the get meta response, allowing the CCR syncer to filter out the binlogs that belong to these partitions. The CCR syncer part PR is selectdb/ccr-syncer#117.
dataroaring pushed a commit
that referenced
this pull request
Jul 17, 2024
This branch was missed in the PR #37196
w41ter added a commit
to w41ter/incubator-doris
that referenced
this pull request
Jul 18, 2024
Cherry-pick apache#37196. The CCR syncer needs to know the distribution of tables, partitions, indexes, and replicas when synchronizing binlogs. If a partition is deleted before the binlog synchronization is complete, the CCR syncer cannot continue synchronizing. This PR will record the deleted partitions and include them in the get meta response, allowing the CCR syncer to filter out the binlogs that belong to these partitions. The CCR syncer part PR is selectdb/ccr-syncer#117.
w41ter added a commit
to w41ter/incubator-doris
that referenced
this pull request
Jul 18, 2024
Cherry-pick apache#37196. The CCR syncer needs to know the distribution of tables, partitions, indexes, and replicas when synchronizing binlogs. If a partition is deleted before the binlog synchronization is complete, the CCR syncer cannot continue synchronizing. This PR will record the deleted partitions and include them in the get meta response, allowing the CCR syncer to filter out the binlogs that belong to these partitions. The CCR syncer part PR is selectdb/ccr-syncer#117.
w41ter added a commit
to w41ter/incubator-doris
that referenced
this pull request
Jul 18, 2024
Cherry-pick apache#37196. The CCR syncer needs to know the distribution of tables, partitions, indexes, and replicas when synchronizing binlogs. If a partition is deleted before the binlog synchronization is complete, the CCR syncer cannot continue synchronizing. This PR will record the deleted partitions and include them in the get meta response, allowing the CCR syncer to filter out the binlogs that belong to these partitions. The CCR syncer part PR is selectdb/ccr-syncer#117.
dataroaring pushed a commit
that referenced
this pull request
Jul 18, 2024
Cherry-pick #37196, #37326. The CCR syncer needs to know the distribution of tables, partitions, indexes, and replicas when synchronizing binlogs. If a partition is deleted before the binlog synchronization is complete, the CCR syncer cannot continue synchronizing. This PR will record the deleted partitions and include them in the get meta response, allowing the CCR syncer to filter out the binlogs that belong to these partitions. The CCR syncer part PR is selectdb/ccr-syncer#117.
dataroaring pushed a commit
that referenced
this pull request
Jul 18, 2024
Cherry-pick #37196, #37326. The CCR syncer needs to know the distribution of tables, partitions, indexes, and replicas when synchronizing binlogs. If a partition is deleted before the binlog synchronization is complete, the CCR syncer cannot continue synchronizing. This PR will record the deleted partitions and include them in the get meta response, allowing the CCR syncer to filter out the binlogs that belong to these partitions. The CCR syncer part PR is selectdb/ccr-syncer#117.
mongo360 pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
Cherry-pick apache#37196, apache#37326. The CCR syncer needs to know the distribution of tables, partitions, indexes, and replicas when synchronizing binlogs. If a partition is deleted before the binlog synchronization is complete, the CCR syncer cannot continue synchronizing. This PR will record the deleted partitions and include them in the get meta response, allowing the CCR syncer to filter out the binlogs that belong to these partitions. The CCR syncer part PR is selectdb/ccr-syncer#117.
w41ter added a commit
to w41ter/incubator-doris
that referenced
this pull request
Aug 26, 2024
The field partition ID of DropPartitionInfo was added in PR: apache#37196, the old version doesn't contain this field so it will be null.
w41ter added a commit
to w41ter/incubator-doris
that referenced
this pull request
Aug 26, 2024
The field partition ID of DropPartitionInfo was added in PR: apache#37196, the old version doesn't contain this field so it will be null.
w41ter added a commit
to w41ter/incubator-doris
that referenced
this pull request
Aug 26, 2024
The field partition ID of DropPartitionInfo was added in PR: apache#37196, the old version doesn't contain this field so it will be null.
dataroaring pushed a commit
that referenced
this pull request
Aug 26, 2024
The field partition ID of DropPartitionInfo was added in PR: #37196, the old version doesn't contain this field so it will be null.
w41ter added a commit
that referenced
this pull request
Aug 26, 2024
w41ter added a commit
that referenced
this pull request
Aug 26, 2024
dataroaring pushed a commit
that referenced
this pull request
Aug 26, 2024
The field partition ID of DropPartitionInfo was added in PR: #37196, the old version doesn't contain this field so it will be null.
HappenLee pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
The CCR syncer needs to know the distribution of tables, partitions, indexes, and replicas when synchronizing binlogs. If a partition is deleted before the binlog synchronization is complete, the CCR syncer cannot continue synchronizing. This PR will record the deleted partitions and include them in the get meta response, allowing the CCR syncer to filter out the binlogs that belong to these partitions. The CCR syncer part PR is selectdb/ccr-syncer#117.
HappenLee pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
…he#37326) This branch was missed in the PR apache#37196
HappenLee pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
The field partition ID of DropPartitionInfo was added in PR: apache#37196, the old version doesn't contain this field so it will be null.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CCR syncer needs to know the distribution of tables, partitions, indexes, and replicas when synchronizing binlogs. If a partition is deleted before the binlog synchronization is complete, the CCR syncer cannot continue synchronizing. This PR will record the deleted partitions and include them in the get meta response, allowing the CCR syncer to filter out the binlogs that belong to these partitions.
The CCR syncer part PR is selectdb/ccr-syncer#117.