Skip to content

[feature](ES Catalog)Support control scroll level by config #37180 - #37290

Merged
morningman merged 1 commit into
apache:branch-2.1from
qidaye:pick_scroll_config_2.1
Jul 15, 2024
Merged

[feature](ES Catalog)Support control scroll level by config #37180#37290
morningman merged 1 commit into
apache:branch-2.1from
qidaye:pick_scroll_config_2.1

Conversation

@qidaye

@qidayeqidaye commented Jul 4, 2024

Copy link
Copy Markdown
Contributor

Proposed changes

backport #37180

@doris-robot

doris-robot commented Jul 4, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@qidaye

qidaye commented Jul 4, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Jul 4, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@qidaye

qidaye commented Jul 4, 2024

Copy link
Copy Markdown
ContributorAuthor

run external

@doris-robot

doris-robot commented Jul 4, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.32% (9151/25193)
Line Coverage: 27.87% (74692/268032)
Region Coverage: 26.76% (38515/143931)
Branch Coverage: 23.45% (19514/83228)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4478d205f3aa4ab41b8dbb70f47d712896ebe91c_4478d205f3aa4ab41b8dbb70f47d712896ebe91c/report/index.html

@qidaye
[feature](ES Catalog)Support control scroll level by config (apache#3…
cb260d8
…7180)
## Proposed changes
1. Add session variable `enable_es_parallel_scroll`, default true. When
it's false, Doris will send a scroll query to ES by one backend without
shard preference and sort info. Which equals to call the search api
directly of ES and it's very useful when you need a global sorting based
on scores.
2. Print ES response body when http request is not OK.
@qidaye
qidayeforce-pushed the pick_scroll_config_2.1 branch from 4478d20 to cb260d8CompareJuly 15, 2024 06:40
@qidaye

qidaye commented Jul 15, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Jul 15, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Jul 15, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.54% (9259/25337)
Line Coverage: 28.04% (75617/269636)
Region Coverage: 26.87% (38889/144731)
Branch Coverage: 23.60% (19752/83686)
Coverage Report: http://coverage.selectdb-in.cc/coverage/cb260d87e774e8127616c3ca7235401e91642451_cb260d87e774e8127616c3ca7235401e91642451/report/index.html

@morningman
morningman merged commit e5339a4 into apache:branch-2.1Jul 15, 2024
@qidaye
qidaye deleted the pick_scroll_config_2.1 branch July 15, 2024 08:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qidaye@doris-robot@morningman