Uh oh!
There was an error while loading. Please reload this page.
[Feat](nereids) add pull up literal when infer predicates - #37314
Merged
Conversation
doris-robot
commented
Jul 4, 2024
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
feiniaofeiafei
commented
Jul 4, 2024
CollaboratorAuthor
run buildall |
doris-robot
commented
Jul 4, 2024
TPC-H: Total hot run time: 40341 ms |
doris-robot
commented
Jul 4, 2024
TPC-DS: Total hot run time: 172571 ms |
doris-robot
commented
Jul 4, 2024
ClickBench: Total hot run time: 30.93 s |
morrySnow
previously approved these changes
Jul 5, 2024
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
feiniaofeiafeiforce-pushed
the
fix_pull_up_predicate
branch
from
July 9, 2024 12:04
5c5d44f to
7441edcComparefeiniaofeiafei
commented
Jul 9, 2024
CollaboratorAuthor
run buildall |
feiniaofeiafeiforce-pushed
the
fix_pull_up_predicate
branch
from
July 10, 2024 01:54
7441edc to
017f777Comparefeiniaofeiafei
commented
Jul 10, 2024
CollaboratorAuthor
run buildall |
doris-robot
commented
Jul 10, 2024
TPC-H: Total hot run time: 40407 ms |
doris-robot
commented
Jul 10, 2024
TPC-DS: Total hot run time: 174090 ms |
doris-robot
commented
Jul 10, 2024
ClickBench: Total hot run time: 30.58 s |
feiniaofeiafei
commented
Jul 11, 2024
CollaboratorAuthor
run buildall |
doris-robot
commented
Jul 11, 2024
TPC-H: Total hot run time: 40272 ms |
doris-robot
commented
Jul 11, 2024
TPC-DS: Total hot run time: 176320 ms |
doris-robot
commented
Jul 11, 2024
ClickBench: Total hot run time: 30.1 s |
feiniaofeiafeiforce-pushed
the
fix_pull_up_predicate
branch
from
July 14, 2024 13:15
017f777 to
2a22f94Comparefeiniaofeiafei
commented
Jul 14, 2024
CollaboratorAuthor
run buildall |
doris-robot
commented
Jul 14, 2024
TPC-H: Total hot run time: 39999 ms |
doris-robot
commented
Jul 14, 2024
TPC-DS: Total hot run time: 172823 ms |
doris-robot
commented
Jul 14, 2024
ClickBench: Total hot run time: 31.47 s |
feiniaofeiafeiforce-pushed
the
fix_pull_up_predicate
branch
from
July 16, 2024 13:00
573f05b to
7ba966aComparefeiniaofeiafei
commented
Jul 16, 2024
CollaboratorAuthor
run buildall |
doris-robot
commented
Jul 16, 2024
TPC-H: Total hot run time: 39909 ms |
doris-robot
commented
Jul 16, 2024
TPC-DS: Total hot run time: 173003 ms |
doris-robot
commented
Jul 16, 2024
ClickBench: Total hot run time: 31.71 s |
feiniaofeiafei
commented
Jul 17, 2024
CollaboratorAuthor
run buildall |
doris-robot
commented
Jul 17, 2024
TPC-H: Total hot run time: 39666 ms |
doris-robot
commented
Jul 17, 2024
TPC-DS: Total hot run time: 173925 ms |
doris-robot
commented
Jul 17, 2024
ClickBench: Total hot run time: 30.74 s |
feiniaofeiafei
commented
Jul 17, 2024
CollaboratorAuthor
run external |
924060929
approved these changes
Jul 17, 2024
Contributor
PR approved by at least one committer and no changes requested. |
morrySnow
approved these changes
Jul 17, 2024
| ----hashJoin[INNER_JOIN] hashCondition=((col1 = ds.col1) and (col2 = ds.col2)) otherCondition=() | ||
| ------PhysicalProject | ||
| --------PhysicalOneRowRelation | ||
| ------filter((ds.col1 = 'abc') and (ds.col1 = ds.col1) and (ds.col2 = 'def') and (ds.col2 = ds.col2)) |
Contributor
There was a problem hiding this comment.
ds.col1 = ds.col1 is another bug in infer fiter?
dataroaring pushed a commit
that referenced
this pull request
Jul 19, 2024
This pr add pull up literal when infer predicates, we can infer tmp.col1='abc' and tmp.col2 = 'def' from subquery tmp, pull up to inner join, and combined with join on condition, we can infer ds.col1='abc' and ds.col2='def' select * from ( select tmp.col1, tmp.col2 from ( select 'abc' as col1, 'def' as col2 from test_pull_up_predicate_literal ) tmp inner join test_pull_up_predicate_literal ds on tmp.col1 = ds.col1 and tmp.col2 = ds.col2 ) t where col1 = 'abc' and col2 = 'def'; --------- Co-authored-by: feiniaofeiafei <moailing@selectdb.com>
feiniaofeiafei added a commit
to feiniaofeiafei/doris
that referenced
this pull request
Jul 19, 2024
This pr add pull up literal when infer predicates, we can infer tmp.col1='abc' and tmp.col2 = 'def' from subquery tmp, pull up to inner join, and combined with join on condition, we can infer ds.col1='abc' and ds.col2='def' select * from ( select tmp.col1, tmp.col2 from ( select 'abc' as col1, 'def' as col2 from test_pull_up_predicate_literal ) tmp inner join test_pull_up_predicate_literal ds on tmp.col1 = ds.col1 and tmp.col2 = ds.col2 ) t where col1 = 'abc' and col2 = 'def'; --------- Co-authored-by: feiniaofeiafei <moailing@selectdb.com>
feiniaofeiafei added a commit
to feiniaofeiafei/doris
that referenced
this pull request
Jul 25, 2024
morrySnow pushed a commit
that referenced
this pull request
Jul 30, 2024
Closed
HappenLee pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
This pr add pull up literal when infer predicates, we can infer tmp.col1='abc' and tmp.col2 = 'def' from subquery tmp, pull up to inner join, and combined with join on condition, we can infer ds.col1='abc' and ds.col2='def' select * from ( select tmp.col1, tmp.col2 from ( select 'abc' as col1, 'def' as col2 from test_pull_up_predicate_literal ) tmp inner join test_pull_up_predicate_literal ds on tmp.col1 = ds.col1 and tmp.col2 = ds.col2 ) t where col1 = 'abc' and col2 = 'def'; --------- Co-authored-by: feiniaofeiafei <moailing@selectdb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr add pull up literal when infer predicates, we can infer tmp.col1='abc' and tmp.col2 = 'def' from subquery tmp, pull up to inner join, and combined with join on condition, we can infer ds.col1='abc' and ds.col2='def'