Skip to content

[HttpServer] capture convert exception - #3736

Merged
imay merged 4 commits into
apache:masterfrom
vagetablechicken:http-action
Jun 3, 2020
Merged

[HttpServer] capture convert exception#3736
imay merged 4 commits into
apache:masterfrom
vagetablechicken:http-action

Conversation

@vagetablechicken

Copy link
Copy Markdown
Member

ref #3725

If parameter str is an empty string, it will throw exception too. Maybe we can add an ut for parsing parameters in http server.

@morningman

Copy link
Copy Markdown
Contributor

compile failed

@vagetablechicken

Copy link
Copy Markdown
MemberAuthor

compile failed

fixed

@imayimay added area/rpc Issues or PRs related to the RPC kind/fix Categorizes issue or PR as related to a bug. labels Jun 1, 2020
imay
imay approved these changes Jun 1, 2020

@imayimay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imayimay added the approved Indicates a PR has been approved by one committer. label Jun 1, 2020
@imayimay self-assigned this Jun 1, 2020
@imay
imay merged commit ed886a4 into apache:masterJun 3, 2020
morningman pushed a commit to morningman/doris that referenced this pull request Jun 4, 2020
If parameter str is an empty string, it will throw exception too. Maybe we can add an ut for parsing parameters in http server.
acelyc111 pushed a commit to acelyc111/incubator-doris that referenced this pull request Jan 20, 2021
If parameter str is an empty string, it will throw exception too. Maybe we can add an ut for parsing parameters in http server.
BiteTheDDDDt pushed a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Feb 7, 2025
pick apache#40146
Co-authored-by: TengJianPing <18241664+jacktengg@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.area/rpcIssues or PRs related to the RPCkind/fixCategorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@vagetablechicken@morningman@imay