Skip to content

[enhancement](compaction) optimizing memory usage for compaction (#37099) - #37486

Merged
dataroaring merged 5 commits into
apache:branch-2.1from
luwei16:pick-37099
Aug 4, 2024
Merged

[enhancement](compaction) optimizing memory usage for compaction (#37099)#37486
dataroaring merged 5 commits into
apache:branch-2.1from
luwei16:pick-37099

Conversation

@luwei16

@luwei16luwei16 commented Jul 8, 2024•
edited by dataroaring
Loading

Copy link
Copy Markdown
Contributor

pick #37099

@doris-robot

doris-robot commented Jul 8, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

github-actions[bot]
github-actionsBot reviewed Jul 8, 2024
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadbe/test/olap/base_compaction_test.cpp
// specific language governing permissions and limitations
// under the License.

#include "olap/base_compaction.h"

@github-actionsgithub-actionsBotJul 8, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'olap/base_compaction.h' file not found [clang-diagnostic-error]

#include"olap/base_compaction.h"
^

@dataroaring

dataroaring commented Jul 9, 2024

Copy link
Copy Markdown
Contributor

run buildall

@luwei16

luwei16 commented Jul 9, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Jul 9, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.36% (9164/25201)
Line Coverage: 27.91% (74884/268333)
Region Coverage: 26.82% (38664/144144)
Branch Coverage: 23.51% (19597/83348)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7d8fff8c5fdffbcf308bfeb77c5b0c38de47a13d_7d8fff8c5fdffbcf308bfeb77c5b0c38de47a13d/report/index.html

@luwei16

luwei16 commented Jul 13, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Jul 13, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.63% (9281/25336)
Line Coverage: 28.16% (75960/269781)
Region Coverage: 26.98% (39053/144761)
Branch Coverage: 23.68% (19833/83746)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9edf23fa4c7129f3b3f3a49bf0041513df84b22b_9edf23fa4c7129f3b3f3a49bf0041513df84b22b/report/index.html

@dataroaring

dataroaring commented Jul 17, 2024

Copy link
Copy Markdown
Contributor

pending for a while to test.

@dataroaring
dataroaring merged commit 0603ec1 into apache:branch-2.1Aug 4, 2024
@yiguoleiyiguolei mentioned this pull request Sep 5, 2024
Closed
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@luwei16@doris-robot@dataroaring