Skip to content

[FIX] fix binaryPredicte's equals function ignore op - #3753

Merged
morningman merged 3 commits into
apache:masterfrom
yangzhg:fix_binary_equal
Jun 4, 2020
Merged

[FIX] fix binaryPredicte's equals function ignore op#3753
morningman merged 3 commits into
apache:masterfrom
yangzhg:fix_binary_equal

Conversation

@yangzhg

@yangzhgyangzhg commented Jun 3, 2020•
edited
Loading

Copy link
Copy Markdown
Member

BinaryPredicte's equals funtion compare by opccode ,
but the opcode is never inited,
so it will return true if this child is same, for example a>1 and a<1 are equal
Fixes#3756

@morningmanmorningman added approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner kind/fix Categorizes issue or PR as related to a bug. labels Jun 3, 2020
morningman
morningman previously approved these changes Jun 3, 2020
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kangkaisen
kangkaisen reviewed Jun 3, 2020
View reviewed changes
Comment threadfe/src/main/java/org/apache/doris/analysis/BinaryPredicate.java Outdated
EmmyMiao87
EmmyMiao87 approved these changes Jun 3, 2020
View reviewed changes

@EmmyMiao87EmmyMiao87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
morningman merged commit a8c95e7 into apache:masterJun 4, 2020
morningman pushed a commit to morningman/doris that referenced this pull request Jun 4, 2020
@yangzhg@morningman-cmy
[Bug] Fix binaryPredicte's equals function ignore op (apache#3753)
922791b
BinaryPredicte's equals function compare by opcode ,
but the opcode may not be inited yet. so it will return true if this child is same, for example `a>1` and `a<1` are equal.
@yangzhg
yangzhg deleted the fix_binary_equal branch July 3, 2020 06:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningmanmorningmanmorningman left review comments
@kangkaisenkangkaisenkangkaisen left review comments
@EmmyMiao87EmmyMiao87EmmyMiao87 approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.area/plannerIssues or PRs related to the query plannerkind/fixCategorizes issue or PR as related to a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BinaryPredict's equals function compares ignore the op

4 participants

@yangzhg@morningman@kangkaisen@EmmyMiao87