Skip to content

[Bug] Clear Txn when load been cancelled - #3766

Merged
chaoyli merged 1 commit into
apache:masterfrom
chaoyli:master
Jun 4, 2020
Merged

[Bug] Clear Txn when load been cancelled#3766
chaoyli merged 1 commit into
apache:masterfrom
chaoyli:master

Conversation

@chaoyli

Copy link
Copy Markdown
Contributor

If you a load task encoutering error, it will be cancelled.
At this time, FE will clear the Txn according to the DbName.
In FE, DbName should be added by cluter name.
If missing cluster name, it will encounter NullPointer.
As a result, the Txn will still exists until timeout.

@chaoylichaoyli self-assigned this Jun 3, 2020
@chaoylichaoyli linked an issue Jun 3, 2020 that may be closed by this pull request
@chaoylichaoyli added the kind/fix Categorizes issue or PR as related to a bug. label Jun 3, 2020

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create an issue to describe the bug you met

Comment threadfe/src/main/java/org/apache/doris/service/FrontendServiceImpl.java Outdated
If you a load task encoutering error, it will be cancelled.
At this time, FE will clear the Txn according to the DbName.
In FE, DbName should be added by cluter name.
If missing cluster name, it will encounter NullPointer.
As a result, the Txn will still exists until timeout.
@chaoyli

Copy link
Copy Markdown
ContributorAuthor

Please create an issue to describe the bug you met

I have already linked issues.

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningmanmorningman added the approved Indicates a PR has been approved by one committer. label Jun 4, 2020
@chaoyli
chaoyli merged commit 9b2cf1c into apache:masterJun 4, 2020
morningman pushed a commit to morningman/doris that referenced this pull request Jun 7, 2020
If you a load task encoutering error, it will be cancelled.
At this time, FE will clear the Txn according to the DbName.
In FE, DbName should be added by cluter name.
If missing cluster name, it will encounter NullPointer.
As a result, the Txn will still exists until timeout.
baidu-doris pushed a commit to baidu-doris/incubator-doris that referenced this pull request Jun 17, 2020
If you a load task encoutering error, it will be cancelled.
At this time, FE will clear the Txn according to the DbName.
In FE, DbName should be added by cluter name.
If missing cluster name, it will encounter NullPointer.
As a result, the Txn will still exists until timeout.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.kind/fixCategorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Txn is not cleared when load been cancelled.

2 participants

@chaoyli@morningman