Uh oh!
There was an error while loading. Please reload this page.
[fix](nereids) fix aggr node colocate flag which local shuffle depending on - #37788
Merged
dataroaring merged 1 commit intoJul 17, 2024
Merged
Conversation
doris-robot
commented
Jul 15, 2024
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
xzj7019
commented
Jul 15, 2024
ContributorAuthor
run buildall |
morrySnow
approved these changes
Jul 15, 2024
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
doris-robot
commented
Jul 15, 2024
TPC-H: Total hot run time: 40129 ms |
doris-robot
commented
Jul 15, 2024
TPC-DS: Total hot run time: 172908 ms |
doris-robot
commented
Jul 15, 2024
ClickBench: Total hot run time: 31.31 s |
Gabriel39
approved these changes
Jul 15, 2024
xzj7019
commented
Jul 15, 2024
ContributorAuthor
run p0 |
xzj7019
commented
Jul 15, 2024
ContributorAuthor
run p0 |
xzj7019force-pushed
the
fix_colocate_flag_localshuffle_dep
branch
from
July 16, 2024 14:06
7f20fe7 to
e7823ffComparexzj7019
commented
Jul 16, 2024
ContributorAuthor
run buildall |
doris-robot
commented
Jul 16, 2024
TPC-H: Total hot run time: 39539 ms |
doris-robot
commented
Jul 16, 2024
TPC-DS: Total hot run time: 173734 ms |
doris-robot
commented
Jul 16, 2024
ClickBench: Total hot run time: 30.56 s |
xzj7019
commented
Jul 17, 2024
ContributorAuthor
run buildall |
doris-robot
commented
Jul 17, 2024
TPC-H: Total hot run time: 39893 ms |
doris-robot
commented
Jul 17, 2024
TPC-DS: Total hot run time: 173554 ms |
doris-robot
commented
Jul 17, 2024
ClickBench: Total hot run time: 31.47 s |
HappenLee pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
…ing on (apache#37788) Local shuffle depends on the operator node's isColocate flag, to decide the shuffle columns. Current aggr node's isColocate true setting is too strict to support shuffle-colocate scenarios. This pr releases the unnecessary restriction (only support table scan) and sets the flag true expectly. Co-authored-by: zhongjian.xzj <zhongjian.xzj@192.168.2.213>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local shuffle depends on the operator node's isColocate flag, to decide the shuffle columns.
Current aggr node's isColocate true setting is too strict to support shuffle-colocate scenarios.
This pr releases the unnecessary restriction (only support table scan) and sets the flag true expectly.