Uh oh!
There was an error while loading. Please reload this page.
[Feat](nereids)Support date_trunc function in partition prune - #38025
Merged
morrySnow merged 9 commits intoAug 1, 2024
Conversation
doris-robot
commented
Jul 17, 2024
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
feiniaofeiafei
commented
Jul 17, 2024
CollaboratorAuthor
run buildall |
doris-robot
commented
Jul 17, 2024
TPC-H: Total hot run time: 39773 ms |
doris-robot
commented
Jul 17, 2024
TPC-DS: Total hot run time: 174509 ms |
doris-robot
commented
Jul 17, 2024
ClickBench: Total hot run time: 30.69 s |
feiniaofeiafeiforce-pushed
the
date_trunc_in_partition_prune
branch
from
July 24, 2024 11:49
cd0a714 to
8644094Comparefeiniaofeiafei
commented
Jul 25, 2024
CollaboratorAuthor
run buildall |
doris-robot
commented
Jul 25, 2024
TPC-H: Total hot run time: 40013 ms |
doris-robot
commented
Jul 25, 2024
TPC-DS: Total hot run time: 172812 ms |
doris-robot
commented
Jul 25, 2024
ClickBench: Total hot run time: 30.43 s |
feiniaofeiafei
commented
Jul 26, 2024
CollaboratorAuthor
run buildall |
doris-robot
commented
Jul 26, 2024
TPC-H: Total hot run time: 39580 ms |
doris-robot
commented
Jul 26, 2024
TPC-DS: Total hot run time: 173096 ms |
doris-robot
commented
Jul 26, 2024
ClickBench: Total hot run time: 31.97 s |
feiniaofeiafeiforce-pushed
the
date_trunc_in_partition_prune
branch
from
July 26, 2024 14:11
b5ff552 to
8a377afComparefeiniaofeiafei
commented
Jul 26, 2024
CollaboratorAuthor
run buildall |
doris-robot
commented
Jul 26, 2024
TPC-H: Total hot run time: 39121 ms |
doris-robot
commented
Jul 26, 2024
TPC-DS: Total hot run time: 172563 ms |
doris-robot
commented
Jul 26, 2024
ClickBench: Total hot run time: 30.67 s |
| @Override | ||
| public Monotonicity getMonotonicity() { | ||
| return new Monotonicity(true, true); |
Contributor
There was a problem hiding this comment.
maybe, u should use some static variables generated in Monotonicity class. refer to org.apache.doris.nereids.properties.PhysicalProperties
Comment on lines
+62
to
+72
| public Expression withConstantArgs(Literal literal) { | ||
| return this; | ||
| } | ||
| public int getMonotonicFunctionChildIndex() { | ||
| return -1; | ||
| } | ||
| public Monotonicity getMonotonicity() { | ||
| return new Monotonicity(false, true); | ||
| } |
Contributor
There was a problem hiding this comment.
add comment to these interfaces
| } | ||
| public Expression withConstantArgs(Literal literal) { | ||
| return this; |
Contributor
There was a problem hiding this comment.
return this is not a good idea. i think we should throw exceptions if on function not support Monotonicity
Comment on lines
+32
to
+39
| public class Monotonicity { | ||
| public boolean isMonotonic; | ||
| public boolean isPositive; | ||
| public Monotonicity(boolean isMonotonic, boolean isPositive) { | ||
| this.isMonotonic = isMonotonic; | ||
| this.isPositive = isPositive; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
move out from function, it should be expression trait?
Comment on lines
+634
to
+645
| public EvaluateRangeResult visitDateTrunc(DateTrunc dateTrunc, EvaluateRangeInput context) { | ||
| EvaluateRangeResult result = super.visitDateTrunc(dateTrunc, context); | ||
| if (!(result.result instanceof DateTrunc)) { | ||
| return result; | ||
| } | ||
| Expression dateTruncChild = dateTrunc.child(0); | ||
| if (partitionSlotContainsNull.containsKey(dateTruncChild)) { | ||
| partitionSlotContainsNull.put(dateTrunc, true); | ||
| } | ||
| return computeMonotonicFunctionRange(result); | ||
| } |
Contributor
There was a problem hiding this comment.
if we add a new trait class Monotonic for expression, could we here use visit Monotoic to do same things for all monotonic functions? then we only need add trait on different function
Contributor
There was a problem hiding this comment.
we should use trait interface
publicinterfaceMonotonicextendsExpressionTrait {
booleanisPositive(); }
publicclassDateTruncimplementMonotonic {
@OverridepublicisPositive() {
returntrue;
}
}| } | ||
| public boolean isCompletelyInfinite() { | ||
| return !span().hasLowerBound() && !span().hasUpperBound(); |
Contributor
There was a problem hiding this comment.
I think this is not completeInfinite
newColumnRange(
ColumnBound.lessThen(Literal.of(0)))
.union(ColumnRange.greaterThan(Literal.of(10))
);
Comment on lines
+204
to
+205
| assert slotResult != null; | ||
| assert slotResult.columnRanges.containsKey(slot); |
Contributor
There was a problem hiding this comment.
assert only throw exception in test environment
Comment on lines
+634
to
+645
| public EvaluateRangeResult visitDateTrunc(DateTrunc dateTrunc, EvaluateRangeInput context) { | ||
| EvaluateRangeResult result = super.visitDateTrunc(dateTrunc, context); | ||
| if (!(result.result instanceof DateTrunc)) { | ||
| return result; | ||
| } | ||
| Expression dateTruncChild = dateTrunc.child(0); | ||
| if (partitionSlotContainsNull.containsKey(dateTruncChild)) { | ||
| partitionSlotContainsNull.put(dateTrunc, true); | ||
| } | ||
| return computeMonotonicFunctionRange(result); | ||
| } |
Contributor
There was a problem hiding this comment.
we should use trait interface
publicinterfaceMonotonicextendsExpressionTrait {
booleanisPositive(); }
publicclassDateTruncimplementMonotonic {
@OverridepublicisPositive() {
returntrue;
}
}feiniaofeiafeiforce-pushed
the
date_trunc_in_partition_prune
branch
from
July 30, 2024 07:30
8a377af to
0dae430Comparefeiniaofeiafei
commented
Jul 30, 2024
CollaboratorAuthor
run buildall |
doris-robot
commented
Jul 30, 2024
TPC-H: Total hot run time: 41509 ms |
doris-robot
commented
Jul 30, 2024
TPC-DS: Total hot run time: 170487 ms |
doris-robot
commented
Jul 30, 2024
ClickBench: Total hot run time: 30.52 s |
feiniaofeiafei
commented
Jul 30, 2024
CollaboratorAuthor
run cloud_p0 |
1 similar comment
feiniaofeiafei
commented
Jul 30, 2024
CollaboratorAuthor
run cloud_p0 |
feiniaofeiafei
commented
Jul 31, 2024
CollaboratorAuthor
run buildall |
doris-robot
commented
Jul 31, 2024
TPC-H: Total hot run time: 41946 ms |
924060929
approved these changes
Aug 1, 2024
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
morrySnow
approved these changes
Aug 1, 2024
dataroaring pushed a commit
that referenced
this pull request
Aug 2, 2024
let range partition pruner support date_trunc(dt, 'day') > 10.
For example, partition column is dt, there is a partition
('2020-01-01 10:00:00', '2020-02-05 10:00:00'),
and a predicate
date_trunc(dt, 'day')<'2019-01-01 ',
this partition can be pruned.feiniaofeiafei added a commit
to feiniaofeiafei/doris
that referenced
this pull request
Aug 5, 2024
…e#38025) let range partition pruner support date_trunc(dt, 'day') > 10. For example, partition column is dt, there is a partition ('2020-01-01 10:00:00', '2020-02-05 10:00:00'), and a predicate date_trunc(dt, 'day')<'2019-01-01 ', this partition can be pruned.
yiguolei pushed a commit
that referenced
this pull request
Aug 5, 2024
starocean999 pushed a commit
that referenced
this pull request
Aug 6, 2024
…8897) introduced by #38025 Or expression evaluate wrongly in #38025. For example, partition column is a, b, predicate is a=a or b>1 , partition column range is min<a<5, b is infinite. The evaluate result of or expression should be b is infinite(because when a is not null, a=a is true, there is no restrict for b, e.g. a=1, b=0 satisfy a=a or b>1). #38025 pr has wrongly evaluate result b >1
dataroaring pushed a commit
that referenced
this pull request
Aug 6, 2024
…8897) introduced by #38025 Or expression evaluate wrongly in #38025. For example, partition column is a, b, predicate is a=a or b>1 , partition column range is min<a<5, b is infinite. The evaluate result of or expression should be b is infinite(because when a is not null, a=a is true, there is no restrict for b, e.g. a=1, b=0 satisfy a=a or b>1). #38025 pr has wrongly evaluate result b >1
feiniaofeiafei added a commit
to feiniaofeiafei/doris
that referenced
this pull request
Aug 7, 2024
…ache#38897) introduced by apache#38025 Or expression evaluate wrongly in apache#38025. For example, partition column is a, b, predicate is a=a or b>1 , partition column range is min<a<5, b is infinite. The evaluate result of or expression should be b is infinite(because when a is not null, a=a is true, there is no restrict for b, e.g. a=1, b=0 satisfy a=a or b>1). apache#38025 pr has wrongly evaluate result b >1
feiniaofeiafei added a commit
to feiniaofeiafei/doris
that referenced
this pull request
Aug 9, 2024
…e#38025) let range partition pruner support date_trunc(dt, 'day') > 10. For example, partition column is dt, there is a partition ('2020-01-01 10:00:00', '2020-02-05 10:00:00'), and a predicate date_trunc(dt, 'day')<'2019-01-01 ', this partition can be pruned.
Closed
3 tasks
18 tasks
HappenLee pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
…e#38025) let range partition pruner support date_trunc(dt, 'day') > 10. For example, partition column is dt, there is a partition ('2020-01-01 10:00:00', '2020-02-05 10:00:00'), and a predicate date_trunc(dt, 'day')<'2019-01-01 ', this partition can be pruned.
HappenLee pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
…ache#38897) introduced by apache#38025 Or expression evaluate wrongly in apache#38025. For example, partition column is a, b, predicate is a=a or b>1 , partition column range is min<a<5, b is infinite. The evaluate result of or expression should be b is infinite(because when a is not null, a=a is true, there is no restrict for b, e.g. a=1, b=0 satisfy a=a or b>1). apache#38025 pr has wrongly evaluate result b >1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nereids range partition pruner does not support date_trunc(dt, 'day')>10. This pr supports to compute date_trunc(dt, 'day')>10. For example, there is a partition ('2020-01-01 10:00:00', '2020-02-05 10:00:00') ,partition column is dt, and a predicate date_trunc(dt, 'day')<'2019-01-01 ', this partition can be pruned.