[Fix](JobManager)Release the lock immediately after modifying job metadata to avoid holding the lock for an extended period. by CalvinKirs · Pull Request #38162 · apache/doris

CalvinKirs · 2024-07-19T15:28:02Z

Proposed changes

When deleting a job in MV, a DB lock is held. However, due to the larger lock granularity of the Job Manager, this may prevent obtaining the lock. This issue arises because during the creation of a job, immediately scheduled tasks need to perform their initial scheduling and compensate for tasks within the time window. To alleviate this issue, we are attempting to reduce the lock granularity.

doris-robot · 2024-07-19T15:28:07Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

CalvinKirs · 2024-07-19T15:30:34Z

run buildall

doris-robot · 2024-07-19T16:07:54Z

TPC-H: Total hot run time: 39899 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1ab1d57958f866caed6541cf7b0142e7b554e37e, data reload: false
------ Round 1 ----------------------------------
q1	17634	4313	4268	4268
q2	2018	198	197	197
q3	10446	1171	1013	1013
q4	10186	879	828	828
q5	7525	2671	2633	2633
q6	218	141	142	141
q7	942	613	621	613
q8	9219	2088	2063	2063
q9	8591	6509	6514	6509
q10	8831	3798	3769	3769
q11	454	249	241	241
q12	403	228	239	228
q13	17960	3012	2994	2994
q14	281	255	240	240
q15	526	487	508	487
q16	508	397	387	387
q17	970	596	665	596
q18	8077	7492	7406	7406
q19	8382	1414	1421	1414
q20	668	330	324	324
q21	4855	3264	3903	3264
q22	356	299	284	284
Total cold run time: 119050 ms
Total hot run time: 39899 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4380	4210	4218	4210
q2	371	278	277	277
q3	3050	2929	2975	2929
q4	1917	1704	1759	1704
q5	5547	5542	5462	5462
q6	227	141	138	138
q7	2276	1890	1883	1883
q8	3292	3434	3417	3417
q9	8724	8921	8760	8760
q10	4142	3782	3893	3782
q11	625	500	526	500
q12	808	638	635	635
q13	17059	3197	3265	3197
q14	340	291	287	287
q15	527	504	494	494
q16	524	454	443	443
q17	1835	1534	1532	1532
q18	8265	7978	7840	7840
q19	1790	1529	1627	1529
q20	2911	1891	1865	1865
q21	7421	4818	4903	4818
q22	614	512	529	512
Total cold run time: 76645 ms
Total hot run time: 56214 ms

doris-robot · 2024-07-19T16:19:00Z

TPC-DS: Total hot run time: 174144 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1ab1d57958f866caed6541cf7b0142e7b554e37e, data reload: false
query1	912	370	370	370
query2	6433	1824	1767	1767
query3	6642	207	235	207
query4	28386	17554	17303	17303
query5	3787	495	503	495
query6	268	185	186	185
query7	4593	289	287	287
query8	259	194	201	194
query9	8503	2451	2407	2407
query10	438	286	263	263
query11	11619	10059	10093	10059
query12	116	96	87	87
query13	1631	363	365	363
query14	10095	7543	8031	7543
query15	228	171	167	167
query16	7071	481	455	455
query17	946	561	550	550
query18	1745	294	290	290
query19	206	156	158	156
query20	90	87	87	87
query21	208	143	127	127
query22	4429	4150	4043	4043
query23	34327	33674	33537	33537
query24	11071	2912	2821	2821
query25	632	422	401	401
query26	707	155	154	154
query27	2265	287	288	287
query28	6178	2089	2073	2073
query29	902	619	662	619
query30	299	154	160	154
query31	953	770	791	770
query32	95	55	56	55
query33	678	348	351	348
query34	945	524	556	524
query35	901	765	746	746
query36	1142	978	971	971
query37	142	87	91	87
query38	2915	2754	2742	2742
query39	894	837	834	834
query40	198	122	121	121
query41	45	44	45	44
query42	117	98	101	98
query43	496	472	464	464
query44	1152	732	732	732
query45	196	162	173	162
query46	1086	738	771	738
query47	1842	1765	1785	1765
query48	362	294	287	287
query49	867	420	429	420
query50	799	391	395	391
query51	6863	6806	6821	6806
query52	109	94	97	94
query53	366	303	309	303
query54	879	456	454	454
query55	78	73	74	73
query56	290	272	266	266
query57	1143	1032	1071	1032
query58	273	271	253	253
query59	2902	2582	2515	2515
query60	296	289	288	288
query61	97	97	90	90
query62	788	660	642	642
query63	327	297	305	297
query64	9179	2239	1691	1691
query65	3205	3128	3113	3113
query66	761	347	382	347
query67	15410	14959	14802	14802
query68	4519	551	560	551
query69	532	395	373	373
query70	1099	1099	1130	1099
query71	371	281	281	281
query72	7214	6025	5754	5754
query73	737	324	323	323
query74	6131	5674	5665	5665
query75	3375	2705	2720	2705
query76	2261	917	872	872
query77	478	320	308	308
query78	9580	9089	8955	8955
query79	2140	552	531	531
query80	2310	488	496	488
query81	610	221	223	221
query82	1053	144	145	144
query83	311	172	172	172
query84	273	87	91	87
query85	1204	316	297	297
query86	468	316	318	316
query87	3266	3119	3153	3119
query88	3459	2392	2396	2392
query89	476	405	401	401
query90	1739	200	199	199
query91	146	113	116	113
query92	68	56	52	52
query93	2090	515	522	515
query94	1250	301	281	281
query95	415	316	317	316
query96	604	276	289	276
query97	3196	3035	3073	3035
query98	220	213	201	201
query99	1626	1293	1286	1286
Total cold run time: 276998 ms
Total hot run time: 174144 ms

doris-robot · 2024-07-19T16:24:32Z

ClickBench: Total hot run time: 30.91 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1ab1d57958f866caed6541cf7b0142e7b554e37e, data reload: false
query1	0.04	0.04	0.04
query2	0.08	0.03	0.04
query3	0.23	0.06	0.05
query4	1.67	0.08	0.08
query5	0.48	0.52	0.49
query6	1.13	0.73	0.72
query7	0.02	0.01	0.01
query8	0.05	0.05	0.04
query9	0.54	0.50	0.49
query10	0.54	0.55	0.52
query11	0.15	0.11	0.12
query12	0.15	0.12	0.12
query13	0.60	0.59	0.58
query14	0.76	0.77	0.78
query15	0.86	0.81	0.82
query16	0.35	0.37	0.36
query17	0.95	0.94	1.02
query18	0.23	0.22	0.22
query19	1.81	1.68	1.71
query20	0.01	0.00	0.00
query21	15.40	0.74	0.64
query22	4.59	6.16	2.32
query23	18.30	1.39	1.24
query24	2.14	0.23	0.22
query25	0.15	0.08	0.08
query26	0.31	0.22	0.20
query27	0.46	0.24	0.23
query28	13.23	1.04	1.01
query29	12.70	3.31	3.27
query30	0.25	0.06	0.05
query31	2.86	0.40	0.40
query32	3.24	0.48	0.48
query33	2.96	2.92	2.89
query34	17.06	4.35	4.36
query35	4.44	4.48	4.43
query36	0.65	0.46	0.49
query37	0.19	0.16	0.16
query38	0.16	0.14	0.15
query39	0.04	0.04	0.03
query40	0.15	0.12	0.12
query41	0.09	0.05	0.05
query42	0.06	0.05	0.04
query43	0.05	0.04	0.04
Total cold run time: 110.13 s
Total hot run time: 30.91 s

…adata to avoid holding the lock for an extended period.

yiguolei · 2024-07-19T22:55:53Z

run buildall

github-actions · 2024-07-19T23:03:29Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-07-19T23:03:32Z

PR approved by anyone and no changes requested.

doris-robot · 2024-07-19T23:32:31Z

TPC-H: Total hot run time: 39693 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a5960cff2d7d1650612c2c517d65a8ea1634a0c1, data reload: false
------ Round 1 ----------------------------------
q1	17629	4314	4249	4249
q2	2011	188	205	188
q3	10454	1246	1149	1149
q4	10185	834	832	832
q5	7557	2706	2637	2637
q6	225	140	137	137
q7	944	599	621	599
q8	9226	2084	2040	2040
q9	8699	6546	6536	6536
q10	8786	3779	3755	3755
q11	452	251	248	248
q12	408	229	226	226
q13	17770	2981	2959	2959
q14	270	230	241	230
q15	523	488	480	480
q16	493	378	383	378
q17	968	627	749	627
q18	8047	7479	7318	7318
q19	8095	1335	1256	1256
q20	677	317	327	317
q21	4974	3260	3243	3243
q22	344	289	294	289
Total cold run time: 118737 ms
Total hot run time: 39693 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4408	4254	4293	4254
q2	376	267	262	262
q3	2962	2928	2931	2928
q4	2004	1656	1770	1656
q5	5661	5545	5537	5537
q6	223	138	145	138
q7	2215	1873	1831	1831
q8	3216	3430	3459	3430
q9	8889	8983	8982	8982
q10	4095	3840	3861	3840
q11	585	497	514	497
q12	810	661	654	654
q13	17421	3221	3200	3200
q14	331	312	279	279
q15	548	491	482	482
q16	487	443	444	443
q17	1833	1518	1532	1518
q18	8148	8055	7748	7748
q19	1742	1547	1701	1547
q20	2213	1973	1937	1937
q21	8913	4940	5051	4940
q22	612	565	522	522
Total cold run time: 77692 ms
Total hot run time: 56625 ms

doris-robot · 2024-07-19T23:43:48Z

TPC-DS: Total hot run time: 173791 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a5960cff2d7d1650612c2c517d65a8ea1634a0c1, data reload: false
query1	2582	379	370	370
query2	8251	1927	1785	1785
query3	6821	204	212	204
query4	28344	17405	17344	17344
query5	3627	476	477	476
query6	246	193	168	168
query7	4569	279	287	279
query8	249	205	195	195
query9	8494	2446	2432	2432
query10	435	277	275	275
query11	11617	10162	9997	9997
query12	119	86	85	85
query13	1645	383	365	365
query14	9637	7654	7792	7654
query15	252	162	165	162
query16	8031	456	466	456
query17	1668	563	549	549
query18	1897	326	276	276
query19	328	151	149	149
query20	85	82	82	82
query21	202	129	119	119
query22	4325	4177	3898	3898
query23	34041	33642	34169	33642
query24	10733	2906	2858	2858
query25	520	410	382	382
query26	690	150	152	150
query27	2153	288	269	269
query28	5925	2068	2066	2066
query29	853	632	627	627
query30	258	153	149	149
query31	966	767	743	743
query32	99	63	54	54
query33	690	329	320	320
query34	920	494	503	494
query35	889	768	753	753
query36	1125	959	951	951
query37	141	83	79	79
query38	2952	2898	2821	2821
query39	872	794	807	794
query40	203	137	116	116
query41	43	42	50	42
query42	128	97	99	97
query43	505	461	442	442
query44	1096	746	726	726
query45	191	156	159	156
query46	1079	728	733	728
query47	1840	1823	1770	1770
query48	368	302	282	282
query49	809	447	417	417
query50	778	382	383	382
query51	6875	6822	6670	6670
query52	97	94	91	91
query53	357	302	286	286
query54	892	452	447	447
query55	75	71	74	71
query56	296	266	270	266
query57	1119	1033	1049	1033
query58	254	243	254	243
query59	2815	2597	2573	2573
query60	317	272	273	272
query61	128	96	99	96
query62	794	659	644	644
query63	315	281	280	280
query64	9166	2206	6321	2206
query65	3163	3097	3100	3097
query66	723	327	334	327
query67	15492	14896	15063	14896
query68	4576	536	543	536
query69	664	436	346	346
query70	1180	1169	1093	1093
query71	420	283	278	278
query72	8036	5532	5417	5417
query73	740	324	317	317
query74	6073	5738	5629	5629
query75	3535	2649	2729	2649
query76	2929	910	843	843
query77	672	303	310	303
query78	9649	9125	9053	9053
query79	2416	516	523	516
query80	2495	459	473	459
query81	599	215	216	215
query82	832	134	141	134
query83	308	163	171	163
query84	266	91	83	83
query85	1851	327	359	327
query86	444	306	314	306
query87	3331	3102	3224	3102
query88	3731	2362	2367	2362
query89	470	382	374	374
query90	1900	193	199	193
query91	136	98	97	97
query92	60	48	49	48
query93	2411	504	511	504
query94	1221	282	291	282
query95	395	311	318	311
query96	588	277	274	274
query97	3222	3037	3053	3037
query98	217	194	187	187
query99	1593	1246	1225	1225
Total cold run time: 284129 ms
Total hot run time: 173791 ms

doris-robot · 2024-07-19T23:49:20Z

ClickBench: Total hot run time: 30.58 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a5960cff2d7d1650612c2c517d65a8ea1634a0c1, data reload: false
query1	0.04	0.04	0.04
query2	0.07	0.03	0.03
query3	0.23	0.04	0.05
query4	1.68	0.08	0.08
query5	0.50	0.49	0.49
query6	1.15	0.73	0.72
query7	0.02	0.01	0.02
query8	0.05	0.05	0.05
query9	0.56	0.48	0.48
query10	0.54	0.54	0.54
query11	0.15	0.11	0.12
query12	0.14	0.12	0.12
query13	0.60	0.59	0.58
query14	0.75	0.79	0.76
query15	0.87	0.82	0.81
query16	0.36	0.35	0.37
query17	1.02	1.03	1.04
query18	0.22	0.23	0.22
query19	1.89	1.80	1.72
query20	0.01	0.01	0.02
query21	15.40	0.76	0.65
query22	4.43	7.32	1.83
query23	18.30	1.47	1.34
query24	2.10	0.22	0.22
query25	0.17	0.08	0.08
query26	0.29	0.22	0.21
query27	0.46	0.23	0.23
query28	13.23	1.04	1.01
query29	12.62	3.32	3.25
query30	0.25	0.06	0.06
query31	2.87	0.40	0.39
query32	3.28	0.49	0.48
query33	2.90	2.88	2.95
query34	17.25	4.31	4.33
query35	4.40	4.42	4.40
query36	0.66	0.50	0.47
query37	0.19	0.16	0.15
query38	0.16	0.15	0.15
query39	0.05	0.03	0.04
query40	0.15	0.12	0.12
query41	0.09	0.05	0.06
query42	0.06	0.04	0.05
query43	0.05	0.04	0.04
Total cold run time: 110.21 s
Total hot run time: 30.58 s

…adata to avoid holding the lock for an extended period.

…-lock # Conflicts: # fe/fe-core/src/main/java/org/apache/doris/job/manager/JobManager.java

CalvinKirs · 2024-07-19T23:59:28Z

run buildall

…adata to avoid holding the lock for an extended period.apache#38162

doris-robot · 2024-07-20T00:35:59Z

TPC-H: Total hot run time: 39981 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b2590fccabfe3705feab4cf0b7dcf4a968f4bd15, data reload: false
------ Round 1 ----------------------------------
q1	17663	4340	4264	4264
q2	2009	189	184	184
q3	10571	1190	1046	1046
q4	10194	809	786	786
q5	7531	2713	2618	2618
q6	221	134	139	134
q7	948	597	605	597
q8	9337	2076	2090	2076
q9	8952	6656	6576	6576
q10	8825	3847	3849	3847
q11	514	242	236	236
q12	435	222	227	222
q13	17771	3043	3018	3018
q14	282	226	232	226
q15	531	469	472	469
q16	494	387	379	379
q17	963	698	642	642
q18	8222	7595	7425	7425
q19	5228	1537	1401	1401
q20	715	345	356	345
q21	4968	3191	3271	3191
q22	364	299	310	299
Total cold run time: 116738 ms
Total hot run time: 39981 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5317	4366	4419	4366
q2	386	265	258	258
q3	3158	3076	2994	2994
q4	2057	1699	1790	1699
q5	5661	5620	5569	5569
q6	220	132	136	132
q7	2175	1889	1819	1819
q8	3274	3449	3437	3437
q9	8681	8772	8863	8772
q10	4039	3802	3774	3774
q11	583	514	497	497
q12	821	653	623	623
q13	16513	3182	3201	3182
q14	325	295	317	295
q15	530	474	489	474
q16	498	440	446	440
q17	1820	1536	1509	1509
q18	8243	8170	7850	7850
q19	1737	1544	1490	1490
q20	2709	1891	1862	1862
q21	8901	5003	4805	4805
q22	575	502	500	500
Total cold run time: 78223 ms
Total hot run time: 56347 ms

doris-robot · 2024-07-20T00:47:08Z

TPC-DS: Total hot run time: 174487 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b2590fccabfe3705feab4cf0b7dcf4a968f4bd15, data reload: false
query1	910	375	375	375
query2	6433	1826	1786	1786
query3	6649	211	218	211
query4	28504	17723	17543	17543
query5	3713	479	471	471
query6	269	172	159	159
query7	4585	297	279	279
query8	241	199	192	192
query9	8667	2444	2413	2413
query10	438	304	277	277
query11	10812	10109	10112	10109
query12	117	85	89	85
query13	1641	383	375	375
query14	10295	7974	7811	7811
query15	215	171	173	171
query16	7566	490	501	490
query17	1317	564	542	542
query18	1754	291	293	291
query19	198	158	162	158
query20	88	85	86	85
query21	213	128	128	128
query22	4388	4024	3965	3965
query23	33927	33651	33828	33651
query24	10820	2888	2983	2888
query25	628	479	390	390
query26	721	151	156	151
query27	2314	275	285	275
query28	6167	2082	2067	2067
query29	918	650	638	638
query30	244	153	156	153
query31	969	740	744	740
query32	91	54	57	54
query33	672	365	359	359
query34	913	487	516	487
query35	858	772	797	772
query36	1152	970	933	933
query37	140	79	84	79
query38	2991	2880	2854	2854
query39	924	847	828	828
query40	196	116	121	116
query41	45	44	44	44
query42	115	96	95	95
query43	491	458	476	458
query44	1077	727	726	726
query45	193	160	158	158
query46	1088	701	713	701
query47	1865	1761	1761	1761
query48	358	292	284	284
query49	827	409	430	409
query50	772	386	396	386
query51	6946	6729	6802	6729
query52	107	92	88	88
query53	353	297	291	291
query54	870	442	446	442
query55	79	75	74	74
query56	283	273	287	273
query57	1129	1050	1056	1050
query58	243	244	251	244
query59	2713	2677	2560	2560
query60	303	281	286	281
query61	98	94	95	94
query62	804	624	627	624
query63	313	282	292	282
query64	9205	2241	1654	1654
query65	3168	3122	3134	3122
query66	761	333	326	326
query67	15299	15001	15023	15001
query68	5012	546	558	546
query69	630	422	360	360
query70	1170	1075	1202	1075
query71	438	291	287	287
query72	7523	5544	5929	5544
query73	771	326	327	326
query74	6147	5635	5708	5635
query75	3447	2755	2670	2670
query76	3095	987	972	972
query77	653	314	302	302
query78	10420	9291	9035	9035
query79	1567	523	521	521
query80	2168	462	475	462
query81	603	215	221	215
query82	765	143	136	136
query83	301	162	168	162
query84	265	89	87	87
query85	1577	323	353	323
query86	493	322	333	322
query87	3362	3139	3082	3082
query88	4269	2386	2368	2368
query89	479	374	388	374
query90	1953	196	186	186
query91	127	102	99	99
query92	67	47	52	47
query93	2035	513	504	504
query94	1381	283	283	283
query95	418	315	316	315
query96	593	270	271	270
query97	3205	3021	3062	3021
query98	222	201	189	189
query99	1645	1261	1264	1261
Total cold run time: 279964 ms
Total hot run time: 174487 ms

doris-robot · 2024-07-20T00:52:39Z

ClickBench: Total hot run time: 30.74 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b2590fccabfe3705feab4cf0b7dcf4a968f4bd15, data reload: false
query1	0.05	0.04	0.03
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.67	0.08	0.07
query5	0.50	0.48	0.49
query6	1.13	0.74	0.73
query7	0.02	0.01	0.02
query8	0.04	0.05	0.05
query9	0.57	0.51	0.49
query10	0.54	0.54	0.56
query11	0.17	0.11	0.11
query12	0.15	0.12	0.12
query13	0.61	0.59	0.59
query14	0.76	0.77	0.78
query15	0.86	0.82	0.81
query16	0.37	0.36	0.37
query17	1.04	0.99	0.95
query18	0.24	0.24	0.24
query19	1.91	1.75	1.72
query20	0.01	0.01	0.02
query21	15.41	0.75	0.66
query22	4.62	6.34	2.07
query23	18.25	1.40	1.28
query24	2.16	0.22	0.22
query25	0.15	0.09	0.09
query26	0.31	0.22	0.21
query27	0.45	0.23	0.23
query28	13.24	1.01	1.00
query29	12.65	3.25	3.28
query30	0.26	0.06	0.05
query31	2.86	0.40	0.39
query32	3.26	0.49	0.47
query33	2.90	2.87	2.95
query34	17.02	4.36	4.34
query35	4.39	4.41	4.39
query36	0.66	0.47	0.48
query37	0.19	0.16	0.15
query38	0.16	0.15	0.15
query39	0.04	0.03	0.03
query40	0.16	0.13	0.13
query41	0.09	0.05	0.05
query42	0.06	0.04	0.05
query43	0.04	0.04	0.03
Total cold run time: 110.27 s
Total hot run time: 30.74 s

…adata to avoid holding the lock for an extended period.#38162 (#38163) ## Proposed changes #38162

github-actions · 2024-07-22T02:15:43Z

PR approved by at least one committer and no changes requested.

CalvinKirs · 2024-07-22T02:16:38Z

run cloud_p0

CalvinKirs · 2024-07-23T02:08:32Z

run cloud_p0

…adata to avoid holding the lock for an extended period. (#38162) ## Proposed changes When deleting a job in MV, a DB lock is held. However, due to the larger lock granularity of the Job Manager, this may prevent obtaining the lock. This issue arises because during the creation of a job, immediately scheduled tasks need to perform their initial scheduling and compensate for tasks within the time window. To alleviate this issue, we are attempting to reduce the lock granularity.

…adata to avoid holding the lock for an extended period. (apache#38162) ## Proposed changes When deleting a job in MV, a DB lock is held. However, due to the larger lock granularity of the Job Manager, this may prevent obtaining the lock. This issue arises because during the creation of a job, immediately scheduled tasks need to perform their initial scheduling and compensate for tasks within the time window. To alleviate this issue, we are attempting to reduce the lock granularity.

[Fix](JobManager)Release the lock immediately after modifying job met…
a5960cf
…adata to avoid holding the lock for an extended period.

yiguolei force-pushed the master-job-lock branch from 1ab1d57 to a5960cfCompare July 19, 2024 22:55

yiguolei previously approved these changes Jul 19, 2024
View reviewed changes

github-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Jul 19, 2024

CalvinKirs added 2 commits July 20, 2024 07:56

[Fix](JobManager)Release the lock immediately after modifying job met…
1f1de40
…adata to avoid holding the lock for an extended period.

Merge remote-tracking branch 'origin/master-job-lock' into master-job…
b2590fc
…-lock # Conflicts: # fe/fe-core/src/main/java/org/apache/doris/job/manager/JobManager.java

CalvinKirs dismissed yiguolei’s stale review via b2590fcJuly 19, 2024 23:58

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label Jul 19, 2024

CalvinKirs added a commit to CalvinKirs/incubator-doris that referenced this pull request Jul 20, 2024
[Fix](JobManager)Release the lock immediately after modifying job met…
7c970a9
…adata to avoid holding the lock for an extended period.apache#38162

CalvinKirs mentioned this pull request Jul 20, 2024
[Fix](JobManager)Release the lock immediately after modifying job metadata to avoid holding the lock for an extended period.#38162 #38163
Merged

yiguolei pushed a commit that referenced this pull request Jul 20, 2024
[Fix](JobManager)Release the lock immediately after modifying job met…
8730685
…adata to avoid holding the lock for an extended period.#38162 (#38163) ## Proposed changes #38162

wm1581066 added the dev/2.1.5-merged label Jul 21, 2024

zddr approved these changes Jul 22, 2024
View reviewed changes

JNSimba approved these changes Jul 22, 2024
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Jul 22, 2024

CalvinKirs merged commit ba5aa31 into apache:masterJul 23, 2024

CalvinKirs deleted the master-job-lock branch July 23, 2024 04:05

morningman added dev/2.1.6-merged dev/2.1.5-merged and removed dev/2.1.5-merged dev/2.1.6-merged labels Jul 26, 2024

dataroaring added the dev/3.0.1-merged label Aug 5, 2024

gavinchou mentioned this pull request Aug 19, 2024
Release Note 3.0.1 #39570
Closed

Uh oh!

Conversation

CalvinKirs commented Jul 19, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Uh oh!

doris-robot commented Jul 19, 2024

Uh oh!

CalvinKirs commented Jul 19, 2024

Uh oh!

doris-robot commented Jul 19, 2024

Uh oh!

doris-robot commented Jul 19, 2024

Uh oh!

doris-robot commented Jul 19, 2024

Uh oh!

yiguolei commented Jul 19, 2024

Uh oh!

github-actionsBot commented Jul 19, 2024

Uh oh!

github-actionsBot commented Jul 19, 2024

Uh oh!

doris-robot commented Jul 19, 2024

Uh oh!

doris-robot commented Jul 19, 2024

Uh oh!

doris-robot commented Jul 19, 2024

Uh oh!

CalvinKirs commented Jul 19, 2024

Uh oh!

doris-robot commented Jul 20, 2024

Uh oh!

doris-robot commented Jul 20, 2024

Uh oh!

doris-robot commented Jul 20, 2024

Uh oh!

github-actionsBot commented Jul 22, 2024

Uh oh!

CalvinKirs commented Jul 22, 2024

Uh oh!

CalvinKirs commented Jul 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

CalvinKirs commented Jul 19, 2024•
edited
Loading