Skip to content

[branch-2.0](function) fix coredump for MULTI_MATCH_ANY (#37959) - #38315

Merged
xiaokang merged 2 commits into
apache:branch-2.0from
zclllyybb:pick_regexp_20
Jul 31, 2024
Merged

[branch-2.0](function) fix coredump for MULTI_MATCH_ANY (#37959)#38315
xiaokang merged 2 commits into
apache:branch-2.0from
zclllyybb:pick_regexp_20

Conversation

@zclllyybb

@zclllyybbzclllyybb commented Jul 24, 2024

Copy link
Copy Markdown
Contributor

pick #37959

[INVALID_ARGUMENT][E33] Compile regexp expression failed. got Embedded start anchors not supported.. some expressions may be illegal

@zclllyybb
[Fix](function) fix coredump for MULTI_MATCH_ANY (apache#37959)
186f541
[INVALID_ARGUMENT][E33] Compile regexp expression failed. got Embedded start anchors not supported.. some expressions may be illegal
@doris-robot

doris-robot commented Jul 24, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zclllyybb

zclllyybb commented Jul 24, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

github-actions[bot]
github-actionsBot reviewed Jul 24, 2024
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadbe/src/vec/functions/regexps.h
@@ -21,21 +21,20 @@
#pragma once

#include <hs/hs.h>

@github-actionsgithub-actionsBotJul 24, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'hs/hs.h' file not found [clang-diagnostic-error]

#include<hs/hs.h>
^

@zclllyybb

zclllyybb commented Jul 24, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Jul 24, 2024

Copy link
Copy Markdown
TPC-H: Total hot run time: 49814 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit abacb82ceee5e2281557d63f701af123c3fe4b59, data reload: false
------ Round 1 ----------------------------------
q1	18111	4367	4399	4367
q2	2082	157	147	147
q3	10265	1908	1954	1908
q4	10291	1234	1345	1234
q5	8466	3879	3910	3879
q6	237	147	127	127
q7	2014	1596	1594	1594
q8	9345	2732	2699	2699
q9	10560	10211	10096	10096
q10	8670	3513	3493	3493
q11	423	250	249	249
q12	471	304	310	304
q13	18366	3987	4083	3987
q14	358	328	340	328
q15	517	466	472	466
q16	683	571	577	571
q17	1129	930	991	930
q18	7348	6901	6956	6901
q19	1810	1701	1665	1665
q20	541	327	304	304
q21	4488	4170	4117	4117
q22	557	455	448	448
Total cold run time: 116732 ms
Total hot run time: 49814 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4411	4377	4344	4344
q2	335	230	235	230
q3	4236	4188	4182	4182
q4	2790	2777	2792	2777
q5	7184	7129	7090	7090
q6	240	124	121	121
q7	3259	2829	2871	2829
q8	4438	4499	4543	4499
q9	17144	17034	17149	17034
q10	4407	4338	4262	4262
q11	735	717	714	714
q12	1050	866	867	866
q13	7194	3808	3806	3806
q14	462	444	448	444
q15	521	474	458	458
q16	748	695	684	684
q17	3792	3811	3867	3811
q18	8869	8807	8813	8807
q19	1704	1720	1680	1680
q20	2370	2144	2130	2130
q21	8551	8416	8573	8416
q22	1087	964	992	964
Total cold run time: 85527 ms
Total hot run time: 80148 ms

@doris-robot

doris-robot commented Jul 24, 2024

Copy link
Copy Markdown
TPC-DS: Total hot run time: 204082 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit abacb82ceee5e2281557d63f701af123c3fe4b59, data reload: false
query1	928	421	378	378
query2	6543	2656	2827	2656
query3	6925	218	213	213
query4	21273	18017	17840	17840
query5	19745	6565	6574	6565
query6	289	218	236	218
query7	4158	318	329	318
query8	431	447	421	421
query9	3172	2745	2654	2654
query10	421	306	293	293
query11	11372	10740	10782	10740
query12	126	80	75	75
query13	5647	693	702	693
query14	17788	13636	13636	13636
query15	366	246	256	246
query16	6456	306	269	269
query17	1691	1434	862	862
query18	2332	415	413	413
query19	213	154	152	152
query20	86	83	82	82
query21	191	97	96	96
query22	5227	5045	4985	4985
query23	32529	32251	31910	31910
query24	6907	6551	6531	6531
query25	529	450	436	436
query26	527	171	166	166
query27	1867	302	312	302
query28	6152	2379	2332	2332
query29	2949	2907	2636	2636
query30	250	169	172	169
query31	912	734	739	734
query32	66	61	62	61
query33	413	242	237	237
query34	855	476	484	476
query35	1142	915	849	849
query36	1415	1244	1241	1241
query37	90	60	66	60
query38	3096	2928	2919	2919
query39	1365	1337	1332	1332
query40	212	96	97	96
query41	46	44	44	44
query42	82	87	84	84
query43	737	748	694	694
query44	1129	715	723	715
query45	252	234	234	234
query46	1251	975	976	975
query47	1872	1751	1881	1751
query48	1021	703	720	703
query49	626	371	371	371
query50	872	585	599	585
query51	4817	4680	4691	4680
query52	98	83	80	80
query53	456	333	336	333
query54	2675	2505	2517	2505
query55	81	78	80	78
query56	239	212	210	210
query57	1173	1130	1047	1047
query58	217	189	214	189
query59	4159	3842	4084	3842
query60	213	204	200	200
query61	105	90	93	90
query62	846	465	518	465
query63	492	353	347	347
query64	2334	1576	1476	1476
query65	3641	3565	3593	3565
query66	790	372	379	372
query67	15673	15748	15215	15215
query68	10528	665	679	665
query69	587	365	375	365
query70	2106	1602	1360	1360
query71	425	314	322	314
query72	6598	3538	3487	3487
query73	750	339	335	335
query74	6286	5914	5876	5876
query75	5346	3723	3790	3723
query76	6852	1159	1194	1159
query77	1188	257	269	257
query78	12856	11663	11562	11562
query79	10519	655	671	655
query80	1029	402	402	402
query81	492	237	235	235
query82	1100	107	103	103
query83	165	135	139	135
query84	261	73	71	71
query85	893	332	336	332
query86	329	287	293	287
query87	3221	2999	3102	2999
query88	4578	2374	2377	2374
query89	491	293	301	293
query90	2014	219	221	219
query91	178	145	138	138
query92	59	55	55	55
query93	7197	567	594	567
query94	739	212	214	212
query95	1104	1073	1068	1068
query96	686	337	332	332
query97	6496	6395	6354	6354
query98	204	180	164	164
query99	3112	957	842	842
Total cold run time: 320942 ms
Total hot run time: 204082 ms

@doris-robot

doris-robot commented Jul 24, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.81% (8117/21466)
Line Coverage: 29.48% (66548/225766)
Region Coverage: 28.95% (34299/118471)
Branch Coverage: 24.84% (17628/70962)
Coverage Report: http://coverage.selectdb-in.cc/coverage/abacb82ceee5e2281557d63f701af123c3fe4b59_abacb82ceee5e2281557d63f701af123c3fe4b59/report/index.html

@doris-robot

doris-robot commented Jul 24, 2024

Copy link
Copy Markdown
ClickBench: Total hot run time: 30.69 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit abacb82ceee5e2281557d63f701af123c3fe4b59, data reload: false
query1	0.03	0.02	0.03
query2	0.07	0.02	0.02
query3	0.25	0.05	0.06
query4	1.76	0.08	0.09
query5	0.54	0.53	0.53
query6	1.27	0.62	0.62
query7	0.01	0.01	0.01
query8	0.03	0.02	0.02
query9	0.53	0.50	0.48
query10	0.53	0.54	0.53
query11	0.11	0.08	0.08
query12	0.12	0.09	0.09
query13	0.63	0.61	0.60
query14	0.80	0.80	0.80
query15	0.79	0.77	0.77
query16	0.36	0.38	0.35
query17	1.00	1.03	1.01
query18	0.21	0.26	0.25
query19	1.93	1.84	1.80
query20	0.02	0.01	0.00
query21	15.48	0.55	0.56
query22	2.33	2.04	1.61
query23	17.25	1.12	0.96
query24	6.50	0.86	1.51
query25	0.41	0.11	0.06
query26	0.67	0.18	0.15
query27	0.04	0.04	0.05
query28	6.26	0.79	0.75
query29	12.65	2.32	2.21
query30	0.57	0.54	0.53
query31	2.81	0.39	0.37
query32	3.38	0.50	0.51
query33	3.06	3.09	3.09
query34	15.28	4.78	4.80
query35	4.87	4.86	4.85
query36	1.07	1.02	1.01
query37	0.06	0.05	0.05
query38	0.03	0.02	0.02
query39	0.02	0.02	0.01
query40	0.17	0.14	0.14
query41	0.07	0.01	0.02
query42	0.03	0.01	0.01
query43	0.02	0.02	0.02
Total cold run time: 104.02 s
Total hot run time: 30.69 s

@doris-robot

doris-robot commented Jul 24, 2024

Copy link
Copy Markdown

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit abacb82ceee5e2281557d63f701af123c3fe4b59 with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 21.1 seconds inserted 10000000 Rows, about 473K ops/s

@xiaokang
xiaokang merged commit 9bf4a01 into apache:branch-2.0Jul 31, 2024
mongo360 pushed a commit to mongo360/doris that referenced this pull request Dec 11, 2024
@zclllyybbcaokaihua1
[branch-2.0](function) fix coredump for MULTI_MATCH_ANY (apache#37959) (
d88aed1
apache#38315)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

Assignees

No one assigned

Labels

kind/test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zclllyybb@doris-robot@xiaokang