Uh oh!
There was an error while loading. Please reload this page.
[Improvement](schema scan) Use async scanner for schema scanners - #38403
Conversation
doris-robot
commented
Jul 26, 2024
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Gabriel39
commented
Jul 26, 2024
run buildall |
| } | ||
| Status SchemaActiveQueriesScanner::_get_active_queries_block_from_fe() { | ||
| void SchemaActiveQueriesScanner::_get_next_block_internal() { |
There was a problem hiding this comment.
warning: function '_get_next_block_internal' exceeds recommended size/complexity thresholds [readability-function-size]
voidSchemaActiveQueriesScanner::_get_next_block_internal() {
^Additional context
be/src/exec/schema_scanner/schema_active_queries_scanner.cpp:53: 97 lines including whitespace and comments (threshold 80)
voidSchemaActiveQueriesScanner::_get_next_block_internal() {
^Gabriel39
commented
Jul 26, 2024
run buildall |
1 similar comment
Gabriel39
commented
Jul 26, 2024
run buildall |
doris-robot
commented
Jul 26, 2024
TPC-H: Total hot run time: 39114 ms |
doris-robot
commented
Jul 26, 2024
TPC-DS: Total hot run time: 171736 ms |
doris-robot
commented
Jul 26, 2024
ClickBench: Total hot run time: 31.28 s |
| } | ||
| Status SchemaActiveQueriesScanner::_get_active_queries_block_from_fe() { | ||
| void SchemaActiveQueriesScanner::_get_next_block_internal() { |
There was a problem hiding this comment.
warning: function '_get_next_block_internal' exceeds recommended size/complexity thresholds [readability-function-size]
voidSchemaActiveQueriesScanner::_get_next_block_internal() {
^Additional context
be/src/exec/schema_scanner/schema_active_queries_scanner.cpp:53: 98 lines including whitespace and comments (threshold 80)
voidSchemaActiveQueriesScanner::_get_next_block_internal() {
^Gabriel39
commented
Jul 26, 2024
run buildall |
doris-robot
commented
Jul 26, 2024
TPC-H: Total hot run time: 39404 ms |
doris-robot
commented
Jul 26, 2024
TPC-DS: Total hot run time: 172537 ms |
doris-robot
commented
Jul 26, 2024
ClickBench: Total hot run time: 31.14 s |
Gabriel39
commented
Jul 29, 2024
run buildall |
Gabriel39
commented
Jul 29, 2024
run buildall |
doris-robot
commented
Jul 29, 2024
TPC-H: Total hot run time: 39149 ms |
Gabriel39
commented
Jul 29, 2024
run buildall |
Uh oh!
There was an error while loading. Please reload this page.
doris-robot
commented
Jul 29, 2024
TPC-H: Total hot run time: 39602 ms |
doris-robot
commented
Jul 29, 2024
TPC-DS: Total hot run time: 174031 ms |
doris-robot
commented
Jul 29, 2024
ClickBench: Total hot run time: 30.61 s |
Gabriel39
commented
Jul 29, 2024
run buildall |
doris-robot
commented
Jul 29, 2024
TPC-H: Total hot run time: 41432 ms |
doris-robot
commented
Jul 29, 2024
TPC-DS: Total hot run time: 170005 ms |
doris-robot
commented
Jul 29, 2024
ClickBench: Total hot run time: 30.16 s |
Gabriel39
commented
Jul 29, 2024
run buildall |
doris-robot
commented
Jul 29, 2024
TPC-H: Total hot run time: 42501 ms |
doris-robot
commented
Jul 29, 2024
TPC-DS: Total hot run time: 169598 ms |
doris-robot
commented
Jul 29, 2024
ClickBench: Total hot run time: 30.03 s |
doris-robot
commented
Jul 30, 2024
ClickBench: Total hot run time: 30.42 s |
Gabriel39
commented
Jul 31, 2024
run buildall |
doris-robot
commented
Jul 31, 2024
TPC-H: Total hot run time: 41837 ms |
doris-robot
commented
Jul 31, 2024
TPC-DS: Total hot run time: 172158 ms |
doris-robot
commented
Jul 31, 2024
ClickBench: Total hot run time: 30.14 s |
PR approved by at least one committer and no changes requested. |
## Proposed changes Resolve conflicts by merging apache#38436 and apache#38403 <!--Describe your changes.-->
## Proposed changes Resolve conflicts by merging apache#38436 and apache#38403 <!--Describe your changes.-->
Proposed changes
Issue Number: close #xxx