[fix](type)support runtime predicate for time type (#38258) by Mryange · Pull Request #38466 · apache/doris

Mryange · 2024-07-29T06:50:05Z

Proposed changes

#38258

doris-robot · 2024-07-29T06:50:11Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

Mryange · 2024-07-29T06:50:18Z

run buildall

github-actions · 2024-07-29T06:57:28Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-07-29T07:25:52Z

TeamCity be ut coverage result:
Function Coverage: 37.81% (8118/21473)
Line Coverage: 29.47% (66581/225900)
Region Coverage: 28.96% (34320/118522)
Branch Coverage: 24.83% (17630/71004)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1121965ce4c043db12dad76ef107add66735a234_1121965ce4c043db12dad76ef107add66735a234/report/index.html

doris-robot · 2024-07-29T07:26:33Z

TPC-H: Total hot run time: 49920 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1121965ce4c043db12dad76ef107add66735a234, data reload: false
------ Round 1 ----------------------------------
q1	17922	4358	4371	4358
q2	2065	157	158	157
q3	10439	1894	1898	1894
q4	10311	1254	1326	1254
q5	8861	3915	3927	3915
q6	238	151	142	142
q7	2053	1611	1589	1589
q8	9296	2725	2713	2713
q9	11048	10292	10363	10292
q10	8631	3540	3484	3484
q11	427	247	246	246
q12	464	304	306	304
q13	18338	3910	4044	3910
q14	349	325	323	323
q15	506	469	469	469
q16	692	576	578	576
q17	1132	977	971	971
q18	7216	6977	6928	6928
q19	1802	1671	1600	1600
q20	526	309	294	294
q21	4397	4106	4077	4077
q22	526	450	424	424
Total cold run time: 117239 ms
Total hot run time: 49920 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4313	4621	4343	4343
q2	323	226	226	226
q3	4162	4134	4126	4126
q4	2761	2751	2734	2734
q5	7277	7173	7092	7092
q6	238	120	121	120
q7	3215	2865	2806	2806
q8	4350	4504	4466	4466
q9	17397	17076	17065	17065
q10	4221	4269	4259	4259
q11	764	698	700	698
q12	1022	848	848	848
q13	7215	3748	3742	3742
q14	466	422	429	422
q15	507	459	457	457
q16	739	685	681	681
q17	3795	3838	3897	3838
q18	8806	8678	8913	8678
q19	1732	1739	1641	1641
q20	2390	2155	2105	2105
q21	8514	8365	8444	8365
q22	1033	938	954	938
Total cold run time: 85240 ms
Total hot run time: 79650 ms

doris-robot · 2024-07-29T07:39:24Z

TPC-DS: Total hot run time: 204752 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1121965ce4c043db12dad76ef107add66735a234, data reload: false
query1	926	393	412	393
query2	6554	2742	2492	2492
query3	6917	205	201	201
query4	20807	18035	17988	17988
query5	19718	6549	6598	6549
query6	296	227	226	226
query7	4166	308	331	308
query8	432	408	406	406
query9	3227	2752	2665	2665
query10	420	297	308	297
query11	11277	10610	10660	10610
query12	134	80	80	80
query13	5615	707	705	705
query14	18196	13386	13623	13386
query15	364	245	247	245
query16	6476	291	267	267
query17	1691	1446	873	873
query18	2323	408	422	408
query19	208	151	153	151
query20	84	77	75	75
query21	199	95	98	95
query22	5158	4945	4945	4945
query23	32929	31923	32080	31923
query24	7030	6501	6511	6501
query25	521	422	445	422
query26	523	167	166	166
query27	1814	307	306	306
query28	6175	2390	2373	2373
query29	2844	2718	2803	2718
query30	248	168	169	168
query31	913	760	745	745
query32	71	62	59	59
query33	414	263	253	253
query34	850	484	472	472
query35	1149	939	923	923
query36	1357	1177	1198	1177
query37	91	60	58	58
query38	3101	2888	2918	2888
query39	1378	1329	1340	1329
query40	208	90	98	90
query41	49	43	44	43
query42	81	82	86	82
query43	686	686	738	686
query44	1167	715	722	715
query45	249	240	230	230
query46	1217	955	974	955
query47	1843	1845	1659	1659
query48	1023	731	703	703
query49	623	369	370	369
query50	861	579	607	579
query51	4814	4713	4686	4686
query52	93	93	79	79
query53	465	325	348	325
query54	2691	2491	2493	2491
query55	83	84	83	83
query56	237	211	219	211
query57	1226	1175	1147	1147
query58	214	210	194	194
query59	4259	4004	3993	3993
query60	212	205	203	203
query61	101	101	99	99
query62	857	437	468	437
query63	504	348	345	345
query64	2475	1544	1530	1530
query65	3636	3539	3567	3539
query66	768	379	390	379
query67	15433	15972	17213	15972
query68	10093	674	685	674
query69	574	358	342	342
query70	1956	1421	1439	1421
query71	392	315	327	315
query72	6569	3491	3484	3484
query73	732	321	332	321
query74	6329	5917	5813	5813
query75	5319	3739	3709	3709
query76	6599	1175	1183	1175
query77	1139	258	254	254
query78	12805	11632	11729	11632
query79	9890	657	659	657
query80	1165	405	417	405
query81	490	238	233	233
query82	1676	105	98	98
query83	170	138	140	138
query84	260	71	74	71
query85	895	349	336	336
query86	324	298	315	298
query87	3292	3053	3047	3047
query88	4746	2329	2323	2323
query89	480	297	287	287
query90	1946	217	211	211
query91	175	141	140	140
query92	60	58	55	55
query93	7204	584	599	584
query94	718	215	215	215
query95	1108	1084	1047	1047
query96	651	336	330	330
query97	6575	6451	6433	6433
query98	194	181	179	179
query99	3099	863	855	855
Total cold run time: 320296 ms
Total hot run time: 204752 ms

doris-robot · 2024-07-29T07:44:49Z

ClickBench: Total hot run time: 30.74 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1121965ce4c043db12dad76ef107add66735a234, data reload: false
query1	0.01	0.02	0.02
query2	0.07	0.02	0.02
query3	0.25	0.05	0.05
query4	1.79	0.06	0.06
query5	0.54	0.52	0.52
query6	1.22	0.61	0.62
query7	0.02	0.01	0.01
query8	0.03	0.02	0.02
query9	0.51	0.48	0.49
query10	0.55	0.54	0.52
query11	0.12	0.08	0.08
query12	0.12	0.09	0.08
query13	0.63	0.61	0.61
query14	0.77	0.78	0.79
query15	0.78	0.78	0.76
query16	0.36	0.36	0.35
query17	1.02	0.97	1.01
query18	0.21	0.26	0.23
query19	1.95	1.87	1.87
query20	0.01	0.01	0.02
query21	15.46	0.57	0.54
query22	2.15	2.41	1.58
query23	17.04	1.00	1.00
query24	6.76	0.97	0.96
query25	0.36	0.09	0.04
query26	0.74	0.14	0.15
query27	0.04	0.05	0.04
query28	6.77	0.78	0.75
query29	12.73	2.30	2.27
query30	0.60	0.54	0.53
query31	2.82	0.39	0.38
query32	3.38	0.50	0.50
query33	3.04	3.07	3.06
query34	15.23	4.80	4.79
query35	4.88	4.85	4.86
query36	1.08	1.01	1.02
query37	0.06	0.05	0.04
query38	0.04	0.02	0.02
query39	0.02	0.02	0.02
query40	0.16	0.14	0.14
query41	0.07	0.01	0.01
query42	0.02	0.01	0.02
query43	0.02	0.01	0.02
Total cold run time: 104.43 s
Total hot run time: 30.74 s

doris-robot · 2024-07-29T07:48:04Z

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 1121965ce4c043db12dad76ef107add66735a234 with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 21.4 seconds inserted 10000000 Rows, about 467K ops/s

Mryange · 2024-07-29T10:26:29Z

wait this #38483

## Proposed changes Issue Number: close #xxx

Mryange · 2024-07-30T05:01:06Z

run buildall

github-actions · 2024-07-30T05:07:19Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-07-30T05:24:25Z

TeamCity be ut coverage result:
Function Coverage: 37.81% (8120/21473)
Line Coverage: 29.48% (66603/225900)
Region Coverage: 28.97% (34340/118524)
Branch Coverage: 24.85% (17642/71006)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9722d1bb01efcc36aa216cbecf8d1ee750a8c134_9722d1bb01efcc36aa216cbecf8d1ee750a8c134/report/index.html

doris-robot · 2024-07-30T05:37:08Z

TPC-H: Total hot run time: 50765 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9722d1bb01efcc36aa216cbecf8d1ee750a8c134, data reload: false
------ Round 1 ----------------------------------
q1	17576	4451	4375	4375
q2	2103	159	146	146
q3	10299	1921	1909	1909
q4	10399	1288	1325	1288
q5	8462	3917	3950	3917
q6	259	127	127	127
q7	2085	1634	1631	1631
q8	9525	2730	2732	2730
q9	14007	10365	10354	10354
q10	8633	3544	3554	3544
q11	413	253	252	252
q12	471	306	319	306
q13	18657	4016	4062	4016
q14	382	334	346	334
q15	507	464	470	464
q16	678	582	575	575
q17	1151	955	941	941
q18	7595	7299	7299	7299
q19	1820	1686	1629	1629
q20	552	329	311	311
q21	4455	4223	4174	4174
q22	529	458	443	443
Total cold run time: 120558 ms
Total hot run time: 50765 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4411	4411	4329	4329
q2	321	227	228	227
q3	4200	4170	4209	4170
q4	2769	2775	2761	2761
q5	7138	7127	7121	7121
q6	244	122	123	122
q7	3260	2867	2839	2839
q8	4373	4446	4485	4446
q9	16854	16872	16860	16860
q10	4222	4240	4226	4226
q11	780	664	690	664
q12	1017	874	841	841
q13	6859	3772	3717	3717
q14	452	422	430	422
q15	507	462	461	461
q16	754	703	701	701
q17	3831	3814	3850	3814
q18	8691	8651	8768	8651
q19	1721	1694	1705	1694
q20	2410	2123	2138	2123
q21	8495	8473	8420	8420
q22	1053	1004	974	974
Total cold run time: 84362 ms
Total hot run time: 79583 ms

doris-robot · 2024-07-30T05:49:53Z

TPC-DS: Total hot run time: 206527 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9722d1bb01efcc36aa216cbecf8d1ee750a8c134, data reload: false
query1	931	428	384	384
query2	6547	2646	2684	2646
query3	6915	208	202	202
query4	21260	18051	18069	18051
query5	19749	6584	6549	6549
query6	287	225	247	225
query7	4164	306	306	306
query8	446	428	402	402
query9	3197	2771	2712	2712
query10	413	317	321	317
query11	11297	10707	10735	10707
query12	130	79	70	70
query13	5607	724	714	714
query14	17738	13393	13496	13393
query15	367	240	250	240
query16	6465	297	269	269
query17	1495	1502	901	901
query18	2254	429	434	429
query19	214	148	148	148
query20	78	81	79	79
query21	192	98	102	98
query22	5183	4991	5053	4991
query23	32411	32064	31937	31937
query24	6890	6563	6584	6563
query25	527	446	449	446
query26	522	167	167	167
query27	1816	305	299	299
query28	6227	2417	2367	2367
query29	2983	2861	2651	2651
query30	243	168	169	168
query31	916	790	750	750
query32	75	72	62	62
query33	410	263	251	251
query34	861	483	496	483
query35	1127	933	961	933
query36	1301	1451	1208	1208
query37	92	61	61	61
query38	3130	2965	2943	2943
query39	1381	1332	1320	1320
query40	208	101	101	101
query41	46	50	45	45
query42	82	84	86	84
query43	691	709	693	693
query44	1143	725	722	722
query45	256	252	237	237
query46	1238	983	1007	983
query47	1938	1832	1975	1832
query48	1029	737	727	727
query49	627	386	382	382
query50	860	614	619	614
query51	4777	4647	4706	4647
query52	98	81	83	81
query53	450	326	331	326
query54	2689	2508	2466	2466
query55	87	78	87	78
query56	241	235	213	213
query57	1172	1123	1103	1103
query58	227	225	201	201
query59	4248	4285	4104	4104
query60	220	198	213	198
query61	101	96	99	96
query62	864	521	469	469
query63	493	348	349	348
query64	2513	1536	1426	1426
query65	3607	3615	3602	3602
query66	772	377	387	377
query67	15745	15574	15726	15574
query68	8557	666	649	649
query69	580	346	340	340
query70	1561	1370	1419	1370
query71	421	323	325	323
query72	6548	3535	3548	3535
query73	738	331	318	318
query74	6243	5937	5825	5825
query75	5239	3823	3707	3707
query76	5248	1128	1176	1128
query77	863	260	266	260
query78	12623	13109	13788	13109
query79	11064	660	659	659
query80	810	400	409	400
query81	502	238	231	231
query82	273	95	103	95
query83	188	132	130	130
query84	260	72	71	71
query85	766	339	338	338
query86	329	301	295	295
query87	3281	3017	3074	3017
query88	5388	2346	2308	2308
query89	363	310	298	298
query90	2579	226	216	216
query91	179	139	152	139
query92	63	53	53	53
query93	2104	552	578	552
query94	1169	220	211	211
query95	1111	1086	1072	1072
query96	628	328	322	322
query97	6552	6387	6390	6387
query98	194	171	174	171
query99	2947	827	897	827
Total cold run time: 311634 ms
Total hot run time: 206527 ms

doris-robot · 2024-07-30T05:55:20Z

ClickBench: Total hot run time: 30.55 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9722d1bb01efcc36aa216cbecf8d1ee750a8c134, data reload: false
query1	0.03	0.02	0.02
query2	0.07	0.02	0.02
query3	0.24	0.05	0.05
query4	1.78	0.07	0.06
query5	0.54	0.52	0.51
query6	1.24	0.62	0.62
query7	0.02	0.01	0.01
query8	0.04	0.02	0.02
query9	0.54	0.48	0.49
query10	0.53	0.53	0.53
query11	0.12	0.08	0.08
query12	0.12	0.09	0.08
query13	0.62	0.61	0.60
query14	0.79	0.80	0.79
query15	0.77	0.77	0.78
query16	0.36	0.37	0.38
query17	1.02	1.03	1.01
query18	0.23	0.24	0.25
query19	1.97	1.90	1.85
query20	0.01	0.01	0.02
query21	15.45	0.57	0.56
query22	1.91	1.86	1.60
query23	16.96	1.10	0.85
query24	4.86	1.06	0.91
query25	0.36	0.13	0.05
query26	0.52	0.16	0.16
query27	0.03	0.04	0.05
query28	8.26	0.71	0.71
query29	12.68	2.33	2.27
query30	0.64	0.54	0.52
query31	2.79	0.38	0.40
query32	3.36	0.50	0.49
query33	3.08	3.01	3.04
query34	15.25	4.80	4.78
query35	4.86	4.84	4.84
query36	1.06	1.02	1.02
query37	0.06	0.05	0.04
query38	0.03	0.02	0.02
query39	0.02	0.02	0.01
query40	0.16	0.14	0.13
query41	0.07	0.02	0.01
query42	0.02	0.01	0.01
query43	0.03	0.02	0.02
Total cold run time: 103.5 s
Total hot run time: 30.55 s

doris-robot · 2024-07-30T05:58:32Z

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 9722d1bb01efcc36aa216cbecf8d1ee750a8c134 with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 21.4 seconds inserted 10000000 Rows, about 467K ops/s

…ache#38466)

[fix](type)support runtime predicate for time type (apache#38258)
1121965

github-actionsBot added the kind/test label Jul 29, 2024

Mryange marked this pull request as draft July 29, 2024 10:25

[env](case) fix error case without order by (apache#38483)
9722d1b
## Proposed changes Issue Number: close #xxx

Mryange marked this pull request as ready for review July 30, 2024 05:01

xiaokang merged commit 0a7f8eb into apache:branch-2.0Aug 1, 2024

mongo360 pushed a commit to mongo360/doris that referenced this pull request Dec 11, 2024
[fix](type)support runtime predicate for time type (apache#38258) (ap…
911d9b6
…ache#38466)

Uh oh!

Conversation

Mryange commented Jul 29, 2024

Proposed changes

Uh oh!

doris-robot commented Jul 29, 2024

Uh oh!

Mryange commented Jul 29, 2024

Uh oh!

github-actionsBot commented Jul 29, 2024

Uh oh!

doris-robot commented Jul 29, 2024

Uh oh!

doris-robot commented Jul 29, 2024

Uh oh!

doris-robot commented Jul 29, 2024

Uh oh!

doris-robot commented Jul 29, 2024

Uh oh!

doris-robot commented Jul 29, 2024

Uh oh!

Mryange commented Jul 29, 2024

Uh oh!

Mryange commented Jul 30, 2024

Uh oh!

github-actionsBot commented Jul 30, 2024

Uh oh!

doris-robot commented Jul 30, 2024

Uh oh!

doris-robot commented Jul 30, 2024

Uh oh!

doris-robot commented Jul 30, 2024

Uh oh!

doris-robot commented Jul 30, 2024

Uh oh!

doris-robot commented Jul 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants