[feature](inverted index) Add multi_match function (#37722) by zzzxl1993 · Pull Request #38877 · apache/doris

zzzxl1993 · 2024-08-05T08:42:46Z

#37722
#38931
#39149

doris-robot · 2024-08-05T08:42:50Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

zzzxl1993 · 2024-08-05T08:42:54Z

run buildall

github-actions

clang-tidy made some suggestions

github-actions · 2024-08-05T08:50:46Z

+ return Status::OK();
+}
+
+Status FunctionMultiMatch::eval_inverted_index(FunctionContext* context,


warning: function 'eval_inverted_index' exceeds recommended size/complexity thresholds [readability-function-size]
Status FunctionMultiMatch::eval_inverted_index(FunctionContext* context, ^
Additional context
be/src/vec/functions/function_multi_match.cpp:94: 85 lines including whitespace and comments (threshold 80)
Status FunctionMultiMatch::eval_inverted_index(FunctionContext* context, ^

github-actions · 2024-08-05T08:50:46Z

+
+#pragma once
+
+#include <boost/algorithm/string/split.hpp>


warning: 'boost/algorithm/string/split.hpp' file not found [clang-diagnostic-error]
#include<boost/algorithm/string/split.hpp> ^

zzzxl1993 · 2024-08-05T10:54:33Z

run buildall

doris-robot · 2024-08-05T12:13:29Z

TeamCity be ut coverage result:
Function Coverage: 36.37% (9274/25499)
Line Coverage: 27.90% (75833/271846)
Region Coverage: 26.74% (39000/145835)
Branch Coverage: 23.47% (19793/84338)
Coverage Report: http://coverage.selectdb-in.cc/coverage/8d4a68f4e133bff4353a41a28ec275e4352e6910_8d4a68f4e133bff4353a41a28ec275e4352e6910/report/index.html

zzzxl1993 · 2024-08-06T05:58:35Z

run buildall

doris-robot · 2024-08-06T07:23:59Z

TeamCity be ut coverage result:
Function Coverage: 36.37% (9274/25497)
Line Coverage: 27.90% (75855/271868)
Region Coverage: 26.75% (39012/145858)
Branch Coverage: 23.47% (19801/84368)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3049aa9a37badf3a28e5e87d761c621a7a2e7c8c_3049aa9a37badf3a28e5e87d761c621a7a2e7c8c/report/index.html

zzzxl1993 · 2024-08-07T03:53:22Z

run buildall

github-actions

clang-tidy made some suggestions

github-actions · 2024-08-07T04:01:15Z

+ return Status::OK();
+}
+
+Status FunctionMultiMatch::eval_inverted_index(FunctionContext* context,


warning: function 'eval_inverted_index' exceeds recommended size/complexity thresholds [readability-function-size]
Status FunctionMultiMatch::eval_inverted_index(FunctionContext* context, ^
Additional context
be/src/vec/functions/function_multi_match.cpp:98: 81 lines including whitespace and comments (threshold 80)
Status FunctionMultiMatch::eval_inverted_index(FunctionContext* context, ^

doris-robot · 2024-08-07T05:28:31Z

TeamCity be ut coverage result:
Function Coverage: 36.37% (9274/25501)
Line Coverage: 27.89% (75852/271986)
Region Coverage: 26.73% (39010/145922)
Branch Coverage: 23.44% (19792/84420)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ae15ddcfd5ed63f4229911c90cd3e6780839c1d5_ae15ddcfd5ed63f4229911c90cd3e6780839c1d5/report/index.html

zzzxl1993 · 2024-08-07T15:24:40Z

run buildall

doris-robot · 2024-08-07T16:32:48Z

TeamCity be ut coverage result:
Function Coverage: 36.33% (9265/25500)
Line Coverage: 27.82% (75674/272030)
Region Coverage: 26.67% (38935/145969)
Branch Coverage: 23.39% (19753/84452)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2c037960192f679e3775e7ef35d9ed830aab22ee_2c037960192f679e3775e7ef35d9ed830aab22ee/report/index.html

1. select * from tbl where multi_match(c1, 'c2, c3, c4', 'phrase_prefix', 'xxx'); 2. multi_match performs a match_phrase_prefix query on the columns specified in the first and second parameters. The value to be searched is specified in the fourth parameter.

… and v2 (apache#39149) ## Proposed changes 1. reversed Index v1 and v2 have different column names

zzzxl1993 · 2024-08-09T12:01:11Z

run buildall

github-actions

clang-tidy made some suggestions

github-actions · 2024-08-09T12:08:40Z

+ return Status::OK();
+}
+
+Status FunctionMultiMatch::eval_inverted_index(FunctionContext* context,


warning: function 'eval_inverted_index' exceeds recommended size/complexity thresholds [readability-function-size]
Status FunctionMultiMatch::eval_inverted_index(FunctionContext* context, ^
Additional context
be/src/vec/functions/function_multi_match.cpp:98: 87 lines including whitespace and comments (threshold 80)
Status FunctionMultiMatch::eval_inverted_index(FunctionContext* context, ^

doris-robot · 2024-08-09T13:22:59Z

TeamCity be ut coverage result:
Function Coverage: 36.46% (9299/25504)
Line Coverage: 27.98% (76200/272298)
Region Coverage: 26.80% (39154/146083)
Branch Coverage: 23.52% (19881/84536)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ff3378d5467d8efa0f1cf381f8670aafc90433fe_ff3378d5467d8efa0f1cf381f8670aafc90433fe/report/index.html

github-actionsBot reviewed Aug 5, 2024
View reviewed changes

zzzxl1993 force-pushed the branch-2.1.multi_match branch from 381c525 to 8d4a68fCompare August 5, 2024 10:54

zzzxl1993 marked this pull request as draft August 6, 2024 12:27

zzzxl1993 force-pushed the branch-2.1.multi_match branch from 3049aa9 to ae15ddcCompare August 7, 2024 03:53

github-actionsBot reviewed Aug 7, 2024
View reviewed changes

zzzxl1993 force-pushed the branch-2.1.multi_match branch from ae15ddc to 2c03796Compare August 7, 2024 07:25

zzzxl1993 marked this pull request as ready for review August 7, 2024 15:24

zzzxl1993and others added 3 commits August 9, 2024 20:00

[fix](inverted index) fix multi match result error
2486218

[fix](inverted index) multi match distinguishes the inverted index v1…
ff3378d
… and v2 (apache#39149) ## Proposed changes 1. reversed Index v1 and v2 have different column names

zzzxl1993 force-pushed the branch-2.1.multi_match branch from 87e7494 to ff3378dCompare August 9, 2024 12:00

github-actionsBot reviewed Aug 9, 2024
View reviewed changes

xiaokang merged commit 5e1e725 into apache:branch-2.1Aug 10, 2024


		#pragma once

		#include <boost/algorithm/string/split.hpp>

Uh oh!

Conversation

zzzxl1993 commented Aug 5, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

doris-robot commented Aug 5, 2024

Uh oh!

zzzxl1993 commented Aug 5, 2024

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBotAug 5, 2024

Choose a reason for hiding this comment

Uh oh!

github-actionsBotAug 5, 2024

Choose a reason for hiding this comment

Uh oh!

zzzxl1993 commented Aug 5, 2024

Uh oh!

doris-robot commented Aug 5, 2024

Uh oh!

zzzxl1993 commented Aug 6, 2024

Uh oh!

doris-robot commented Aug 6, 2024

Uh oh!

zzzxl1993 commented Aug 7, 2024

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBotAug 7, 2024

Choose a reason for hiding this comment

Uh oh!

doris-robot commented Aug 7, 2024

Uh oh!

zzzxl1993 commented Aug 7, 2024

Uh oh!

doris-robot commented Aug 7, 2024

Uh oh!

zzzxl1993 commented Aug 9, 2024

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBotAug 9, 2024

Choose a reason for hiding this comment

Uh oh!

doris-robot commented Aug 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zzzxl1993 commented Aug 5, 2024•
edited
Loading