[fix](cluster key) some data type is not supported for cluster key by mymeiyi · Pull Request #38966 · apache/doris

mymeiyi · 2024-08-06T10:14:06Z

some data type is not supported for key column, it's the same for cluster key column
modify some cluster key cases as the mow cases

doris-robot · 2024-08-06T10:14:12Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

mymeiyi · 2024-08-06T10:38:36Z

run buildall

doris-robot · 2024-08-06T11:17:03Z

TPC-H: Total hot run time: 41048 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ada2d291db3c521a1412eb236615f18cc72b2bc8, data reload: false
------ Round 1 ----------------------------------
q1	17633	4045	4015	4015
q2	2019	213	198	198
q3	10458	1252	1295	1252
q4	10174	790	927	790
q5	7617	2939	2938	2938
q6	218	135	134	134
q7	1040	613	602	602
q8	9422	1781	1930	1781
q9	8479	6595	6527	6527
q10	8717	3821	3800	3800
q11	434	245	243	243
q12	408	226	224	224
q13	17761	2953	2933	2933
q14	267	248	246	246
q15	514	476	498	476
q16	526	405	380	380
q17	955	934	920	920
q18	7935	7318	7157	7157
q19	1436	1208	1196	1196
q20	558	326	337	326
q21	5276	4676	4628	4628
q22	351	282	287	282
Total cold run time: 112198 ms
Total hot run time: 41048 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4073	3986	3988	3986
q2	331	227	229	227
q3	2985	3006	3052	3006
q4	1950	1993	2031	1993
q5	5531	5489	5430	5430
q6	217	135	128	128
q7	2077	1785	1797	1785
q8	3284	3338	3290	3290
q9	8585	8627	8734	8627
q10	3939	4021	3944	3944
q11	551	439	453	439
q12	739	618	619	618
q13	16479	3084	3108	3084
q14	315	279	274	274
q15	540	509	486	486
q16	458	404	404	404
q17	1748	1739	1705	1705
q18	8201	7628	7793	7628
q19	1700	1690	1718	1690
q20	2088	1859	1830	1830
q21	5661	5431	5299	5299
q22	532	449	458	449
Total cold run time: 71984 ms
Total hot run time: 56322 ms

doris-robot · 2024-08-06T11:27:45Z

TPC-DS: Total hot run time: 169903 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ada2d291db3c521a1412eb236615f18cc72b2bc8, data reload: false
query1	914	377	371	371
query2	6454	1680	1697	1680
query3	6653	211	222	211
query4	20342	17432	17232	17232
query5	3648	535	544	535
query6	279	173	173	173
query7	4596	310	296	296
query8	257	199	201	199
query9	8519	2389	2388	2388
query10	455	313	279	279
query11	10468	9954	10151	9954
query12	124	89	113	89
query13	1630	378	364	364
query14	8845	7664	7033	7033
query15	205	165	163	163
query16	6819	463	487	463
query17	954	570	544	544
query18	1935	282	297	282
query19	193	146	144	144
query20	93	87	89	87
query21	214	102	101	101
query22	4277	4109	3959	3959
query23	33739	33658	33533	33533
query24	10450	3093	3114	3093
query25	716	410	421	410
query26	1791	164	153	153
query27	2956	290	294	290
query28	7592	2041	2017	2017
query29	1292	437	437	437
query30	233	156	161	156
query31	971	797	794	794
query32	105	58	61	58
query33	712	346	332	332
query34	935	506	507	506
query35	891	765	764	764
query36	1033	874	896	874
query37	222	82	80	80
query38	2865	2787	2758	2758
query39	897	816	837	816
query40	260	120	120	120
query41	53	52	46	46
query42	118	104	103	103
query43	473	429	425	425
query44	1211	733	740	733
query45	214	179	183	179
query46	1118	822	806	806
query47	1793	1708	1745	1708
query48	371	297	298	297
query49	991	432	440	432
query50	901	444	443	443
query51	6793	6768	6755	6755
query52	109	88	93	88
query53	273	189	185	185
query54	655	455	452	452
query55	77	77	75	75
query56	282	258	271	258
query57	1127	1055	1024	1024
query58	291	271	274	271
query59	2473	2293	2407	2293
query60	309	284	282	282
query61	97	95	92	92
query62	900	654	659	654
query63	219	194	193	193
query64	5595	1989	1927	1927
query65	3174	3083	3110	3083
query66	1309	351	331	331
query67	15208	15241	14837	14837
query68	4335	578	587	578
query69	620	360	306	306
query70	1103	1050	1059	1050
query71	439	287	287	287
query72	7050	2743	2482	2482
query73	788	331	330	330
query74	6000	5632	5587	5587
query75	3388	2749	2756	2749
query76	2590	1200	1287	1200
query77	479	317	328	317
query78	9428	8878	8870	8870
query79	1925	560	544	544
query80	1122	518	530	518
query81	563	235	227	227
query82	1033	139	198	139
query83	242	174	175	174
query84	279	80	81	80
query85	1286	331	307	307
query86	448	321	303	303
query87	3230	3072	3104	3072
query88	2993	2429	2440	2429
query89	400	294	298	294
query90	1735	196	203	196
query91	132	105	101	101
query92	65	51	52	51
query93	1747	616	623	616
query94	825	306	298	298
query95	390	280	279	279
query96	623	283	288	283
query97	3225	3085	3043	3043
query98	217	204	201	201
query99	1614	1282	1284	1282
Total cold run time: 261982 ms
Total hot run time: 169903 ms

doris-robot · 2024-08-06T11:33:14Z

ClickBench: Total hot run time: 30.29 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ada2d291db3c521a1412eb236615f18cc72b2bc8, data reload: false
query1	0.05	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.06	0.05
query4	1.67	0.06	0.06
query5	0.50	0.47	0.48
query6	1.14	0.72	0.72
query7	0.03	0.01	0.01
query8	0.05	0.04	0.05
query9	0.58	0.53	0.51
query10	0.56	0.57	0.57
query11	0.16	0.12	0.12
query12	0.15	0.12	0.12
query13	0.63	0.61	0.60
query14	0.78	0.81	0.80
query15	0.90	0.86	0.87
query16	0.35	0.35	0.36
query17	1.02	1.04	1.00
query18	0.22	0.21	0.21
query19	1.85	1.70	1.77
query20	0.01	0.00	0.02
query21	15.40	0.75	0.65
query22	4.02	7.13	1.57
query23	18.50	1.36	1.32
query24	2.27	0.22	0.22
query25	0.19	0.08	0.07
query26	0.32	0.22	0.21
query27	0.46	0.23	0.23
query28	13.18	0.99	0.97
query29	12.51	3.38	3.32
query30	0.25	0.05	0.06
query31	2.87	0.42	0.40
query32	3.24	0.50	0.48
query33	2.93	2.96	2.94
query34	15.44	4.29	4.25
query35	4.30	4.26	4.28
query36	0.67	0.48	0.48
query37	0.19	0.16	0.17
query38	0.17	0.15	0.16
query39	0.04	0.03	0.04
query40	0.17	0.14	0.13
query41	0.10	0.05	0.04
query42	0.06	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 108.28 s
Total hot run time: 30.29 s

dataroaring

LGTM

github-actions · 2024-08-07T01:49:57Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-08-07T01:49:59Z

PR approved by anyone and no changes requested.

mymeiyi · 2024-08-07T03:10:38Z

run buildall

mymeiyi · 2024-08-07T06:24:49Z

run cloud_p1

mymeiyi · 2024-08-07T06:24:59Z

run performance

mymeiyi · 2024-08-07T09:05:42Z

run performance

doris-robot · 2024-08-07T09:23:23Z

TPC-H: Total hot run time: 41618 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit af3b736b502d4c5a8497559c4f0f9d81cedc83aa, data reload: false
------ Round 1 ----------------------------------
q1	18397	4173	4145	4145
q2	2453	210	205	205
q3	11380	1324	1382	1324
q4	11146	816	942	816
q5	8863	2965	2969	2965
q6	217	140	143	140
q7	1066	619	611	611
q8	9449	1848	1951	1848
q9	8546	6644	6595	6595
q10	8702	3826	3858	3826
q11	428	257	262	257
q12	413	235	231	231
q13	17761	2929	2933	2929
q14	276	238	241	238
q15	533	483	499	483
q16	500	402	384	384
q17	987	923	918	918
q18	7978	7355	7215	7215
q19	1377	1214	1216	1214
q20	584	314	343	314
q21	5354	4680	4700	4680
q22	359	289	280	280
Total cold run time: 116769 ms
Total hot run time: 41618 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4144	4029	4023	4023
q2	332	221	220	220
q3	2994	2992	2976	2976
q4	1865	1876	1871	1871
q5	5253	5248	5235	5235
q6	217	133	136	133
q7	2041	1705	1680	1680
q8	3169	3239	3196	3196
q9	8309	8256	8278	8256
q10	3763	3859	3826	3826
q11	554	465	453	453
q12	704	552	558	552
q13	16095	2966	2933	2933
q14	286	266	257	257
q15	529	480	483	480
q16	448	408	408	408
q17	1722	1668	1706	1668
q18	7618	7332	7206	7206
q19	1661	1664	1667	1664
q20	2002	1763	1741	1741
q21	5409	5116	5404	5116
q22	552	463	477	463
Total cold run time: 69667 ms
Total hot run time: 54357 ms

doris-robot · 2024-08-07T09:34:14Z

TPC-DS: Total hot run time: 168868 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit af3b736b502d4c5a8497559c4f0f9d81cedc83aa, data reload: false
query1	909	377	365	365
query2	6467	1629	1734	1629
query3	6667	209	224	209
query4	19729	17480	17297	17297
query5	4306	519	503	503
query6	281	161	162	161
query7	4590	296	288	288
query8	255	204	200	200
query9	8518	2327	2316	2316
query10	442	308	263	263
query11	10598	10008	10001	10001
query12	139	90	87	87
query13	1632	375	375	375
query14	9978	7723	7472	7472
query15	212	159	170	159
query16	7061	474	456	456
query17	982	564	563	563
query18	1828	290	297	290
query19	208	153	147	147
query20	97	85	85	85
query21	211	97	99	97
query22	4238	4094	4059	4059
query23	33734	32896	32811	32811
query24	10238	3073	3029	3029
query25	698	400	420	400
query26	1745	153	162	153
query27	2843	276	280	276
query28	6807	1953	1929	1929
query29	1280	436	423	423
query30	283	150	153	150
query31	938	751	771	751
query32	102	61	61	61
query33	722	330	314	314
query34	915	475	483	475
query35	858	730	713	713
query36	998	854	867	854
query37	277	84	79	79
query38	2862	2772	2772	2772
query39	862	804	840	804
query40	285	117	114	114
query41	50	47	46	46
query42	129	95	105	95
query43	459	404	442	404
query44	1184	722	719	719
query45	211	182	178	178
query46	1091	842	783	783
query47	1831	1717	1742	1717
query48	371	291	302	291
query49	1188	438	426	426
query50	893	438	437	437
query51	6850	6730	6652	6652
query52	102	88	92	88
query53	254	179	182	179
query54	631	458	458	458
query55	80	75	77	75
query56	295	263	268	263
query57	1188	1051	1035	1035
query58	289	292	274	274
query59	2463	2343	2418	2343
query60	401	275	281	275
query61	130	98	97	97
query62	931	656	672	656
query63	215	181	175	175
query64	5940	1931	1874	1874
query65	3137	3106	3069	3069
query66	1426	333	336	333
query67	15234	14972	14685	14685
query68	5423	572	570	570
query69	790	393	320	320
query70	1077	1081	1045	1045
query71	501	280	276	276
query72	8148	2671	2467	2467
query73	922	324	328	324
query74	6049	5626	5687	5626
query75	4465	2750	2696	2696
query76	3745	1252	1280	1252
query77	698	303	302	302
query78	9482	8926	8929	8926
query79	3870	533	535	533
query80	1132	501	504	501
query81	561	227	223	223
query82	884	127	134	127
query83	338	176	179	176
query84	270	76	79	76
query85	1494	328	348	328
query86	438	299	293	293
query87	3299	3135	3057	3057
query88	3789	2413	2394	2394
query89	469	286	291	286
query90	2012	192	190	190
query91	128	99	104	99
query92	66	52	50	50
query93	4622	619	612	612
query94	941	290	298	290
query95	391	272	274	272
query96	626	281	283	281
query97	3254	3010	3041	3010
query98	223	200	198	198
query99	1604	1311	1317	1311
Total cold run time: 274479 ms
Total hot run time: 168868 ms

doris-robot · 2024-08-07T09:39:44Z

ClickBench: Total hot run time: 29.94 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit af3b736b502d4c5a8497559c4f0f9d81cedc83aa, data reload: false
query1	0.05	0.04	0.04
query2	0.08	0.04	0.03
query3	0.23	0.06	0.05
query4	1.69	0.07	0.06
query5	0.48	0.48	0.48
query6	1.13	0.72	0.71
query7	0.02	0.01	0.02
query8	0.04	0.04	0.04
query9	0.58	0.52	0.51
query10	0.58	0.57	0.58
query11	0.15	0.11	0.12
query12	0.15	0.12	0.12
query13	0.60	0.61	0.60
query14	0.78	0.81	0.80
query15	0.91	0.86	0.88
query16	0.36	0.36	0.36
query17	0.99	0.99	0.98
query18	0.23	0.21	0.20
query19	1.86	1.70	1.77
query20	0.02	0.01	0.01
query21	15.42	0.77	0.68
query22	3.78	8.05	1.24
query23	18.14	1.36	1.30
query24	2.30	0.22	0.22
query25	0.19	0.08	0.07
query26	0.32	0.21	0.23
query27	0.46	0.23	0.23
query28	13.17	1.00	0.97
query29	12.53	3.30	3.28
query30	0.27	0.06	0.06
query31	2.86	0.41	0.41
query32	3.23	0.50	0.49
query33	2.94	2.97	2.94
query34	15.42	4.24	4.25
query35	4.28	4.29	4.31
query36	0.69	0.49	0.48
query37	0.19	0.16	0.15
query38	0.16	0.14	0.16
query39	0.04	0.04	0.04
query40	0.16	0.14	0.12
query41	0.10	0.05	0.05
query42	0.06	0.05	0.05
query43	0.04	0.05	0.04
Total cold run time: 107.68 s
Total hot run time: 29.94 s

dataroaring

LGTM

github-actions · 2024-08-07T15:45:38Z

PR approved by at least one committer and no changes requested.

…38966) 1. some data type is not supported for key column, it's the same for cluster key column 2. modify some cluster key cases as the mow cases

…pache#38966) 1. some data type is not supported for key column, it's the same for cluster key column 2. modify some cluster key cases as the mow cases

…38966) 1. some data type is not supported for key column, it's the same for cluster key column 2. modify some cluster key cases as the mow cases

…pache#38966) 1. some data type is not supported for key column, it's the same for cluster key column 2. modify some cluster key cases as the mow cases

github-actionsBot added the doing label Aug 6, 2024

dataroaring previously approved these changes Aug 7, 2024
View reviewed changes

dataroaring added not-merge/2.1 not-merge/3.0 labels Aug 7, 2024

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 7, 2024

github-actionsBot added the reviewed label Aug 7, 2024

bobhan1 approved these changes Aug 7, 2024
View reviewed changes

Yukang-Lian approved these changes Aug 7, 2024
View reviewed changes

mymeiyi added 2 commits August 7, 2024 10:45

[fix](cluster key) some data type is not supported for cluster key
09a1fd5

fix case
af3b736

mymeiyi dismissed dataroaring’s stale review via af3b736August 7, 2024 03:10

mymeiyi force-pushed the cluster-key-column-type branch from ada2d29 to af3b736Compare August 7, 2024 03:10

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label Aug 7, 2024

dataroaring approved these changes Aug 7, 2024
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 7, 2024

dataroaring merged commit adeae3c into apache:masterAug 7, 2024

dataroaring added the dev/3.0.2-merged label Aug 12, 2024

gavinchou mentioned this pull request Oct 13, 2024
Release Note 3.0.2 #41558
Closed

Uh oh!

Conversation

mymeiyi commented Aug 6, 2024

Uh oh!

doris-robot commented Aug 6, 2024

Uh oh!

mymeiyi commented Aug 6, 2024

Uh oh!

doris-robot commented Aug 6, 2024

Uh oh!

doris-robot commented Aug 6, 2024

Uh oh!

doris-robot commented Aug 6, 2024

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Aug 7, 2024

Uh oh!

github-actionsBot commented Aug 7, 2024

Uh oh!

mymeiyi commented Aug 7, 2024

Uh oh!

mymeiyi commented Aug 7, 2024

Uh oh!

mymeiyi commented Aug 7, 2024

Uh oh!

mymeiyi commented Aug 7, 2024

Uh oh!

doris-robot commented Aug 7, 2024

Uh oh!

doris-robot commented Aug 7, 2024

Uh oh!

doris-robot commented Aug 7, 2024

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Aug 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants