Skip to content

[Bug] Unify the timezone - #3910

Merged
morningman merged 3 commits into
apache:masterfrom
morningman:checkpoint_thread_missing
Jun 24, 2020
Merged

[Bug] Unify the timezone#3910
morningman merged 3 commits into
apache:masterfrom
morningman:checkpoint_thread_missing

Conversation

@morningman

@morningmanmorningman commented Jun 19, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

When we get default system time zone, it will return PRC, which is not supported by us, thus
will cause dynamic partition create failed. Fix#3919

This CL mainly changes:

  1. Use a unified method to get the system default time zone
  2. Now the default variable system_time_zone and time_zone is set to the default system
    time zone, which is Asia/Shanghai.
  3. Modify related unit test.
  4. Support time zone PRC.

@morningmanmorningman added kind/fix Categorizes issue or PR as related to a bug. area/catalog Issues or PRs related to catalog management labels Jun 19, 2020
@morningmanmorningman changed the title [Bug] Checkpoint thread is not running[Bug] Unify the timezoneJun 19, 2020
WingsGo
WingsGo reviewed Jun 19, 2020
View reviewed changes
Comment threadfe/src/main/java/org/apache/doris/catalog/Catalog.java Outdated
}

// NOTICE: In most cases, you should use getCurrentCatalog() to get the catalog.
// getServiingCatalog() is only used for Checkpoint thread and some special places

@WingsGoWingsGoJun 19, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getServingCatalog

@morningmanmorningmanJun 19, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I moved the change to PR #3229
I will rebase after that PR merged.

@morningmanmorningmanJun 21, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for review.

@morningman
morningmanforce-pushed the checkpoint_thread_missing branch from a543f78 to d42573fCompareJune 20, 2020 03:40
@morningman
morningmanforce-pushed the checkpoint_thread_missing branch from d42573f to 4a40cc1CompareJune 21, 2020 08:57
@WingsGo

WingsGo commented Jun 21, 2020

Copy link
Copy Markdown
Contributor

LGTM

EmmyMiao87
EmmyMiao87 approved these changes Jun 23, 2020
View reviewed changes

@EmmyMiao87EmmyMiao87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningmanmorningman added the approved Indicates a PR has been approved by one committer. label Jun 23, 2020
@morningman
morningman merged commit df8f9cc into apache:masterJun 24, 2020
suxiaogang223 pushed a commit to suxiaogang223/doris that referenced this pull request Jul 15, 2025
@bobhan1
(selectdb-cloud-4.0.4): pick [opt](cloud) Make get tablet stats and u…
8397e94
…pdate delete bitmap update lock be able to be in different fdb txns apache#45206 (apache#45559) (apache#3910)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EmmyMiao87EmmyMiao87EmmyMiao87 approved these changes
+1 more reviewer
@WingsGoWingsGoWingsGo left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.area/catalogIssues or PRs related to catalog managementkind/fixCategorizes issue or PR as related to a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Create table with dynamic partition encounter exception

4 participants

@morningman@WingsGo@EmmyMiao87@morningman-cmy