Skip to content

[Bug] Checkpoint thread is not running - #3913

Merged
morningman merged 2 commits into
apache:masterfrom
morningman:checkpoint_thread_bug
Jun 20, 2020
Merged

[Bug] Checkpoint thread is not running#3913
morningman merged 2 commits into
apache:masterfrom
morningman:checkpoint_thread_bug

Conversation

@morningman

@morningmanmorningman commented Jun 19, 2020

Copy link
Copy Markdown
Contributor

This bug is introduced by PR #3784
In #3784, I remove the Catalog.getInstance(), and use Catalog.getCurrentCatalog() instead.

But actually, there are some place that should use the serving catalog explicitly.

Mainly changed:

  1. Add a new method getServingCatalog() to explicitly return the real catalog instance.
  2. Fix a compile bug of broker introduced by [BUG]Fix broker read buffer size from input stream #3881

@morningmanmorningman added kind/fix Categorizes issue or PR as related to a bug. area/catalog Issues or PRs related to catalog management labels Jun 19, 2020
@morningmanmorningman self-assigned this Jun 19, 2020

@EmmyMiao87EmmyMiao87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningmanmorningman added the approved Indicates a PR has been approved by one committer. label Jun 19, 2020
@morningman
morningman merged commit 8e89595 into apache:masterJun 20, 2020
morningman added a commit to morningman/doris that referenced this pull request Jun 22, 2020
This bug is introduced by PR apache#3784 In apache#3784, I remove the `Catalog.getInstance()`, and use `Catalog.getCurrentCatalog()` instead.
But actually, there are some place that should use the serving catalog explicitly.
Mainly changed:
1. Add a new method `getServingCatalog()` to explicitly return the real catalog instance.
2. Fix a compile bug of broker introduced by apache#3881
acelyc111 pushed a commit to acelyc111/incubator-doris that referenced this pull request Jan 20, 2021
This bug is introduced by PR apache#3784
In apache#3784, I remove the `Catalog.getInstance()`, and use `Catalog.getCurrentCatalog()` instead.
But actually, there are some place that should use the serving catalog explicitly.
Mainly changed:
1. Add a new method `getServingCatalog()` to explicitly return the real catalog instance.
2. Fix a compile bug of broker introduced by apache#3881
suxiaogang223 pushed a commit to suxiaogang223/doris that referenced this pull request Jul 15, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.area/catalogIssues or PRs related to catalog managementkind/fixCategorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@morningman@EmmyMiao87@morningman-cmy