Skip to content

[Bug](brpc) fix sync_filter_size/apply_filterv2 has wrong closure - #39155

Merged
BiteTheDDDDt merged 4 commits into
apache:masterfrom
BiteTheDDDDt:dev_0809_3
Aug 13, 2024
Merged

[Bug](brpc) fix sync_filter_size/apply_filterv2 has wrong closure#39155
BiteTheDDDDt merged 4 commits into
apache:masterfrom
BiteTheDDDDt:dev_0809_3

Conversation

@BiteTheDDDDt

@BiteTheDDDDtBiteTheDDDDt commented Aug 9, 2024

Copy link
Copy Markdown
Contributor

Proposed changes

  1. fix sync_filter_size/apply_filterv2 has wrong closure
  2. avoid to use thread local storage of iobuf

@BiteTheDDDDt

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@BiteTheDDDDt

Copy link
Copy Markdown
ContributorAuthor

run buildall

@BiteTheDDDDtBiteTheDDDDt changed the title [Improvement](brpc) do not create iobuf on RuntimeFilterMergeControllerEntity::merge[Bug](brpc) fix sync_filter_size/apply_filterv2 has wrong clouseAug 12, 2024
@BiteTheDDDDtBiteTheDDDDt changed the title [Bug](brpc) fix sync_filter_size/apply_filterv2 has wrong clouse[Bug](brpc) fix sync_filter_size/apply_filterv2 has wrong closureAug 12, 2024
@BiteTheDDDDt

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

2 similar comments
@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@yiguoleiyiguolei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 13, 2024
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yiguoleiyiguolei added usercase Important user case type label dev/2.1.6-merged dev/3.0.x labels Aug 13, 2024
@BiteTheDDDDt
BiteTheDDDDt merged commit ee356e5 into apache:masterAug 13, 2024
wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Aug 14, 2024
…ache#39155)
## Proposed changes
1. fix sync_filter_size/apply_filterv2 has wrong closure
2. avoid to use thread local storage of iobuf
dataroaring pushed a commit that referenced this pull request Aug 17, 2024
…9155)
## Proposed changes
1. fix sync_filter_size/apply_filterv2 has wrong closure
2. avoid to use thread local storage of iobuf
@gavinchougavinchou mentioned this pull request Oct 13, 2024
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Nov 12, 2024
…ache#39155)
## Proposed changes
1. fix sync_filter_size/apply_filterv2 has wrong closure
2. avoid to use thread local storage of iobuf
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
…ache#39155)
## Proposed changes
1. fix sync_filter_size/apply_filterv2 has wrong closure
2. avoid to use thread local storage of iobuf
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.6-mergeddev/3.0.2-mergeddoingreviewedusercaseImportant user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@BiteTheDDDDt@yiguolei@Mryange@dataroaring