Skip to content

[Bug] Enable to get TCP metrics for linux kernel 2.x - #3921

Merged
morningman merged 5 commits into
apache:masterfrom
morningman:tcp_metric_bug
Jun 24, 2020
Merged

[Bug] Enable to get TCP metrics for linux kernel 2.x#3921
morningman merged 5 commits into
apache:masterfrom
morningman:tcp_metric_bug

Conversation

@morningman

@morningmanmorningman commented Jun 21, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Fix#3920

CL:

  1. Parse the TCP metrics header in /proc/net/snmp to get the right position of the metrics.
  2. Add 2 new metrics: tcp_in_segs and tcp_out_segs

@morningmanmorningman added kind/fix Categorizes issue or PR as related to a bug. area/metrics Issues or PRs related to the metrics labels Jun 21, 2020
@morningmanmorningman self-assigned this Jun 21, 2020
yangzhg
yangzhg previously approved these changes Jun 24, 2020
View reviewed changes

@yangzhgyangzhg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningmanmorningman added the approved Indicates a PR has been approved by one committer. label Jun 24, 2020
yangzhg
yangzhg approved these changes Jun 24, 2020
View reviewed changes

@yangzhgyangzhg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
morningman merged commit 46c64f0 into apache:masterJun 24, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yangzhgyangzhgyangzhg approved these changes

Assignees

@morningmanmorningman

Labels

approvedIndicates a PR has been approved by one committer.area/metricsIssues or PRs related to the metricskind/fixCategorizes issue or PR as related to a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Failed to get TCP metrics when linux kernel is 2.x

3 participants

@morningman@yangzhg@morningman-cmy