[Fix](Txn) Fix wrong columns sequence in txn model by Yukang-Lian · Pull Request #39295 · apache/doris

Yukang-Lian · 2024-08-13T08:25:26Z

Proposed changes

Issue Number: close #xxx

doris-robot · 2024-08-13T08:25:32Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

Yukang-Lian · 2024-08-13T09:47:29Z

run buildall

doris-robot · 2024-08-13T10:33:53Z

TPC-H: Total hot run time: 40143 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fcd02915b3a51574e68f2cc51e9656f59aeb2028, data reload: false
------ Round 1 ----------------------------------
q1	17618	4462	4267	4267
q2	2014	186	173	173
q3	12008	1012	1024	1012
q4	10493	742	714	714
q5	7771	2805	2817	2805
q6	223	143	141	141
q7	969	612	598	598
q8	9496	2035	2048	2035
q9	10155	6545	6562	6545
q10	7052	2229	2158	2158
q11	451	250	247	247
q12	388	220	217	217
q13	18832	2986	3009	2986
q14	276	233	237	233
q15	536	493	501	493
q16	494	391	390	390
q17	976	622	680	622
q18	8124	7529	7576	7529
q19	6891	1109	1099	1099
q20	693	345	343	343
q21	5231	4516	4517	4516
q22	1143	1043	1020	1020
Total cold run time: 121834 ms
Total hot run time: 40143 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4493	4303	4281	4281
q2	361	281	289	281
q3	2958	2811	2743	2743
q4	2138	1829	1748	1748
q5	5628	5569	5715	5569
q6	227	133	136	133
q7	2180	1750	1816	1750
q8	3292	3411	3383	3383
q9	8891	8779	8712	8712
q10	3437	3287	3289	3287
q11	609	494	522	494
q12	800	697	635	635
q13	16047	3156	3181	3156
q14	319	290	313	290
q15	528	500	489	489
q16	493	436	430	430
q17	1811	1506	1520	1506
q18	8301	7881	7886	7881
q19	1791	1537	1609	1537
q20	2943	1890	1890	1890
q21	5506	5111	5340	5111
q22	1147	1033	1027	1027
Total cold run time: 73900 ms
Total hot run time: 56333 ms

Yukang-Lian · 2024-08-13T13:38:45Z

run buildall

doris-robot · 2024-08-13T14:35:23Z

TPC-H: Total hot run time: 40390 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 38bb93f3bbab6fac7ebace6b3a10421ecce95844, data reload: false
------ Round 1 ----------------------------------
q1	18242	4509	4373	4373
q2	2837	180	185	180
q3	11378	1165	1081	1081
q4	10485	790	794	790
q5	7934	2920	2875	2875
q6	226	146	141	141
q7	988	619	602	602
q8	9308	2068	2042	2042
q9	8638	6546	6598	6546
q10	7058	2241	2262	2241
q11	472	257	253	253
q12	394	218	216	216
q13	17791	2994	2998	2994
q14	270	236	233	233
q15	534	475	488	475
q16	521	396	388	388
q17	982	660	730	660
q18	8247	7494	7417	7417
q19	4457	1072	1074	1072
q20	692	341	324	324
q21	5429	4664	4525	4525
q22	1107	1005	962	962
Total cold run time: 117990 ms
Total hot run time: 40390 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4482	4304	4286	4286
q2	380	273	269	269
q3	2891	2585	2637	2585
q4	1860	1665	1609	1609
q5	5355	5398	5421	5398
q6	218	130	130	130
q7	2051	1681	1668	1668
q8	3190	3374	3313	3313
q9	8428	8379	8351	8351
q10	3382	3178	3151	3151
q11	606	505	489	489
q12	795	639	571	571
q13	16532	3017	3016	3016
q14	300	259	259	259
q15	526	482	471	471
q16	464	418	413	413
q17	1794	1500	1480	1480
q18	7636	7532	7423	7423
q19	1714	1571	1486	1486
q20	2043	1818	1813	1813
q21	5184	5074	5108	5074
q22	1099	1031	1017	1017
Total cold run time: 70930 ms
Total hot run time: 54272 ms

doris-robot · 2024-08-13T14:47:48Z

TPC-DS: Total hot run time: 185769 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 38bb93f3bbab6fac7ebace6b3a10421ecce95844, data reload: false
query1	908	384	370	370
query2	6453	2009	1895	1895
query3	6656	208	216	208
query4	34001	23398	23077	23077
query5	4220	496	483	483
query6	272	160	160	160
query7	4596	297	291	291
query8	265	206	208	206
query9	8619	2460	2463	2460
query10	443	282	272	272
query11	17896	14947	15227	14947
query12	144	99	102	99
query13	1638	376	372	372
query14	10450	6958	7684	6958
query15	216	169	171	169
query16	7804	511	501	501
query17	1579	577	559	559
query18	2025	299	297	297
query19	203	148	148	148
query20	113	109	106	106
query21	204	105	101	101
query22	4237	4193	3949	3949
query23	34280	33166	33246	33166
query24	12234	2952	2891	2891
query25	691	401	399	399
query26	1766	164	163	163
query27	2851	278	282	278
query28	7631	2065	2047	2047
query29	1122	432	435	432
query30	309	162	155	155
query31	1000	779	763	763
query32	103	56	58	56
query33	753	301	300	300
query34	912	476	486	476
query35	841	745	696	696
query36	1096	909	928	909
query37	282	82	86	82
query38	4092	3874	3840	3840
query39	1573	1372	1382	1372
query40	293	120	117	117
query41	49	48	51	48
query42	114	101	99	99
query43	511	453	475	453
query44	1193	737	735	735
query45	202	163	166	163
query46	1138	756	743	743
query47	1824	1746	1796	1746
query48	370	293	302	293
query49	1190	434	444	434
query50	801	413	413	413
query51	6827	6709	6705	6705
query52	104	94	96	94
query53	269	189	186	186
query54	937	461	458	458
query55	82	80	78	78
query56	280	263	270	263
query57	1156	1087	1060	1060
query58	249	239	238	238
query59	3023	3001	2781	2781
query60	309	284	290	284
query61	119	117	227	117
query62	805	656	660	656
query63	215	185	187	185
query64	10645	2310	1743	1743
query65	3314	3176	3139	3139
query66	1324	340	343	340
query67	15601	14988	14782	14782
query68	8883	563	567	563
query69	632	413	331	331
query70	1262	1147	1118	1118
query71	561	273	290	273
query72	8117	2255	1986	1986
query73	1918	336	334	334
query74	9253	8929	8793	8793
query75	5417	2713	2712	2712
query76	5410	1012	986	986
query77	776	322	332	322
query78	11384	9535	9132	9132
query79	11711	542	538	538
query80	1310	497	496	496
query81	594	230	226	226
query82	551	131	132	131
query83	334	149	145	145
query84	273	79	81	79
query85	885	311	275	275
query86	396	309	295	295
query87	4394	4254	4111	4111
query88	5131	2428	2425	2425
query89	432	290	292	290
query90	1945	203	200	200
query91	123	95	101	95
query92	63	51	53	51
query93	5322	547	535	535
query94	974	309	290	290
query95	367	272	272	272
query96	625	279	278	278
query97	3221	3040	3017	3017
query98	234	207	210	207
query99	1514	1257	1268	1257
Total cold run time: 331434 ms
Total hot run time: 185769 ms

doris-robot · 2024-08-13T14:53:20Z

ClickBench: Total hot run time: 31.08 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 38bb93f3bbab6fac7ebace6b3a10421ecce95844, data reload: false
query1	0.05	0.04	0.04
query2	0.09	0.04	0.04
query3	0.22	0.06	0.05
query4	1.66	0.08	0.08
query5	0.47	0.48	0.51
query6	1.13	0.73	0.74
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.55	0.48	0.48
query10	0.55	0.55	0.53
query11	0.16	0.12	0.11
query12	0.14	0.12	0.13
query13	0.60	0.60	0.58
query14	0.77	0.79	0.76
query15	0.88	0.82	0.82
query16	0.37	0.37	0.38
query17	1.03	1.03	1.05
query18	0.23	0.22	0.23
query19	1.87	1.84	1.77
query20	0.01	0.01	0.01
query21	15.38	0.74	0.65
query22	3.75	7.85	2.12
query23	18.31	1.43	1.33
query24	2.16	0.22	0.22
query25	0.15	0.08	0.08
query26	0.30	0.22	0.21
query27	0.46	0.24	0.23
query28	13.26	1.02	1.01
query29	12.59	3.32	3.29
query30	0.24	0.05	0.05
query31	2.91	0.41	0.38
query32	3.27	0.48	0.47
query33	2.97	2.92	2.98
query34	16.93	4.39	4.40
query35	4.51	4.44	4.41
query36	0.64	0.46	0.47
query37	0.19	0.15	0.16
query38	0.16	0.15	0.15
query39	0.05	0.04	0.04
query40	0.15	0.13	0.12
query41	0.10	0.05	0.04
query42	0.06	0.06	0.05
query43	0.06	0.04	0.04
Total cold run time: 109.45 s
Total hot run time: 31.08 s

Yukang-Lian · 2024-08-13T17:27:48Z

run p0

Yukang-Lian · 2024-08-14T02:06:34Z

run p0

Yukang-Lian · 2024-08-14T03:17:39Z

run buildall

doris-robot · 2024-08-14T03:52:53Z

TPC-H: Total hot run time: 39730 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fad1a2c8add922ed651dfa4535c37749ed5a4fa7, data reload: false
------ Round 1 ----------------------------------
q1	17617	4331	4236	4236
q2	2024	182	174	174
q3	11627	978	1169	978
q4	10507	758	750	750
q5	7756	2785	2793	2785
q6	226	136	135	135
q7	955	580	577	577
q8	9527	2002	2020	2002
q9	10179	6536	6542	6536
q10	7003	2133	2176	2133
q11	453	249	245	245
q12	388	230	221	221
q13	17752	2985	2981	2981
q14	277	239	225	225
q15	521	469	496	469
q16	502	391	381	381
q17	954	702	826	702
q18	8016	7448	7467	7448
q19	6754	1018	1043	1018
q20	690	349	332	332
q21	5341	4400	4436	4400
q22	1106	1016	1002	1002
Total cold run time: 120175 ms
Total hot run time: 39730 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4613	4286	4222	4222
q2	376	261	273	261
q3	2886	2709	2788	2709
q4	2034	1783	1769	1769
q5	5570	5557	5503	5503
q6	227	129	130	129
q7	2223	1783	1759	1759
q8	3271	3479	3440	3440
q9	8776	8914	8801	8801
q10	3506	3159	3274	3159
q11	613	502	508	502
q12	814	667	636	636
q13	16499	3136	3151	3136
q14	318	303	299	299
q15	522	512	482	482
q16	498	457	438	438
q17	1834	1505	1484	1484
q18	8222	7905	7901	7901
q19	1771	1667	1572	1572
q20	2168	1919	1859	1859
q21	5488	5312	5295	5295
q22	1145	1023	1051	1023
Total cold run time: 73374 ms
Total hot run time: 56379 ms

doris-robot · 2024-08-14T04:05:05Z

TPC-DS: Total hot run time: 190229 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fad1a2c8add922ed651dfa4535c37749ed5a4fa7, data reload: false
query1	1272	898	863	863
query2	6372	1982	1867	1867
query3	10607	3819	3917	3819
query4	58915	23722	23310	23310
query5	6004	492	487	487
query6	509	168	160	160
query7	6499	287	298	287
query8	318	196	199	196
query9	8919	2413	2379	2379
query10	507	266	261	261
query11	18435	14973	15091	14973
query12	163	103	95	95
query13	1596	395	365	365
query14	12160	7872	7622	7622
query15	293	168	166	166
query16	7635	456	471	456
query17	1351	578	574	574
query18	2081	290	290	290
query19	288	150	147	147
query20	119	118	114	114
query21	208	102	99	99
query22	4510	4324	4418	4324
query23	34258	34536	33569	33569
query24	5592	2846	2892	2846
query25	481	377	392	377
query26	681	156	151	151
query27	1878	269	269	269
query28	4023	2051	2015	2015
query29	641	404	406	404
query30	305	159	143	143
query31	953	767	749	749
query32	77	52	56	52
query33	460	281	297	281
query34	848	449	463	449
query35	808	706	746	706
query36	1051	938	896	896
query37	138	76	81	76
query38	4037	3879	3794	3794
query39	1471	1380	1388	1380
query40	199	117	113	113
query41	44	43	43	43
query42	117	92	98	92
query43	501	473	469	469
query44	1036	712	717	712
query45	190	160	164	160
query46	1082	712	728	712
query47	1827	1776	1790	1776
query48	371	283	285	283
query49	776	409	432	409
query50	796	404	396	396
query51	6769	6778	6634	6634
query52	104	88	91	88
query53	256	184	180	180
query54	550	442	442	442
query55	77	76	71	71
query56	261	240	272	240
query57	1134	1060	1051	1051
query58	209	215	224	215
query59	3004	2736	2704	2704
query60	281	266	266	266
query61	100	95	96	95
query62	745	624	631	624
query63	207	178	178	178
query64	3598	1762	1709	1709
query65	3197	3224	3124	3124
query66	704	328	333	328
query67	15244	14807	14623	14623
query68	4709	532	543	532
query69	408	263	260	260
query70	1164	1143	1107	1107
query71	361	276	265	265
query72	2646	2110	2050	2050
query73	711	323	320	320
query74	9315	8779	8758	8758
query75	3332	2682	2676	2676
query76	2143	992	938	938
query77	530	307	298	298
query78	9773	9063	9065	9063
query79	2545	518	514	514
query80	841	481	506	481
query81	612	222	218	218
query82	596	135	136	135
query83	215	144	143	143
query84	264	80	83	80
query85	1049	283	275	275
query86	477	297	297	297
query87	4369	4217	4254	4217
query88	4121	2398	2369	2369
query89	382	284	281	281
query90	1859	196	196	196
query91	118	96	97	96
query92	58	48	49	48
query93	2150	525	535	525
query94	818	292	284	284
query95	357	261	264	261
query96	595	273	320	273
query97	3209	3035	3054	3035
query98	220	215	200	200
query99	1545	1288	1286	1286
Total cold run time: 311334 ms
Total hot run time: 190229 ms

doris-robot · 2024-08-14T04:10:38Z

ClickBench: Total hot run time: 30.44 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fad1a2c8add922ed651dfa4535c37749ed5a4fa7, data reload: false
query1	0.05	0.04	0.03
query2	0.08	0.04	0.05
query3	0.23	0.05	0.06
query4	1.67	0.10	0.10
query5	0.49	0.51	0.51
query6	1.12	0.74	0.75
query7	0.02	0.02	0.01
query8	0.06	0.04	0.04
query9	0.55	0.48	0.48
query10	0.54	0.56	0.54
query11	0.15	0.12	0.12
query12	0.15	0.12	0.12
query13	0.59	0.60	0.59
query14	0.76	0.79	0.77
query15	0.85	0.81	0.81
query16	0.37	0.38	0.36
query17	1.03	1.02	0.99
query18	0.23	0.22	0.22
query19	1.81	1.79	1.85
query20	0.01	0.01	0.01
query21	15.38	0.76	0.66
query22	3.97	8.16	1.64
query23	18.27	1.44	1.23
query24	2.20	0.21	0.21
query25	0.15	0.08	0.09
query26	0.32	0.21	0.22
query27	0.45	0.24	0.23
query28	13.23	1.02	1.01
query29	12.66	3.24	3.28
query30	0.24	0.05	0.05
query31	2.88	0.39	0.39
query32	3.29	0.48	0.48
query33	2.94	2.98	2.94
query34	16.95	4.34	4.39
query35	4.44	4.48	4.36
query36	0.67	0.48	0.47
query37	0.19	0.15	0.16
query38	0.15	0.14	0.15
query39	0.05	0.03	0.04
query40	0.15	0.13	0.12
query41	0.10	0.05	0.05
query42	0.05	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.53 s
Total hot run time: 30.44 s

github-actions · 2024-08-15T13:26:34Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-08-15T13:26:35Z

PR approved by anyone and no changes requested.

dataroaring

LGTM

1
ee05f3d

github-actionsBot added the doing label Aug 13, 2024

2
fcd0291

Yukang-Lian added 3 commits August 13, 2024 21:01

3
fce198e

4
902f312

5
38bb93f

6
fad1a2c

morrySnow reviewed Aug 14, 2024
View reviewed changes

Comment threadfe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/physical/PhysicalSink.java

Yukang-Lian force-pushed the Fix-Txn-Wrong-Columns-Sequence branch from e6626c5 to fad1a2cCompare August 15, 2024 08:28

morrySnow approved these changes Aug 15, 2024
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 15, 2024

github-actionsBot added the reviewed label Aug 15, 2024

dataroaring approved these changes Aug 16, 2024
View reviewed changes

dataroaring added the dev/3.0.x label Aug 16, 2024

dataroaring merged commit 8306a21 into apache:masterAug 16, 2024

dataroaring pushed a commit that referenced this pull request Aug 17, 2024
[Fix](Txn) Fix wrong columns sequence in txn model (#39295)
085553c

dataroaring added dev/3.0.2-merged and removed dev/3.0.x labels Aug 17, 2024

gavinchou mentioned this pull request Oct 13, 2024
Release Note 3.0.2 #41558
Closed

bobhan1 pushed a commit to bobhan1/doris that referenced this pull request Oct 16, 2024
pick [Fix](Txn) Fix wrong columns sequence in txn model (apache#39295)
11236ee

bobhan1 mentioned this pull request Oct 16, 2024
test only #41784
Closed

HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
[Fix](Txn) Fix wrong columns sequence in txn model (apache#39295)
e19fd0b

Uh oh!

Conversation

Yukang-Lian commented Aug 13, 2024

Proposed changes

Uh oh!

doris-robot commented Aug 13, 2024

Uh oh!

Yukang-Lian commented Aug 13, 2024

Uh oh!

doris-robot commented Aug 13, 2024

Uh oh!

Yukang-Lian commented Aug 13, 2024

Uh oh!

doris-robot commented Aug 13, 2024

Uh oh!

doris-robot commented Aug 13, 2024

Uh oh!

doris-robot commented Aug 13, 2024

Uh oh!

Yukang-Lian commented Aug 13, 2024

Uh oh!

Yukang-Lian commented Aug 14, 2024

Uh oh!

Yukang-Lian commented Aug 14, 2024

Uh oh!

doris-robot commented Aug 14, 2024

Uh oh!

doris-robot commented Aug 14, 2024

Uh oh!

doris-robot commented Aug 14, 2024

Uh oh!

Uh oh!

github-actionsBot commented Aug 15, 2024

Uh oh!

github-actionsBot commented Aug 15, 2024

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants