Skip to content

[opt](Nereids) polish aggregate function signature matching - #39352

Merged
morrySnow merged 1 commit into
apache:masterfrom
morrySnow:polish_agg_function
Aug 15, 2024
Merged

[opt](Nereids) polish aggregate function signature matching#39352
morrySnow merged 1 commit into
apache:masterfrom
morrySnow:polish_agg_function

Conversation

@morrySnow

@morrySnowmorrySnow commented Aug 14, 2024

Copy link
Copy Markdown
Contributor

use double to match string

  • corr
  • covar
  • covar_samp
  • stddev
  • stddev_samp

use largeint to match string

  • group_bit_and
  • group_bit_or
  • group_git_xor

use double to match decimalv3

  • topn_weighted

optimize error message

  • multi_distinct_sum
  • multi_distinct_sum0

@morrySnow

morrySnow commented Aug 14, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Aug 14, 2024

Copy link
Copy Markdown
TPC-H: Total hot run time: 37727 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 99c63f4f5ac4a32dd9f44c229777378ee8ae10d5, data reload: false
------ Round 1 ----------------------------------
q1	18380	4612	4324	4324
q2	2039	187	176	176
q3	11488	1018	1151	1018
q4	10494	717	740	717
q5	7781	2813	2748	2748
q6	226	139	138	138
q7	963	600	594	594
q8	9352	2072	2105	2072
q9	7174	6543	6544	6543
q10	7030	2193	2131	2131
q11	450	239	246	239
q12	395	230	225	225
q13	17742	3024	2980	2980
q14	276	239	245	239
q15	532	487	495	487
q16	494	381	388	381
q17	996	643	744	643
q18	7445	6885	6764	6764
q19	6106	1055	1020	1020
q20	675	345	352	345
q21	3888	2950	3011	2950
q22	1137	993	997	993
Total cold run time: 115063 ms
Total hot run time: 37727 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4408	4333	4285	4285
q2	359	280	285	280
q3	2848	2657	2627	2627
q4	1946	1699	1736	1699
q5	5698	5719	5628	5628
q6	226	135	135	135
q7	2178	1749	1709	1709
q8	3275	3477	3480	3477
q9	8817	8777	8811	8777
q10	3593	3283	3236	3236
q11	625	497	526	497
q12	859	590	593	590
q13	15810	3047	3152	3047
q14	331	295	301	295
q15	539	489	502	489
q16	488	446	468	446
q17	1809	1558	1510	1510
q18	8152	8154	7946	7946
q19	3484	1654	1450	1450
q20	2136	1880	1913	1880
q21	5692	5372	5393	5372
q22	1120	1047	1019	1019
Total cold run time: 74393 ms
Total hot run time: 56394 ms

@doris-robot

doris-robot commented Aug 14, 2024

Copy link
Copy Markdown
TPC-DS: Total hot run time: 188756 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 99c63f4f5ac4a32dd9f44c229777378ee8ae10d5, data reload: false
query1	1261	864	845	845
query2	6448	1926	1846	1846
query3	10604	3870	3773	3773
query4	58704	23759	23164	23164
query5	5672	490	478	478
query6	495	161	162	161
query7	6465	294	287	287
query8	302	206	201	201
query9	8934	2458	2444	2444
query10	509	266	271	266
query11	18109	15006	14946	14946
query12	158	100	103	100
query13	1595	394	366	366
query14	11867	7177	6706	6706
query15	246	166	179	166
query16	7604	518	488	488
query17	1151	610	576	576
query18	1950	324	312	312
query19	264	157	165	157
query20	129	116	124	116
query21	218	105	102	102
query22	4456	4286	4385	4286
query23	34323	33747	33086	33086
query24	5506	2942	2857	2857
query25	516	382	376	376
query26	684	154	151	151
query27	1802	270	276	270
query28	3837	2090	2071	2071
query29	659	400	408	400
query30	269	150	145	145
query31	927	750	727	727
query32	78	53	54	53
query33	444	290	272	272
query34	836	458	464	458
query35	804	710	682	682
query36	1026	927	892	892
query37	132	82	78	78
query38	3971	3866	3848	3848
query39	1431	1364	1379	1364
query40	227	115	111	111
query41	47	43	43	43
query42	108	93	100	93
query43	499	451	471	451
query44	1040	736	735	735
query45	197	169	162	162
query46	1096	734	757	734
query47	1843	1738	1733	1733
query48	363	286	286	286
query49	747	415	424	415
query50	796	409	407	407
query51	6794	6741	6696	6696
query52	97	91	89	89
query53	254	183	180	180
query54	579	449	444	444
query55	77	79	75	75
query56	295	248	239	239
query57	1153	1067	1066	1066
query58	217	222	226	222
query59	3012	2629	2722	2629
query60	287	263	272	263
query61	96	92	99	92
query62	737	612	655	612
query63	205	180	188	180
query64	3124	1783	1711	1711
query65	3193	3150	3158	3150
query66	684	324	325	324
query67	15126	14845	14766	14766
query68	4727	536	544	536
query69	426	272	280	272
query70	1144	1128	1147	1128
query71	465	278	313	278
query72	6453	2265	2024	2024
query73	746	323	322	322
query74	9100	8706	8735	8706
query75	3378	2727	2710	2710
query76	2545	1009	1015	1009
query77	572	324	321	321
query78	9623	9008	8929	8929
query79	2382	525	535	525
query80	1593	515	493	493
query81	547	221	220	220
query82	911	133	140	133
query83	236	149	148	148
query84	273	77	79	77
query85	1122	314	272	272
query86	459	307	291	291
query87	4381	4216	4224	4216
query88	3758	2309	2299	2299
query89	402	292	281	281
query90	1893	198	192	192
query91	121	97	99	97
query92	64	52	50	50
query93	3166	535	533	533
query94	877	287	283	283
query95	348	267	257	257
query96	611	273	270	270
query97	3231	3006	3011	3006
query98	237	202	202	202
query99	1570	1286	1252	1252
Total cold run time: 314640 ms
Total hot run time: 188756 ms

@doris-robot

doris-robot commented Aug 14, 2024

Copy link
Copy Markdown
ClickBench: Total hot run time: 31.37 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 99c63f4f5ac4a32dd9f44c229777378ee8ae10d5, data reload: false
query1	0.04	0.04	0.05
query2	0.07	0.04	0.04
query3	0.23	0.05	0.06
query4	1.66	0.09	0.09
query5	0.49	0.48	0.52
query6	1.13	0.73	0.73
query7	0.02	0.02	0.01
query8	0.04	0.04	0.04
query9	0.54	0.48	0.47
query10	0.55	0.53	0.54
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.60	0.60	0.59
query14	0.77	0.78	0.78
query15	0.86	0.82	0.81
query16	0.39	0.36	0.37
query17	0.99	1.00	1.02
query18	0.22	0.22	0.21
query19	1.79	1.69	1.79
query20	0.03	0.01	0.01
query21	15.42	0.74	0.66
query22	3.94	7.14	2.55
query23	18.30	1.42	1.26
query24	2.04	0.23	0.23
query25	0.16	0.09	0.08
query26	0.29	0.22	0.21
query27	0.47	0.23	0.22
query28	13.35	1.02	1.01
query29	12.62	3.31	3.29
query30	0.24	0.04	0.04
query31	2.89	0.39	0.39
query32	3.28	0.50	0.47
query33	2.97	2.99	2.97
query34	17.07	4.36	4.34
query35	4.40	4.42	4.43
query36	0.65	0.48	0.49
query37	0.20	0.17	0.16
query38	0.17	0.15	0.15
query39	0.04	0.03	0.04
query40	0.16	0.13	0.12
query41	0.09	0.05	0.05
query42	0.05	0.05	0.04
query43	0.05	0.04	0.04
Total cold run time: 109.57 s
Total hot run time: 31.37 s

@morrySnow

morrySnow commented Aug 14, 2024

Copy link
Copy Markdown
ContributorAuthor

run cloud_p0

@morrySnow

morrySnow commented Aug 14, 2024

Copy link
Copy Markdown
ContributorAuthor

run cloud_p1

@morrySnow
[opt](Nereids) polish aggregate function signature matching
ec07dd2
use double to match string
- corr
- covar
- covar_samp
- stddev
- stddev_samp
use largeint to match string
- group_bit_and
- group_bit_or
- group_git_xor
use double to match decimalv3
- topn_weighted
optimize error message
- multi_distinct_sum
- multi_distinct_sum0
@morrySnow

morrySnow commented Aug 14, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Aug 14, 2024

Copy link
Copy Markdown
TPC-H: Total hot run time: 37605 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ec07dd2b521bf8305972a0d96e9e30e5b81d2eec, data reload: false
------ Round 1 ----------------------------------
q1	17646	4386	4317	4317
q2	2021	180	196	180
q3	10470	1141	1225	1141
q4	10137	665	694	665
q5	7769	2825	2781	2781
q6	232	138	142	138
q7	990	606	593	593
q8	9877	2021	2036	2021
q9	7379	6574	6572	6572
q10	7067	2262	2124	2124
q11	452	245	250	245
q12	391	225	218	218
q13	17753	3009	2966	2966
q14	286	245	239	239
q15	531	469	487	469
q16	507	394	389	389
q17	954	703	803	703
q18	7622	6780	6788	6780
q19	6468	961	1017	961
q20	701	330	327	327
q21	4365	2758	3029	2758
q22	1135	1026	1018	1018
Total cold run time: 114753 ms
Total hot run time: 37605 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4466	4286	4285	4285
q2	410	281	273	273
q3	2862	2590	2614	2590
q4	1912	1645	1621	1621
q5	5392	5397	5362	5362
q6	218	134	133	133
q7	2041	1673	1653	1653
q8	3165	3328	3305	3305
q9	8464	8357	8393	8357
q10	3427	3147	3189	3147
q11	607	496	485	485
q12	752	638	607	607
q13	17407	2978	3002	2978
q14	307	286	267	267
q15	521	485	472	472
q16	477	444	415	415
q17	1754	1485	1457	1457
q18	7764	7443	7465	7443
q19	2304	1549	1479	1479
q20	2108	1815	1800	1800
q21	5352	5085	5099	5085
q22	1143	1048	1033	1033
Total cold run time: 72853 ms
Total hot run time: 54247 ms

@doris-robot

doris-robot commented Aug 14, 2024

Copy link
Copy Markdown
TPC-DS: Total hot run time: 185254 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ec07dd2b521bf8305972a0d96e9e30e5b81d2eec, data reload: false
query1	917	389	364	364
query2	6445	1927	1874	1874
query3	6651	209	215	209
query4	34312	23407	23096	23096
query5	4214	486	508	486
query6	284	163	157	157
query7	4588	290	297	290
query8	245	203	195	195
query9	8524	2471	2434	2434
query10	424	272	259	259
query11	17841	15027	15015	15015
query12	153	101	102	101
query13	1637	378	365	365
query14	9704	7070	7173	7070
query15	247	167	168	167
query16	7980	448	473	448
query17	1604	590	558	558
query18	2089	291	299	291
query19	190	152	147	147
query20	116	107	107	107
query21	209	108	102	102
query22	4256	3965	3958	3958
query23	34093	33318	33179	33179
query24	11524	2824	2846	2824
query25	649	402	410	402
query26	1265	161	158	158
query27	2824	282	276	276
query28	7291	2078	2051	2051
query29	882	424	417	417
query30	301	152	152	152
query31	982	739	775	739
query32	99	56	57	56
query33	765	299	295	295
query34	921	461	476	461
query35	834	728	720	720
query36	1086	905	938	905
query37	152	87	83	83
query38	3948	3832	3801	3801
query39	1420	1423	1404	1404
query40	279	123	120	120
query41	50	48	46	46
query42	119	100	101	100
query43	500	458	478	458
query44	1256	736	735	735
query45	197	170	169	169
query46	1123	735	723	723
query47	1882	1775	1800	1775
query48	362	299	289	289
query49	1108	439	433	433
query50	822	410	405	405
query51	7026	6784	6683	6683
query52	98	98	92	92
query53	251	189	189	189
query54	885	457	453	453
query55	78	77	84	77
query56	280	260	265	260
query57	1150	1074	1080	1074
query58	278	223	232	223
query59	2967	2752	2672	2672
query60	302	278	287	278
query61	120	226	98	98
query62	815	655	658	655
query63	211	184	183	183
query64	5309	2275	1757	1757
query65	3401	3144	3132	3132
query66	1241	342	340	340
query67	15782	14768	14856	14768
query68	6473	542	554	542
query69	716	380	298	298
query70	1212	1162	1112	1112
query71	546	271	275	271
query72	7600	2263	2034	2034
query73	844	321	322	321
query74	9250	8851	8722	8722
query75	4925	2642	2719	2642
query76	4774	1050	1012	1012
query77	775	304	313	304
query78	9606	9041	9157	9041
query79	8346	536	527	527
query80	1984	546	500	500
query81	581	233	227	227
query82	795	137	134	134
query83	276	150	145	145
query84	274	78	75	75
query85	1425	275	273	273
query86	422	291	304	291
query87	4451	4248	4228	4228
query88	5054	2295	2316	2295
query89	524	304	292	292
query90	2031	208	191	191
query91	127	96	97	96
query92	67	49	55	49
query93	6776	540	527	527
query94	999	274	294	274
query95	350	259	261	259
query96	610	268	274	268
query97	3204	3056	3060	3056
query98	221	208	204	204
query99	1588	1245	1241	1241
Total cold run time: 316384 ms
Total hot run time: 185254 ms

@doris-robot

doris-robot commented Aug 14, 2024

Copy link
Copy Markdown
ClickBench: Total hot run time: 31.34 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ec07dd2b521bf8305972a0d96e9e30e5b81d2eec, data reload: false
query1	0.04	0.04	0.04
query2	0.07	0.04	0.04
query3	0.22	0.05	0.06
query4	1.68	0.09	0.09
query5	0.50	0.49	0.49
query6	1.13	0.73	0.74
query7	0.02	0.02	0.01
query8	0.05	0.05	0.05
query9	0.54	0.48	0.49
query10	0.56	0.53	0.54
query11	0.16	0.11	0.11
query12	0.14	0.12	0.12
query13	0.60	0.60	0.58
query14	0.76	0.78	0.80
query15	0.87	0.81	0.83
query16	0.38	0.37	0.37
query17	1.01	1.04	1.00
query18	0.23	0.22	0.23
query19	1.84	1.75	1.81
query20	0.01	0.02	0.01
query21	15.42	0.76	0.66
query22	4.26	6.16	2.44
query23	18.28	1.35	1.25
query24	2.08	0.24	0.23
query25	0.15	0.09	0.09
query26	0.30	0.20	0.21
query27	0.45	0.23	0.23
query28	13.69	1.06	1.00
query29	12.78	3.30	3.27
query30	0.24	0.06	0.04
query31	2.89	0.39	0.39
query32	3.30	0.49	0.48
query33	2.94	2.92	2.99
query34	17.04	4.48	4.40
query35	4.43	4.40	4.49
query36	0.65	0.48	0.49
query37	0.20	0.16	0.15
query38	0.16	0.15	0.15
query39	0.06	0.03	0.03
query40	0.16	0.12	0.13
query41	0.09	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.05	0.05
Total cold run time: 110.49 s
Total hot run time: 31.34 s

@morrySnow

morrySnow commented Aug 15, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Aug 15, 2024

Copy link
Copy Markdown
TPC-H: Total hot run time: 37558 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ec07dd2b521bf8305972a0d96e9e30e5b81d2eec, data reload: false
------ Round 1 ----------------------------------
q1	17634	4847	4280	4280
q2	2024	181	200	181
q3	11770	983	1024	983
q4	10506	651	750	651
q5	7778	2815	2783	2783
q6	226	144	145	144
q7	957	607	596	596
q8	9549	2012	2046	2012
q9	8349	6523	6524	6523
q10	7010	2143	2188	2143
q11	512	251	243	243
q12	398	228	221	221
q13	17764	2975	2993	2975
q14	294	234	240	234
q15	537	483	497	483
q16	490	421	388	388
q17	968	765	729	729
q18	7502	6729	6744	6729
q19	6220	1092	1023	1023
q20	706	335	345	335
q21	4318	2918	2990	2918
q22	1085	984	1010	984
Total cold run time: 116597 ms
Total hot run time: 37558 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4433	4290	4285	4285
q2	368	284	277	277
q3	2817	2639	2637	2637
q4	1996	1710	1726	1710
q5	5632	5692	5610	5610
q6	227	145	141	141
q7	2123	1715	1759	1715
q8	3316	3512	3448	3448
q9	8789	8776	8782	8776
q10	3559	3279	3236	3236
q11	613	505	517	505
q12	789	621	627	621
q13	16919	3184	3211	3184
q14	310	288	317	288
q15	550	501	479	479
q16	491	449	449	449
q17	1827	1515	1544	1515
q18	8056	8111	7854	7854
q19	1842	1507	1660	1507
q20	2211	1894	1894	1894
q21	5583	5346	5469	5346
q22	1087	1045	991	991
Total cold run time: 73538 ms
Total hot run time: 56468 ms

@doris-robot

doris-robot commented Aug 15, 2024

Copy link
Copy Markdown
TPC-DS: Total hot run time: 189459 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ec07dd2b521bf8305972a0d96e9e30e5b81d2eec, data reload: false
query1	1255	891	856	856
query2	6476	1896	1888	1888
query3	10596	3943	3622	3622
query4	59362	24397	23122	23122
query5	6149	500	488	488
query6	495	157	161	157
query7	6518	298	302	298
query8	310	229	201	201
query9	8953	2448	2416	2416
query10	520	263	273	263
query11	18190	15045	15200	15045
query12	160	104	104	104
query13	1577	404	375	375
query14	12050	7153	7264	7153
query15	254	176	183	176
query16	7577	514	495	495
query17	1141	569	593	569
query18	1870	293	304	293
query19	283	153	149	149
query20	121	108	120	108
query21	219	108	114	108
query22	4504	4277	4617	4277
query23	34411	33333	33303	33303
query24	5529	2913	2829	2829
query25	560	398	411	398
query26	708	158	156	156
query27	1783	273	277	273
query28	3660	2036	2049	2036
query29	697	423	430	423
query30	235	151	153	151
query31	931	750	732	732
query32	97	56	57	56
query33	536	292	286	286
query34	859	469	471	469
query35	826	729	735	729
query36	1052	927	943	927
query37	139	83	85	83
query38	3922	3834	3832	3832
query39	1451	1383	1414	1383
query40	205	122	120	120
query41	47	46	46	46
query42	115	95	99	95
query43	508	469	464	464
query44	1087	730	731	730
query45	216	162	165	162
query46	1090	768	717	717
query47	1850	1750	1747	1747
query48	371	299	299	299
query49	771	430	428	428
query50	799	408	413	408
query51	6761	6642	6719	6642
query52	101	96	90	90
query53	258	188	184	184
query54	681	440	441	440
query55	78	73	76	73
query56	274	244	239	239
query57	1125	1046	1025	1025
query58	226	237	232	232
query59	2986	2782	2771	2771
query60	300	261	258	258
query61	103	97	101	97
query62	755	671	644	644
query63	211	186	183	183
query64	4185	2266	1698	1698
query65	3191	3169	3146	3146
query66	708	335	326	326
query67	15182	14942	14865	14865
query68	7967	553	563	553
query69	635	395	285	285
query70	1328	1054	1117	1054
query71	526	301	275	275
query72	6666	2304	2017	2017
query73	2038	321	326	321
query74	9205	8668	8860	8668
query75	4089	2646	2692	2646
query76	4312	953	1017	953
query77	728	346	313	313
query78	10071	9350	8995	8995
query79	10524	525	524	524
query80	1703	483	490	483
query81	545	221	223	221
query82	952	130	134	130
query83	275	144	141	141
query84	273	72	75	72
query85	1305	269	298	269
query86	373	296	296	296
query87	4365	4158	4228	4158
query88	4537	2300	2295	2295
query89	534	287	293	287
query90	2012	194	188	188
query91	123	96	92	92
query92	65	48	49	48
query93	6164	516	522	516
query94	769	274	284	274
query95	338	249	250	249
query96	601	269	269	269
query97	3189	3088	3068	3068
query98	222	202	193	193
query99	1598	1248	1249	1248
Total cold run time: 338192 ms
Total hot run time: 189459 ms

@doris-robot

doris-robot commented Aug 15, 2024

Copy link
Copy Markdown
ClickBench: Total hot run time: 30.88 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ec07dd2b521bf8305972a0d96e9e30e5b81d2eec, data reload: false
query1	0.05	0.04	0.04
query2	0.09	0.04	0.04
query3	0.23	0.04	0.04
query4	1.68	0.08	0.08
query5	0.48	0.50	0.48
query6	1.13	0.73	0.73
query7	0.02	0.02	0.01
query8	0.04	0.04	0.04
query9	0.56	0.48	0.48
query10	0.53	0.53	0.54
query11	0.16	0.11	0.12
query12	0.15	0.12	0.12
query13	0.61	0.60	0.58
query14	0.76	0.78	0.78
query15	0.84	0.81	0.81
query16	0.36	0.37	0.38
query17	0.95	1.02	0.95
query18	0.23	0.22	0.21
query19	1.92	1.71	1.79
query20	0.02	0.01	0.01
query21	15.39	0.75	0.66
query22	3.66	7.74	2.11
query23	18.30	1.40	1.26
query24	2.13	0.23	0.22
query25	0.16	0.08	0.08
query26	0.30	0.21	0.21
query27	0.45	0.23	0.23
query28	13.18	1.02	1.00
query29	12.64	3.34	3.35
query30	0.24	0.05	0.05
query31	2.88	0.39	0.38
query32	3.29	0.49	0.47
query33	2.91	2.96	2.98
query34	17.05	4.36	4.34
query35	4.41	4.44	4.40
query36	0.65	0.48	0.47
query37	0.19	0.16	0.16
query38	0.16	0.15	0.15
query39	0.04	0.03	0.04
query40	0.15	0.11	0.13
query41	0.09	0.05	0.05
query42	0.06	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 109.18 s
Total hot run time: 30.88 s

@morrySnow

morrySnow commented Aug 15, 2024

Copy link
Copy Markdown
ContributorAuthor

run cloud_p1

@morrySnow

morrySnow commented Aug 15, 2024

Copy link
Copy Markdown
ContributorAuthor

run feut

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 15, 2024
@github-actions

github-actionsBot commented Aug 15, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Aug 15, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@morrySnow
morrySnow merged commit 755221b into apache:masterAug 15, 2024
@morrySnow
morrySnow deleted the polish_agg_function branch August 15, 2024 12:44
morrySnow added a commit that referenced this pull request Aug 16, 2024
@morrySnow
[opt](Nereids) polish aggregate function signature matching (#39352)
0e696c7
pick from master #39352
use double to match string
- corr
- covar
- covar_samp
- stddev
- stddev_samp
use largeint to match string
- group_bit_and
- group_bit_or
- group_git_xor
use double to match decimalv3
- topn_weighted
optimize error message
- multi_distinct_sum
- multi_distinct_sum0
@morrySnowmorrySnow mentioned this pull request Aug 16, 2024
Merged
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Aug 16, 2024
@morrySnow
[opt](Nereids) polish aggregate function signature matching (apache#3…
0ec1150
…9352)
pick from master apache#39352
use double to match string
- corr
- covar
- covar_samp
- stddev
- stddev_samp
use largeint to match string
- group_bit_and
- group_bit_or
- group_git_xor
use double to match decimalv3
- topn_weighted
optimize error message
- multi_distinct_sum
- multi_distinct_sum0
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Aug 16, 2024
@morrySnow
[opt](Nereids) polish aggregate function signature matching (apache#3…
2c5ee78
…9352)
pick from master apache#39352
use double to match string
- stddev
- stddev_samp
use largeint to match string
- group_bit_and
- group_bit_or
- group_git_xor
use double to match decimalv3
- topn_weighted
optimize error message
- multi_distinct_sum
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Aug 16, 2024
@morrySnow
[opt](Nereids) polish aggregate function signature matching (apache#3…
8a0075c
…9352)
pick from master apache#39352
use double to match string
- stddev
- stddev_samp
use largeint to match string
- group_bit_and
- group_bit_or
- group_git_xor
use double to match decimalv3
- topn_weighted
optimize error message
- multi_distinct_sum
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Aug 16, 2024
@morrySnow
[opt](Nereids) polish aggregate function signature matching (apache#3…
1916952
…9352)
pick from master apache#39352
use double to match string
- stddev
- stddev_samp
use largeint to match string
- group_bit_and
- group_bit_or
- group_git_xor
optimize error message
- multi_distinct_sum
@morrySnowmorrySnow mentioned this pull request Aug 16, 2024
Merged
morrySnow added a commit that referenced this pull request Aug 16, 2024
@morrySnow
[opt](Nereids) polish aggregate function signature matching (#39352) (#…
d56000e
…39460)
pick from master #39352
use double to match string
- corr
- covar
- covar_samp
- stddev
- stddev_samp
use largeint to match string
- group_bit_and
- group_bit_or
- group_git_xor
use double to match decimalv3
- topn_weighted
optimize error message
- multi_distinct_sum
- multi_distinct_sum0
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Aug 16, 2024
@morrySnow
[opt](Nereids) polish aggregate function signature matching (apache#3…
a5de741
…9352)
pick from master apache#39352
use double to match string
- stddev
- stddev_samp
use largeint to match string
- group_bit_and
- group_bit_or
- group_git_xor
optimize error message
- multi_distinct_sum
morrySnow added a commit that referenced this pull request Aug 16, 2024
@morrySnow
[opt](Nereids) polish aggregate function signature matching (#39352) (#…
7fd2f96
…39466)
pick from master #39352
use double to match string
- stddev
- stddev_samp
use largeint to match string
- group_bit_and
- group_bit_or
- group_git_xor
optimize error message
- multi_distinct_sum
dataroaring pushed a commit that referenced this pull request Aug 17, 2024
@morrySnow@dataroaring
[opt](Nereids) polish aggregate function signature matching (#39352)
e11c7ec
use double to match string
- corr
- covar
- covar_samp
- stddev
- stddev_samp
use largeint to match string
- group_bit_and
- group_bit_or
- group_git_xor
use double to match decimalv3
- topn_weighted
optimize error message
- multi_distinct_sum
- multi_distinct_sum0
@xiaokangxiaokang mentioned this pull request Sep 14, 2024
Closed
@zhangstar333zhangstar333 mentioned this pull request Sep 20, 2024
Merged
mongo360 pushed a commit to mongo360/doris that referenced this pull request Dec 11, 2024
@morrySnow@Baymine
[opt](Nereids) polish aggregate function signature matching (apache#3…
09686af
…9352) (apache#39466)
pick from master apache#39352
use double to match string
- stddev
- stddev_samp
use largeint to match string
- group_bit_and
- group_bit_or
- group_git_xor
optimize error message
- multi_distinct_sum
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@morrySnow@HappenLee
[opt](Nereids) polish aggregate function signature matching (apache#3…
a4d2126
…9352)
use double to match string
- corr
- covar
- covar_samp
- stddev
- stddev_samp
use largeint to match string
- group_bit_and
- group_bit_or
- group_git_xor
use double to match decimalv3
- topn_weighted
optimize error message
- multi_distinct_sum
- multi_distinct_sum0
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starocean999starocean999starocean999 approved these changes
+1 more reviewer
@feiniaofeiafeifeiniaofeiafeifeiniaofeiafei approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.15-mergeddev/2.1.6-mergeddev/3.0.2-mergeddoingreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@morrySnow@doris-robot@starocean999@feiniaofeiafei@dataroaring