Skip to content

[fix](delete) Only apply regex check on delete condition str for non-lsc tables - #39357

Merged
dataroaring merged 1 commit into
apache:masterfrom
Hastyshell:fix-delete-subpred-check
Aug 15, 2024
Merged

[fix](delete) Only apply regex check on delete condition str for non-lsc tables#39357
dataroaring merged 1 commit into
apache:masterfrom
Hastyshell:fix-delete-subpred-check

Conversation

@Hastyshell

@HastyshellHastyshell commented Aug 14, 2024

Copy link
Copy Markdown
Collaborator

Proposed changes

Light schema change capable tables will work on delete sub predicate v2 and doesn't need this check.

@doris-robot

doris-robot commented Aug 14, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Hastyshell

Hastyshell commented Aug 14, 2024

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@HastyshellHastyshell changed the title [fix] Only apply regex check on delete condition str for non-lsc tables[fix](delete) Only apply regex check on delete condition str for non-lsc tablesAug 14, 2024
@doris-robot

doris-robot commented Aug 14, 2024

Copy link
Copy Markdown
TPC-H: Total hot run time: 38040 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 566483bfc5ee314b32be3bd3e074d5e4ecc21b6e, data reload: false
------ Round 1 ----------------------------------
q1	18060	4528	4430	4430
q2	2159	176	171	171
q3	10473	1243	1153	1153
q4	10139	736	688	688
q5	7755	2836	2804	2804
q6	222	141	139	139
q7	971	588	591	588
q8	9329	2046	2060	2046
q9	7157	6560	6537	6537
q10	7011	2183	2171	2171
q11	459	245	242	242
q12	397	222	218	218
q13	17774	2977	2992	2977
q14	294	247	241	241
q15	525	474	499	474
q16	495	381	376	376
q17	970	658	653	653
q18	7552	6878	6829	6829
q19	7257	1163	979	979
q20	695	329	342	329
q21	4372	2978	3099	2978
q22	1112	1057	1017	1017
Total cold run time: 115178 ms
Total hot run time: 38040 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4550	4283	4295	4283
q2	375	271	253	253
q3	2852	2691	2664	2664
q4	1862	1618	1595	1595
q5	5343	5347	5376	5347
q6	221	130	129	129
q7	2026	1662	1706	1662
q8	3179	3341	3352	3341
q9	8449	8445	8361	8361
q10	3403	3179	3135	3135
q11	605	503	505	503
q12	821	642	607	607
q13	17310	2982	3020	2982
q14	308	277	282	277
q15	520	474	477	474
q16	487	431	416	416
q17	1787	1505	1492	1492
q18	7602	7670	7452	7452
q19	1636	1526	1624	1526
q20	2014	1813	1805	1805
q21	5303	5184	5254	5184
q22	1101	1076	1042	1042
Total cold run time: 71754 ms
Total hot run time: 54530 ms

@doris-robot

doris-robot commented Aug 14, 2024

Copy link
Copy Markdown
TPC-DS: Total hot run time: 185069 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 566483bfc5ee314b32be3bd3e074d5e4ecc21b6e, data reload: false
query1	915	395	366	366
query2	6449	1915	1791	1791
query3	6638	221	215	215
query4	34036	23258	23072	23072
query5	4171	492	479	479
query6	274	164	158	158
query7	4592	306	289	289
query8	257	204	205	204
query9	8458	2442	2408	2408
query10	443	278	259	259
query11	17771	14860	15015	14860
query12	151	102	95	95
query13	1636	378	363	363
query14	9174	6584	7175	6584
query15	216	168	168	168
query16	7793	473	498	473
query17	1586	583	550	550
query18	2005	287	285	285
query19	197	147	146	146
query20	113	108	104	104
query21	215	101	105	101
query22	4728	4254	4232	4232
query23	34020	33556	33380	33380
query24	12089	2882	2832	2832
query25	684	390	391	390
query26	1796	160	158	158
query27	2902	275	278	275
query28	7768	2068	2052	2052
query29	1118	421	413	413
query30	300	151	148	148
query31	952	748	756	748
query32	98	59	65	59
query33	766	285	283	283
query34	956	465	466	465
query35	848	729	734	729
query36	1078	910	898	898
query37	187	83	96	83
query38	3964	3836	3814	3814
query39	1441	1401	1390	1390
query40	283	119	114	114
query41	49	46	46	46
query42	121	98	97	97
query43	500	467	449	449
query44	1247	740	743	740
query45	195	164	165	164
query46	1118	751	735	735
query47	1846	1812	1786	1786
query48	371	295	294	294
query49	1184	425	428	425
query50	798	398	409	398
query51	6928	6797	6673	6673
query52	103	93	96	93
query53	251	187	185	185
query54	1035	460	452	452
query55	78	74	74	74
query56	291	252	255	252
query57	1153	1069	1063	1063
query58	246	227	225	225
query59	3026	2786	2744	2744
query60	300	264	275	264
query61	118	116	217	116
query62	841	611	660	611
query63	224	184	181	181
query64	6293	2260	1744	1744
query65	3185	3164	3124	3124
query66	1373	329	338	329
query67	15620	14980	14968	14968
query68	9047	553	549	549
query69	715	378	290	290
query70	1311	1101	1021	1021
query71	543	272	271	271
query72	7637	2255	1994	1994
query73	2242	323	320	320
query74	9244	8871	8802	8802
query75	5567	2684	2726	2684
query76	5523	1003	978	978
query77	788	308	313	308
query78	9777	9390	9142	9142
query79	8970	529	527	527
query80	1019	489	494	489
query81	576	220	224	220
query82	475	131	130	130
query83	337	148	145	145
query84	266	77	73	73
query85	1068	315	274	274
query86	352	275	300	275
query87	4446	4249	4137	4137
query88	4830	2346	2337	2337
query89	483	294	281	281
query90	2057	194	189	189
query91	122	94	94	94
query92	62	50	51	50
query93	6476	532	526	526
query94	1020	286	294	286
query95	361	256	260	256
query96	601	274	267	267
query97	3216	3027	3072	3027
query98	231	204	199	199
query99	1529	1275	1263	1263
Total cold run time: 322453 ms
Total hot run time: 185069 ms

@doris-robot

doris-robot commented Aug 14, 2024

Copy link
Copy Markdown
ClickBench: Total hot run time: 30.93 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 566483bfc5ee314b32be3bd3e074d5e4ecc21b6e, data reload: false
query1	0.05	0.04	0.04
query2	0.09	0.05	0.04
query3	0.23	0.06	0.06
query4	1.69	0.08	0.10
query5	0.49	0.50	0.50
query6	1.13	0.73	0.72
query7	0.02	0.01	0.01
query8	0.05	0.05	0.05
query9	0.54	0.49	0.48
query10	0.53	0.54	0.53
query11	0.15	0.12	0.12
query12	0.15	0.12	0.12
query13	0.59	0.60	0.59
query14	0.75	0.79	0.79
query15	0.84	0.82	0.82
query16	0.36	0.38	0.35
query17	0.98	0.99	0.98
query18	0.22	0.22	0.21
query19	1.85	1.67	1.68
query20	0.01	0.01	0.02
query21	15.40	0.75	0.65
query22	3.86	7.00	2.10
query23	18.34	1.47	1.30
query24	1.75	0.30	0.20
query25	0.16	0.08	0.08
query26	0.28	0.21	0.21
query27	0.47	0.22	0.22
query28	13.37	1.01	0.99
query29	12.61	3.29	3.29
query30	0.24	0.05	0.05
query31	2.90	0.39	0.39
query32	3.28	0.48	0.48
query33	2.97	2.95	2.97
query34	17.18	4.33	4.40
query35	4.42	4.43	4.44
query36	0.66	0.48	0.48
query37	0.18	0.16	0.16
query38	0.17	0.15	0.15
query39	0.04	0.03	0.04
query40	0.16	0.13	0.12
query41	0.11	0.06	0.06
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.38 s
Total hot run time: 30.93 s

@gavinchou

gavinchou commented Aug 14, 2024

Copy link
Copy Markdown
Contributor

run p0

@github-actions

github-actionsBot commented Aug 14, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Aug 14, 2024
@github-actions

github-actionsBot commented Aug 14, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Aug 15, 2024
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
dataroaring merged commit 257e3ff into apache:masterAug 15, 2024
dataroaring pushed a commit that referenced this pull request Aug 16, 2024
@Hastyshell@dataroaring
[fix](delete) Only apply regex check on delete condition str for non-…
4244287
…lsc tables (#39357)
## Proposed changes
Light schema change capable tables will work on delete sub predicate v2
and doesn't need this check.
Hastyshell added a commit to Hastyshell/doris that referenced this pull request Aug 16, 2024
@Hastyshell
[fix](delete) Only apply regex check on delete condition str for non-…
1cd6dda
…lsc tables (apache#39357)
## Proposed changes
Light schema change capable tables will work on delete sub predicate v2
and doesn't need this check.
yiguolei pushed a commit that referenced this pull request Aug 17, 2024
@Hastyshell
[fix](delete) Only apply regex check on delete condition str for non-…
0ff2a9d
…lsc tables (#39357) (#39500)
## Proposed changes
Light schema change capable tables will work on delete sub predicate v2
and doesn't need this check.
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@Hastyshell@HappenLee
[fix](delete) Only apply regex check on delete condition str for non-…
b99bd55
…lsc tables (apache#39357)
## Proposed changes
Light schema change capable tables will work on delete sub predicate v2
and doesn't need this check.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchougavinchougavinchou approved these changes
@dataroaringdataroaringdataroaring approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.6-mergeddev/3.0.2-mergeddoingreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Hastyshell@doris-robot@gavinchou@dataroaring