[fix](nereids)prevent null pointer exception if datetime value overflows by starocean999 · Pull Request #39482 · apache/doris

starocean999 · 2024-08-16T08:03:56Z

date and datetime literal's plusXXX method( plusDays, plusWeeks, plusMonths) may return NullLiteral, So we should only convert the return value to date or datetime literal when it's not a NullLiteral

doris-robot · 2024-08-16T08:04:02Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

starocean999 · 2024-08-16T08:04:18Z

run buildall

doris-robot · 2024-08-16T08:23:59Z

TPC-H: Total hot run time: 38165 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f54c15bbcb4aa4b486947930f57debefadccd447, data reload: false
------ Round 1 ----------------------------------
q1	18757	4540	4373	4373
q2	2060	215	225	215
q3	10393	1221	1076	1076
q4	10161	799	692	692
q5	7797	2829	2811	2811
q6	271	158	160	158
q7	1015	657	656	656
q8	9389	2094	2069	2069
q9	6997	6599	6567	6567
q10	7094	2209	2190	2190
q11	485	274	282	274
q12	442	269	263	263
q13	18717	2988	3017	2988
q14	321	259	267	259
q15	572	523	533	523
q16	551	417	420	417
q17	1005	706	694	694
q18	7518	6955	6771	6771
q19	5607	1091	1059	1059
q20	735	377	376	376
q21	4464	3004	2700	2700
q22	1129	1074	1034	1034
Total cold run time: 115480 ms
Total hot run time: 38165 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4622	4310	4363	4310
q2	412	325	320	320
q3	2913	2626	2635	2626
q4	1902	1638	1685	1638
q5	5478	5382	5387	5382
q6	231	150	147	147
q7	2087	1705	1707	1705
q8	3217	3355	3387	3355
q9	8476	8358	8430	8358
q10	3440	3191	3219	3191
q11	612	506	515	506
q12	811	612	635	612
q13	16610	3015	3024	3015
q14	336	301	294	294
q15	555	515	518	515
q16	498	438	449	438
q17	1808	1509	1497	1497
q18	7854	7631	7334	7334
q19	6017	1535	1591	1535
q20	2066	1808	1823	1808
q21	13672	5176	5209	5176
q22	1116	1051	1028	1028
Total cold run time: 84733 ms
Total hot run time: 54790 ms

doris-robot · 2024-08-16T08:36:15Z

TPC-DS: Total hot run time: 190725 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f54c15bbcb4aa4b486947930f57debefadccd447, data reload: false
query1	982	401	388	388
query2	6725	1990	1873	1873
query3	6670	222	240	222
query4	34031	23513	23111	23111
query5	4404	640	631	631
query6	315	186	194	186
query7	4605	317	330	317
query8	437	365	366	365
query9	8599	2499	2480	2480
query10	483	331	316	316
query11	17309	15000	15007	15000
query12	172	127	126	126
query13	1674	425	409	409
query14	10006	7406	7379	7379
query15	279	187	184	184
query16	8084	534	500	500
query17	1662	622	576	576
query18	2154	337	332	332
query19	208	171	167	167
query20	140	133	133	133
query21	250	149	139	139
query22	4308	3985	3879	3879
query23	34151	33525	33482	33482
query24	11287	2902	2941	2902
query25	642	417	418	417
query26	1181	179	177	177
query27	2302	300	308	300
query28	7265	2137	2122	2122
query29	850	447	482	447
query30	340	187	177	177
query31	1044	839	850	839
query32	116	81	80	80
query33	827	345	342	342
query34	917	511	498	498
query35	892	765	771	765
query36	1118	967	966	966
query37	170	104	104	104
query38	3946	3881	3917	3881
query39	1510	1463	1482	1463
query40	242	157	155	155
query41	140	137	134	134
query42	140	116	119	116
query43	530	506	511	506
query44	1251	797	785	785
query45	225	192	225	192
query46	1154	796	773	773
query47	1898	1816	1854	1816
query48	410	346	337	337
query49	1247	568	577	568
query50	860	472	467	467
query51	6927	6809	6955	6809
query52	115	112	116	112
query53	309	225	231	225
query54	990	508	506	506
query55	88	88	90	88
query56	327	308	305	305
query57	1191	1117	1125	1117
query58	311	310	312	310
query59	2918	2805	2629	2629
query60	353	327	330	327
query61	151	178	147	147
query62	879	707	684	684
query63	269	230	237	230
query64	5296	2387	1913	1913
query65	3290	3179	3178	3178
query66	1166	675	670	670
query67	15588	14845	14870	14845
query68	6291	592	601	592
query69	731	444	344	344
query70	1214	1228	1182	1182
query71	564	329	313	313
query72	7613	2344	2089	2089
query73	863	360	361	360
query74	9059	8754	8830	8754
query75	4939	2765	2767	2765
query76	4812	1000	1090	1000
query77	907	447	444	444
query78	9818	9089	9564	9089
query79	7422	557	554	554
query80	1165	615	598	598
query81	621	259	268	259
query82	1112	155	154	154
query83	372	212	214	212
query84	292	99	97	97
query85	1523	360	349	349
query86	358	333	317	317
query87	4426	4319	4288	4288
query88	4714	2555	2519	2519
query89	474	327	315	315
query90	1799	233	234	233
query91	156	129	126	126
query92	90	77	75	75
query93	5543	550	557	550
query94	706	327	328	327
query95	389	296	294	294
query96	635	287	290	287
query97	3295	3096	3111	3096
query98	251	231	225	225
query99	1585	1317	1299	1299
Total cold run time: 314059 ms
Total hot run time: 190725 ms

doris-robot · 2024-08-16T08:41:49Z

ClickBench: Total hot run time: 31.03 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f54c15bbcb4aa4b486947930f57debefadccd447, data reload: false
query1	0.04	0.05	0.04
query2	0.08	0.05	0.04
query3	0.23	0.05	0.06
query4	1.66	0.08	0.07
query5	0.50	0.49	0.49
query6	1.13	0.73	0.73
query7	0.02	0.02	0.01
query8	0.06	0.05	0.05
query9	0.56	0.48	0.48
query10	0.56	0.56	0.54
query11	0.16	0.12	0.12
query12	0.15	0.13	0.13
query13	0.62	0.61	0.59
query14	0.79	0.79	0.79
query15	0.85	0.83	0.82
query16	0.37	0.37	0.39
query17	1.05	1.05	0.97
query18	0.23	0.22	0.22
query19	1.83	1.83	1.78
query20	0.01	0.02	0.01
query21	15.43	0.83	0.66
query22	4.57	7.36	1.62
query23	18.37	1.43	1.33
query24	2.09	0.22	0.22
query25	0.15	0.10	0.09
query26	0.31	0.23	0.22
query27	0.46	0.23	0.24
query28	13.33	1.03	1.01
query29	12.59	3.29	3.27
query30	0.43	0.25	0.25
query31	2.81	0.41	0.40
query32	3.23	0.49	0.50
query33	2.91	2.98	2.99
query34	17.11	4.31	4.38
query35	4.39	4.43	4.42
query36	0.67	0.52	0.48
query37	0.20	0.18	0.19
query38	0.18	0.17	0.17
query39	0.07	0.06	0.06
query40	0.18	0.15	0.16
query41	0.11	0.07	0.07
query42	0.07	0.06	0.06
query43	0.06	0.06	0.06
Total cold run time: 110.62 s
Total hot run time: 31.03 s

starocean999 · 2024-08-18T11:27:31Z

run buildall

doris-robot · 2024-08-18T12:04:58Z

TPC-H: Total hot run time: 38128 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f54c15bbcb4aa4b486947930f57debefadccd447, data reload: false
------ Round 1 ----------------------------------
q1	17876	4401	4366	4366
q2	2056	208	208	208
q3	11800	982	1068	982
q4	10527	705	780	705
q5	7746	2829	2822	2822
q6	262	160	163	160
q7	1018	660	659	659
q8	9590	2085	2087	2085
q9	8695	6506	6552	6506
q10	7016	2267	2265	2265
q11	494	270	258	258
q12	428	256	263	256
q13	17804	3006	3036	3006
q14	289	249	254	249
q15	553	526	526	526
q16	514	418	420	418
q17	978	658	738	658
q18	7412	6793	6714	6714
q19	6829	997	1038	997
q20	710	339	351	339
q21	3992	2941	2919	2919
q22	1151	1042	1030	1030
Total cold run time: 117740 ms
Total hot run time: 38128 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4535	4340	4313	4313
q2	429	310	294	294
q3	2849	2662	2659	2659
q4	1999	1760	1684	1684
q5	5714	5717	5829	5717
q6	250	157	157	157
q7	2261	1899	1874	1874
q8	3356	3590	3534	3534
q9	9030	9008	9069	9008
q10	3706	3361	3318	3318
q11	653	542	542	542
q12	840	699	677	677
q13	18407	3240	3164	3164
q14	314	288	288	288
q15	558	513	514	513
q16	505	454	459	454
q17	1878	1566	1528	1528
q18	8232	7936	7680	7680
q19	6636	1548	1562	1548
q20	2163	1888	1894	1888
q21	14136	5289	5432	5289
q22	1147	1072	1064	1064
Total cold run time: 89598 ms
Total hot run time: 57193 ms

doris-robot · 2024-08-18T12:17:53Z

TPC-DS: Total hot run time: 195911 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f54c15bbcb4aa4b486947930f57debefadccd447, data reload: false
query1	1327	904	894	894
query2	6644	2037	2009	2009
query3	10636	3882	3770	3770
query4	57079	27043	23169	23169
query5	6134	666	663	663
query6	529	209	214	209
query7	6413	341	331	331
query8	538	434	448	434
query9	9284	2594	2574	2574
query10	608	355	335	335
query11	18739	15061	15497	15061
query12	189	130	126	126
query13	1663	469	464	464
query14	12142	7345	7518	7345
query15	285	209	220	209
query16	7633	531	488	488
query17	1157	624	605	605
query18	2135	350	335	335
query19	287	179	164	164
query20	150	138	140	138
query21	257	143	142	142
query22	4471	4329	4254	4254
query23	34832	33592	33840	33592
query24	5663	3011	3024	3011
query25	576	427	435	427
query26	712	179	186	179
query27	1749	313	309	309
query28	3778	2180	2167	2167
query29	737	446	450	446
query30	224	195	192	192
query31	1087	846	864	846
query32	134	81	83	81
query33	509	335	338	335
query34	883	504	504	504
query35	870	795	777	777
query36	1060	1000	967	967
query37	167	107	102	102
query38	3934	3768	3834	3768
query39	1533	1449	1462	1449
query40	237	152	152	152
query41	141	138	138	138
query42	142	117	120	117
query43	558	512	528	512
query44	1099	781	793	781
query45	227	193	196	193
query46	1131	742	755	742
query47	1904	1823	1885	1823
query48	412	338	335	335
query49	909	588	588	588
query50	873	486	472	472
query51	6851	6791	6819	6791
query52	122	107	108	107
query53	305	224	230	224
query54	600	502	507	502
query55	91	89	91	89
query56	336	310	316	310
query57	1207	1138	1101	1101
query58	333	309	299	299
query59	3002	2794	2883	2794
query60	350	325	318	318
query61	152	144	145	144
query62	781	703	677	677
query63	255	226	230	226
query64	3385	1845	4030	1845
query65	3204	3194	3186	3186
query66	996	684	680	680
query67	15318	15105	14702	14702
query68	8379	590	600	590
query69	671	428	328	328
query70	1353	1102	1114	1102
query71	505	315	321	315
query72	6719	2256	2087	2087
query73	2148	416	359	359
query74	9230	8949	8908	8908
query75	3726	2709	2800	2709
query76	4348	1116	1075	1075
query77	856	437	439	437
query78	10761	9294	9288	9288
query79	9889	560	568	560
query80	949	614	612	612
query81	619	260	256	256
query82	573	155	155	155
query83	269	213	212	212
query84	291	96	94	94
query85	799	358	352	352
query86	374	321	325	321
query87	4387	4267	4242	4242
query88	3878	2457	2448	2448
query89	532	322	323	322
query90	2257	228	227	227
query91	152	127	124	124
query92	91	74	75	74
query93	4651	555	551	551
query94	1128	320	314	314
query95	388	299	299	299
query96	632	279	280	279
query97	3206	3025	3054	3025
query98	236	232	225	225
query99	1517	1309	1302	1302
Total cold run time: 337183 ms
Total hot run time: 195911 ms

doris-robot · 2024-08-18T12:23:28Z

ClickBench: Total hot run time: 31.93 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f54c15bbcb4aa4b486947930f57debefadccd447, data reload: false
query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.22	0.06	0.05
query4	1.66	0.08	0.08
query5	0.49	0.50	0.52
query6	1.14	0.75	0.73
query7	0.02	0.01	0.02
query8	0.06	0.05	0.05
query9	0.55	0.48	0.47
query10	0.53	0.54	0.54
query11	0.17	0.12	0.12
query12	0.16	0.13	0.13
query13	0.62	0.60	0.59
query14	0.75	0.78	0.77
query15	0.86	0.82	0.81
query16	0.39	0.37	0.36
query17	1.03	1.05	0.98
query18	0.22	0.22	0.22
query19	1.78	1.78	1.67
query20	0.01	0.01	0.02
query21	15.39	0.67	0.66
query22	3.75	6.77	2.71
query23	18.24	1.53	1.34
query24	2.08	0.24	0.22
query25	0.16	0.09	0.08
query26	0.31	0.24	0.23
query27	0.45	0.23	0.22
query28	13.25	1.04	1.00
query29	12.64	3.30	3.32
query30	0.44	0.23	0.19
query31	2.80	0.39	0.39
query32	3.28	0.49	0.49
query33	2.96	2.95	2.95
query34	17.13	4.34	4.34
query35	4.43	4.42	4.47
query36	0.67	0.49	0.50
query37	0.20	0.17	0.17
query38	0.17	0.17	0.16
query39	0.06	0.06	0.05
query40	0.17	0.15	0.15
query41	0.11	0.07	0.07
query42	0.08	0.08	0.07
query43	0.06	0.06	0.06
Total cold run time: 109.61 s
Total hot run time: 31.93 s

morrySnow · 2024-08-20T08:29:06Z


 protected static boolean isDateOutOfRange(LocalDateTime dateTime) {
- return dateTime.isBefore(START_OF_A_DAY) || dateTime.isAfter(END_OF_A_DAY);
+ return dateTime.isBefore(START_OF_A_DAY) || dateTime.isAfter(END_OF_A_DAY) || dateTime == null;


Suggested change
returndateTime.isBefore(START_OF_A_DAY) || dateTime.isAfter(END_OF_A_DAY) || dateTime == null;
returndateTime == null || dateTime.isBefore(START_OF_A_DAY) || dateTime.isAfter(END_OF_A_DAY);

morrySnow · 2024-08-20T08:33:14Z

+ break;
+ }
+ } catch (Exception ex) {
+ // do nothing


exception is expensive, could we process it without try catch

starocean999 · 2024-08-20T08:58:41Z

run buildall

doris-robot · 2024-08-20T10:43:02Z

TPC-H: Total hot run time: 38313 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b27f49841ea16081e543182d82fa01ed73e5b4b8, data reload: false
------ Round 1 ----------------------------------
q1	18153	4450	4391	4391
q2	2737	214	234	214
q3	11043	1147	1112	1112
q4	10606	705	792	705
q5	7848	2843	2883	2843
q6	264	160	164	160
q7	1032	675	650	650
q8	9406	2093	2094	2093
q9	7250	6513	6541	6513
q10	7095	2217	2197	2197
q11	491	274	272	272
q12	429	260	261	260
q13	19040	2981	2982	2981
q14	297	271	267	267
q15	565	537	549	537
q16	531	423	429	423
q17	1010	694	760	694
q18	7510	6940	6729	6729
q19	6217	1188	1070	1070
q20	731	355	349	349
q21	3942	2816	2841	2816
q22	1137	1059	1037	1037
Total cold run time: 117334 ms
Total hot run time: 38313 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4615	4316	4319	4316
q2	412	326	325	325
q3	2902	2637	2647	2637
q4	1904	1649	1688	1649
q5	5374	5421	5392	5392
q6	240	152	151	151
q7	2066	1721	1707	1707
q8	3233	3413	3401	3401
q9	8486	8440	8420	8420
q10	3451	3150	3154	3150
q11	637	538	526	526
q12	840	638	618	618
q13	17539	2988	3022	2988
q14	324	307	281	281
q15	548	524	511	511
q16	494	445	462	445
q17	1795	1499	1481	1481
q18	7661	7530	7353	7353
q19	6789	1632	1583	1583
q20	2093	1823	1803	1803
q21	13601	5145	5166	5145
q22	1145	1044	1000	1000
Total cold run time: 86149 ms
Total hot run time: 54882 ms

doris-robot · 2024-08-20T10:55:18Z

TPC-DS: Total hot run time: 190750 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b27f49841ea16081e543182d82fa01ed73e5b4b8, data reload: false
query1	992	400	398	398
query2	6742	2021	1907	1907
query3	6660	228	245	228
query4	29470	23217	23352	23217
query5	4415	708	737	708
query6	315	214	215	214
query7	4619	340	322	322
query8	476	432	440	432
query9	8619	2552	2516	2516
query10	514	363	314	314
query11	15558	15121	14981	14981
query12	180	124	121	121
query13	1687	415	429	415
query14	9492	6967	6942	6942
query15	247	196	190	190
query16	7526	542	504	504
query17	1212	592	581	581
query18	1777	334	333	333
query19	221	171	197	171
query20	143	139	139	139
query21	256	146	142	142
query22	4328	4012	4090	4012
query23	34064	33271	33237	33237
query24	11804	2895	2865	2865
query25	674	427	430	427
query26	1363	181	178	178
query27	2833	301	304	301
query28	7599	2141	2109	2109
query29	955	451	440	440
query30	340	186	185	185
query31	1052	834	833	833
query32	120	81	81	81
query33	823	341	337	337
query34	931	511	504	504
query35	898	771	769	769
query36	1116	979	970	970
query37	193	106	103	103
query38	3943	3838	3836	3836
query39	1520	1484	1492	1484
query40	319	154	155	154
query41	142	138	140	138
query42	138	119	124	119
query43	563	512	496	496
query44	1291	789	813	789
query45	229	197	196	196
query46	1125	784	798	784
query47	1911	1838	1846	1838
query48	424	343	340	340
query49	1262	602	657	602
query50	862	468	486	468
query51	7211	7199	7184	7184
query52	125	108	110	108
query53	305	234	224	224
query54	977	513	506	506
query55	92	91	93	91
query56	324	306	312	306
query57	1228	1132	1137	1132
query58	330	320	310	310
query59	3024	2815	2963	2815
query60	343	327	327	327
query61	148	145	172	145
query62	914	724	747	724
query63	287	248	248	248
query64	6659	2551	1837	1837
query65	3220	3146	3162	3146
query66	1457	682	675	675
query67	15571	14887	14991	14887
query68	6950	594	590	590
query69	743	414	325	325
query70	1199	1168	1151	1151
query71	569	316	315	315
query72	7542	2307	2115	2115
query73	874	356	357	356
query74	9373	8691	8875	8691
query75	4771	2718	2797	2718
query76	4579	1047	1037	1037
query77	892	473	467	467
query78	9767	9143	9018	9018
query79	8612	544	547	544
query80	1193	615	601	601
query81	624	258	262	258
query82	850	156	159	156
query83	363	215	212	212
query84	295	97	102	97
query85	1438	351	392	351
query86	454	322	327	322
query87	4439	4128	4208	4128
query88	5281	2466	2497	2466
query89	559	333	327	327
query90	1985	232	227	227
query91	155	125	129	125
query92	94	77	76	76
query93	6826	571	550	550
query94	906	332	317	317
query95	395	287	289	287
query96	629	277	277	277
query97	3229	3078	3128	3078
query98	254	227	223	223
query99	1815	1310	1337	1310
Total cold run time: 313813 ms
Total hot run time: 190750 ms

doris-robot · 2024-08-20T11:00:49Z

ClickBench: Total hot run time: 31.29 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b27f49841ea16081e543182d82fa01ed73e5b4b8, data reload: false
query1	0.05	0.04	0.05
query2	0.08	0.04	0.04
query3	0.23	0.05	0.06
query4	1.66	0.08	0.07
query5	0.49	0.50	0.49
query6	1.13	0.73	0.72
query7	0.02	0.01	0.02
query8	0.06	0.05	0.05
query9	0.55	0.49	0.48
query10	0.54	0.54	0.54
query11	0.15	0.12	0.12
query12	0.16	0.13	0.13
query13	0.61	0.60	0.59
query14	0.75	0.76	0.79
query15	0.86	0.81	0.82
query16	0.37	0.38	0.38
query17	1.01	1.02	0.99
query18	0.21	0.22	0.20
query19	1.77	1.69	1.74
query20	0.01	0.02	0.01
query21	15.42	0.67	0.66
query22	4.30	6.48	2.23
query23	18.29	1.44	1.30
query24	2.09	0.24	0.25
query25	0.18	0.09	0.09
query26	0.28	0.19	0.18
query27	0.09	0.08	0.09
query28	13.20	1.04	1.02
query29	12.70	3.29	3.28
query30	0.44	0.25	0.24
query31	2.80	0.40	0.40
query32	3.24	0.48	0.48
query33	2.93	3.01	2.99
query34	16.96	4.37	4.32
query35	4.43	4.40	4.38
query36	0.68	0.50	0.49
query37	0.21	0.18	0.18
query38	0.18	0.16	0.17
query39	0.06	0.05	0.06
query40	0.18	0.15	0.15
query41	0.11	0.07	0.07
query42	0.09	0.07	0.07
query43	0.07	0.06	0.06
Total cold run time: 109.64 s
Total hot run time: 31.29 s

github-actions · 2024-08-21T02:47:34Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-08-21T02:47:36Z

PR approved by anyone and no changes requested.

…ows (#39676) pick from master #39482

…ows (#39675) pick from master #39482

…lows (#39482) date and datetime literal's plusXXX method( plusDays, plusWeeks, plusMonths) may return NullLiteral, So we should only convert the return value to date or datetime literal when it's not a NullLiteral

…ows (apache#39676) pick from master apache#39482

…lows (apache#39482) date and datetime literal's plusXXX method( plusDays, plusWeeks, plusMonths) may return NullLiteral, So we should only convert the return value to date or datetime literal when it's not a NullLiteral

starocean999 marked this pull request as ready for review August 19, 2024 06:33

morrySnow reviewed Aug 20, 2024
View reviewed changes

starocean999 added 2 commits August 20, 2024 16:35

[fix](nereids)prevent null pointer exception if datetime value overflows
50813fc

modified based on comments
b27f498

starocean999 force-pushed the master_0826 branch from f54c15b to b27f498Compare August 20, 2024 08:58

morrySnow approved these changes Aug 21, 2024
View reviewed changes

morrySnow added dev/2.0.x dev/2.1.x labels Aug 21, 2024

LiBinfeng-01 approved these changes Aug 21, 2024
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 21, 2024

github-actionsBot added the reviewed label Aug 21, 2024

morrySnow merged commit 4e651e1 into apache:masterAug 21, 2024

This was referenced Aug 21, 2024
[fix](nereids)prevent null pointer exception if datetime value overflows #39675
Merged
[fix](nereids)prevent null pointer exception if datetime value overflows #39676
Merged

starocean999 added a commit that referenced this pull request Aug 21, 2024
[fix](nereids)prevent null pointer exception if datetime value overfl…
31f5072
…ows (#39676) pick from master #39482

starocean999 added a commit that referenced this pull request Aug 21, 2024
[fix](nereids)prevent null pointer exception if datetime value overfl…
ba3b56d
…ows (#39675) pick from master #39482

starocean999 added dev/2.1.6-merged dev/2.0.15-merged and removed dev/2.1.x dev/2.0.x labels Aug 21, 2024

yiguolei mentioned this pull request Sep 5, 2024
Release Note 2.1.6 #40443
Closed
3 tasks

morrySnow added p0_b dev/3.0.x labels Sep 25, 2024

dataroaring added dev/3.0.2-merged and removed dev/3.0.x labels Sep 26, 2024

mongo360 pushed a commit to mongo360/doris that referenced this pull request Dec 11, 2024
[fix](nereids)prevent null pointer exception if datetime value overfl…
3c9fafa
…ows (apache#39676) pick from master apache#39482

	returndateTime.isBefore(START_OF_A_DAY) \|\| dateTime.isAfter(END_OF_A_DAY) \|\| dateTime == null;
	returndateTime == null \|\| dateTime.isBefore(START_OF_A_DAY) \|\| dateTime.isAfter(END_OF_A_DAY);

Uh oh!

Conversation

starocean999 commented Aug 16, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

doris-robot commented Aug 16, 2024

Uh oh!

starocean999 commented Aug 16, 2024

Uh oh!

doris-robot commented Aug 16, 2024

Uh oh!

doris-robot commented Aug 16, 2024

Uh oh!

doris-robot commented Aug 16, 2024

Uh oh!

starocean999 commented Aug 18, 2024

Uh oh!

doris-robot commented Aug 18, 2024

Uh oh!

doris-robot commented Aug 18, 2024

Uh oh!

doris-robot commented Aug 18, 2024

Uh oh!

morrySnowAug 20, 2024

Choose a reason for hiding this comment

Uh oh!

morrySnowAug 20, 2024

Choose a reason for hiding this comment

Uh oh!

starocean999 commented Aug 20, 2024

Uh oh!

doris-robot commented Aug 20, 2024

Uh oh!

doris-robot commented Aug 20, 2024

Uh oh!

doris-robot commented Aug 20, 2024

Uh oh!

github-actionsBot commented Aug 21, 2024

Uh oh!

github-actionsBot commented Aug 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

starocean999 commented Aug 16, 2024•
edited
Loading