Uh oh!
There was an error while loading. Please reload this page.
[Bug](predicate) fix wrong result of AcceptNullPredicate - #39497
Merged
Conversation
BiteTheDDDDt
commented
Aug 16, 2024
ContributorAuthor
run buildall |
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
| } | ||
| // create selected_flags | ||
| uint16_t max_idx = sel[size - 1]; | ||
| std::vector<uint16_t> old_sel(size); |
| uint16_t row_idx = sel[i]; | ||
| selected[row_idx] = true; | ||
| } | ||
| for (uint16_t i = 0; i < size; ++i) { |
| const auto& nullable_col = assert_cast<const vectorized::ColumnNullable&>(column); | ||
| // call nested predicate evaluate | ||
| uint16_t new_size = _nested->evaluate(nullable_col.get_nested_column(), sel, size); | ||
Contributor
There was a problem hiding this comment.
sel 1,2,3,7,8,9
sel 1,2,3,4,5,6,7,8,9
BiteTheDDDDt
commented
Aug 19, 2024
ContributorAuthor
run buildall |
BiteTheDDDDt
commented
Aug 19, 2024
ContributorAuthor
run buildall |
| const auto& nullmap = nullable_col.get_null_map_data(); | ||
| for (uint16_t i = 0; i < size; ++i) { | ||
| flags[i] |= nullmap[sel[i]]; | ||
| flags[i] |= (original_flags[i] && nullmap[sel[i]]); |
Contributor
There was a problem hiding this comment.
我觉得这里不对吧
是不是应该是 flags[sel[i]] |= (original_flags[sel[i]] && nullmap[sel[i]]);
Uh oh!
There was an error while loading. Please reload this page.
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
yiguolei
approved these changes
Aug 19, 2024
BiteTheDDDDt
commented
Aug 19, 2024
ContributorAuthor
run buildall |
yiguolei
approved these changes
Aug 19, 2024
BiteTheDDDDt added a commit
to BiteTheDDDDt/incubator-doris
that referenced
this pull request
Aug 21, 2024
fix wrong result of AcceptNullPredicate
yiguolei pushed a commit
that referenced
this pull request
Aug 21, 2024
dataroaring pushed a commit
that referenced
this pull request
Aug 26, 2024
## Proposed changes fix wrong result of AcceptNullPredicate
Closed
HappenLee pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
## Proposed changes fix wrong result of AcceptNullPredicate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
fix wrong result of AcceptNullPredicate