Skip to content

[opt](bytebuffer) allocate ByteBuffer memory by Allocator and make it exception safe (#38960) - #39524

Closed
sollhui wants to merge 1 commit into
apache:branch-2.1from
sollhui:2.1_bytebuffer
Closed

[opt](bytebuffer) allocate ByteBuffer memory by Allocator and make it exception safe (#38960)#39524
sollhui wants to merge 1 commit into
apache:branch-2.1from
sollhui:2.1_bytebuffer

Conversation

@sollhui

@sollhuisollhui commented Aug 18, 2024

Copy link
Copy Markdown
Contributor

pick (#38960)

At present, the memory allocation of ByteBuffer is done through new char[capacity_]. Now, it is uniformly allocated by Allocator for the following purposes:

  1. Better memory statistics
  2. Better support for memory limit check

@doris-robot

doris-robot commented Aug 18, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@sollhui

sollhui commented Aug 18, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

yiguolei
yiguolei reviewed Aug 18, 2024
View reviewed changes
Comment threadbe/src/util/byte_buffer.h
@yiguolei

yiguolei commented Aug 24, 2024

Copy link
Copy Markdown
Contributor

run buildall

github-actions[bot]
github-actionsBot reviewed Aug 24, 2024
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadbe/src/util/byte_buffer.h Outdated
@sollhui

sollhui commented Aug 27, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

2 similar comments
@sollhui

sollhui commented Aug 29, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@sollhui

sollhui commented Sep 2, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

github-actions[bot]
github-actionsBot reviewed Sep 2, 2024
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadbe/src/util/byte_buffer.h
@sollhui

sollhui commented Sep 2, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@sollhuisollhui closed this Sep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguoleiyiguoleiyiguolei left review comments
@github-actionsgithub-actions[bot]github-actions[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sollhui@doris-robot@yiguolei