[fix](tableFuncs) fix explode_json_array_funcs by amorynan · Pull Request #39572 · apache/doris

amorynan · 2024-08-19T10:20:39Z

Proposed changes

explode_json_array_json accept jsonb type and return jsonb type or string type and return string type
fix explode_json_array return empty set issue
Issue Number: close #xxx

doris-robot · 2024-08-19T10:20:44Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

amorynan · 2024-08-19T10:23:06Z

run buildall

doris-robot · 2024-08-19T11:36:59Z

TPC-H: Total hot run time: 38694 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9ce7bf870246251f42ddf6c5de793977eaa8e9a0, data reload: false
------ Round 1 ----------------------------------
q1	17991	4411	4376	4376
q2	2063	211	244	211
q3	12469	987	1097	987
q4	10538	799	682	682
q5	7812	2885	2854	2854
q6	266	161	164	161
q7	1017	656	683	656
q8	10791	2129	2096	2096
q9	7976	6547	6648	6547
q10	7095	2317	2237	2237
q11	510	283	279	279
q12	443	262	290	262
q13	18912	3172	3229	3172
q14	330	276	277	276
q15	582	553	588	553
q16	908	445	468	445
q17	1116	731	746	731
q18	8202	6883	6803	6803
q19	7366	1125	1127	1125
q20	718	362	353	353
q21	3868	3031	2877	2877
q22	1144	1011	1047	1011
Total cold run time: 122117 ms
Total hot run time: 38694 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5376	4353	4290	4290
q2	417	314	298	298
q3	3013	2757	2756	2756
q4	2001	1693	1676	1676
q5	5710	5616	5550	5550
q6	245	150	146	146
q7	2174	1830	1793	1793
q8	3325	3485	3470	3470
q9	8819	8734	8912	8734
q10	3518	3254	3259	3254
q11	614	524	516	516
q12	832	676	675	675
q13	17099	3077	3149	3077
q14	348	334	281	281
q15	584	523	536	523
q16	515	460	456	456
q17	1848	1548	1523	1523
q18	8170	7843	7775	7775
q19	9568	1699	1629	1629
q20	2245	1887	1905	1887
q21	10235	5226	5283	5226
q22	1163	1075	1040	1040
Total cold run time: 87819 ms
Total hot run time: 56575 ms

doris-robot · 2024-08-19T11:49:56Z

TPC-DS: Total hot run time: 197130 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9ce7bf870246251f42ddf6c5de793977eaa8e9a0, data reload: false
query1	1339	926	867	867
query2	6712	2006	1941	1941
query3	10635	3832	3832	3832
query4	58676	24206	23696	23696
query5	5774	661	651	651
query6	518	212	213	212
query7	6369	324	319	319
query8	538	442	431	431
query9	9167	2523	2514	2514
query10	629	342	329	329
query11	18332	15166	15581	15166
query12	191	135	125	125
query13	1642	436	459	436
query14	11896	7629	7206	7206
query15	250	195	198	195
query16	7641	531	493	493
query17	1192	645	641	641
query18	2011	360	348	348
query19	323	191	198	191
query20	155	154	151	151
query21	274	160	161	160
query22	4891	4449	4507	4449
query23	34873	34196	34225	34196
query24	5786	2956	3061	2956
query25	560	457	432	432
query26	718	180	191	180
query27	1832	308	308	308
query28	3798	2182	2103	2103
query29	650	437	441	437
query30	222	183	189	183
query31	1008	833	825	825
query32	100	77	79	77
query33	538	351	337	337
query34	894	503	504	503
query35	875	798	754	754
query36	1102	948	951	948
query37	161	103	101	101
query38	3933	3900	3837	3837
query39	1655	1470	1494	1470
query40	238	157	155	155
query41	140	137	138	137
query42	136	114	116	114
query43	544	508	522	508
query44	1184	798	789	789
query45	224	198	198	198
query46	1127	787	762	762
query47	1933	1845	1822	1822
query48	413	332	336	332
query49	918	581	578	578
query50	853	468	480	468
query51	6826	6844	6769	6769
query52	126	105	116	105
query53	301	234	223	223
query54	625	524	499	499
query55	92	90	89	89
query56	331	302	311	302
query57	1197	1124	1135	1124
query58	296	299	300	299
query59	3000	2910	2770	2770
query60	344	328	334	328
query61	148	143	145	143
query62	802	698	682	682
query63	260	226	227	226
query64	3445	1884	1875	1875
query65	3262	3173	3166	3166
query66	950	712	681	681
query67	15434	15109	14900	14900
query68	8444	586	595	586
query69	707	415	335	335
query70	1191	1190	1152	1152
query71	573	323	324	323
query72	6318	2318	2105	2105
query73	1187	350	353	350
query74	9372	8756	8919	8756
query75	4001	2745	2746	2745
query76	4536	1122	1074	1074
query77	830	443	438	438
query78	9794	10122	9181	9181
query79	11017	552	551	551
query80	1119	611	616	611
query81	613	260	263	260
query82	704	163	158	158
query83	338	208	213	208
query84	293	95	95	95
query85	848	361	362	361
query86	372	319	331	319
query87	4351	4284	4409	4284
query88	4967	2475	2476	2475
query89	568	332	317	317
query90	2334	226	232	226
query91	155	128	125	125
query92	88	77	76	76
query93	5998	546	563	546
query94	1078	298	292	292
query95	396	294	297	294
query96	628	287	288	287
query97	3201	3026	3067	3026
query98	251	238	223	223
query99	1594	1307	1309	1307
Total cold run time: 340875 ms
Total hot run time: 197130 ms

doris-robot · 2024-08-19T11:55:30Z

ClickBench: Total hot run time: 30.63 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9ce7bf870246251f42ddf6c5de793977eaa8e9a0, data reload: false
query1	0.05	0.04	0.05
query2	0.08	0.04	0.04
query3	0.23	0.06	0.05
query4	1.68	0.07	0.08
query5	0.50	0.49	0.50
query6	1.13	0.73	0.73
query7	0.02	0.01	0.01
query8	0.06	0.04	0.05
query9	0.56	0.51	0.50
query10	0.56	0.56	0.54
query11	0.16	0.12	0.12
query12	0.16	0.12	0.13
query13	0.60	0.59	0.58
query14	0.78	0.78	0.77
query15	0.88	0.82	0.83
query16	0.37	0.37	0.39
query17	1.03	1.05	0.99
query18	0.22	0.21	0.20
query19	1.93	1.74	1.74
query20	0.01	0.01	0.01
query21	15.38	0.69	0.67
query22	4.20	7.58	1.54
query23	18.30	1.41	1.30
query24	2.09	0.22	0.23
query25	0.15	0.08	0.08
query26	0.26	0.19	0.19
query27	0.08	0.08	0.09
query28	13.26	1.02	0.99
query29	12.66	3.34	3.29
query30	0.44	0.25	0.23
query31	2.80	0.40	0.41
query32	3.23	0.50	0.49
query33	2.96	2.98	2.99
query34	16.90	4.34	4.38
query35	4.41	4.36	4.45
query36	0.65	0.50	0.50
query37	0.23	0.18	0.17
query38	0.18	0.17	0.16
query39	0.07	0.06	0.06
query40	0.19	0.15	0.16
query41	0.12	0.07	0.07
query42	0.08	0.08	0.07
query43	0.07	0.06	0.06
Total cold run time: 109.72 s
Total hot run time: 30.63 s

amorynan · 2024-08-20T07:22:36Z

run buildall

amorynan · 2024-08-20T07:27:01Z

run buildall

doris-robot · 2024-08-20T09:33:33Z

TPC-H: Total hot run time: 38411 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a57e4728645d97ed093b15509fdb51ac5da10420, data reload: false
------ Round 1 ----------------------------------
q1	14898	4414	4305	4305
q2	1280	215	229	215
q3	9768	1109	1202	1109
q4	9978	738	815	738
q5	6584	2846	2817	2817
q6	268	162	162	162
q7	993	666	665	665
q8	7816	2111	2100	2100
q9	6834	6567	6597	6567
q10	4665	2239	2148	2148
q11	445	277	286	277
q12	486	266	267	266
q13	17405	3031	3044	3031
q14	313	260	263	260
q15	572	526	531	526
q16	525	424	426	424
q17	973	695	725	695
q18	7421	6812	6763	6763
q19	1746	1111	1072	1072
q20	673	391	368	368
q21	3933	2863	2997	2863
q22	1154	1040	1058	1040
Total cold run time: 98730 ms
Total hot run time: 38411 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4429	4330	4325	4325
q2	424	318	318	318
q3	2906	2662	2572	2572
q4	1921	1694	1672	1672
q5	5405	5404	5411	5404
q6	236	155	154	154
q7	2126	1720	1728	1720
q8	3290	3420	3399	3399
q9	8515	8459	8472	8459
q10	3416	3218	3171	3171
q11	631	541	533	533
q12	811	637	676	637
q13	16469	2998	3018	2998
q14	324	298	289	289
q15	560	518	510	510
q16	504	442	442	442
q17	1798	1476	1482	1476
q18	7867	7642	7585	7585
q19	7431	1636	1720	1636
q20	2067	1815	1815	1815
q21	10972	5070	4998	4998
q22	1107	1058	1034	1034
Total cold run time: 83209 ms
Total hot run time: 55147 ms

doris-robot · 2024-08-20T09:45:52Z

TPC-DS: Total hot run time: 190542 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a57e4728645d97ed093b15509fdb51ac5da10420, data reload: false
query1	961	399	396	396
query2	6742	1968	1845	1845
query3	6669	234	246	234
query4	34014	23215	23208	23208
query5	4301	663	660	660
query6	294	193	191	191
query7	4612	315	307	307
query8	431	435	448	435
query9	8743	2560	2519	2519
query10	514	351	339	339
query11	17845	15042	14940	14940
query12	191	139	142	139
query13	1706	466	469	466
query14	10032	7278	7438	7278
query15	285	192	189	189
query16	7954	484	507	484
query17	1633	591	576	576
query18	1950	344	332	332
query19	357	172	168	168
query20	145	137	141	137
query21	255	148	141	141
query22	4210	4034	3892	3892
query23	34541	33428	33050	33050
query24	11644	2940	2877	2877
query25	641	420	421	420
query26	1187	181	179	179
query27	2555	306	298	298
query28	7292	2111	2093	2093
query29	813	458	470	458
query30	349	198	186	186
query31	1042	845	854	845
query32	121	83	83	83
query33	816	350	345	345
query34	911	507	510	507
query35	872	773	758	758
query36	1100	970	954	954
query37	176	105	104	104
query38	4023	3868	3988	3868
query39	1534	1472	1466	1466
query40	233	155	154	154
query41	141	156	140	140
query42	139	117	120	117
query43	554	501	507	501
query44	1226	791	799	791
query45	223	197	200	197
query46	1138	806	802	802
query47	1932	1846	1865	1846
query48	417	335	334	334
query49	1228	577	586	577
query50	879	460	460	460
query51	7201	7252	7035	7035
query52	123	111	114	111
query53	309	230	225	225
query54	973	510	503	503
query55	92	92	88	88
query56	344	309	313	309
query57	1193	1128	1105	1105
query58	320	298	305	298
query59	2970	2812	2752	2752
query60	364	330	326	326
query61	150	147	146	146
query62	838	687	694	687
query63	258	230	227	227
query64	5319	2390	1851	1851
query65	3265	3177	3198	3177
query66	1081	734	688	688
query67	15572	14869	14987	14869
query68	6299	581	585	581
query69	678	428	322	322
query70	1230	1198	1177	1177
query71	549	314	308	308
query72	7652	2307	2102	2102
query73	853	353	354	353
query74	9455	8847	8751	8751
query75	4631	2738	2722	2722
query76	4768	1036	975	975
query77	976	434	444	434
query78	10358	9348	9127	9127
query79	8821	558	558	558
query80	1031	601	607	601
query81	614	256	259	256
query82	304	155	160	155
query83	371	217	215	215
query84	294	98	96	96
query85	927	357	353	353
query86	376	321	327	321
query87	4428	4210	4198	4198
query88	4420	2484	2458	2458
query89	524	326	358	326
query90	2315	230	228	228
query91	156	128	130	128
query92	85	75	76	75
query93	5741	549	543	543
query94	1236	318	318	318
query95	387	298	288	288
query96	633	282	282	282
query97	3233	3076	3094	3076
query98	270	234	225	225
query99	1567	1307	1321	1307
Total cold run time: 317125 ms
Total hot run time: 190542 ms

doris-robot · 2024-08-20T09:51:26Z

ClickBench: Total hot run time: 31.07 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a57e4728645d97ed093b15509fdb51ac5da10420, data reload: false
query1	0.06	0.05	0.04
query2	0.08	0.05	0.05
query3	0.24	0.05	0.05
query4	1.66	0.08	0.07
query5	0.49	0.50	0.50
query6	1.13	0.72	0.73
query7	0.02	0.01	0.01
query8	0.06	0.05	0.05
query9	0.54	0.49	0.49
query10	0.56	0.55	0.55
query11	0.16	0.12	0.12
query12	0.16	0.12	0.14
query13	0.62	0.60	0.59
query14	0.76	0.77	0.81
query15	0.87	0.84	0.82
query16	0.38	0.37	0.36
query17	1.01	0.98	0.98
query18	0.21	0.21	0.21
query19	1.80	1.81	1.78
query20	0.01	0.01	0.02
query21	15.40	0.66	0.65
query22	4.41	7.84	1.97
query23	18.31	1.49	1.27
query24	2.12	0.24	0.23
query25	0.16	0.09	0.09
query26	0.27	0.19	0.18
query27	0.09	0.08	0.08
query28	13.17	1.02	1.00
query29	12.64	3.35	3.24
query30	0.43	0.25	0.24
query31	2.81	0.40	0.41
query32	3.24	0.48	0.49
query33	2.96	2.98	2.97
query34	17.06	4.36	4.39
query35	4.39	4.40	4.42
query36	0.68	0.48	0.50
query37	0.22	0.17	0.17
query38	0.17	0.16	0.16
query39	0.06	0.06	0.05
query40	0.18	0.16	0.15
query41	0.12	0.07	0.07
query42	0.07	0.07	0.07
query43	0.07	0.07	0.07
Total cold run time: 109.85 s
Total hot run time: 31.07 s

github-actions · 2024-08-20T09:54:57Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-08-20T09:54:59Z

PR approved by anyone and no changes requested.

amorynan · 2024-08-21T03:04:34Z

run cloud_p1

amorynan · 2024-08-21T06:12:03Z

run cloud_p1

xiaokang

LGTM

1. explode_json_array_json accept jsonb type and return jsonb type or string type and return string type 2. fix explode_json_array return empty set issue

fix explode_json_array_funcs
9ce7bf8

morrySnow requested changes Aug 19, 2024
View reviewed changes

Comment thread...ava/org/apache/doris/nereids/trees/expressions/functions/generator/ExplodeJsonArrayJson.java Outdated

amorynan added 2 commits August 20, 2024 11:22

fix function_fake
d5f28f4

fix be and add case
54fa727

amorynan requested a review from morrySnow August 20, 2024 07:22

amorynan added 2 commits August 20, 2024 15:24

revert build.sh
138322c

fix code
a57e472

morrySnow approved these changes Aug 20, 2024
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 20, 2024

github-actionsBot added the reviewed label Aug 20, 2024

xiaokang approved these changes Aug 21, 2024
View reviewed changes

xiaokang merged commit e87c9e0 into apache:masterAug 21, 2024

xiaokang added the dev/2.1.x label Aug 21, 2024

dataroaring pushed a commit that referenced this pull request Aug 22, 2024
[fix](tableFuncs) fix explode_json_array_funcs (#39572)
2e01cc5
1. explode_json_array_json accept jsonb type and return jsonb type or string type and return string type 2. fix explode_json_array return empty set issue

dataroaring added the dev/3.0.2-merged label Aug 22, 2024

amorynan mentioned this pull request Aug 26, 2024
[Improve](table-function) explode json array with json args #39491
Merged

xiaokang added dev/2.1.6-merged and removed dev/2.1.x labels Aug 27, 2024

xiaokang mentioned this pull request Sep 1, 2024
[improve](explode-json-array)change explode-json-array-xx func signature from string to json type #37278
Merged

zhangstar333 mentioned this pull request Apr 18, 2025
[Bug](function) fix Could not find function explode_json_array_json_outer #50164
Merged
16 tasks

Uh oh!

Conversation

amorynan commented Aug 19, 2024

Proposed changes

Uh oh!

doris-robot commented Aug 19, 2024

Uh oh!

amorynan commented Aug 19, 2024

Uh oh!

Uh oh!

doris-robot commented Aug 19, 2024

Uh oh!

doris-robot commented Aug 19, 2024

Uh oh!

doris-robot commented Aug 19, 2024

Uh oh!

amorynan commented Aug 20, 2024

Uh oh!

amorynan commented Aug 20, 2024

Uh oh!

doris-robot commented Aug 20, 2024

Uh oh!

doris-robot commented Aug 20, 2024

Uh oh!

doris-robot commented Aug 20, 2024

Uh oh!

github-actionsBot commented Aug 20, 2024

Uh oh!

github-actionsBot commented Aug 20, 2024

Uh oh!

amorynan commented Aug 21, 2024

Uh oh!

amorynan commented Aug 21, 2024

Uh oh!

xiaokang left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants