Uh oh!
There was an error while loading. Please reload this page.
[fix](Nereids) fix lexer Backtracking or Ambiguity cause of key word duplicate - #39590
Merged
Conversation
doris-robot
commented
Aug 20, 2024
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
LiBinfeng-01
commented
Aug 20, 2024
ContributorAuthor
run buildall |
doris-robot
commented
Aug 20, 2024
TPC-H: Total hot run time: 37610 ms |
| BRACKETED_COMMENT | ||
| : '/*' {!isHint()}? ( BRACKETED_COMMENT | . )*? ('*/' | {markUnclosedComment();} EOF) -> channel(HIDDEN) | ||
| : COMMENT_START ( BRACKETED_COMMENT | . )*? ('*/' | {markUnclosedComment();} EOF) -> channel(HIDDEN) |
Contributor
There was a problem hiding this comment.
Suggested change
| : COMMENT_START ( BRACKETED_COMMENT | . )*? ('*/' | {markUnclosedComment();}EOF) -> channel(HIDDEN) | |
| : COMMENT_START ( BRACKETED_COMMENT | HINT_WITH_CHANNEL | . )*? ('*/' | {markUnclosedComment();}EOF) -> channel(HIDDEN) |
| ARROW: '->'; | ||
| HINT_START: '/*+'; | ||
| HINT_END: '*/'; | ||
| COMMENT_START: '/*'; |
Contributor
There was a problem hiding this comment.
add to non-reserved key word
| HINT_WITH_CHANNEL | ||
| : {isChannel2()}? HINT_START .*? HINT_END -> channel(2) | ||
| : HINT_START {isChannel2()}? .*? HINT_END -> channel(2) |
Contributor
There was a problem hiding this comment.
Suggested change
| : HINT_START{isChannel2()}? .*? HINT_END -> channel(2) | |
| : HINT_START{isChannel2()}? ( BRACKETED_COMMENT | HINT_WITH_CHANNEL | . )*? HINT_END -> channel(2) |
| : COMMENT_START ( BRACKETED_COMMENT | . )*? ('*/' | {markUnclosedComment();} EOF) -> channel(HIDDEN) | ||
| ; | ||
| HINT_WITH_CHANNEL |
Contributor
There was a problem hiding this comment.
Suggested change
| HINT_WITH_CHANNEL | |
| HINT |
LiBinfeng-01
commented
Aug 20, 2024
ContributorAuthor
run buildall |
1 similar comment
LiBinfeng-01
commented
Aug 20, 2024
ContributorAuthor
run buildall |
| | COLOCATE | ||
| | COLUMNS | ||
| | COMMENT | ||
| | COMMENT_START |
LiBinfeng-01
commented
Aug 20, 2024
ContributorAuthor
run buildall |
doris-robot
commented
Aug 20, 2024
TPC-H: Total hot run time: 37419 ms |
doris-robot
commented
Aug 20, 2024
TPC-DS: Total hot run time: 189113 ms |
doris-robot
commented
Aug 20, 2024
ClickBench: Total hot run time: 31.45 s |
LiBinfeng-01
commented
Aug 20, 2024
ContributorAuthor
run buildall |
doris-robot
commented
Aug 20, 2024
TPC-H: Total hot run time: 37920 ms |
doris-robot
commented
Aug 20, 2024
TPC-DS: Total hot run time: 193830 ms |
doris-robot
commented
Aug 20, 2024
ClickBench: Total hot run time: 30.75 s |
LiBinfeng-01
commented
Aug 20, 2024
ContributorAuthor
run buildall |
doris-robot
commented
Aug 20, 2024
TPC-H: Total hot run time: 38354 ms |
doris-robot
commented
Aug 20, 2024
TPC-DS: Total hot run time: 195202 ms |
doris-robot
commented
Aug 20, 2024
ClickBench: Total hot run time: 31.22 s |
LiBinfeng-01
commented
Aug 21, 2024
ContributorAuthor
run feut |
LiBinfeng-01
commented
Aug 21, 2024
ContributorAuthor
run buildall |
doris-robot
commented
Aug 21, 2024
TPC-H: Total hot run time: 38335 ms |
| HINT_WITH_CHANNEL | ||
| : {isChannel2()}? HINT_START .*? HINT_END -> channel(2) | ||
| BRACKETED_COMMENT | ||
| : {isChannel()}? COMMENT_START ( BRACKETED_COMMENT | HINT | . )*? ('*/' | {markUnclosedComment();} EOF) -> channel(HIDDEN) |
LiBinfeng-01
commented
Aug 21, 2024
ContributorAuthor
run buildall |
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
englefly
approved these changes
Aug 22, 2024
morrySnow pushed a commit
that referenced
this pull request
Aug 22, 2024
LiBinfeng-01 added a commit
to LiBinfeng-01/doris
that referenced
this pull request
Aug 23, 2024
…duplicate (apache#39590) nereids timeout cause of parser cost too long time intro by: apache#39113 ## Proposed changes Issue Number: close #xxx <!--Describe your changes.-->
LiBinfeng-01 added a commit
to LiBinfeng-01/doris
that referenced
this pull request
Sep 20, 2024
…duplicate (apache#39590) nereids timeout cause of parser cost too long time intro by: apache#39113 ## Proposed changes Issue Number: close #xxx <!--Describe your changes.-->
dataroaring pushed a commit
that referenced
this pull request
Sep 20, 2024
mongo360 pushed a commit
to mongo360/doris
that referenced
this pull request
Dec 11, 2024
…duplicate (apache#39590) (apache#39750) cherry-pick from master apache#39590 issue intro by apache#39416
HappenLee pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
…duplicate (apache#39590) nereids timeout cause of parser cost too long time intro by: apache#39113 ## Proposed changes Issue Number: close #xxx <!--Describe your changes.-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nereids timeout cause of parser cost too long time
intro by: #39113
Proposed changes
Issue Number: close #xxx