[Fix](Variant) casting to decimal type may lost precision and scale when _normalize_predicate by eldenmoon · Pull Request #39650 · apache/doris

eldenmoon · 2024-08-20T13:36:22Z

use TypeDescriptor to prevent from info lost

Proposed changes

Issue Number: close #xxx

doris-robot · 2024-08-20T13:36:28Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

eldenmoon · 2024-08-20T13:36:58Z

run buildall

eldenmoon · 2024-08-20T13:41:11Z

run buildall

…hen _normalize_predicate use TypeDescriptor to prevent from info lost

eldenmoon · 2024-08-20T13:42:42Z

run buildall

github-actions · 2024-08-20T13:49:00Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-08-20T13:53:15Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-08-20T13:55:44Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-08-20T16:51:45Z

TPC-H: Total hot run time: 38333 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8e5600b9ba34aafb3b987e481de2e62f07db4a49, data reload: false
------ Round 1 ----------------------------------
q1	17993	4474	4318	4318
q2	2088	211	202	202
q3	11437	1006	1218	1006
q4	10535	734	685	685
q5	7776	2837	2815	2815
q6	270	160	160	160
q7	1044	650	654	650
q8	9600	2127	2153	2127
q9	8764	6590	6631	6590
q10	7068	2262	2213	2213
q11	526	278	277	277
q12	432	263	265	263
q13	17987	2983	3008	2983
q14	317	253	276	253
q15	545	513	535	513
q16	516	413	405	405
q17	1000	659	734	659
q18	7459	6960	6838	6838
q19	6241	1092	1089	1089
q20	680	340	352	340
q21	4599	2946	2931	2931
q22	1140	1055	1016	1016
Total cold run time: 118017 ms
Total hot run time: 38333 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4788	4320	4279	4279
q2	412	302	307	302
q3	2854	2659	2777	2659
q4	2050	1682	1725	1682
q5	5675	5736	5662	5662
q6	263	156	157	156
q7	2170	1794	1808	1794
q8	3306	3590	3490	3490
q9	8837	8818	8784	8784
q10	3649	3385	3282	3282
q11	627	527	543	527
q12	861	716	654	654
q13	16227	3236	3109	3109
q14	335	283	293	283
q15	568	514	526	514
q16	508	479	466	466
q17	1874	1605	1537	1537
q18	8279	7853	7745	7745
q19	4887	1699	1600	1600
q20	2163	1915	1915	1915
q21	13238	5312	5352	5312
q22	1202	1084	1114	1084
Total cold run time: 84773 ms
Total hot run time: 56836 ms

doris-robot · 2024-08-20T17:04:40Z

TPC-DS: Total hot run time: 196166 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8e5600b9ba34aafb3b987e481de2e62f07db4a49, data reload: false
query1	1301	897	890	890
query2	6620	1977	1971	1971
query3	10758	4071	3783	3783
query4	58763	27441	23212	23212
query5	6245	732	759	732
query6	555	220	215	215
query7	6440	337	330	330
query8	543	436	429	429
query9	9351	2541	2513	2513
query10	607	345	350	345
query11	18398	15177	15533	15177
query12	187	131	126	126
query13	1679	451	442	442
query14	12217	6658	7489	6658
query15	256	190	201	190
query16	7621	534	554	534
query17	1222	630	626	626
query18	2131	348	358	348
query19	319	179	177	177
query20	157	138	137	137
query21	247	148	144	144
query22	4518	4419	4442	4419
query23	34618	33597	33842	33597
query24	5700	3061	3039	3039
query25	588	430	429	429
query26	747	187	188	187
query27	1863	306	310	306
query28	3951	2148	2116	2116
query29	735	445	444	444
query30	244	182	184	182
query31	1057	826	787	787
query32	103	78	79	78
query33	575	354	345	345
query34	918	512	508	508
query35	859	758	757	757
query36	1081	961	949	949
query37	162	102	106	102
query38	4167	3889	3849	3849
query39	1526	1471	1513	1471
query40	245	158	156	156
query41	136	134	137	134
query42	134	115	115	115
query43	558	495	510	495
query44	1132	794	801	794
query45	234	194	195	194
query46	1116	788	770	770
query47	1958	1815	1862	1815
query48	419	346	345	345
query49	896	571	607	571
query50	856	474	467	467
query51	7136	7147	7146	7146
query52	119	111	110	110
query53	299	229	226	226
query54	633	522	515	515
query55	88	88	87	87
query56	329	313	308	308
query57	1202	1160	1115	1115
query58	295	297	303	297
query59	3141	2983	2797	2797
query60	349	327	326	326
query61	151	149	143	143
query62	792	703	718	703
query63	260	226	229	226
query64	4288	2410	1838	1838
query65	3291	3210	3199	3199
query66	1044	660	662	660
query67	15430	15054	15064	15054
query68	6928	593	594	593
query69	716	442	346	346
query70	1245	1164	1142	1142
query71	541	335	317	317
query72	6819	2297	2120	2120
query73	831	360	359	359
query74	9705	8903	8869	8869
query75	3973	2700	2810	2700
query76	3950	1056	973	973
query77	832	433	439	433
query78	9910	8988	9168	8988
query79	6287	567	550	550
query80	2559	607	640	607
query81	592	268	264	264
query82	867	167	156	156
query83	360	207	213	207
query84	298	99	97	97
query85	1022	357	398	357
query86	381	328	328	328
query87	4555	4360	4231	4231
query88	4539	2559	2562	2559
query89	444	330	324	324
query90	2021	228	234	228
query91	152	126	124	124
query92	92	75	74	74
query93	5126	561	558	558
query94	780	325	299	299
query95	388	293	290	290
query96	630	289	287	287
query97	3227	3075	3122	3075
query98	250	229	232	229
query99	1695	1346	1332	1332
Total cold run time: 337275 ms
Total hot run time: 196166 ms

doris-robot · 2024-08-20T17:10:15Z

ClickBench: Total hot run time: 31.01 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8e5600b9ba34aafb3b987e481de2e62f07db4a49, data reload: false
query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.67	0.07	0.07
query5	0.52	0.50	0.48
query6	1.14	0.73	0.72
query7	0.02	0.02	0.01
query8	0.05	0.05	0.05
query9	0.57	0.48	0.49
query10	0.54	0.55	0.55
query11	0.16	0.13	0.13
query12	0.16	0.14	0.13
query13	0.62	0.59	0.60
query14	0.78	0.77	0.81
query15	0.85	0.82	0.83
query16	0.37	0.38	0.36
query17	1.02	1.01	1.00
query18	0.21	0.20	0.21
query19	1.82	1.77	1.68
query20	0.01	0.01	0.01
query21	15.39	0.66	0.65
query22	4.46	7.83	1.78
query23	18.29	1.42	1.39
query24	2.17	0.22	0.22
query25	0.16	0.09	0.08
query26	0.27	0.18	0.18
query27	0.09	0.08	0.09
query28	13.19	1.03	1.01
query29	12.67	3.36	3.34
query30	0.43	0.24	0.24
query31	2.80	0.40	0.40
query32	3.25	0.49	0.49
query33	2.95	2.98	2.97
query34	17.17	4.39	4.35
query35	4.46	4.42	4.42
query36	0.68	0.51	0.50
query37	0.22	0.17	0.18
query38	0.18	0.16	0.17
query39	0.06	0.06	0.06
query40	0.19	0.15	0.15
query41	0.12	0.07	0.06
query42	0.08	0.07	0.07
query43	0.07	0.06	0.06
Total cold run time: 110.21 s
Total hot run time: 31.01 s

xiaokang

LGTM

github-actions · 2024-08-22T11:15:35Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-08-22T11:15:38Z

PR approved by anyone and no changes requested.

airborne12

LGTM

…hen _normalize_predicate (apache#39650) use TypeDescriptor to prevent from info lost

#39650

…hen _normalize_predicate (#39650) use TypeDescriptor to prevent from info lost

…hen _normalize_predicate (apache#39650) use TypeDescriptor to prevent from info lost

eldenmoon changed the title ~~[Fix](Variant) casting to decimal type may lost precision and scale w…~~[Fix](Variant) casting to decimal type may lost precision and scale when _normalize_predicateAug 20, 2024

eldenmoon added dev/2.1.x dev/3.0.x doing labels Aug 20, 2024

eldenmoon force-pushed the fix-decimal-var branch from 059b7f9 to 3fa9946Compare August 20, 2024 13:41

[Fix](Variant) casting to decimal type may lost precision and scale w…
8e5600b
…hen _normalize_predicate use TypeDescriptor to prevent from info lost

eldenmoon force-pushed the fix-decimal-var branch from 3fa9946 to 8e5600bCompare August 20, 2024 13:42

xiaokang approved these changes Aug 22, 2024
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 22, 2024

github-actionsBot added the reviewed label Aug 22, 2024

airborne12 approved these changes Aug 23, 2024
View reviewed changes

eldenmoon merged commit 979d957 into apache:masterAug 23, 2024

eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Aug 23, 2024
[Fix](Variant) casting to decimal type may lost precision and scale w…
9f1b0fb
…hen _normalize_predicate (apache#39650) use TypeDescriptor to prevent from info lost

eldenmoon mentioned this pull request Aug 23, 2024
[pick](Variant) casting to decimal type may lost precision #39843
Merged

eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Aug 23, 2024
[Fix](Variant) casting to decimal type may lost precision and scale w…
81aa969
…hen _normalize_predicate (apache#39650) use TypeDescriptor to prevent from info lost

yiguolei pushed a commit that referenced this pull request Aug 23, 2024
[pick](Variant) casting to decimal type may lost precision (#39843)
3103bb0
#39650

yiguolei added dev/2.1.6-merged and removed dev/2.1.x labels Aug 23, 2024

dataroaring added dev/3.0.2-merged and removed dev/3.0.x labels Aug 26, 2024

dataroaring pushed a commit that referenced this pull request Aug 26, 2024
[Fix](Variant) casting to decimal type may lost precision and scale w…
3f2a514
…hen _normalize_predicate (#39650) use TypeDescriptor to prevent from info lost

xiaokang removed the doing label Sep 1, 2024

gavinchou mentioned this pull request Oct 13, 2024
Release Note 3.0.2 #41558
Closed

HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
[Fix](Variant) casting to decimal type may lost precision and scale w…
b03f4b5
…hen _normalize_predicate (apache#39650) use TypeDescriptor to prevent from info lost

Uh oh!

Conversation

eldenmoon commented Aug 20, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Uh oh!

doris-robot commented Aug 20, 2024

Uh oh!

eldenmoon commented Aug 20, 2024

Uh oh!

eldenmoon commented Aug 20, 2024

Uh oh!

eldenmoon commented Aug 20, 2024

Uh oh!

github-actionsBot commented Aug 20, 2024

Uh oh!

github-actionsBot commented Aug 20, 2024

Uh oh!

github-actionsBot commented Aug 20, 2024

Uh oh!

doris-robot commented Aug 20, 2024

Uh oh!

doris-robot commented Aug 20, 2024

Uh oh!

doris-robot commented Aug 20, 2024

Uh oh!

xiaokang left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Aug 22, 2024

Uh oh!

github-actionsBot commented Aug 22, 2024

Uh oh!

airborne12 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

eldenmoon commented Aug 20, 2024•
edited
Loading