Skip to content

[fix](fe) LIST partition table support modify default bucket num - #39688

Merged
morningman merged 1 commit into
apache:branch-2.1from
htyoung:branch-2.1-list-partition-table-buckets
Aug 23, 2024
Merged

[fix](fe) LIST partition table support modify default bucket num#39688
morningman merged 1 commit into
apache:branch-2.1from
htyoung:branch-2.1-list-partition-table-buckets

Conversation

@htyoung

@htyounghtyoung commented Aug 21, 2024

Copy link
Copy Markdown
Contributor

Proposed changes

bp #39696

Issue Number: close#39684

CREATETABLE `test1` (
`id1`VARCHAR(255) NULL COMMENT 'id1',
`id2`VARCHAR(255) NULL COMMENT 'id2',
`event_time`VARCHAR(255) NULL COMMENT '事件时间',
`event_date`VARCHAR(255) NULL COMMENT '事件日期',
`event_ts`VARCHAR(256) NULL COMMENT '事件发生时间戳(毫秒)',
`dt`VARCHAR(255) NOT NULL COMMENT '日期分区',
`hr`VARCHAR(255) NOT NULL COMMENT '小时分区'
) ENGINE = OLAP DUPLICATE KEY(`id1`) COMMENT 'xxx' PARTITION BY LIST(`dt`, `hr`) (
PARTITION p2024082021 VALUESIN (("2024-08-20", "21"))
) DISTRIBUTED BY HASH(`dt`, `hr`) BUCKETS 2 PROPERTIES (
"replication_allocation"="tag.location.default: 1",
"min_load_replica_num"="-1",
"is_being_synced"="false",
"storage_medium"="hdd",
"storage_format"="V2",
"inverted_index_storage_format"="V1",
"light_schema_change"="true",
"disable_auto_compaction"="false",
"enable_single_replica_compaction"="false",
"group_commit_interval_ms"="10000",
"group_commit_data_bytes"="134217728"
);
  1. 修改前表已有分区的bucket num为2
    image

  2. 修改List分区表bucket num(从2 -> 4)
    image

  3. 修改List分区后,添加的新分区bucket num为4
    image

@doris-robot

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@htyounghtyoung changed the title [feature](fe) LIST partition table support modify default bucket num[Fix](fe) LIST partition table support modify default bucket numAug 21, 2024

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please add unit test

@htyoung
htyoungforce-pushed the branch-2.1-list-partition-table-buckets branch 2 times, most recently from cab8895 to eea37a3CompareAugust 21, 2024 10:05
@htyounghtyoung changed the title [Fix](fe) LIST partition table support modify default bucket num[fix](fe) LIST partition table support modify default bucket numAug 21, 2024

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman

Copy link
Copy Markdown
Contributor

run buildall

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Aug 21, 2024
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please insert values to table and alter bucket and check values.

@dataroaring

Copy link
Copy Markdown
Contributor

Why is the pr not go to master?

@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Aug 21, 2024
@htyoung

Copy link
Copy Markdown
ContributorAuthor

Why is the pr not go to master?

master branch has another same pr #39696

@htyoung
htyoungforce-pushed the branch-2.1-list-partition-table-buckets branch from eea37a3 to 02c25cbCompareAugust 22, 2024 03:44
@htyoung

Copy link
Copy Markdown
ContributorAuthor

Please insert values to table and alter bucket and check values.

I have updated the regression-test suit

@morningman
morningmanforce-pushed the branch-2.1-list-partition-table-buckets branch from 02c25cb to ae00755CompareAugust 22, 2024 14:22
@morningman

Copy link
Copy Markdown
Contributor

run buildall

@morningman
morningman merged commit 6c10c47 into apache:branch-2.1Aug 23, 2024
@yiguoleiyiguolei mentioned this pull request Sep 5, 2024
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@htyoung@doris-robot@morningman@dataroaring