Uh oh!
There was an error while loading. Please reload this page.
[pick][Improment]Add schema table workload_group_privileges (#38436) - #39708
Merged
Conversation
doris-robot
commented
Aug 21, 2024
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
wangbo
commented
Aug 21, 2024
ContributorAuthor
run buildall |
| {"IS_GRANTABLE", TYPE_VARCHAR, sizeof(StringRef), true}, | ||
| }; | ||
| SchemaWorkloadGroupPrivilegesScanner::SchemaWorkloadGroupPrivilegesScanner() |
Contributor
There was a problem hiding this comment.
warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
be/src/exec/schema_scanner/schema_workload_group_privileges.cpp:36:
- : SchemaScanner(_s_tbls_columns, TSchemaTableType::SCH_WORKLOAD_GROUPS) {}+ : SchemaScanner(_s_tbls_columns, TSchemaTableType::SCH_WORKLOAD_GROUPS) = default;| SchemaWorkloadGroupPrivilegesScanner::SchemaWorkloadGroupPrivilegesScanner() | ||
| : SchemaScanner(_s_tbls_columns, TSchemaTableType::SCH_WORKLOAD_GROUPS) {} | ||
| SchemaWorkloadGroupPrivilegesScanner::~SchemaWorkloadGroupPrivilegesScanner() {} |
Contributor
There was a problem hiding this comment.
warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
Suggested change
| SchemaWorkloadGroupPrivilegesScanner::~SchemaWorkloadGroupPrivilegesScanner() {} | |
| SchemaWorkloadGroupPrivilegesScanner::~SchemaWorkloadGroupPrivilegesScanner() = default; |
Add schema table workload_group_privileges. ``` mysql [information_schema]>desc workload_group_privileges; +---------------------+--------------+------+-------+---------+-------+ | Field | Type | Null | Key | Default | Extra | +---------------------+--------------+------+-------+---------+-------+ | GRANTEE | varchar(64) | Yes | false | NULL | | | WORKLOAD_GROUP_NAME | varchar(256) | Yes | false | NULL | | | PRIVILEGE_TYPE | varchar(64) | Yes | false | NULL | | | IS_GRANTABLE | varchar(3) | Yes | false | NULL | | +---------------------+--------------+------+-------+---------+-------+ 4 rows in set (0.01 sec) ```
wangboforce-pushed
the
0821_pick_auth_sys_table
branch
from
August 21, 2024 11:53
09932c6 to
b84c1bcComparewangbo
commented
Aug 21, 2024
ContributorAuthor
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pick #38436