Skip to content

[fix](auth)Fix ordinary users can see the processes of other users - #39747

Merged
morrySnow merged 4 commits into
apache:masterfrom
zddr:fix_user_show_process
Aug 29, 2024
Merged

[fix](auth)Fix ordinary users can see the processes of other users#39747
morrySnow merged 4 commits into
apache:masterfrom
zddr:fix_user_show_process

Conversation

@zddr

@zddrzddr commented Aug 22, 2024

Copy link
Copy Markdown
Contributor

Fix when set show_all_fe_connection="true"; At this time, ordinary users can see the processes of other users,

@doris-robot

doris-robot commented Aug 22, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zddr

zddr commented Aug 22, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Aug 22, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Aug 22, 2024

Copy link
Copy Markdown
TPC-H: Total hot run time: 38650 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1061e9e788b19b7cde34bd6f9550f63ab154c726, data reload: false
------ Round 1 ----------------------------------
q1	18378	4803	4330	4330
q2	2066	214	207	207
q3	11621	1004	1249	1004
q4	10317	707	826	707
q5	7769	2887	2846	2846
q6	269	162	162	162
q7	1033	665	664	664
q8	9417	2149	2118	2118
q9	7294	6596	6589	6589
q10	7044	2227	2259	2227
q11	493	276	283	276
q12	425	257	255	255
q13	17769	3072	3110	3072
q14	304	262	252	252
q15	546	510	541	510
q16	538	418	411	411
q17	1006	720	747	720
q18	7604	7018	6865	6865
q19	1451	1090	1075	1075
q20	715	342	349	342
q21	4064	3083	2979	2979
q22	1161	1071	1039	1039
Total cold run time: 111284 ms
Total hot run time: 38650 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4364	4305	4308	4305
q2	412	309	296	296
q3	2925	2655	2714	2655
q4	2022	1678	1741	1678
q5	5674	5771	5690	5690
q6	240	160	153	153
q7	2312	1898	1898	1898
q8	3364	3456	3485	3456
q9	8833	8816	8831	8816
q10	3594	3378	3401	3378
q11	665	542	546	542
q12	877	682	724	682
q13	15700	3240	3309	3240
q14	364	310	312	310
q15	553	533	540	533
q16	523	458	460	458
q17	1851	1576	1564	1564
q18	8208	7807	7807	7807
q19	1759	1629	1326	1326
q20	2150	1928	1886	1886
q21	5795	5531	5671	5531
q22	1221	1157	1117	1117
Total cold run time: 73406 ms
Total hot run time: 57321 ms

@doris-robot

doris-robot commented Aug 22, 2024

Copy link
Copy Markdown
TPC-DS: Total hot run time: 197938 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1061e9e788b19b7cde34bd6f9550f63ab154c726, data reload: false
query1	1337	894	887	887
query2	6450	2093	2018	2018
query3	10797	4104	4035	4035
query4	60337	26944	23252	23252
query5	5576	661	655	655
query6	441	190	203	190
query7	5804	333	329	329
query8	524	439	441	439
query9	8981	2573	2552	2552
query10	554	349	334	334
query11	16697	15091	15681	15091
query12	208	143	141	141
query13	1603	449	440	440
query14	11142	7540	7440	7440
query15	255	200	193	193
query16	7537	473	519	473
query17	1179	613	612	612
query18	2028	360	352	352
query19	332	177	173	173
query20	147	142	149	142
query21	246	143	142	142
query22	4734	4577	4270	4270
query23	34540	34070	33884	33884
query24	6108	2961	2989	2961
query25	573	427	422	422
query26	712	186	200	186
query27	1738	302	314	302
query28	3861	2161	2163	2161
query29	741	471	463	463
query30	246	193	191	191
query31	1050	901	883	883
query32	102	79	88	79
query33	520	350	384	350
query34	953	529	523	523
query35	866	809	770	770
query36	1080	956	972	956
query37	160	107	107	107
query38	4012	3967	3968	3967
query39	1500	1476	1476	1476
query40	234	153	155	153
query41	140	136	137	136
query42	137	117	118	117
query43	558	510	499	499
query44	1143	793	810	793
query45	226	197	195	195
query46	1124	788	774	774
query47	1948	1908	1887	1887
query48	406	352	341	341
query49	926	585	602	585
query50	871	463	477	463
query51	7285	7042	7098	7042
query52	114	107	105	105
query53	305	234	223	223
query54	615	520	510	510
query55	90	89	93	89
query56	333	316	323	316
query57	1274	1142	1140	1140
query58	295	295	327	295
query59	3164	2988	3175	2988
query60	375	325	334	325
query61	151	146	150	146
query62	805	679	719	679
query63	263	232	225	225
query64	3375	1932	1849	1849
query65	3243	3199	3187	3187
query66	1023	682	667	667
query67	15683	15070	15300	15070
query68	4339	612	607	607
query69	472	332	314	314
query70	1211	1199	1121	1121
query71	442	323	321	321
query72	6430	2356	2156	2156
query73	807	360	358	358
query74	9226	8886	8955	8886
query75	3428	2742	2752	2742
query76	1677	1017	1007	1007
query77	661	446	445	445
query78	9947	9221	9092	9092
query79	1111	577	556	556
query80	1017	611	603	603
query81	555	257	267	257
query82	1430	160	159	159
query83	264	214	210	210
query84	293	97	97	97
query85	857	356	407	356
query86	351	302	331	302
query87	4408	4320	4433	4320
query88	3192	2556	2534	2534
query89	436	326	337	326
query90	1950	335	253	253
query91	151	126	126	126
query92	87	77	74	74
query93	1648	556	554	554
query94	759	327	327	327
query95	378	300	302	300
query96	604	290	280	280
query97	3212	3115	3094	3094
query98	251	229	223	223
query99	1680	1298	1333	1298
Total cold run time: 315051 ms
Total hot run time: 197938 ms

@doris-robot

doris-robot commented Aug 22, 2024

Copy link
Copy Markdown
ClickBench: Total hot run time: 31.06 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1061e9e788b19b7cde34bd6f9550f63ab154c726, data reload: false
query1	0.05	0.04	0.04
query2	0.09	0.03	0.04
query3	0.22	0.06	0.06
query4	1.65	0.07	0.07
query5	0.50	0.49	0.49
query6	1.13	0.73	0.74
query7	0.02	0.02	0.01
query8	0.06	0.05	0.05
query9	0.56	0.49	0.48
query10	0.55	0.57	0.58
query11	0.16	0.12	0.12
query12	0.16	0.14	0.12
query13	0.62	0.63	0.60
query14	0.80	0.79	0.80
query15	0.84	0.82	0.83
query16	0.39	0.38	0.39
query17	0.98	1.02	0.98
query18	0.22	0.20	0.21
query19	1.98	1.86	1.82
query20	0.01	0.01	0.01
query21	15.41	0.68	0.65
query22	4.20	6.85	1.67
query23	18.30	1.34	1.26
query24	2.13	0.24	0.23
query25	0.15	0.08	0.08
query26	0.27	0.19	0.18
query27	0.08	0.08	0.09
query28	13.24	1.04	1.01
query29	12.64	3.36	3.35
query30	0.44	0.24	0.25
query31	2.81	0.43	0.39
query32	3.24	0.49	0.50
query33	2.97	2.98	3.03
query34	17.02	4.38	4.49
query35	4.51	4.47	4.54
query36	0.68	0.48	0.51
query37	0.21	0.18	0.17
query38	0.17	0.17	0.18
query39	0.07	0.05	0.06
query40	0.18	0.16	0.15
query41	0.12	0.07	0.07
query42	0.08	0.08	0.07
query43	0.08	0.07	0.07
Total cold run time: 109.99 s
Total hot run time: 31.06 s

@zddr

zddr commented Aug 23, 2024

Copy link
Copy Markdown
ContributorAuthor

run feut

@morrySnowmorrySnow changed the title [fix](auth)Fix ordinary users can see the processes of other users,[fix](auth)Fix ordinary users can see the processes of other usersAug 29, 2024
@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 29, 2024
@github-actions

github-actionsBot commented Aug 29, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Aug 29, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@morrySnow
morrySnow merged commit 9cb7d83 into apache:masterAug 29, 2024
zddr added a commit to zddr/incubator-doris that referenced this pull request Sep 5, 2024
@zddr
[fix](auth) ordinary users can see the processes of other users (apac…
aeb7a2a
…he#39747)
Fix when set show_all_fe_connection="true";
At this time, ordinary users can see the processes of other users
@zddrzddr mentioned this pull request Sep 5, 2024
Merged
zddr added a commit to zddr/incubator-doris that referenced this pull request Sep 5, 2024
@zddr
[fix](auth) ordinary users can see the processes of other users (apac…
61cb82d
…he#39747)
Fix when set show_all_fe_connection="true";
At this time, ordinary users can see the processes of other users
@zddrzddr mentioned this pull request Sep 5, 2024
Merged
yiguolei pushed a commit that referenced this pull request Sep 9, 2024
@zddr
[fix](auth) ordinary users can see the processes of other users (#39747…
a3eba2a
…) (#40415)
pick: #39747
morrySnow pushed a commit that referenced this pull request Sep 9, 2024
@zddr
[fix](auth) ordinary users can see the processes of other users (#39747…
921901a
…) (#40417)
pick from master #39747
dataroaring pushed a commit that referenced this pull request Sep 26, 2024
@zddr@dataroaring
[fix](auth) ordinary users can see the processes of other users (#39747)
19ee6c0
Fix when set show_all_fe_connection="true"; At this time, ordinary users can see the processes of other users
@gavinchougavinchou mentioned this pull request Oct 13, 2024
Closed
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@zddr@HappenLee
[fix](auth) ordinary users can see the processes of other users (apac…
e10254b
…he#39747)
Fix when set show_all_fe_connection="true"; At this time, ordinary users can see the processes of other users
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CalvinKirsCalvinKirsCalvinKirs approved these changes
@morrySnowmorrySnowmorrySnow approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.15-mergeddev/2.1.7-mergeddev/3.0.2-mergedp0_breviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zddr@doris-robot@CalvinKirs@morrySnow@yiguolei@dataroaring