[opt](function)Some geo functions incorrectly used get. by Mryange · Pull Request #40107 · apache/doris

Mryange · 2024-08-29T07:29:23Z

Proposed changes


mysql [test]>select count(st_distance_sphere(db, db, db, db)) from double_ranges;
+-------------------------------------------+
| count(st_distance_sphere(db, db, db, db)) |
+-------------------------------------------+
| 0 |
+-------------------------------------------+
1 row in set (1.25 sec)
mysql [test]>select count(st_distance_sphere(db, db, db, db)) from double_ranges;
+-------------------------------------------+
| count(st_distance_sphere(db, db, db, db)) |
+-------------------------------------------+
| 0 |
+-------------------------------------------+
1 row in set (0.33 sec)

doris-robot · 2024-08-29T07:29:28Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

Mryange · 2024-08-29T07:31:41Z

run buildall

github-actions · 2024-08-29T07:36:19Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-08-29T08:06:52Z

TPC-H: Total hot run time: 38078 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7db6ffa43d6d48df6aab483cd98c62e1cc34455b, data reload: false
------ Round 1 ----------------------------------
q1	18144	5349	4325	4325
q2	2020	192	176	176
q3	11715	924	1030	924
q4	10509	790	733	733
q5	7765	2819	2800	2800
q6	230	142	136	136
q7	965	614	602	602
q8	10328	2055	2099	2055
q9	7042	6664	6619	6619
q10	7057	2325	2272	2272
q11	463	249	242	242
q12	402	227	231	227
q13	18181	3024	3051	3024
q14	286	239	246	239
q15	534	502	520	502
q16	1090	526	528	526
q17	1118	666	749	666
q18	8862	6854	6860	6854
q19	1383	1062	1095	1062
q20	659	340	333	333
q21	3905	2774	3042	2774
q22	1097	1033	987	987
Total cold run time: 113755 ms
Total hot run time: 38078 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4389	4272	4220	4220
q2	387	273	278	273
q3	2843	2672	2680	2672
q4	1912	1774	1760	1760
q5	5687	5760	5670	5670
q6	241	137	137	137
q7	2202	1831	1753	1753
q8	3292	3496	3452	3452
q9	8788	8779	8768	8768
q10	3607	3365	3290	3290
q11	598	523	502	502
q12	844	654	683	654
q13	15834	3230	3221	3221
q14	320	302	297	297
q15	553	504	483	483
q16	639	588	592	588
q17	1843	1562	1543	1543
q18	8082	7851	7914	7851
q19	1734	1671	1624	1624
q20	2131	1937	1899	1899
q21	5882	5351	5510	5351
q22	1080	1020	1008	1008
Total cold run time: 72888 ms
Total hot run time: 57016 ms

doris-robot · 2024-08-29T08:19:02Z

TPC-DS: Total hot run time: 192621 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7db6ffa43d6d48df6aab483cd98c62e1cc34455b, data reload: false
query1	1260	894	855	855
query2	6346	1986	1877	1877
query3	10608	3955	3824	3824
query4	58601	25985	23284	23284
query5	5467	516	501	501
query6	405	165	158	158
query7	5744	304	302	302
query8	323	221	217	217
query9	8828	2503	2472	2472
query10	500	282	278	278
query11	15969	14992	15111	14992
query12	155	105	107	105
query13	1526	389	375	375
query14	10825	7349	7672	7349
query15	226	178	184	178
query16	7157	481	526	481
query17	1125	567	563	563
query18	1439	308	312	308
query19	272	156	146	146
query20	119	117	113	113
query21	208	112	106	106
query22	4583	4319	4446	4319
query23	34465	33934	33346	33346
query24	6032	2861	2826	2826
query25	542	399	406	399
query26	656	161	167	161
query27	1717	279	287	279
query28	3651	2135	2117	2117
query29	663	432	428	428
query30	237	157	160	157
query31	956	768	795	768
query32	86	55	64	55
query33	481	296	290	290
query34	845	498	479	479
query35	844	737	712	712
query36	1032	909	928	909
query37	156	94	90	90
query38	3984	3846	3859	3846
query39	1438	1419	1388	1388
query40	199	120	125	120
query41	49	48	48	48
query42	122	101	100	100
query43	511	479	457	457
query44	1080	760	748	748
query45	202	168	172	168
query46	1095	784	754	754
query47	1880	1793	1836	1793
query48	377	310	306	306
query49	771	448	441	441
query50	818	409	422	409
query51	7227	6980	7046	6980
query52	103	89	90	89
query53	258	180	188	180
query54	568	479	465	465
query55	83	78	81	78
query56	291	276	276	276
query57	1192	1086	1044	1044
query58	232	230	229	229
query59	2933	2861	2782	2782
query60	306	348	266	266
query61	103	99	98	98
query62	725	650	653	650
query63	208	186	184	184
query64	2375	673	702	673
query65	3213	3145	3160	3145
query66	680	330	337	330
query67	15356	15206	15430	15206
query68	3888	580	581	580
query69	415	288	285	285
query70	1189	1024	1083	1024
query71	340	272	273	272
query72	6417	4053	3960	3960
query73	746	330	334	330
query74	9380	8796	8833	8796
query75	3373	2645	2719	2645
query76	1921	1042	985	985
query77	577	322	369	322
query78	9774	9089	9162	9089
query79	1064	537	534	534
query80	739	522	507	507
query81	540	233	236	233
query82	246	152	149	149
query83	181	149	151	149
query84	261	74	75	74
query85	789	288	282	282
query86	322	293	294	293
query87	4415	4277	4190	4190
query88	3491	2340	2336	2336
query89	391	333	294	294
query90	1885	188	191	188
query91	120	101	99	99
query92	60	52	52	52
query93	1077	544	546	544
query94	729	297	300	297
query95	353	263	257	257
query96	583	269	264	264
query97	3167	3051	3126	3051
query98	215	214	209	209
query99	1505	1305	1259	1259
Total cold run time: 302581 ms
Total hot run time: 192621 ms

doris-robot · 2024-08-29T08:24:39Z

ClickBench: Total hot run time: 31.64 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7db6ffa43d6d48df6aab483cd98c62e1cc34455b, data reload: false
query1	0.05	0.04	0.03
query2	0.07	0.04	0.04
query3	0.22	0.05	0.05
query4	1.67	0.07	0.07
query5	0.51	0.49	0.48
query6	1.14	0.74	0.73
query7	0.02	0.02	0.01
query8	0.06	0.04	0.05
query9	0.55	0.49	0.49
query10	0.55	0.54	0.54
query11	0.14	0.12	0.11
query12	0.14	0.12	0.12
query13	0.60	0.60	0.59
query14	2.10	2.09	2.06
query15	0.84	0.83	0.82
query16	0.37	0.38	0.36
query17	1.05	1.05	1.07
query18	0.22	0.21	0.21
query19	1.85	1.70	1.79
query20	0.01	0.01	0.01
query21	15.41	0.66	0.64
query22	3.76	8.26	1.72
query23	18.32	1.36	1.25
query24	2.09	0.21	0.24
query25	0.16	0.08	0.08
query26	0.26	0.18	0.17
query27	0.08	0.07	0.08
query28	13.27	1.02	1.00
query29	12.64	3.33	3.23
query30	0.23	0.06	0.07
query31	2.86	0.40	0.40
query32	3.26	0.50	0.48
query33	2.94	3.02	2.98
query34	16.87	4.46	4.40
query35	4.44	4.38	4.47
query36	0.66	0.47	0.47
query37	0.19	0.16	0.17
query38	0.16	0.15	0.16
query39	0.04	0.03	0.04
query40	0.16	0.12	0.13
query41	0.09	0.05	0.05
query42	0.06	0.05	0.04
query43	0.05	0.04	0.04
Total cold run time: 110.16 s
Total hot run time: 31.64 s

HappenLee

LGTM

github-actions · 2024-08-31T07:01:03Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-08-31T07:01:05Z

PR approved by anyone and no changes requested.

Mryange · 2024-09-03T03:58:49Z

run buildall

doris-robot · 2024-09-03T04:36:40Z

TPC-H: Total hot run time: 38703 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7db6ffa43d6d48df6aab483cd98c62e1cc34455b, data reload: false
------ Round 1 ----------------------------------
q1	18074	4615	4422	4422
q2	2021	185	178	178
q3	11860	1052	1153	1052
q4	10513	718	674	674
q5	7754	2866	2808	2808
q6	228	145	135	135
q7	949	608	614	608
q8	9508	2132	2105	2105
q9	7178	6592	6657	6592
q10	7106	2255	2294	2255
q11	463	257	244	244
q12	403	232	232	232
q13	18129	3322	3277	3277
q14	288	266	268	266
q15	545	507	518	507
q16	633	529	555	529
q17	998	748	789	748
q18	7746	6908	6947	6908
q19	1490	1033	1090	1033
q20	675	322	342	322
q21	4271	2794	3144	2794
q22	1148	1014	1026	1014
Total cold run time: 111980 ms
Total hot run time: 38703 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4405	4347	4338	4338
q2	373	272	276	272
q3	2932	2625	2630	2625
q4	1883	1686	1682	1682
q5	5750	5656	5735	5656
q6	222	133	131	131
q7	2202	1833	1820	1820
q8	3268	3462	3462	3462
q9	8823	8805	8796	8796
q10	3665	3381	3286	3286
q11	597	513	506	506
q12	839	665	705	665
q13	15966	3336	3286	3286
q14	327	278	285	278
q15	536	478	510	478
q16	668	606	601	601
q17	1844	1567	1504	1504
q18	8163	7834	7854	7834
q19	1716	1656	1616	1616
q20	2196	1910	1913	1910
q21	5721	5449	5421	5421
q22	1125	1088	1096	1088
Total cold run time: 73221 ms
Total hot run time: 57255 ms

doris-robot · 2024-09-03T04:48:57Z

TPC-DS: Total hot run time: 193068 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7db6ffa43d6d48df6aab483cd98c62e1cc34455b, data reload: false
query1	1285	896	874	874
query2	6436	1979	1940	1940
query3	10577	4165	3996	3996
query4	59678	23879	23198	23198
query5	5432	504	486	486
query6	401	163	154	154
query7	5777	286	282	282
query8	280	206	206	206
query9	8878	2455	2447	2447
query10	467	263	250	250
query11	18038	15022	15287	15022
query12	150	109	100	100
query13	1556	382	375	375
query14	11113	7780	7240	7240
query15	250	175	193	175
query16	7599	463	477	463
query17	1191	589	576	576
query18	1984	292	297	292
query19	302	205	180	180
query20	127	118	112	112
query21	208	110	109	109
query22	4648	4431	4634	4431
query23	34350	33673	33671	33671
query24	5939	2914	2829	2829
query25	539	381	391	381
query26	687	156	162	156
query27	1802	280	277	277
query28	3692	2026	2010	2010
query29	683	402	393	393
query30	238	151	156	151
query31	939	763	762	762
query32	87	52	57	52
query33	466	288	283	283
query34	854	475	490	475
query35	801	715	711	711
query36	1043	920	908	908
query37	156	90	89	89
query38	3999	3925	3952	3925
query39	1471	1390	1368	1368
query40	198	113	113	113
query41	47	47	44	44
query42	115	98	95	95
query43	511	467	465	465
query44	1067	719	733	719
query45	194	168	172	168
query46	1081	736	738	736
query47	1917	1799	1821	1799
query48	364	289	283	283
query49	747	419	439	419
query50	799	422	420	420
query51	7079	6765	6941	6765
query52	95	86	89	86
query53	251	176	174	174
query54	601	477	460	460
query55	75	73	79	73
query56	286	259	271	259
query57	1232	1097	1049	1049
query58	227	228	233	228
query59	3064	3032	2884	2884
query60	318	276	316	276
query61	128	120	117	117
query62	767	636	634	634
query63	210	182	189	182
query64	2957	751	725	725
query65	3212	3129	3164	3129
query66	628	345	346	345
query67	15592	15218	15307	15218
query68	3051	577	573	573
query69	401	297	283	283
query70	1185	1067	1116	1067
query71	346	287	280	280
query72	6196	4165	4151	4151
query73	771	330	331	330
query74	9096	8792	8834	8792
query75	3356	2657	2688	2657
query76	1443	1018	1046	1018
query77	554	323	326	323
query78	10657	9293	9168	9168
query79	1889	531	672	531
query80	1110	497	500	497
query81	532	232	237	232
query82	1055	148	146	146
query83	227	149	145	145
query84	259	75	73	73
query85	751	290	286	286
query86	367	286	292	286
query87	4467	4232	4380	4232
query88	3128	2323	2321	2321
query89	396	291	282	282
query90	1874	187	185	185
query91	122	96	101	96
query92	63	48	50	48
query93	1613	518	519	518
query94	777	294	287	287
query95	382	247	252	247
query96	601	263	267	263
query97	3182	3128	3095	3095
query98	219	199	206	199
query99	1738	1260	1243	1243
Total cold run time: 309693 ms
Total hot run time: 193068 ms

doris-robot · 2024-09-03T04:54:35Z

ClickBench: Total hot run time: 32.54 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7db6ffa43d6d48df6aab483cd98c62e1cc34455b, data reload: false
query1	0.05	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.04	0.05
query4	1.67	0.08	0.07
query5	0.50	0.49	0.51
query6	1.14	0.73	0.73
query7	0.01	0.01	0.01
query8	0.05	0.05	0.04
query9	0.55	0.49	0.49
query10	0.55	0.54	0.56
query11	0.16	0.11	0.12
query12	0.15	0.12	0.13
query13	0.62	0.59	0.59
query14	2.02	2.06	2.11
query15	0.84	0.82	0.81
query16	0.38	0.39	0.38
query17	1.06	1.05	0.99
query18	0.20	0.20	0.20
query19	1.92	1.81	1.78
query20	0.01	0.01	0.01
query21	15.40	0.66	0.66
query22	4.56	7.15	2.28
query23	18.28	1.37	1.33
query24	2.16	0.22	0.23
query25	0.15	0.08	0.08
query26	0.28	0.18	0.18
query27	0.07	0.08	0.08
query28	13.20	1.02	1.01
query29	12.63	3.35	3.34
query30	0.24	0.06	0.05
query31	2.87	0.41	0.42
query32	3.23	0.48	0.48
query33	2.99	3.00	3.07
query34	17.15	4.38	4.44
query35	4.46	4.50	4.43
query36	0.66	0.46	0.49
query37	0.20	0.16	0.16
query38	0.15	0.15	0.16
query39	0.05	0.04	0.04
query40	0.16	0.13	0.13
query41	0.09	0.05	0.04
query42	0.06	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 111.27 s
Total hot run time: 32.54 s

Mryange · 2024-09-03T11:30:03Z

run buildall

doris-robot · 2024-09-03T12:04:06Z

TeamCity be ut coverage result:
Function Coverage: 36.84% (9388/25485)
Line Coverage: 28.29% (77483/273895)
Region Coverage: 27.68% (39980/144412)
Branch Coverage: 24.33% (20346/83624)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7db6ffa43d6d48df6aab483cd98c62e1cc34455b_7db6ffa43d6d48df6aab483cd98c62e1cc34455b/report/index.html

doris-robot · 2024-09-03T12:16:41Z

TPC-H: Total hot run time: 37937 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7db6ffa43d6d48df6aab483cd98c62e1cc34455b, data reload: false
------ Round 1 ----------------------------------
q1	17665	4409	4308	4308
q2	2022	181	176	176
q3	11729	980	1102	980
q4	10522	765	697	697
q5	7768	2861	2722	2722
q6	226	138	136	136
q7	960	609	617	609
q8	9314	2047	2057	2047
q9	7109	6555	6582	6555
q10	6992	2192	2202	2192
q11	456	244	240	240
q12	396	221	227	221
q13	18868	3060	3066	3060
q14	278	232	243	232
q15	526	501	483	483
q16	588	521	507	507
q17	978	614	652	614
q18	7219	6788	6912	6788
q19	1428	1067	1093	1067
q20	709	336	332	332
q21	3937	2966	3014	2966
q22	1099	1005	1007	1005
Total cold run time: 110789 ms
Total hot run time: 37937 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4382	4368	4263	4263
q2	376	274	274	274
q3	2887	2638	2694	2638
q4	1919	1627	1647	1627
q5	5636	5679	5698	5679
q6	236	138	137	137
q7	2219	1794	1847	1794
q8	3318	3382	3452	3382
q9	8793	8830	8803	8803
q10	3551	3379	3379	3379
q11	597	499	513	499
q12	821	678	645	645
q13	15869	3200	3313	3200
q14	322	300	284	284
q15	522	483	496	483
q16	641	559	576	559
q17	1835	1520	1542	1520
q18	8115	8010	8018	8010
q19	1710	1563	1545	1545
q20	2182	1914	1939	1914
q21	5662	5516	5286	5286
q22	1125	1012	1100	1012
Total cold run time: 72718 ms
Total hot run time: 56933 ms

doris-robot · 2024-09-03T12:28:47Z

TPC-DS: Total hot run time: 192161 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7db6ffa43d6d48df6aab483cd98c62e1cc34455b, data reload: false
query1	1247	869	861	861
query2	6317	1936	1927	1927
query3	10614	3960	3880	3880
query4	59710	23881	23260	23260
query5	5517	490	495	490
query6	421	172	162	162
query7	5758	295	304	295
query8	281	228	206	206
query9	8845	2445	2429	2429
query10	471	285	268	268
query11	16016	15117	15134	15117
query12	163	102	104	102
query13	1599	399	370	370
query14	11047	6740	7031	6740
query15	261	186	179	179
query16	7521	486	495	486
query17	1147	596	570	570
query18	2040	329	295	295
query19	291	148	152	148
query20	121	111	111	111
query21	211	105	111	105
query22	4574	4330	4359	4330
query23	34270	33917	33494	33494
query24	5940	2896	2842	2842
query25	525	389	388	388
query26	688	154	150	150
query27	1788	276	274	274
query28	3869	2023	2021	2021
query29	694	424	431	424
query30	239	159	158	158
query31	964	732	795	732
query32	87	53	59	53
query33	499	304	297	297
query34	855	484	481	481
query35	851	728	737	728
query36	1056	932	937	932
query37	152	90	95	90
query38	3967	4003	3974	3974
query39	1431	1398	1402	1398
query40	196	112	111	111
query41	47	44	44	44
query42	119	94	92	92
query43	532	466	487	466
query44	1061	720	751	720
query45	201	163	162	162
query46	1089	738	728	728
query47	1921	1803	1820	1803
query48	370	303	314	303
query49	772	444	454	444
query50	818	419	420	419
query51	6999	6915	6894	6894
query52	99	82	85	82
query53	250	179	180	179
query54	563	456	445	445
query55	74	73	71	71
query56	288	254	251	251
query57	1264	1093	1069	1069
query58	216	227	239	227
query59	2942	2920	2751	2751
query60	294	265	265	265
query61	99	102	100	100
query62	742	641	656	641
query63	222	184	183	183
query64	2859	698	640	640
query65	3230	3169	3164	3164
query66	694	338	331	331
query67	15299	15217	15299	15217
query68	2983	565	575	565
query69	401	276	287	276
query70	1140	1129	1094	1094
query71	338	278	283	278
query72	4930	4081	3938	3938
query73	749	326	329	326
query74	9119	8884	8880	8880
query75	3367	2682	2679	2679
query76	1547	1036	939	939
query77	528	329	330	329
query78	9605	9724	9070	9070
query79	1039	535	518	518
query80	688	495	561	495
query81	461	237	239	237
query82	248	143	149	143
query83	169	151	146	146
query84	255	80	79	79
query85	683	290	277	277
query86	308	286	304	286
query87	4419	4313	4310	4310
query88	3169	2340	2319	2319
query89	377	281	283	281
query90	2048	194	191	191
query91	126	98	98	98
query92	56	49	48	48
query93	1033	526	518	518
query94	703	291	281	281
query95	307	253	253	253
query96	594	261	264	261
query97	3221	3051	3036	3036
query98	220	217	198	198
query99	1539	1339	1243	1243
Total cold run time: 301677 ms
Total hot run time: 192161 ms

doris-robot · 2024-09-03T12:34:26Z

ClickBench: Total hot run time: 32.38 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7db6ffa43d6d48df6aab483cd98c62e1cc34455b, data reload: false
query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.68	0.08	0.07
query5	0.53	0.50	0.51
query6	1.40	0.73	0.74
query7	0.02	0.01	0.02
query8	0.05	0.05	0.05
query9	0.56	0.49	0.48
query10	0.55	0.54	0.53
query11	0.16	0.11	0.11
query12	0.14	0.12	0.13
query13	0.60	0.59	0.59
query14	2.02	2.09	2.06
query15	0.90	0.82	0.85
query16	0.38	0.36	0.39
query17	1.06	1.01	0.99
query18	0.22	0.21	0.20
query19	1.84	1.81	1.77
query20	0.02	0.01	0.01
query21	15.39	0.66	0.66
query22	4.17	7.47	2.15
query23	18.30	1.44	1.30
query24	2.09	0.24	0.22
query25	0.15	0.08	0.08
query26	0.28	0.18	0.18
query27	0.09	0.08	0.07
query28	13.24	1.03	1.01
query29	12.63	3.41	3.37
query30	0.24	0.06	0.05
query31	2.87	0.39	0.40
query32	3.26	0.49	0.48
query33	2.96	2.98	3.00
query34	17.01	4.39	4.39
query35	4.43	4.46	4.46
query36	0.66	0.49	0.48
query37	0.19	0.15	0.16
query38	0.16	0.15	0.15
query39	0.05	0.04	0.04
query40	0.16	0.12	0.13
query41	0.10	0.04	0.05
query42	0.06	0.04	0.04
query43	0.04	0.05	0.04
Total cold run time: 111.01 s
Total hot run time: 32.38 s

## Proposed changes ``` mysql [test]>select count(st_distance_sphere(db, db, db, db)) from double_ranges; +-------------------------------------------+ | count(st_distance_sphere(db, db, db, db)) | +-------------------------------------------+ | 0 | +-------------------------------------------+ 1 row in set (1.25 sec) mysql [test]>select count(st_distance_sphere(db, db, db, db)) from double_ranges; +-------------------------------------------+ | count(st_distance_sphere(db, db, db, db)) | +-------------------------------------------+ | 0 | +-------------------------------------------+ 1 row in set (0.33 sec) ```

…Sphere (#45508) ### What problem does this PR solve? Issue Number: close #xxx Related PR: #40107 Problem Summary: In #40107 we introduced a wrong behaviour which would lead to BE crash because of dangling reference. now fix it. ### Release note fix BE crash of function StDistanceSphere and StAngleSphere ### Check List (For Author) - Test  - [x] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason  - Behavior changed: - [x] No. - [ ] Yes.  - Does this need documentation? - [x] No. - [ ] Yes.  ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label

…Sphere (apache#45508) ### What problem does this PR solve? Issue Number: close #xxx Related PR: apache#40107 Problem Summary: In apache#40107 we introduced a wrong behaviour which would lead to BE crash because of dangling reference. now fix it. ### Release note fix BE crash of function StDistanceSphere and StAngleSphere ### Check List (For Author) - Test  - [x] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason  - Behavior changed: - [x] No. - [ ] Yes.  - Does this need documentation? - [x] No. - [ ] Yes.  ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label

## Proposed changes ``` mysql [test]>select count(st_distance_sphere(db, db, db, db)) from double_ranges; +-------------------------------------------+ | count(st_distance_sphere(db, db, db, db)) | +-------------------------------------------+ | 0 | +-------------------------------------------+ 1 row in set (1.25 sec) mysql [test]>select count(st_distance_sphere(db, db, db, db)) from double_ranges; +-------------------------------------------+ | count(st_distance_sphere(db, db, db, db)) | +-------------------------------------------+ | 0 | +-------------------------------------------+ 1 row in set (0.33 sec) ```

…Sphere (apache#45508) ### What problem does this PR solve? Issue Number: close #xxx Related PR: apache#40107 Problem Summary: In apache#40107 we introduced a wrong behaviour which would lead to BE crash because of dangling reference. now fix it. ### Release note fix BE crash of function StDistanceSphere and StAngleSphere ### Check List (For Author) - Test  - [x] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason  - Behavior changed: - [x] No. - [ ] Yes.  - Does this need documentation? - [x] No. - [ ] Yes.  ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label

upd
7db6ffa

HappenLee approved these changes Aug 31, 2024
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 31, 2024

github-actionsBot added the reviewed label Aug 31, 2024

BiteTheDDDDt approved these changes Aug 31, 2024
View reviewed changes

zhangstar333 merged commit 9a92b4c into apache:masterSep 4, 2024

dataroaring added the dev/3.0.3-merged label Oct 12, 2024

zclllyybb mentioned this pull request Dec 17, 2024
[Fix](function) fix coredump of function StDistanceSphere and StAngleSphere #45508
Merged
16 tasks

Uh oh!

Conversation

Mryange commented Aug 29, 2024

Proposed changes

Uh oh!

doris-robot commented Aug 29, 2024

Uh oh!

Mryange commented Aug 29, 2024

Uh oh!

github-actionsBot commented Aug 29, 2024

Uh oh!

doris-robot commented Aug 29, 2024

Uh oh!

doris-robot commented Aug 29, 2024

Uh oh!

doris-robot commented Aug 29, 2024

Uh oh!

HappenLee left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Aug 31, 2024

Uh oh!

github-actionsBot commented Aug 31, 2024

Uh oh!

Mryange commented Sep 3, 2024

Uh oh!

doris-robot commented Sep 3, 2024

Uh oh!

doris-robot commented Sep 3, 2024

Uh oh!

doris-robot commented Sep 3, 2024

Uh oh!

Mryange commented Sep 3, 2024

Uh oh!

doris-robot commented Sep 3, 2024

Uh oh!

doris-robot commented Sep 3, 2024

Uh oh!

doris-robot commented Sep 3, 2024

Uh oh!

doris-robot commented Sep 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants