Skip to content

[chore](cloud) Improve cloud start stop script: wait for quit synchronously - #40218

Merged
dataroaring merged 1 commit into
apache:masterfrom
gavinchou:gavin-improve-cloud-start-stop-sh
Sep 3, 2024
Merged

[chore](cloud) Improve cloud start stop script: wait for quit synchronously#40218
dataroaring merged 1 commit into
apache:masterfrom
gavinchou:gavin-improve-cloud-start-stop-sh

Conversation

@gavinchou

Copy link
Copy Markdown
Contributor

No description provided.

@doris-robot

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@gavinchou

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

Copy link
Copy Markdown
Contributor

sh-checker report

To get the full details, please check in the job output.

shellcheck errors

'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In cloud/script/stop.sh line 36:
while [[ 1 ]]; do
^-- SC2161 (style): Instead of '[ 1 ]', use 'true'.
In cloud/script/stop.sh line 39:
msg=$(ps ${pid})
^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean: msg=$(ps "${pid}")
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
https://www.shellcheck.net/wiki/SC2161 -- Instead of '[ 1 ]', use 'true'.
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
shfmt errors
'shfmt ' found no issues.

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@gavinchou
gavinchouforce-pushed the gavin-improve-cloud-start-stop-sh branch from b491ad9 to 7bcfb5aCompareAugust 31, 2024 14:00
@gavinchou

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 3, 2024
@dataroaring
dataroaring merged commit da52648 into apache:masterSep 3, 2024
@gavinchougavinchou mentioned this pull request Oct 13, 2024
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.2-mergedreviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@gavinchou@doris-robot@bobhan1@dataroaring