Skip to content

Add thrift_client_retry_interval_ms config in be for thrift client to avoid avalanche disaster in fe thrift server - #4022

Merged
morningman merged 3 commits into
apache:masterfrom
caiconghui:rpc_sleep
Jul 8, 2020
Merged

Add thrift_client_retry_interval_ms config in be for thrift client to avoid avalanche disaster in fe thrift server#4022
morningman merged 3 commits into
apache:masterfrom
caiconghui:rpc_sleep

Conversation

@caiconghui

Copy link
Copy Markdown
Contributor

This PR is mainly to add thrift_client_retry_interval_ms config in be for thrift client to avoid avalanche disaster in fe thrift server and fix some typo and some rpc setting problems at the same time.

@caiconghui

Copy link
Copy Markdown
ContributorAuthor

for #4023

Comment threadbe/src/util/thrift_rpc_helper.cpp Outdated

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningmanmorningman added the approved Indicates a PR has been approved by one committer. label Jul 6, 2020
@morningman

Copy link
Copy Markdown
Contributor

UT failed on ThreadPoolManagerTest.java.
Can you pass it in your local env?

@caiconghui

caiconghui commented Jul 8, 2020

Copy link
Copy Markdown
ContributorAuthor

UT failed on ThreadPoolManagerTest.java.
Can you pass it in your local env?
@morningman
I test it with "mvn test -Dtest=ThreadPoolManagerTest", and it passed

@morningman
morningman merged commit 5a27981 into apache:masterJul 8, 2020
morningman pushed a commit to morningman/doris that referenced this pull request Jul 9, 2020
…client to avoid avalanche disaster in fe thrift server (apache#4022)
This PR is mainly to add `thrift_client_retry_interval_ms` config in be for thrift client
to avoid avalanche disaster in fe thrift server and fix some typo and some rpc
setting problems at the same time.
@caiconghui
caiconghui deleted the rpc_sleep branch July 30, 2020 02:21
csun5285 pushed a commit to csun5285/doris that referenced this pull request Sep 23, 2025
… and add UT for it (apache#4022)
for UT coverage:
amory/selectdb-core/be/src/olap/rowset/segment_v2/variant_column_reader.cpp
| 100.00% (21/21) | 96.66% (376/389) | 90.79% (286/315) | 81.00%
(162/200)
-- | -- | -- | -- | --
amory/selectdb-core/be/src/olap/rowset/segment_v2/variant_column_reader.h
| 100.00% (18/18) | 97.87% (46/47) | 96.67% (29/30) | 87.50% (7/8)
csun5285 pushed a commit to csun5285/doris that referenced this pull request Sep 23, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.kind/improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@caiconghui@morningman