Skip to content

[chore](cloud) Support starting both meta-service and recycler within single process - #40223

Merged
gavinchou merged 7 commits into
apache:masterfrom
gavinchou:gavin-support-ms-re-start
Sep 4, 2024
Merged

[chore](cloud) Support starting both meta-service and recycler within single process#40223
gavinchou merged 7 commits into
apache:masterfrom
gavinchou:gavin-support-ms-re-start

Conversation

@gavinchou

@gavinchougavinchou commented Aug 31, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

e.g. the following will start meta-service and recycler within single process.

./bin/start.sh --daemon

the log file will be meta_service.INFO*

and it is the same effect as ./bin/start.sh --meta-service --recycler --daemon

doc PR apache/doris-website#1073

@doris-robot

doris-robot commented Aug 31, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@gavinchou

gavinchou commented Aug 31, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Aug 31, 2024

Copy link
Copy Markdown
Contributor

sh-checker report

To get the full details, please check in the job output.

shellcheck errors
'shellcheck ' found no issues.
shfmt errors

'shfmt ' returned error 1 finding the following formatting issues:
----------
--- cloud/script/start.sh.orig
+++ cloud/script/start.sh
@@ -134,9 +134,9 @@
out_file=${DORIS_HOME}/log/${process}.out
if [[ "${RUN_DAEMON}" -eq 1 ]]; then
# append 10 blank lines to ensure the following tail -n10 works correctly
- printf "\n\n\n\n\n\n\n\n\n\n" >> "${out_file}"
- echo "$(date +'%F %T') try to start ${process}" >> "${out_file}"
- nohup "${bin}" "$@" >> "${out_file}" 2>&1 &
+ printf "\n\n\n\n\n\n\n\n\n\n" >>"${out_file}"
+ echo "$(date +'%F %T') try to start ${process}" >>"${out_file}"
+ nohup "${bin}" "$@" >>"${out_file}" 2>&1 &
echo "wait and check ${process} start successfully"
sleep 3
tail -n10 "${out_file}" | grep 'successfully started brpc'
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename

@github-actions

github-actionsBot commented Aug 31, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

gavinchou
gavinchou commented Aug 31, 2024
View reviewed changes
Comment threadcloud/script/start.sh Outdated
@gavinchou

gavinchou commented Aug 31, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Aug 31, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

airborne12
airborne12 previously approved these changes Sep 1, 2024
View reviewed changes

@airborne12airborne12 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented Sep 1, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 1, 2024
@github-actions

github-actionsBot commented Sep 1, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

liaoxin01
liaoxin01 previously approved these changes Sep 1, 2024
View reviewed changes

@liaoxin01liaoxin01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavinchou
gavinchou dismissed stale reviews from liaoxin01 and airborne12 via b30dc54September 2, 2024 13:58
@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Sep 2, 2024
@github-actions

github-actionsBot commented Sep 2, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@gavinchou

gavinchou commented Sep 2, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Sep 2, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@gavinchou
[chore](cloud) Support starting both meta-service and recycler within…
e1e081e
… single process
e.g.
```
./bin/start.sh --recycler --meta-service --daemon
```
the log file will be meta_service.INFO*
@gavinchou
Update cloud/script/start.sh
402ed72
@gavinchou
support start 2 roles by default
367fcdc
@gavinchou
format
67dbd59
@gavinchou
fix UT
02da207
@gavinchou
gavinchouforce-pushed the gavin-support-ms-re-start branch from 8b0a1cb to 02da207CompareSeptember 2, 2024 16:44
@gavinchou

gavinchou commented Sep 2, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Sep 2, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@gavinchou

gavinchou commented Sep 3, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

gavinchou
gavinchou commented Sep 3, 2024
View reviewed changes
Comment threadcloud/src/common/config.h Outdated
@gavinchou

gavinchou commented Sep 3, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Sep 3, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions

github-actionsBot commented Sep 3, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

dataroaring
dataroaring approved these changes Sep 3, 2024
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented Sep 3, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 3, 2024
@gavinchou
gavinchou merged commit d177d5b into apache:masterSep 4, 2024
gavinchou added a commit that referenced this pull request Sep 5, 2024
@gavinchou
[chore](cloud) Support starting both meta-service and recycler within…
eda09de
… single process (#40223)
e.g. the following will start meta-service and recycler within single
process.
```
./bin/start.sh --daemon
```
the log file will be meta_service.INFO*
and it is the same effect as `./bin/start.sh --meta-service --recycler
--daemon`
doc PR apache/doris-website#1073
@gavinchougavinchou mentioned this pull request Oct 13, 2024
Closed
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@gavinchou@HappenLee
[chore](cloud) Support starting both meta-service and recycler within…
aa893d4
… single process (apache#40223)
e.g. the following will start meta-service and recycler within single
process.
```
./bin/start.sh --daemon
```
the log file will be meta_service.INFO*
and it is the same effect as `./bin/start.sh --meta-service --recycler
--daemon`
doc PR apache/doris-website#1073
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bobhan1bobhan1bobhan1 approved these changes
@dataroaringdataroaringdataroaring approved these changes
@airborne12airborne12airborne12 left review comments
@liaoxin01liaoxin01liaoxin01 left review comments

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.2-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gavinchou@doris-robot@airborne12@liaoxin01@bobhan1@dataroaring