[feat](nereids)set actual row count in physical plan according to merged profile by englefly · Pull Request #40361 · apache/doris

englefly · 2024-09-04T06:28:57Z

Proposed changes

physical plan is already printed in profile.
however, it is hard to compare the estimated rows of sql operator and the actual rows.
In this pr, we get actual rows from merged profile, and set it to corresponding physical node in physical plan.
here is an example:
"PhysicalHashJoin[13890]@115 ( stats=17,964.27 actualRows=20499, type=INNER_JOIN, hashCondition=[(l_suppkey#19 = s_suppkey#33)]"
the estmated rows is 17,964, the actual rows is 20499
Issue Number: close #xxx

doris-robot · 2024-09-04T06:29:02Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

englefly · 2024-09-05T02:17:45Z

run buildall

doris-robot · 2024-09-05T02:53:09Z

TPC-H: Total hot run time: 37803 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 60722b10e22cab3b6f442622e8a2b87e43678cf2, data reload: false
------ Round 1 ----------------------------------
q1	17635	4333	4293	4293
q2	2020	181	182	181
q3	11873	960	1080	960
q4	10520	726	783	726
q5	7742	2817	2819	2817
q6	226	139	144	139
q7	948	614	605	605
q8	9451	2056	2072	2056
q9	6885	6516	6567	6516
q10	6991	2212	2254	2212
q11	447	237	233	233
q12	398	229	229	229
q13	17766	3104	3090	3090
q14	279	237	233	233
q15	544	493	499	493
q16	590	492	511	492
q17	976	703	617	617
q18	7190	6935	6750	6750
q19	1397	974	1000	974
q20	672	324	338	324
q21	3907	2840	3075	2840
q22	1137	1034	1023	1023
Total cold run time: 109594 ms
Total hot run time: 37803 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4338	4323	4259	4259
q2	382	288	284	284
q3	2910	2655	2653	2653
q4	1951	1613	1641	1613
q5	5580	5684	5676	5676
q6	239	142	135	135
q7	2291	1801	1862	1801
q8	3306	3436	3404	3404
q9	8900	8816	8766	8766
q10	3526	3377	3314	3314
q11	637	511	509	509
q12	820	670	687	670
q13	12896	3208	3296	3208
q14	313	303	285	285
q15	546	485	483	483
q16	643	585	576	576
q17	1834	1529	1502	1502
q18	8015	7942	7941	7941
q19	1738	1700	1630	1630
q20	2205	1893	1941	1893
q21	5792	5484	5467	5467
q22	1088	1043	1061	1043
Total cold run time: 69950 ms
Total hot run time: 57112 ms

doris-robot · 2024-09-05T03:05:21Z

TPC-DS: Total hot run time: 192644 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 60722b10e22cab3b6f442622e8a2b87e43678cf2, data reload: false
query1	1273	884	847	847
query2	6307	1939	1877	1877
query3	10613	3972	4032	3972
query4	59297	27167	23233	23233
query5	5380	503	488	488
query6	402	166	167	166
query7	5768	297	290	290
query8	277	199	201	199
query9	8954	2522	2493	2493
query10	477	269	259	259
query11	18012	15097	15694	15097
query12	157	98	99	98
query13	1559	410	402	402
query14	10985	7282	7105	7105
query15	241	178	178	178
query16	7466	469	472	469
query17	1116	586	589	586
query18	1926	288	284	284
query19	276	149	144	144
query20	119	112	105	105
query21	208	107	104	104
query22	4710	4564	4794	4564
query23	34076	33466	33593	33466
query24	5962	2897	2805	2805
query25	550	405	406	405
query26	676	155	154	154
query27	1756	274	274	274
query28	3817	2063	2052	2052
query29	695	424	435	424
query30	234	151	151	151
query31	943	776	775	775
query32	85	48	51	48
query33	429	281	281	281
query34	837	455	463	455
query35	808	711	711	711
query36	1046	912	936	912
query37	142	93	86	86
query38	4093	3815	3943	3815
query39	1435	1401	1369	1369
query40	201	115	110	110
query41	47	44	45	44
query42	110	98	95	95
query43	509	479	471	471
query44	1068	735	738	735
query45	190	162	165	162
query46	1083	737	767	737
query47	1960	1848	1818	1818
query48	381	300	295	295
query49	767	429	441	429
query50	811	421	421	421
query51	6995	6920	6853	6853
query52	98	84	86	84
query53	247	175	174	174
query54	555	478	465	465
query55	75	75	78	75
query56	268	254	248	248
query57	1210	1092	1102	1092
query58	216	224	222	222
query59	2934	2719	2771	2719
query60	288	261	264	261
query61	99	101	100	100
query62	732	642	661	642
query63	211	179	181	179
query64	2514	684	730	684
query65	3212	3131	3152	3131
query66	687	335	329	329
query67	15626	15330	15402	15330
query68	3004	585	591	585
query69	409	281	275	275
query70	1214	1154	1057	1057
query71	351	271	265	265
query72	5583	4291	4016	4016
query73	749	329	324	324
query74	9033	9070	8819	8819
query75	3358	2685	2668	2668
query76	1382	1007	957	957
query77	528	320	321	320
query78	9618	9436	9037	9037
query79	1036	531	521	521
query80	683	506	502	502
query81	537	240	236	236
query82	236	137	143	137
query83	171	149	147	147
query84	265	77	75	75
query85	728	284	278	278
query86	303	301	298	298
query87	4538	4267	4294	4267
query88	3107	2351	2345	2345
query89	383	282	280	280
query90	1742	180	182	180
query91	126	99	100	99
query92	59	49	49	49
query93	1073	528	529	528
query94	560	286	296	286
query95	329	245	240	240
query96	588	267	271	267
query97	3237	3091	3089	3089
query98	220	199	243	199
query99	1772	1271	1250	1250
Total cold run time: 303123 ms
Total hot run time: 192644 ms

doris-robot · 2024-09-05T03:10:55Z

ClickBench: Total hot run time: 31.98 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 60722b10e22cab3b6f442622e8a2b87e43678cf2, data reload: false
query1	0.04	0.05	0.04
query2	0.07	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.08	0.07
query5	0.50	0.51	0.50
query6	1.12	0.72	0.73
query7	0.02	0.01	0.01
query8	0.05	0.04	0.05
query9	0.56	0.48	0.50
query10	0.52	0.54	0.54
query11	0.14	0.12	0.11
query12	0.15	0.12	0.12
query13	0.60	0.59	0.60
query14	2.09	2.05	2.09
query15	0.89	0.82	0.83
query16	0.38	0.38	0.37
query17	1.01	0.98	1.00
query18	0.21	0.20	0.20
query19	1.80	1.74	1.78
query20	0.01	0.01	0.01
query21	15.39	0.65	0.65
query22	4.04	6.87	1.94
query23	18.24	1.43	1.26
query24	2.12	0.22	0.21
query25	0.15	0.08	0.07
query26	0.27	0.19	0.18
query27	0.08	0.07	0.08
query28	13.23	1.02	1.02
query29	12.60	3.37	3.34
query30	0.25	0.06	0.05
query31	2.86	0.40	0.39
query32	3.27	0.47	0.48
query33	2.95	2.99	3.03
query34	17.10	4.36	4.42
query35	4.49	4.43	4.43
query36	0.66	0.49	0.47
query37	0.19	0.16	0.15
query38	0.15	0.15	0.15
query39	0.05	0.03	0.03
query40	0.15	0.13	0.13
query41	0.09	0.05	0.05
query42	0.05	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 110.48 s
Total hot run time: 31.98 s

englefly · 2024-09-06T05:33:44Z

run buildall

doris-robot · 2024-09-06T05:52:16Z

TPC-H: Total hot run time: 38125 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6fce1d13c43051a70b3252fb266fad22b5d9543a, data reload: false
------ Round 1 ----------------------------------
q1	17916	4487	4415	4415
q2	2661	189	183	183
q3	11438	1171	1136	1136
q4	10756	752	666	666
q5	8093	2874	2863	2863
q6	228	140	139	139
q7	982	628	629	628
q8	9296	2049	2065	2049
q9	7194	6505	6511	6505
q10	6996	2195	2218	2195
q11	455	242	249	242
q12	402	224	224	224
q13	17758	3079	3074	3074
q14	269	235	245	235
q15	547	486	488	486
q16	518	424	434	424
q17	977	640	659	640
q18	7436	6770	6863	6770
q19	1386	997	970	970
q20	697	351	327	327
q21	4248	3001	2949	2949
q22	1111	1005	1040	1005
Total cold run time: 111364 ms
Total hot run time: 38125 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4315	4246	4233	4233
q2	378	270	267	267
q3	2879	2642	2677	2642
q4	1903	1645	1599	1599
q5	5388	5407	5419	5407
q6	216	129	130	129
q7	2060	1708	1711	1708
q8	3190	3342	3320	3320
q9	8466	8404	8463	8404
q10	3432	3176	3212	3176
q11	608	514	504	504
q12	773	586	601	586
q13	12100	3051	3085	3051
q14	313	284	279	279
q15	526	482	470	470
q16	517	500	458	458
q17	1790	1492	1501	1492
q18	7814	7569	7423	7423
q19	1668	1504	1540	1504
q20	2073	1825	1833	1825
q21	5354	5115	5142	5115
q22	1110	1040	1041	1040
Total cold run time: 66873 ms
Total hot run time: 54632 ms

doris-robot · 2024-09-06T06:03:58Z

TPC-DS: Total hot run time: 187087 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6fce1d13c43051a70b3252fb266fad22b5d9543a, data reload: false
query1	912	368	355	355
query2	6472	1965	1964	1964
query3	6653	203	226	203
query4	33856	23096	23025	23025
query5	4225	498	490	490
query6	257	158	152	152
query7	4582	283	286	283
query8	275	232	211	211
query9	8608	2456	2451	2451
query10	435	269	249	249
query11	17871	14896	14990	14896
query12	154	97	107	97
query13	1631	390	356	356
query14	9387	7105	7052	7052
query15	262	167	163	163
query16	8050	452	435	435
query17	1558	550	534	534
query18	2113	296	278	278
query19	195	145	147	145
query20	116	110	109	109
query21	212	103	102	102
query22	4320	4163	4163	4163
query23	33989	33389	33347	33347
query24	11231	2768	2828	2768
query25	628	377	406	377
query26	1154	150	148	148
query27	2491	270	275	270
query28	7459	2041	2005	2005
query29	812	400	399	399
query30	315	156	147	147
query31	984	771	774	771
query32	91	54	55	54
query33	749	285	276	276
query34	996	461	479	461
query35	831	718	713	713
query36	1082	937	954	937
query37	163	83	87	83
query38	4014	3962	3920	3920
query39	1431	1399	1390	1390
query40	196	113	111	111
query41	47	46	45	45
query42	114	101	95	95
query43	508	467	463	463
query44	1216	759	731	731
query45	193	164	166	164
query46	1101	744	768	744
query47	1925	1746	1797	1746
query48	360	288	292	288
query49	1086	432	441	432
query50	813	399	400	399
query51	7078	6954	6915	6915
query52	96	86	85	85
query53	248	181	176	176
query54	933	448	439	439
query55	75	75	73	73
query56	296	246	262	246
query57	1216	1035	1046	1035
query58	238	228	234	228
query59	2937	2856	2805	2805
query60	293	259	259	259
query61	102	100	98	98
query62	823	653	655	653
query63	224	185	183	183
query64	4253	758	649	649
query65	3190	3151	3149	3149
query66	1447	336	340	336
query67	15686	15236	15322	15236
query68	4038	550	544	544
query69	403	280	281	280
query70	1109	1006	1019	1006
query71	350	274	269	269
query72	6435	4186	4059	4059
query73	741	315	320	315
query74	9061	8779	8721	8721
query75	3352	2717	2667	2667
query76	2453	1049	953	953
query77	511	322	309	309
query78	9650	9208	9869	9208
query79	1099	533	531	531
query80	748	527	499	499
query81	500	232	229	229
query82	245	139	141	139
query83	180	156	154	154
query84	219	80	71	71
query85	839	292	277	277
query86	291	306	301	301
query87	4359	4332	4247	4247
query88	3178	2275	2275	2275
query89	389	296	282	282
query90	1920	190	191	190
query91	127	102	97	97
query92	67	47	46	46
query93	1045	542	532	532
query94	861	300	293	293
query95	351	243	251	243
query96	580	264	267	264
query97	3200	3086	3047	3047
query98	278	203	194	194
query99	1486	1310	1283	1283
Total cold run time: 287323 ms
Total hot run time: 187087 ms

doris-robot · 2024-09-06T06:09:27Z

ClickBench: Total hot run time: 31.9 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6fce1d13c43051a70b3252fb266fad22b5d9543a, data reload: false
query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.06	0.06
query4	1.67	0.09	0.08
query5	0.51	0.51	0.50
query6	1.14	0.73	0.72
query7	0.02	0.01	0.01
query8	0.05	0.05	0.04
query9	0.54	0.50	0.50
query10	0.54	0.55	0.55
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.60	0.58	0.57
query14	1.37	1.42	1.45
query15	0.84	0.81	0.81
query16	0.38	0.38	0.38
query17	1.05	1.03	1.01
query18	0.21	0.20	0.19
query19	1.94	1.78	1.72
query20	0.01	0.00	0.01
query21	15.40	0.69	0.67
query22	3.54	7.28	2.54
query23	18.36	1.44	1.22
query24	2.09	0.21	0.22
query25	0.16	0.07	0.08
query26	0.26	0.19	0.18
query27	0.08	0.08	0.08
query28	13.26	1.01	0.99
query29	12.67	3.29	3.33
query30	0.24	0.06	0.05
query31	2.89	0.40	0.39
query32	3.25	0.47	0.48
query33	3.00	3.01	3.05
query34	16.96	4.37	4.40
query35	4.44	4.43	4.40
query36	0.65	0.50	0.49
query37	0.19	0.16	0.16
query38	0.16	0.15	0.15
query39	0.04	0.04	0.04
query40	0.15	0.13	0.12
query41	0.09	0.05	0.05
query42	0.06	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 109.5 s
Total hot run time: 31.9 s

englefly · 2024-09-09T01:56:18Z

run buildall

doris-robot · 2024-09-09T02:47:02Z

TPC-H: Total hot run time: 37522 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b1d5172903add964ebe275e9200598045f5cda42, data reload: false
------ Round 1 ----------------------------------
q1	17604	4357	4299	4299
q2	2033	183	196	183
q3	11644	967	1090	967
q4	10515	679	711	679
q5	7756	2828	2809	2809
q6	230	136	134	134
q7	952	615	598	598
q8	9313	2044	2078	2044
q9	7006	6483	6469	6469
q10	7002	2216	2234	2216
q11	472	241	239	239
q12	393	220	215	215
q13	19035	3095	3102	3095
q14	279	243	239	239
q15	534	493	494	493
q16	518	444	426	426
q17	967	620	632	620
q18	7232	6645	6878	6645
q19	1384	1099	1006	1006
q20	697	337	321	321
q21	4328	2865	2828	2828
q22	1108	997	1004	997
Total cold run time: 111002 ms
Total hot run time: 37522 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4376	4282	4319	4282
q2	376	272	273	272
q3	2838	2662	2619	2619
q4	1907	1644	1670	1644
q5	5599	5681	5661	5661
q6	229	134	144	134
q7	2221	1787	1783	1783
q8	3268	3389	3392	3389
q9	8790	8822	8796	8796
q10	3543	3373	3390	3373
q11	614	508	519	508
q12	807	647	652	647
q13	14622	3205	3307	3205
q14	321	291	285	285
q15	535	475	479	475
q16	561	515	506	506
q17	1835	1546	1523	1523
q18	8177	7917	8055	7917
q19	1691	1516	1535	1516
q20	2168	1903	1933	1903
q21	5715	5391	5352	5352
q22	1113	1022	1002	1002
Total cold run time: 71306 ms
Total hot run time: 56792 ms

doris-robot · 2024-09-09T02:59:14Z

TPC-DS: Total hot run time: 193101 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b1d5172903add964ebe275e9200598045f5cda42, data reload: false
query1	1262	900	893	893
query2	6366	1958	1919	1919
query3	10613	3970	3909	3909
query4	59073	23942	23267	23267
query5	5343	527	532	527
query6	402	176	161	161
query7	5764	294	289	289
query8	308	219	236	219
query9	8986	2496	2503	2496
query10	480	266	272	266
query11	18135	15134	15131	15131
query12	158	103	120	103
query13	1588	382	401	382
query14	10292	7433	7609	7433
query15	246	179	188	179
query16	7111	457	439	439
query17	1132	619	559	559
query18	1676	307	309	307
query19	299	151	152	151
query20	121	110	110	110
query21	212	111	101	101
query22	4693	4309	4317	4309
query23	34509	34022	33425	33425
query24	5901	2882	2819	2819
query25	529	389	379	379
query26	683	155	152	152
query27	1783	273	278	273
query28	3823	2034	2022	2022
query29	659	406	400	400
query30	242	161	156	156
query31	938	767	767	767
query32	86	49	52	49
query33	452	288	283	283
query34	880	479	472	472
query35	844	729	699	699
query36	1064	906	948	906
query37	151	81	87	81
query38	4013	3849	3973	3849
query39	1441	1408	1399	1399
query40	199	111	113	111
query41	46	46	45	45
query42	119	98	100	98
query43	493	478	483	478
query44	1092	758	741	741
query45	191	162	164	162
query46	1085	747	717	717
query47	1881	1782	1754	1754
query48	370	296	298	296
query49	794	450	457	450
query50	825	415	427	415
query51	6989	6826	6962	6826
query52	103	86	86	86
query53	252	181	188	181
query54	562	456	455	455
query55	78	78	80	78
query56	289	282	276	276
query57	1180	1098	1101	1098
query58	225	263	237	237
query59	2951	2969	2784	2784
query60	300	293	282	282
query61	122	120	122	120
query62	764	664	673	664
query63	227	197	188	188
query64	2938	766	745	745
query65	3208	3134	3138	3134
query66	708	340	347	340
query67	15268	15286	15130	15130
query68	3031	573	579	573
query69	419	283	291	283
query70	1155	1123	1052	1052
query71	375	283	286	283
query72	6461	4003	3987	3987
query73	741	318	320	318
query74	9128	8801	8924	8801
query75	3372	2642	2710	2642
query76	1477	1004	930	930
query77	549	328	320	320
query78	9841	9585	9434	9434
query79	1663	538	540	538
query80	947	525	568	525
query81	572	239	233	233
query82	422	140	143	140
query83	175	152	149	149
query84	263	74	79	74
query85	901	287	281	281
query86	303	285	292	285
query87	4325	4335	4400	4335
query88	3386	2299	2283	2283
query89	394	283	282	282
query90	1608	190	188	188
query91	124	102	97	97
query92	68	50	51	50
query93	1320	533	543	533
query94	558	290	273	273
query95	344	300	257	257
query96	582	261	259	259
query97	3226	3051	3045	3045
query98	215	202	199	199
query99	1856	1288	1280	1280
Total cold run time: 305318 ms
Total hot run time: 193101 ms

doris-robot · 2024-09-09T03:04:47Z

ClickBench: Total hot run time: 31.49 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b1d5172903add964ebe275e9200598045f5cda42, data reload: false
query1	0.04	0.05	0.04
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.67	0.07	0.08
query5	0.49	0.49	0.50
query6	1.13	0.73	0.72
query7	0.02	0.01	0.02
query8	0.06	0.04	0.04
query9	0.55	0.49	0.49
query10	0.55	0.58	0.54
query11	0.15	0.12	0.11
query12	0.14	0.12	0.11
query13	0.60	0.58	0.58
query14	1.41	1.43	1.43
query15	0.83	0.83	0.84
query16	0.37	0.35	0.39
query17	1.02	1.02	1.04
query18	0.21	0.20	0.19
query19	1.84	1.81	1.83
query20	0.01	0.01	0.01
query21	15.41	0.68	0.66
query22	4.01	6.80	2.05
query23	18.32	1.38	1.27
query24	2.10	0.24	0.22
query25	0.14	0.08	0.08
query26	0.26	0.19	0.18
query27	0.08	0.07	0.08
query28	13.19	1.01	0.98
query29	12.59	3.31	3.32
query30	0.26	0.06	0.06
query31	2.85	0.41	0.38
query32	3.27	0.48	0.48
query33	2.96	2.99	3.01
query34	17.17	4.37	4.44
query35	4.43	4.38	4.44
query36	0.65	0.50	0.49
query37	0.19	0.15	0.15
query38	0.16	0.14	0.14
query39	0.05	0.04	0.05
query40	0.15	0.13	0.13
query41	0.09	0.05	0.05
query42	0.05	0.04	0.04
query43	0.05	0.04	0.04
Total cold run time: 109.82 s
Total hot run time: 31.49 s

github-actions · 2024-09-09T06:58:36Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-09-09T06:58:37Z

PR approved by anyone and no changes requested.

RoanHeNaN · 2024-09-25T15:21:01Z

Can we pick this pr to branch-3.0 ?

englefly · 2024-10-17T09:04:12Z

not-merge/2.1
this pr is based on #35144, which is not merged into branch-2.1

englefly · 2024-10-17T09:04:32Z

Can we pick this pr to branch-3.0 ?

YES

@115

…ged profile (apache#40361) physical plan is already printed in profile. however, it is hard to compare the estimated rows of sql operator and the actual rows. In this pr, we get actual rows from merged profile, and set it to corresponding physical node in physical plan. here is an example: "PhysicalHashJoin[13890]@115 ( stats=17,964.27 actualRows=20499, type=INNER_JOIN, hashCondition=[(l_suppkey#19 = s_suppkey#33)]" the estmated rows is 17,964, the actual rows is 20499 Issue Number: close #xxx

@115

…ged profile (apache#40361) physical plan is already printed in profile. however, it is hard to compare the estimated rows of sql operator and the actual rows. In this pr, we get actual rows from merged profile, and set it to corresponding physical node in physical plan. here is an example: "PhysicalHashJoin[13890]@115 ( stats=17,964.27 actualRows=20499, type=INNER_JOIN, hashCondition=[(l_suppkey#19 = s_suppkey#33)]" the estmated rows is 17,964, the actual rows is 20499 Issue Number: close #xxx

…ged profile (branch-3.0) (#42254) ## Proposed changes pick #40361 Issue Number: close #xxx

@115

…ged profile (apache#40361) ## Proposed changes physical plan is already printed in profile. however, it is hard to compare the estimated rows of sql operator and the actual rows. In this pr, we get actual rows from merged profile, and set it to corresponding physical node in physical plan. here is an example: "PhysicalHashJoin[13890]@115 ( stats=17,964.27 actualRows=20499, type=INNER_JOIN, hashCondition=[(l_suppkey#19 = s_suppkey#33)]" the estmated rows is 17,964, the actual rows is 20499 Issue Number: close #xxx

englefly marked this pull request as ready for review September 4, 2024 06:31

englefly force-pushed the mmprofile branch from 60722b1 to 6fce1d1Compare September 6, 2024 05:33

englefly added 2 commits September 9, 2024 09:50

set actual row count in physical plan according to merged profile
5ab2a4e

fix
b1d5172

englefly force-pushed the mmprofile branch from 6fce1d1 to b1d5172Compare September 9, 2024 01:56

starocean999 approved these changes Sep 9, 2024
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 9, 2024

github-actionsBot added the reviewed label Sep 9, 2024

Mryange approved these changes Sep 9, 2024
View reviewed changes

englefly merged commit cd35604 into apache:masterSep 9, 2024

englefly deleted the mmprofile branch September 9, 2024 07:18

morrySnow added dev/3.0.x dev/2.1.x labels Oct 10, 2024

englefly added not-merge/2.1 dev/2.1.x and removed dev/2.1.x not-merge/2.1 labels Oct 17, 2024

englefly mentioned this pull request Oct 22, 2024
[feat](nereids)set actual row count in physical plan according to merged profile (branch-3.0) #42254
Merged

englefly added a commit that referenced this pull request Oct 22, 2024
[feat](nereids)set actual row count in physical plan according to mer…
f1bf64e
…ged profile (branch-3.0) (#42254) ## Proposed changes pick #40361 Issue Number: close #xxx

englefly added dev/3.0.3-merged and removed dev/3.0.x labels Oct 22, 2024

Uh oh!

Conversation

englefly commented Sep 4, 2024

Proposed changes

Uh oh!

doris-robot commented Sep 4, 2024

Uh oh!

englefly commented Sep 5, 2024

Uh oh!

doris-robot commented Sep 5, 2024

Uh oh!

doris-robot commented Sep 5, 2024

Uh oh!

doris-robot commented Sep 5, 2024

Uh oh!

englefly commented Sep 6, 2024

Uh oh!

doris-robot commented Sep 6, 2024

Uh oh!

doris-robot commented Sep 6, 2024

Uh oh!

doris-robot commented Sep 6, 2024

Uh oh!

englefly commented Sep 9, 2024

Uh oh!

doris-robot commented Sep 9, 2024

Uh oh!

doris-robot commented Sep 9, 2024

Uh oh!

doris-robot commented Sep 9, 2024

Uh oh!

github-actionsBot commented Sep 9, 2024

Uh oh!

github-actionsBot commented Sep 9, 2024

Uh oh!

RoanHeNaN commented Sep 25, 2024

Uh oh!

englefly commented Oct 17, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

englefly commented Oct 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

englefly commented Oct 17, 2024•
edited
Loading