Skip to content

[Bug] Fix core when modifing char to varchar and loading boolean with replace aggregation - #4042

Merged
chaoyli merged 1 commit into
apache:masterfrom
chaoyli:master
Jul 8, 2020
Merged

[Bug] Fix core when modifing char to varchar and loading boolean with replace aggregation#4042
chaoyli merged 1 commit into
apache:masterfrom
chaoyli:master

Conversation

@chaoyli

Copy link
Copy Markdown
Contributor
  1. Doris support modify char to varchar. There is a bug when use two-level pointer when converting the date.
  2. Boolean can be used as metric value with REPLACE and REPLACE_IF_NOT_NULL aggregation function. The aggregation function should be added into aggregation map.

@chaoylichaoyli self-assigned this Jul 7, 2020

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningmanmorningman added area/schema-change Issues or PRs related to schema change kind/fix Categorizes issue or PR as related to a bug. approved Indicates a PR has been approved by one committer. labels Jul 7, 2020
@chaoyli
chaoyli merged commit 413d6d2 into apache:masterJul 8, 2020
morningman pushed a commit to morningman/doris that referenced this pull request Jul 9, 2020
… replace aggregation (apache#4042)
1. Doris support modify char to varchar. There is a bug when use two-level pointer when converting the date.
2. Boolean can be used as metric value with REPLACE and REPLACE_IF_NOT_NULL aggregation function. The aggregation function should be added into aggregation map.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.area/schema-changeIssues or PRs related to schema changekind/fixCategorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Core upon modifing char to varchar Core upon modifing char to varchar

2 participants

@chaoyli@morningman