[fix](window_funnel) fix wrong result of fixed mode by jacktengg · Pull Request #40459 · apache/doris

jacktengg · 2024-09-05T18:42:28Z

Proposed changes

Issue Number: close #xxx

doris-robot · 2024-09-05T18:42:33Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

jacktengg · 2024-09-05T18:42:44Z

run buildall

doris-robot · 2024-09-05T19:45:40Z

TPC-H: Total hot run time: 38120 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f9ce22a5dbc0629ce1d70f5c7fa2e35ec0fb0740, data reload: false
------ Round 1 ----------------------------------
q1	17609	4508	4308	4308
q2	2023	189	187	187
q3	11701	965	1101	965
q4	10514	760	661	661
q5	7745	2864	2888	2864
q6	227	141	139	139
q7	976	627	602	602
q8	9312	2102	2066	2066
q9	7264	6546	6562	6546
q10	7000	2254	2210	2210
q11	461	247	245	245
q12	403	224	225	224
q13	19009	3076	3070	3070
q14	288	240	246	240
q15	521	496	487	487
q16	523	446	437	437
q17	994	690	776	690
q18	7407	6876	6859	6859
q19	1397	1020	1019	1019
q20	679	344	336	336
q21	4186	3044	2990	2990
q22	1087	975	1006	975
Total cold run time: 111326 ms
Total hot run time: 38120 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4356	4271	4324	4271
q2	386	280	268	268
q3	2879	2673	2655	2655
q4	1958	1689	1700	1689
q5	5674	5685	5799	5685
q6	228	137	146	137
q7	2198	1843	1804	1804
q8	3306	3434	3546	3434
q9	8874	8853	8872	8853
q10	3643	3402	3346	3346
q11	639	509	508	508
q12	827	665	651	651
q13	14910	3309	3298	3298
q14	330	311	280	280
q15	546	483	489	483
q16	549	495	506	495
q17	1860	1542	1576	1542
q18	8118	7727	7841	7727
q19	1735	1641	1545	1545
q20	2180	1903	1906	1903
q21	5733	5522	5380	5380
q22	1146	1016	1065	1016
Total cold run time: 72075 ms
Total hot run time: 56970 ms

doris-robot · 2024-09-05T19:57:50Z

TPC-DS: Total hot run time: 192357 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f9ce22a5dbc0629ce1d70f5c7fa2e35ec0fb0740, data reload: false
query1	1255	912	868	868
query2	6482	1876	1825	1825
query3	10618	4064	3913	3913
query4	59613	26274	22980	22980
query5	5435	508	507	507
query6	413	169	167	167
query7	5773	302	308	302
query8	325	230	222	222
query9	8870	2550	2542	2542
query10	496	291	275	275
query11	16691	15132	15325	15132
query12	166	103	111	103
query13	1553	411	418	411
query14	10768	7554	7526	7526
query15	251	173	195	173
query16	7464	489	473	473
query17	1108	553	559	553
query18	2084	308	291	291
query19	287	149	145	145
query20	129	114	114	114
query21	200	124	104	104
query22	4730	4585	4548	4548
query23	34369	33164	33292	33164
query24	5945	2845	2774	2774
query25	530	377	393	377
query26	684	153	155	153
query27	1773	277	279	277
query28	3781	2052	2034	2034
query29	686	403	408	403
query30	232	151	153	151
query31	926	717	762	717
query32	81	52	54	52
query33	432	291	298	291
query34	900	473	467	467
query35	857	713	709	709
query36	1072	885	913	885
query37	150	84	85	84
query38	3900	3817	3826	3817
query39	1456	1423	1404	1404
query40	202	116	115	115
query41	46	48	45	45
query42	119	94	94	94
query43	501	466	454	454
query44	1070	750	750	750
query45	198	166	167	166
query46	1090	770	748	748
query47	1901	1781	1776	1776
query48	374	306	295	295
query49	789	453	491	453
query50	831	407	408	407
query51	7056	6849	6866	6849
query52	101	85	84	84
query53	250	175	177	175
query54	563	447	460	447
query55	73	72	74	72
query56	281	251	262	251
query57	1202	1075	1054	1054
query58	226	256	265	256
query59	2889	2812	2931	2812
query60	299	270	269	269
query61	102	100	102	100
query62	737	676	735	676
query63	220	188	184	184
query64	2801	691	684	684
query65	3225	3105	3161	3105
query66	677	349	340	340
query67	15425	15263	15083	15083
query68	2951	589	608	589
query69	411	286	282	282
query70	1209	1131	1108	1108
query71	359	284	289	284
query72	6242	4095	3834	3834
query73	728	320	328	320
query74	9171	8813	8834	8813
query75	3363	2700	2707	2700
query76	1376	1010	1007	1007
query77	546	333	319	319
query78	9687	9042	9065	9042
query79	1036	539	525	525
query80	684	509	509	509
query81	459	232	231	231
query82	235	140	140	140
query83	171	145	151	145
query84	257	82	75	75
query85	679	290	282	282
query86	322	293	290	290
query87	4388	4368	4438	4368
query88	3639	2334	2352	2334
query89	388	286	280	280
query90	1953	194	186	186
query91	129	98	97	97
query92	61	51	56	51
query93	1053	540	547	540
query94	702	304	268	268
query95	327	274	266	266
query96	582	274	270	270
query97	3221	3071	3089	3071
query98	210	199	204	199
query99	1527	1255	1289	1255
Total cold run time: 303799 ms
Total hot run time: 192357 ms

doris-robot · 2024-09-05T20:03:22Z

ClickBench: Total hot run time: 31.8 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f9ce22a5dbc0629ce1d70f5c7fa2e35ec0fb0740, data reload: false
query1	0.04	0.04	0.04
query2	0.08	0.03	0.04
query3	0.22	0.04	0.05
query4	1.67	0.08	0.08
query5	0.52	0.49	0.49
query6	1.14	0.74	0.72
query7	0.02	0.02	0.02
query8	0.05	0.04	0.05
query9	0.56	0.48	0.49
query10	0.53	0.55	0.54
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.60	0.60	0.59
query14	1.38	1.43	1.44
query15	0.85	0.83	0.81
query16	0.37	0.37	0.36
query17	1.00	1.00	1.05
query18	0.22	0.21	0.21
query19	1.87	1.80	1.75
query20	0.01	0.01	0.01
query21	15.38	0.68	0.66
query22	4.18	6.55	2.40
query23	18.66	1.40	1.25
query24	2.16	0.24	0.22
query25	0.16	0.08	0.08
query26	0.27	0.18	0.18
query27	0.08	0.09	0.07
query28	13.20	1.03	0.99
query29	12.60	3.35	3.37
query30	0.24	0.06	0.05
query31	2.88	0.40	0.39
query32	3.25	0.48	0.47
query33	2.98	2.96	3.04
query34	17.01	4.38	4.41
query35	4.41	4.42	4.46
query36	0.66	0.46	0.49
query37	0.18	0.15	0.17
query38	0.15	0.15	0.15
query39	0.05	0.04	0.04
query40	0.16	0.12	0.14
query41	0.09	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 110.3 s
Total hot run time: 31.8 s

doris-robot · 2024-09-05T20:04:21Z

TeamCity be ut coverage result:
Function Coverage: 36.77% (9379/25507)
Line Coverage: 28.20% (77322/274206)
Region Coverage: 27.61% (39918/144587)
Branch Coverage: 24.26% (20318/83758)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f9ce22a5dbc0629ce1d70f5c7fa2e35ec0fb0740_f9ce22a5dbc0629ce1d70f5c7fa2e35ec0fb0740/report/index.html

BP #40459

jacktengg · 2024-09-13T10:05:36Z

run buildall

doris-robot · 2024-09-13T10:26:58Z

TeamCity be ut coverage result:
Function Coverage: 36.89% (9465/25654)
Line Coverage: 28.26% (77844/275427)
Region Coverage: 27.67% (40197/145295)
Branch Coverage: 24.27% (20423/84140)
Coverage Report: http://coverage.selectdb-in.cc/coverage/392c3a8b396ccda47e50c0576267334f1fc95b8b_392c3a8b396ccda47e50c0576267334f1fc95b8b/report/index.html

doris-robot · 2024-09-13T10:43:13Z

TPC-H: Total hot run time: 42760 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 392c3a8b396ccda47e50c0576267334f1fc95b8b, data reload: false
------ Round 1 ----------------------------------
q1	17599	7245	7232	7232
q2	2025	185	177	177
q3	10755	1285	1376	1285
q4	10358	1014	1041	1014
q5	7718	3152	3135	3135
q6	238	152	150	150
q7	1036	654	601	601
q8	9446	2015	2032	2015
q9	6691	6257	6311	6257
q10	7057	2545	2518	2518
q11	444	255	256	255
q12	404	227	223	223
q13	17762	2998	3032	2998
q14	287	241	263	241
q15	586	538	530	530
q16	568	444	425	425
q17	1001	946	946	946
q18	7266	6745	6718	6718
q19	1384	1238	1225	1225
q20	594	331	326	326
q21	3854	3482	3527	3482
q22	1074	1019	1007	1007
Total cold run time: 108147 ms
Total hot run time: 42760 ms
----- Round 2, with runtime_filter_mode=off -----
q1	7195	7142	7182	7142
q2	342	237	248	237
q3	3116	3107	3017	3017
q4	2078	2088	2072	2072
q5	5658	5620	5669	5620
q6	241	149	148	148
q7	2171	1784	1784	1784
q8	3429	3458	3450	3450
q9	8891	9054	8873	8873
q10	3474	3546	3570	3546
q11	592	479	482	479
q12	819	621	627	621
q13	9769	3238	3190	3190
q14	307	275	274	274
q15	605	529	532	529
q16	502	451	470	451
q17	1791	1735	1739	1735
q18	8415	7924	7935	7924
q19	1770	1739	1729	1729
q20	2111	1883	1901	1883
q21	5870	5399	5622	5399
q22	1181	1003	999	999
Total cold run time: 70327 ms
Total hot run time: 61102 ms

doris-robot · 2024-09-13T10:55:31Z

TPC-DS: Total hot run time: 199597 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 392c3a8b396ccda47e50c0576267334f1fc95b8b, data reload: false
query1	1256	877	887	877
query2	6371	1749	1762	1749
query3	10652	3881	3796	3796
query4	58358	25300	23943	23943
query5	5120	551	525	525
query6	372	170	182	170
query7	5665	312	300	300
query8	286	221	226	221
query9	6197	2593	2586	2586
query10	405	292	272	272
query11	15989	15544	15682	15544
query12	148	102	101	101
query13	1454	440	409	409
query14	10211	7076	6944	6944
query15	203	181	185	181
query16	6950	505	503	503
query17	1150	608	592	592
query18	1705	328	322	322
query19	206	161	157	157
query20	120	114	113	113
query21	230	106	111	106
query22	4873	4596	4413	4413
query23	34567	33731	33599	33599
query24	6161	3103	3053	3053
query25	525	405	399	399
query26	612	159	159	159
query27	1576	283	291	283
query28	2772	2092	2062	2062
query29	696	436	426	426
query30	225	155	158	155
query31	940	801	750	750
query32	77	54	57	54
query33	456	306	298	298
query34	889	481	492	481
query35	853	752	732	732
query36	1038	870	897	870
query37	142	86	89	86
query38	4022	3974	3935	3935
query39	1450	1445	1405	1405
query40	213	115	119	115
query41	49	48	46	46
query42	118	100	101	100
query43	486	439	448	439
query44	1186	800	776	776
query45	197	172	174	172
query46	1098	842	815	815
query47	1892	1800	1816	1800
query48	372	297	290	290
query49	748	453	459	453
query50	909	446	450	446
query51	7192	7108	6820	6820
query52	102	93	89	89
query53	256	182	183	182
query54	562	464	464	464
query55	75	75	76	75
query56	283	265	284	265
query57	1200	1083	1051	1051
query58	221	232	248	232
query59	2804	2586	2517	2517
query60	293	278	268	268
query61	100	114	106	106
query62	809	683	667	667
query63	225	185	188	185
query64	1473	703	701	701
query65	3263	3185	3149	3149
query66	673	290	296	290
query67	16023	15687	15546	15546
query68	1932	797	571	571
query69	418	275	277	275
query70	1168	1099	1102	1099
query71	394	285	282	282
query72	6110	4064	4105	4064
query73	766	327	337	327
query74	9345	9117	9038	9038
query75	3338	2716	2784	2716
query76	1373	1349	1308	1308
query77	527	320	317	317
query78	9960	9440	9606	9440
query79	1156	883	876	876
query80	1099	877	835	835
query81	487	263	265	263
query82	1284	272	266	266
query83	211	195	191	191
query84	265	104	107	104
query85	740	441	412	412
query86	334	303	317	303
query87	4330	4318	4335	4318
query88	4187	4101	4094	4094
query89	398	380	377	377
query90	1825	315	309	309
query91	124	122	124	122
query92	80	76	74	74
query93	1216	1048	1058	1048
query94	784	373	387	373
query95	533	424	419	419
query96	473	473	471	471
query97	3143	3181	3146	3146
query98	237	228	222	222
query99	1684	1307	1313	1307
Total cold run time: 297665 ms
Total hot run time: 199597 ms

doris-robot · 2024-09-13T11:01:02Z

ClickBench: Total hot run time: 31.19 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 392c3a8b396ccda47e50c0576267334f1fc95b8b, data reload: false
query1	0.04	0.04	0.04
query2	0.07	0.03	0.04
query3	0.22	0.05	0.05
query4	1.68	0.07	0.07
query5	0.49	0.49	0.50
query6	1.14	0.72	0.72
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.56	0.53	0.52
query10	0.56	0.60	0.57
query11	0.16	0.12	0.12
query12	0.15	0.13	0.12
query13	0.63	0.62	0.61
query14	1.45	1.47	1.53
query15	0.92	0.87	0.88
query16	0.37	0.36	0.36
query17	1.00	1.00	1.02
query18	0.17	0.17	0.17
query19	1.90	1.83	1.81
query20	0.02	0.01	0.01
query21	15.39	0.65	0.66
query22	4.02	8.34	1.38
query23	17.88	1.42	1.37
query24	2.26	0.23	0.21
query25	0.19	0.09	0.08
query26	0.29	0.18	0.18
query27	0.09	0.08	0.07
query28	13.18	1.14	1.10
query29	12.51	3.46	3.34
query30	0.24	0.06	0.07
query31	2.86	0.42	0.42
query32	3.23	0.50	0.50
query33	3.04	2.99	3.09
query34	15.46	4.32	4.32
query35	4.33	4.34	4.36
query36	0.69	0.49	0.51
query37	0.18	0.16	0.16
query38	0.17	0.16	0.15
query39	0.04	0.04	0.04
query40	0.16	0.15	0.14
query41	0.10	0.04	0.04
query42	0.06	0.05	0.05
query43	0.04	0.03	0.05
Total cold run time: 108.01 s
Total hot run time: 31.19 s

github-actions · 2024-09-13T14:38:03Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-09-13T14:38:06Z

PR approved by anyone and no changes requested.

mrhhsg

lgtm

## Proposed changes Issue Number: close #xxx BP #40146 and #40459

## Proposed changes Issue Number: close #xxx

jacktengg mentioned this pull request Sep 5, 2024
[fix](window_funnel) fix wrong result of fixed mode #40460
Merged

yiguolei pushed a commit that referenced this pull request Sep 6, 2024
[fix](window_funnel) fix wrong result of fixed mode (#40460)
7e27bb1
BP #40459

yiguolei added the dev/2.1.6-merged label Sep 6, 2024

[fix](window_funnel) fix wrong result of fixed mode
392c3a8

jacktengg force-pushed the fix-0906 branch from f9ce22a to 392c3a8Compare September 13, 2024 10:05

yiguolei approved these changes Sep 13, 2024
View reviewed changes

github-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Sep 13, 2024

mrhhsg approved these changes Sep 13, 2024
View reviewed changes

yiguolei merged commit c226d9f into apache:masterSep 14, 2024

yiguolei added the dev/3.0.x label Sep 14, 2024

jacktengg added a commit to jacktengg/incubator-doris that referenced this pull request Sep 19, 2024
[fix](window_funnel) fix wrong result of fixed mode (apache#40459)
5e42ffc

jacktengg mentioned this pull request Sep 19, 2024
[fix](window_funnel) fix wrong result of fixed mode (#40146 #40459) #40960
Merged

yiguolei pushed a commit that referenced this pull request Sep 19, 2024
[fix](window_funnel) fix wrong result of fixed mode (#40459) (#40960)
b935b73
## Proposed changes Issue Number: close #xxx BP #40146 and #40459

dataroaring added dev/3.0.2-merged and removed dev/3.0.x labels Sep 20, 2024

HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
[fix](window_funnel) fix wrong result of fixed mode (apache#40459)
50451f6
## Proposed changes Issue Number: close #xxx

Uh oh!

Conversation

jacktengg commented Sep 5, 2024

Proposed changes

Uh oh!

doris-robot commented Sep 5, 2024

Uh oh!

jacktengg commented Sep 5, 2024

Uh oh!

doris-robot commented Sep 5, 2024

Uh oh!

doris-robot commented Sep 5, 2024

Uh oh!

doris-robot commented Sep 5, 2024

Uh oh!

doris-robot commented Sep 5, 2024

Uh oh!

jacktengg commented Sep 13, 2024

Uh oh!

doris-robot commented Sep 13, 2024

Uh oh!

doris-robot commented Sep 13, 2024

Uh oh!

doris-robot commented Sep 13, 2024

Uh oh!

doris-robot commented Sep 13, 2024

Uh oh!

github-actionsBot commented Sep 13, 2024

Uh oh!

github-actionsBot commented Sep 13, 2024

Uh oh!

mrhhsg left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants