Skip to content

[Thread Resource Leak] Fix thread resource leak after checkpoint catalog destroyed - #4049

Merged
morningman merged 9 commits into
apache:masterfrom
caiconghui:threadpool_leak
Jul 16, 2020
Merged

[Thread Resource Leak] Fix thread resource leak after checkpoint catalog destroyed#4049
morningman merged 9 commits into
apache:masterfrom
caiconghui:threadpool_leak

Conversation

@caiconghui

Copy link
Copy Markdown
Contributor

This PR is mainly to fix thread resource leak, and then add some notice to use newDaemonScheduledThreadPool api in ThreadPoolManager .

@caiconghui

Copy link
Copy Markdown
ContributorAuthor

for #4046

Comment threadfe/src/main/java/org/apache/doris/common/publish/FixedTimePublisher.java Outdated
@morningmanmorningman added area/catalog Issues or PRs related to catalog management kind/fix Categorizes issue or PR as related to a bug. labels Jul 8, 2020
Comment threadfe/src/main/java/org/apache/doris/catalog/Catalog.java
@morningman

Copy link
Copy Markdown
Contributor

Most of UT are failed. I do not know why... Have you run it in your local env?

@morningmanmorningman self-assigned this Jul 15, 2020
@caiconghui

Copy link
Copy Markdown
ContributorAuthor

Most of UT are failed. I do not know why... Have you run it in your local env?

my bad, I will fix it.

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningmanmorningman added the approved Indicates a PR has been approved by one committer. label Jul 16, 2020
@morningman
morningman merged commit db50c19 into apache:masterJul 16, 2020
morningman pushed a commit to morningman/doris that referenced this pull request Jul 16, 2020
…log destroyed (apache#4049)
This PR is mainly to fix thread resource leak, and then add some notice
to use newDaemonScheduledThreadPool api in ThreadPoolManager.
@caiconghui
caiconghui deleted the threadpool_leak branch July 30, 2020 02:21
csun5285 pushed a commit to csun5285/doris that referenced this pull request Sep 23, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.area/catalogIssues or PRs related to catalog managementkind/fixCategorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@caiconghui@morningman@WingsGo