Skip to content

[fix](cloud) Fix possible incorrect merged tablet stats while iterating detached tablet stats - #40494

Merged
dataroaring merged 3 commits into
apache:masterfrom
gavinchou:gavin-fix-detached-tablet-stats
Sep 11, 2024
Merged

[fix](cloud) Fix possible incorrect merged tablet stats while iterating detached tablet stats#40494
dataroaring merged 3 commits into
apache:masterfrom
gavinchou:gavin-fix-detached-tablet-stats

Conversation

@gavinchou

Copy link
Copy Markdown
Contributor

Previous impl. of get_detached_tablet_stats() may miss some detached KVs or tablet stats due to KV iterating paging (RangeGetIterator.more() == true), which leads to zero detached stats and produce buggy data size report to FE.

Previous impl. of `get_detached_tablet_stats()` may miss some detached
KVs or tablet stats due to KV iterating paging (`RangeGetIterator.more() == true`),
which leads to zero detached stats and produce buggy data size report to FE.
@doris-robot

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@gavinchou

Copy link
Copy Markdown
ContributorAuthor

run buildall

@gavinchou

Copy link
Copy Markdown
ContributorAuthor

run buildall

@gavinchougavinchou changed the title [fix](cloud) Fix incorrect merged tablet stats[fix](cloud) Fix possible incorrect merged tablet stats while iterating detached tablet statsSep 8, 2024
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 10, 2024
@gavinchou

Copy link
Copy Markdown
ContributorAuthor

run buildall

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
dataroaring merged commit fe4efdd into apache:masterSep 11, 2024
dataroaring pushed a commit that referenced this pull request Sep 11, 2024
…ng detached tablet stats (#40494)
Previous impl. of `get_detached_tablet_stats()` may miss some detached
KVs or tablet stats due to KV iterating paging (`RangeGetIterator.more()
== true`), which leads to zero detached stats and produce buggy data
size report to FE.
@gavinchougavinchou mentioned this pull request Oct 13, 2024
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
…ng detached tablet stats (apache#40494)
Previous impl. of `get_detached_tablet_stats()` may miss some detached
KVs or tablet stats due to KV iterating paging (`RangeGetIterator.more()
== true`), which leads to zero detached stats and produce buggy data
size report to FE.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.2-mergedp0_creviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@gavinchou@doris-robot@Hastyshell@Yukang-Lian@dataroaring