Skip to content

[Improvement](sort) do not sort partitial when spill disabled#40528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BiteTheDDDDt merged 1 commit into from
Sep 9, 2024
Merged

[Improvement](sort) do not sort partitial when spill disabled #40528

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions be/src/vec/common/sort/sorter.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -177,8 +177,8 @@ class FullSorter final : public Sorter {

private:
bool _reach_limit() {
return _state->unsorted_block_->rows() > buffered_block_size_ ||
_state->unsorted_block_->bytes() > buffered_block_bytes_;
return _enable_spill && (_state->unsorted_block_->rows() > buffered_block_size_ ||
_state->unsorted_block_->bytes() > buffered_block_bytes_);
}

Status _do_sort();
Expand Down