[feature](array-func)support array_match_all/any by amorynan · Pull Request #40605 · apache/doris

amorynan · 2024-09-10T07:49:25Z

Proposed changes

array_match_all
means that every element in array column should all match filter according to lambda expr
array_match_any
means that any element in array column match filter according to lambda expr
Issue Number: close #xxx

doris-robot · 2024-09-10T07:49:30Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

amorynan · 2024-09-10T07:49:33Z

run buildall

github-actions

clang-tidy made some suggestions

doris-robot · 2024-09-10T08:28:01Z

TeamCity be ut coverage result:
Function Coverage: 36.83% (9396/25513)
Line Coverage: 28.21% (77486/274631)
Region Coverage: 27.62% (40011/144841)
Branch Coverage: 24.24% (20346/83922)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f3f350fbe672c9f8a369c06f4bf398e3fc57ad1e_f3f350fbe672c9f8a369c06f4bf398e3fc57ad1e/report/index.html

morrySnow · 2024-09-10T08:34:39Z

+ private ArrayMatchAll(List<Expression> expressions) {
+ super("array_match_all", expressions);
+ }


remove this

morrySnow · 2024-09-10T08:35:41Z

+ super("array_match_all", arg instanceof Lambda ? arg.child(1).child(0) : arg, new ArrayMap(arg));
+ if (!(arg instanceof Lambda)) {
+ throw new AnalysisException(
+ String.format("The 1st arg of %s must be lambda but is %s", getName(), arg));
+ }


Suggested change
super("array_match_all", arginstanceofLambda ? arg.child(1).child(0) : arg, newArrayMap(arg));
if (!(arginstanceofLambda)) {
thrownewAnalysisException(
String.format("The 1st arg of %s must be lambda but is %s", getName(), arg));
}
super("array_match_all", arginstanceofLambda ? newArrayMap(arg) : arg);

doris-robot · 2024-09-10T12:53:26Z

TPC-H: Total hot run time: 38163 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f3f350fbe672c9f8a369c06f4bf398e3fc57ad1e, data reload: false
------ Round 1 ----------------------------------
q1	17608	4519	4303	4303
q2	2013	191	194	191
q3	11756	980	1093	980
q4	10509	695	723	695
q5	7738	2837	2739	2739
q6	256	143	139	139
q7	969	634	604	604
q8	9331	2127	2086	2086
q9	7275	6563	6606	6563
q10	7009	2239	2267	2239
q11	448	246	248	246
q12	400	231	231	231
q13	17787	3126	3089	3089
q14	284	236	236	236
q15	539	474	483	474
q16	537	448	429	429
q17	985	692	719	692
q18	7341	6889	6980	6889
q19	1398	1154	1023	1023
q20	678	345	330	330
q21	3978	3170	2972	2972
q22	1100	1021	1013	1013
Total cold run time: 109939 ms
Total hot run time: 38163 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4411	4303	4299	4299
q2	373	279	260	260
q3	2884	2710	2695	2695
q4	1942	1707	1649	1649
q5	5719	5732	5798	5732
q6	239	139	138	138
q7	2254	1836	1847	1836
q8	3353	3470	3511	3470
q9	8904	8907	8855	8855
q10	3589	3389	3431	3389
q11	636	527	506	506
q12	841	677	676	676
q13	13248	3333	3360	3333
q14	334	294	310	294
q15	530	508	493	493
q16	574	497	507	497
q17	1867	1540	1562	1540
q18	8246	7923	7870	7870
q19	1765	1480	1656	1480
q20	2179	1924	1913	1913
q21	6007	5694	5578	5578
q22	1132	1050	1015	1015
Total cold run time: 71027 ms
Total hot run time: 57518 ms

doris-robot · 2024-09-10T13:05:42Z

TPC-DS: Total hot run time: 197908 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f3f350fbe672c9f8a369c06f4bf398e3fc57ad1e, data reload: false
query1	1265	912	883	883
query2	6380	2013	2033	2013
query3	10606	4013	3882	3882
query4	60242	27056	23229	23229
query5	5052	514	523	514
query6	394	159	169	159
query7	5640	300	299	299
query8	323	227	223	223
query9	7746	2530	2503	2503
query10	423	291	276	276
query11	17184	15046	15347	15046
query12	154	109	109	109
query13	1459	401	411	401
query14	10255	7010	6963	6963
query15	213	182	174	174
query16	6805	468	433	433
query17	1099	571	578	571
query18	1544	304	292	292
query19	202	149	149	149
query20	132	113	112	112
query21	220	106	102	102
query22	4673	4534	4699	4534
query23	34742	33655	33602	33602
query24	6104	2883	2915	2883
query25	507	405	407	405
query26	612	163	159	159
query27	1600	286	278	278
query28	3928	2060	2054	2054
query29	663	425	444	425
query30	230	160	151	151
query31	951	805	788	788
query32	72	53	56	53
query33	393	311	298	298
query34	916	504	476	476
query35	830	732	731	731
query36	1076	950	936	936
query37	141	87	89	87
query38	4025	3942	3858	3858
query39	1464	1420	1414	1414
query40	196	117	118	117
query41	50	48	47	47
query42	114	97	100	97
query43	517	479	496	479
query44	1104	781	753	753
query45	195	167	165	165
query46	1092	719	776	719
query47	1919	1819	1853	1819
query48	371	308	299	299
query49	770	452	466	452
query50	839	426	421	421
query51	6971	6950	6936	6936
query52	100	91	88	88
query53	250	184	183	183
query54	574	468	463	463
query55	79	79	80	79
query56	299	274	278	274
query57	1201	1112	1092	1092
query58	237	244	246	244
query59	3193	3007	2824	2824
query60	387	270	274	270
query61	103	96	104	96
query62	747	645	652	645
query63	219	195	190	190
query64	1360	696	658	658
query65	3257	3125	3170	3125
query66	599	333	340	333
query67	15739	15579	15362	15362
query68	1965	868	867	867
query69	426	321	323	321
query70	1214	1210	1129	1129
query71	334	342	344	342
query72	4621	3557	3542	3542
query73	601	584	585	584
query74	9143	8885	8927	8885
query75	3054	2979	2933	2933
query76	954	841	841	841
query77	565	406	405	405
query78	9351	9316	9277	9277
query79	897	883	860	860
query80	804	791	807	791
query81	451	259	263	259
query82	264	259	263	259
query83	189	191	188	188
query84	202	104	104	104
query85	618	395	376	376
query86	339	295	315	295
query87	4351	4376	4291	4291
query88	4436	4211	4098	4098
query89	387	366	367	366
query90	1509	313	310	310
query91	176	121	118	118
query92	76	75	75	75
query93	927	921	910	910
query94	477	352	362	352
query95	427	425	414	414
query96	474	481	470	470
query97	3094	3082	3145	3082
query98	245	224	226	224
query99	1312	1245	1272	1245
Total cold run time: 296630 ms
Total hot run time: 197908 ms

doris-robot · 2024-09-10T13:11:12Z

ClickBench: Total hot run time: 31.52 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f3f350fbe672c9f8a369c06f4bf398e3fc57ad1e, data reload: false
query1	0.05	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.05	0.06
query4	1.66	0.10	0.10
query5	0.50	0.48	0.48
query6	1.13	0.74	0.74
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.56	0.52	0.50
query10	0.54	0.57	0.55
query11	0.15	0.12	0.12
query12	0.15	0.12	0.12
query13	0.61	0.59	0.59
query14	1.39	1.41	1.43
query15	0.85	0.83	0.86
query16	0.37	0.37	0.39
query17	1.06	1.08	1.02
query18	0.20	0.22	0.20
query19	1.91	1.76	1.88
query20	0.01	0.01	0.01
query21	15.40	0.66	0.66
query22	4.56	7.04	1.91
query23	18.28	1.37	1.27
query24	2.10	0.23	0.23
query25	0.16	0.10	0.08
query26	0.27	0.18	0.18
query27	0.07	0.08	0.08
query28	13.20	1.04	0.99
query29	12.62	3.38	3.34
query30	0.25	0.05	0.06
query31	2.84	0.40	0.40
query32	3.24	0.47	0.48
query33	3.00	3.00	3.00
query34	17.10	4.38	4.40
query35	4.44	4.47	4.43
query36	0.67	0.47	0.48
query37	0.18	0.15	0.16
query38	0.15	0.15	0.15
query39	0.06	0.04	0.04
query40	0.16	0.13	0.13
query41	0.10	0.05	0.04
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 110.48 s
Total hot run time: 31.52 s

eldenmoon · 2024-09-11T09:16:48Z

+ if (first_outside_null_map->get_data()[row] ||
+ second_outside_null_map->get_data()[row]) {
+ result_null_column->get_data()[row] = 1;
+ result_data_column->get_data()[row] = 0;


better add comment to explain why return null instead of false, and need to describe the behavior in document

amorynan · 2024-09-11T12:34:44Z

run buildall

github-actions · 2024-09-11T12:39:29Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-09-11T12:59:17Z

TeamCity be ut coverage result:
Function Coverage: 36.88% (9455/25635)
Line Coverage: 28.23% (77737/275355)
Region Coverage: 27.63% (40118/145216)
Branch Coverage: 24.24% (20382/84094)
Coverage Report: http://coverage.selectdb-in.cc/coverage/494c49537930284690b1eb800b495ee84097bda6_494c49537930284690b1eb800b495ee84097bda6/report/index.html

eldenmoon · 2024-09-11T13:00:16Z

@@ -0,0 +1,68 @@
+// Licensed to the Apache Software Foundation (ASF) under one


add document and link to this PR

we need to detail explain the behavior if encounter null in arrays for the two functions, it's confusing

doris-robot · 2024-09-11T13:11:51Z

TPC-H: Total hot run time: 38190 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 494c49537930284690b1eb800b495ee84097bda6, data reload: false
------ Round 1 ----------------------------------
q1	17649	4434	4287	4287
q2	2015	192	188	188
q3	11727	949	1125	949
q4	10538	746	715	715
q5	7758	2852	2822	2822
q6	231	140	140	140
q7	963	618	615	615
q8	9548	2085	2114	2085
q9	8366	6540	6509	6509
q10	7004	2209	2252	2209
q11	464	239	240	239
q12	393	231	234	231
q13	19051	3118	3142	3118
q14	294	241	242	241
q15	548	510	503	503
q16	522	441	454	441
q17	991	723	752	723
q18	7422	6817	6962	6817
q19	1405	1029	1019	1019
q20	659	342	351	342
q21	3994	3018	2996	2996
q22	1104	1041	1001	1001
Total cold run time: 112646 ms
Total hot run time: 38190 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4446	4278	4328	4278
q2	382	270	269	269
q3	2932	2669	2714	2669
q4	1922	1676	1747	1676
q5	5733	5658	5801	5658
q6	228	137	138	137
q7	2178	1871	1879	1871
q8	3255	3450	3495	3450
q9	8871	8888	8939	8888
q10	3636	3383	3421	3383
q11	605	523	526	523
q12	824	640	651	640
q13	14847	3255	3388	3255
q14	328	283	306	283
q15	542	495	481	481
q16	564	503	499	499
q17	1832	1570	1534	1534
q18	8140	7881	8069	7881
q19	1739	1579	1689	1579
q20	2167	1925	1940	1925
q21	5813	5517	5483	5483
q22	1091	1028	1029	1028
Total cold run time: 72075 ms
Total hot run time: 57390 ms

doris-robot · 2024-09-11T13:24:02Z

TPC-DS: Total hot run time: 197140 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 494c49537930284690b1eb800b495ee84097bda6, data reload: false
query1	1232	877	888	877
query2	6315	1918	1840	1840
query3	10628	3977	3876	3876
query4	59701	26340	23092	23092
query5	5121	510	496	496
query6	394	164	177	164
query7	5614	296	293	293
query8	323	223	220	220
query9	7658	2527	2514	2514
query10	426	284	268	268
query11	17321	15002	15325	15002
query12	162	108	114	108
query13	1470	393	385	385
query14	10635	7120	7457	7120
query15	211	184	180	180
query16	6828	471	455	455
query17	1089	561	564	561
query18	1324	293	320	293
query19	205	145	150	145
query20	119	108	112	108
query21	205	103	103	103
query22	4768	4621	4631	4621
query23	34385	33470	33398	33398
query24	5981	2862	2885	2862
query25	520	394	384	384
query26	612	153	153	153
query27	1607	281	279	279
query28	3640	2051	2032	2032
query29	642	400	398	398
query30	234	148	159	148
query31	930	749	770	749
query32	70	52	52	52
query33	452	286	278	278
query34	883	478	463	463
query35	860	719	721	719
query36	1026	930	933	930
query37	140	85	89	85
query38	4060	3872	3886	3872
query39	1451	1377	1413	1377
query40	202	114	111	111
query41	46	46	45	45
query42	114	95	94	94
query43	505	466	468	466
query44	1106	754	744	744
query45	197	164	169	164
query46	1077	734	748	734
query47	1905	1821	1851	1821
query48	374	292	290	290
query49	794	425	421	421
query50	830	412	415	412
query51	7108	6900	6909	6900
query52	102	89	90	89
query53	246	181	178	178
query54	558	470	456	456
query55	76	73	73	73
query56	267	274	252	252
query57	1207	1087	1059	1059
query58	219	250	227	227
query59	2889	2741	2768	2741
query60	289	266	271	266
query61	105	98	103	98
query62	754	642	670	642
query63	211	183	181	181
query64	1388	671	667	667
query65	3253	3136	3182	3136
query66	678	354	327	327
query67	15949	15393	15294	15294
query68	1193	860	875	860
query69	418	318	324	318
query70	1199	1154	1099	1099
query71	340	338	350	338
query72	4613	3527	3510	3510
query73	597	591	589	589
query74	8970	9006	8875	8875
query75	3009	2941	2969	2941
query76	993	865	850	850
query77	425	395	421	395
query78	9670	10352	9394	9394
query79	906	869	870	869
query80	794	822	811	811
query81	449	261	257	257
query82	261	265	271	265
query83	200	191	192	191
query84	199	105	107	105
query85	624	406	392	392
query86	336	337	309	309
query87	4412	4460	4331	4331
query88	4123	4030	4020	4020
query89	368	359	361	359
query90	833	311	311	311
query91	123	122	124	122
query92	78	82	79	79
query93	914	916	906	906
query94	393	381	354	354
query95	424	413	410	410
query96	465	467	467	467
query97	3121	3149	3135	3135
query98	231	240	231	231
query99	1294	1259	1281	1259
Total cold run time: 293666 ms
Total hot run time: 197140 ms

doris-robot · 2024-09-11T13:29:33Z

ClickBench: Total hot run time: 31.29 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 494c49537930284690b1eb800b495ee84097bda6, data reload: false
query1	0.05	0.04	0.04
query2	0.07	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.07	0.08
query5	0.51	0.50	0.50
query6	1.13	0.74	0.73
query7	0.02	0.01	0.02
query8	0.06	0.04	0.04
query9	0.55	0.49	0.50
query10	0.55	0.56	0.55
query11	0.16	0.12	0.12
query12	0.15	0.13	0.12
query13	0.60	0.60	0.59
query14	1.44	1.38	1.41
query15	0.88	0.83	0.82
query16	0.38	0.35	0.37
query17	1.07	0.98	1.03
query18	0.18	0.17	0.18
query19	1.93	1.71	1.78
query20	0.01	0.01	0.02
query21	15.39	0.66	0.65
query22	3.87	7.82	1.85
query23	18.24	1.39	1.28
query24	2.10	0.23	0.23
query25	0.15	0.09	0.08
query26	0.27	0.18	0.18
query27	0.08	0.08	0.07
query28	13.19	1.02	1.00
query29	12.56	3.36	3.33
query30	0.24	0.06	0.06
query31	2.88	0.41	0.40
query32	3.22	0.48	0.48
query33	2.99	3.02	3.07
query34	17.15	4.40	4.42
query35	4.46	4.47	4.43
query36	0.66	0.49	0.48
query37	0.18	0.15	0.17
query38	0.15	0.14	0.14
query39	0.05	0.04	0.04
query40	0.15	0.14	0.13
query41	0.09	0.05	0.04
query42	0.06	0.04	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.82 s
Total hot run time: 31.29 s

amorynan · 2024-09-12T02:10:25Z

run buildall

github-actions · 2024-09-12T02:16:32Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-09-12T02:43:19Z

TeamCity be ut coverage result:
Function Coverage: 36.89% (9457/25638)
Line Coverage: 28.24% (77757/275377)
Region Coverage: 27.64% (40140/145236)
Branch Coverage: 24.25% (20393/84110)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e87b481e3c42c6d71eb092bf129860d5dcdd423f_e87b481e3c42c6d71eb092bf129860d5dcdd423f/report/index.html

doris-robot · 2024-09-12T02:50:17Z

TPC-H: Total hot run time: 38521 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e87b481e3c42c6d71eb092bf129860d5dcdd423f, data reload: false
------ Round 1 ----------------------------------
q1	17629	4485	4385	4385
q2	2029	193	189	189
q3	11672	963	1145	963
q4	10517	678	776	678
q5	7756	2872	2832	2832
q6	229	142	142	142
q7	970	631	631	631
q8	9317	2095	2135	2095
q9	7104	6650	6654	6650
q10	7016	2243	2242	2242
q11	445	247	241	241
q12	411	230	227	227
q13	17758	3112	3143	3112
q14	281	243	256	243
q15	562	506	493	493
q16	527	434	426	426
q17	979	706	741	706
q18	7336	6960	6965	6960
q19	1394	1082	998	998
q20	671	346	324	324
q21	3963	3147	2965	2965
q22	1122	1019	1059	1019
Total cold run time: 109688 ms
Total hot run time: 38521 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4415	4356	4511	4356
q2	390	271	271	271
q3	2925	2737	2719	2719
q4	1962	1714	1667	1667
q5	5779	5741	5801	5741
q6	240	140	137	137
q7	2235	1860	1812	1812
q8	3348	3539	3522	3522
q9	8954	8941	8938	8938
q10	3698	3410	3408	3408
q11	605	525	520	520
q12	867	683	674	674
q13	13990	3391	3371	3371
q14	319	297	284	284
q15	567	496	490	490
q16	540	498	503	498
q17	1877	1584	1561	1561
q18	8236	8067	7947	7947
q19	1783	1576	1621	1576
q20	2150	1962	1978	1962
q21	5760	5621	5583	5583
q22	1114	1031	1062	1031
Total cold run time: 71754 ms
Total hot run time: 58068 ms

doris-robot · 2024-09-12T03:02:33Z

TPC-DS: Total hot run time: 198173 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e87b481e3c42c6d71eb092bf129860d5dcdd423f, data reload: false
query1	1254	872	907	872
query2	6458	1975	1904	1904
query3	10592	4057	3934	3934
query4	60155	25234	23766	23766
query5	5200	523	516	516
query6	409	176	189	176
query7	5637	303	293	293
query8	321	222	217	217
query9	7796	2502	2500	2500
query10	433	290	259	259
query11	17390	15305	15455	15305
query12	162	128	107	107
query13	1471	411	400	400
query14	10780	7625	7525	7525
query15	208	184	173	173
query16	6681	476	508	476
query17	1114	606	606	606
query18	1479	305	310	305
query19	207	162	155	155
query20	131	114	112	112
query21	210	107	110	107
query22	4715	4465	4667	4465
query23	34635	33555	33899	33555
query24	5998	2891	2891	2891
query25	523	421	426	421
query26	603	157	156	156
query27	1578	279	285	279
query28	3864	2058	2031	2031
query29	719	401	402	401
query30	227	149	160	149
query31	937	754	769	754
query32	69	50	52	50
query33	412	289	295	289
query34	879	479	482	479
query35	850	720	723	720
query36	1092	955	953	953
query37	144	85	83	83
query38	4096	3916	3989	3916
query39	1469	1407	1407	1407
query40	202	114	112	112
query41	46	48	45	45
query42	117	101	94	94
query43	509	483	462	462
query44	1069	754	736	736
query45	198	170	167	167
query46	1115	730	760	730
query47	1944	1834	1843	1834
query48	376	294	296	294
query49	771	438	490	438
query50	851	447	417	417
query51	7011	6920	6847	6847
query52	97	87	85	85
query53	250	183	177	177
query54	548	449	465	449
query55	76	72	75	72
query56	278	254	261	254
query57	1215	1110	1099	1099
query58	224	232	245	232
query59	3021	2831	2914	2831
query60	290	271	270	270
query61	100	97	102	97
query62	743	661	669	661
query63	222	186	201	186
query64	1366	726	672	672
query65	3256	3153	3213	3153
query66	657	351	357	351
query67	16140	15456	15636	15456
query68	1905	859	853	853
query69	426	317	326	317
query70	1188	1163	1121	1121
query71	340	339	335	335
query72	4928	3502	2375	2375
query73	587	589	577	577
query74	9070	8929	8961	8929
query75	3099	2932	3023	2932
query76	925	849	844	844
query77	524	405	399	399
query78	9482	9663	9354	9354
query79	910	875	868	868
query80	792	804	805	804
query81	453	268	270	268
query82	265	261	266	261
query83	193	191	190	190
query84	198	108	109	108
query85	614	413	385	385
query86	328	314	303	303
query87	4417	4333	4325	4325
query88	4285	4029	4117	4029
query89	379	367	365	365
query90	1473	316	305	305
query91	121	123	121	121
query92	75	75	80	75
query93	903	894	896	894
query94	541	347	391	347
query95	420	410	410	410
query96	470	466	464	464
query97	3168	3156	3153	3153
query98	238	242	233	233
query99	1332	1301	1308	1301
Total cold run time: 297639 ms
Total hot run time: 198173 ms

eldenmoon

LGTM but need document

eldenmoon · 2024-09-12T03:06:33Z

we need to detail explain the behavior if encounter null in arrays for the two functions, it's confusing

github-actions · 2024-09-12T03:06:41Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-09-12T03:06:44Z

PR approved by anyone and no changes requested.

doris-robot · 2024-09-12T03:08:05Z

ClickBench: Total hot run time: 32.02 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e87b481e3c42c6d71eb092bf129860d5dcdd423f, data reload: false
query1	0.04	0.05	0.04
query2	0.08	0.04	0.03
query3	0.22	0.05	0.05
query4	1.68	0.08	0.08
query5	0.52	0.51	0.50
query6	1.13	0.75	0.74
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.54	0.49	0.48
query10	0.55	0.56	0.54
query11	0.15	0.11	0.11
query12	0.16	0.13	0.12
query13	0.62	0.59	0.59
query14	1.42	1.42	1.41
query15	0.85	0.84	0.83
query16	0.38	0.39	0.39
query17	1.07	1.06	1.08
query18	0.18	0.18	0.18
query19	1.88	1.89	1.84
query20	0.01	0.02	0.01
query21	15.39	0.67	0.68
query22	4.67	7.29	1.88
query23	18.31	1.38	1.38
query24	2.17	0.21	0.22
query25	0.15	0.08	0.08
query26	0.27	0.18	0.18
query27	0.08	0.08	0.07
query28	13.27	1.03	1.00
query29	12.61	3.44	3.45
query30	0.24	0.07	0.07
query31	2.85	0.40	0.41
query32	3.23	0.49	0.49
query33	2.96	3.04	3.05
query34	16.82	4.49	4.47
query35	4.47	4.52	4.50
query36	0.66	0.51	0.48
query37	0.19	0.16	0.16
query38	0.15	0.14	0.15
query39	0.05	0.04	0.04
query40	0.16	0.13	0.13
query41	0.09	0.04	0.04
query42	0.06	0.05	0.05
query43	0.05	0.05	0.05
Total cold run time: 110.45 s
Total hot run time: 32.02 s

amorynan · 2024-09-12T06:36:40Z

run cloud_p0

array_match_all means that every element in array column should all match filter according to lambda expr array_match_any means that any element in array column match filter according to lambda expr

array_match_all means that every element in array column should all match filter according to lambda expr array_match_any means that any element in array column match filter according to lambda expr ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test  - [x] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason  - Behavior changed: - [x] No. - [ ] Yes.  - Does this need documentation? - [ ] No. - [ ] Yes.  ### Check List (For Reviewer who merge this PR) - [x] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label

array_match_all means that every element in array column should all match filter according to lambda expr array_match_any means that any element in array column match filter according to lambda expr

support array_match_all/any
f3f350f

github-actionsBot reviewed Sep 10, 2024
View reviewed changes

Comment threadbe/src/vec/exprs/lambda_function/varray_match_function.cpp Outdated
Comment threadbe/src/vec/exprs/lambda_function/varray_match_function.cpp Outdated
Comment threadbe/src/vec/exprs/lambda_function/varray_match_function.cpp Outdated

morrySnow reviewed Sep 10, 2024
View reviewed changes

fix signature
eb746b9

update data file
b08ec5e

eldenmoon reviewed Sep 11, 2024
View reviewed changes

Comment threadbe/src/vec/exprs/lambda_function/varray_match_function.cpp Outdated

eldenmoon reviewed Sep 11, 2024
View reviewed changes

Comment threadbe/src/vec/exprs/lambda_function/varray_match_function.cpp Outdated

fix nereid
494c495

eldenmoon reviewed Sep 11, 2024
View reviewed changes

Comment threadregression-test/suites/nereids_function_p0/scalar_function/Array.groovy

morrySnow reviewed Sep 11, 2024
View reviewed changes

Comment thread.../src/main/java/org/apache/doris/nereids/trees/expressions/visitor/ScalarFunctionVisitor.java Outdated
Comment threadfe/fe-core/src/main/java/org/apache/doris/catalog/BuiltinScalarFunctions.java Outdated

fix all
e87b481

eldenmoon approved these changes Sep 12, 2024
View reviewed changes

github-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Sep 12, 2024

amorynan requested a review from morrySnow September 12, 2024 08:47

morrySnow approved these changes Sep 12, 2024
View reviewed changes

eldenmoon merged commit 7a34ebb into apache:masterSep 12, 2024

eldenmoon added dev/3.0.x dev/2.1.x and removed dev/2.1.x labels Nov 1, 2024

gavinchou mentioned this pull request Nov 26, 2024
Release Note 3.0.3 #44522
Closed

eldenmoon removed the dev/3.0.x label Mar 6, 2025

-super("array_match_all", arginstanceofLambda ? arg.child(1).child(0) : arg, newArrayMap(arg));
-if (!(arginstanceofLambda)) {
-thrownewAnalysisException(
-String.format("The 1st arg of %s must be lambda but is %s", getName(), arg));
- }
+super("array_match_all", arginstanceofLambda ? newArrayMap(arg) : arg);

		@@ -0,0 +1,68 @@
		// Licensed to the Apache Software Foundation (ASF) under one

Uh oh!

Conversation

amorynan commented Sep 10, 2024

Proposed changes

Uh oh!

doris-robot commented Sep 10, 2024

Uh oh!

amorynan commented Sep 10, 2024

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

doris-robot commented Sep 10, 2024

Uh oh!

Uh oh!

Uh oh!

morrySnowSep 10, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

morrySnowSep 10, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

doris-robot commented Sep 10, 2024

Uh oh!

doris-robot commented Sep 10, 2024

Uh oh!

doris-robot commented Sep 10, 2024

Uh oh!

Uh oh!

eldenmoonSep 11, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

amorynan commented Sep 11, 2024

Uh oh!

github-actionsBot commented Sep 11, 2024

Uh oh!

doris-robot commented Sep 11, 2024

Uh oh!

eldenmoonSep 11, 2024

Choose a reason for hiding this comment

Uh oh!

eldenmoonSep 12, 2024

Choose a reason for hiding this comment

Uh oh!

doris-robot commented Sep 11, 2024

Uh oh!

doris-robot commented Sep 11, 2024

Uh oh!

doris-robot commented Sep 11, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

amorynan commented Sep 12, 2024

Uh oh!

github-actionsBot commented Sep 12, 2024

Uh oh!

doris-robot commented Sep 12, 2024

Uh oh!

doris-robot commented Sep 12, 2024

Uh oh!

doris-robot commented Sep 12, 2024

Uh oh!

eldenmoon left a comment

Choose a reason for hiding this comment

Uh oh!

eldenmoon commented Sep 12, 2024

Uh oh!

github-actionsBot commented Sep 12, 2024

Uh oh!

github-actionsBot commented Sep 12, 2024

Uh oh!

doris-robot commented Sep 12, 2024

eldenmoonSep 11, 2024•
edited
Loading