[Bug](rpad) should check_chars_length avoid exceed max_string_size in pad function by zhangstar333 · Pull Request #40676 · apache/doris

zhangstar333 · 2024-09-11T08:32:43Z

Proposed changes

this pr #40162 introduced,
and have test case in P1, regression-test/suites/query_p1/test_big_pad.groovy

… pad function

doris-robot · 2024-09-11T08:32:47Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

zhangstar333 · 2024-09-11T08:32:53Z

run buildall

doris-robot · 2024-09-11T09:06:43Z

TeamCity be ut coverage result:
Function Coverage: 36.88% (9451/25624)
Line Coverage: 28.25% (77743/275155)
Region Coverage: 27.65% (40125/145116)
Branch Coverage: 24.26% (20386/84022)
Coverage Report: http://coverage.selectdb-in.cc/coverage/481c775e7424383278ba0e761307cca32bbacf51_481c775e7424383278ba0e761307cca32bbacf51/report/index.html

doris-robot · 2024-09-11T09:16:32Z

TPC-H: Total hot run time: 37927 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 481c775e7424383278ba0e761307cca32bbacf51, data reload: false
------ Round 1 ----------------------------------
q1	17661	4353	4350	4350
q2	2018	191	202	191
q3	11647	950	1014	950
q4	10523	782	730	730
q5	7796	2855	2818	2818
q6	225	137	134	134
q7	962	627	627	627
q8	9324	2060	2073	2060
q9	6922	6543	6552	6543
q10	7017	2212	2169	2169
q11	458	241	240	240
q12	400	221	222	221
q13	18206	3076	3105	3076
q14	284	238	238	238
q15	548	496	497	496
q16	521	430	431	430
q17	978	615	754	615
q18	7369	6851	6895	6851
q19	1391	1069	977	977
q20	653	328	327	327
q21	3962	2936	2874	2874
q22	1120	1012	1010	1010
Total cold run time: 109985 ms
Total hot run time: 37927 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4411	4329	4301	4301
q2	376	272	279	272
q3	2910	2653	2652	2652
q4	1955	1614	1656	1614
q5	5583	5701	5695	5695
q6	241	133	134	133
q7	2223	1793	1823	1793
q8	3293	3440	3464	3440
q9	8833	8871	8814	8814
q10	3607	3374	3368	3368
q11	626	527	500	500
q12	835	660	682	660
q13	14233	3214	3301	3214
q14	327	293	297	293
q15	530	506	502	502
q16	532	503	503	503
q17	1871	1550	1539	1539
q18	8265	7787	7983	7787
q19	1751	1668	1524	1524
q20	2174	1880	1900	1880
q21	5667	5415	5522	5415
q22	1133	1070	1023	1023
Total cold run time: 71376 ms
Total hot run time: 56922 ms

zhangstar333 · 2024-09-11T11:07:46Z

run buildall

doris-robot · 2024-09-11T11:54:18Z

TPC-H: Total hot run time: 38510 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 481c775e7424383278ba0e761307cca32bbacf51, data reload: false
------ Round 1 ----------------------------------
q1	17709	4526	4379	4379
q2	2038	190	189	189
q3	11291	994	1130	994
q4	10519	729	691	691
q5	7775	2912	2897	2897
q6	236	141	139	139
q7	980	627	643	627
q8	9332	2084	2122	2084
q9	7161	6626	6622	6622
q10	7040	2181	2244	2181
q11	455	256	247	247
q12	403	231	227	227
q13	18946	3085	3087	3085
q14	284	235	253	235
q15	550	507	490	490
q16	546	426	426	426
q17	999	708	720	708
q18	7418	6862	6885	6862
q19	1396	1006	1057	1006
q20	686	337	331	331
q21	4189	3141	3052	3052
q22	1108	1058	1038	1038
Total cold run time: 111061 ms
Total hot run time: 38510 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4411	4346	4911	4346
q2	391	284	264	264
q3	2927	2648	2649	2648
q4	1956	1678	1739	1678
q5	5704	5723	5790	5723
q6	246	136	134	134
q7	2159	1861	1792	1792
q8	3295	3461	3513	3461
q9	8970	8964	8782	8782
q10	3644	3429	3370	3370
q11	593	512	501	501
q12	864	657	664	657
q13	14133	3194	3251	3194
q14	325	286	287	286
q15	554	487	496	487
q16	559	504	530	504
q17	1876	1545	1542	1542
q18	8243	7924	7738	7738
q19	1023	1012	1010	1010
q20	2032	2002	1966	1966
q21	5276	5251	5284	5251
q22	1122	1090	1069	1069
Total cold run time: 70303 ms
Total hot run time: 56403 ms

doris-robot · 2024-09-11T12:01:05Z

TeamCity be ut coverage result:
Function Coverage: 36.90% (9455/25626)
Line Coverage: 28.24% (77751/275279)
Region Coverage: 27.64% (40131/145175)
Branch Coverage: 24.25% (20390/84068)
Coverage Report: http://coverage.selectdb-in.cc/coverage/481c775e7424383278ba0e761307cca32bbacf51_481c775e7424383278ba0e761307cca32bbacf51/report/index.html

doris-robot · 2024-09-11T12:06:31Z

TPC-DS: Total hot run time: 197079 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 481c775e7424383278ba0e761307cca32bbacf51, data reload: false
query1	1242	882	900	882
query2	6314	1894	1857	1857
query3	10603	4055	4002	4002
query4	59718	29021	23125	23125
query5	5007	493	497	493
query6	394	160	164	160
query7	5630	294	290	290
query8	330	229	219	219
query9	7537	2514	2499	2499
query10	426	298	252	252
query11	17516	15102	15365	15102
query12	150	105	100	100
query13	1456	426	401	401
query14	10876	7508	7427	7427
query15	230	178	168	168
query16	6829	488	460	460
query17	1111	602	575	575
query18	1574	284	286	284
query19	204	149	146	146
query20	123	110	104	104
query21	219	104	103	103
query22	4828	4365	4780	4365
query23	34205	33332	33359	33332
query24	5968	2887	2874	2874
query25	495	388	380	380
query26	617	154	152	152
query27	1619	270	276	270
query28	3618	2067	2042	2042
query29	631	398	425	398
query30	242	156	154	154
query31	920	751	748	748
query32	68	53	52	52
query33	388	284	281	281
query34	882	465	463	463
query35	842	723	724	723
query36	1046	922	931	922
query37	158	86	80	80
query38	3907	3914	3856	3856
query39	1487	1410	1397	1397
query40	200	118	113	113
query41	47	47	44	44
query42	119	96	95	95
query43	510	462	466	462
query44	1080	745	738	738
query45	191	164	161	161
query46	1083	727	720	720
query47	1909	1765	1804	1765
query48	365	291	285	285
query49	768	437	441	437
query50	829	408	428	408
query51	6919	6991	6836	6836
query52	100	84	84	84
query53	248	183	184	183
query54	561	491	449	449
query55	76	73	76	73
query56	274	247	252	247
query57	1206	1064	1103	1064
query58	223	253	267	253
query59	2860	2733	2658	2658
query60	291	259	265	259
query61	101	97	100	97
query62	776	650	656	650
query63	213	183	182	182
query64	1351	675	728	675
query65	3234	3149	3155	3149
query66	614	343	345	343
query67	15874	15461	15378	15378
query68	1639	856	850	850
query69	427	325	317	317
query70	1211	1187	1151	1151
query71	349	337	343	337
query72	4556	3512	3558	3512
query73	588	581	576	576
query74	8928	8884	9026	8884
query75	3046	2952	2926	2926
query76	984	846	848	846
query77	400	402	393	393
query78	9325	9175	9570	9175
query79	906	871	855	855
query80	817	815	804	804
query81	452	254	255	254
query82	268	261	260	260
query83	191	187	187	187
query84	198	105	105	105
query85	617	505	389	389
query86	305	321	320	320
query87	4372	4299	4309	4299
query88	4159	4051	4049	4049
query89	372	364	367	364
query90	777	306	307	306
query91	122	124	124	124
query92	79	78	75	75
query93	927	923	918	918
query94	399	378	352	352
query95	418	410	418	410
query96	472	473	467	467
query97	3115	3095	3095	3095
query98	230	233	228	228
query99	1274	1311	1305	1305
Total cold run time: 293355 ms
Total hot run time: 197079 ms

doris-robot · 2024-09-11T12:12:02Z

ClickBench: Total hot run time: 31.96 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 481c775e7424383278ba0e761307cca32bbacf51, data reload: false
query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.06	0.04
query4	1.66	0.07	0.09
query5	0.50	0.50	0.50
query6	1.12	0.73	0.72
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.54	0.49	0.48
query10	0.54	0.55	0.55
query11	0.15	0.11	0.12
query12	0.14	0.12	0.11
query13	0.60	0.59	0.60
query14	1.41	1.43	1.43
query15	0.84	0.81	0.82
query16	0.37	0.38	0.37
query17	0.99	1.00	0.97
query18	0.18	0.17	0.18
query19	1.87	1.81	1.78
query20	0.01	0.01	0.01
query21	15.43	0.66	0.65
query22	4.58	6.65	2.35
query23	18.25	1.43	1.36
query24	2.14	0.22	0.21
query25	0.14	0.08	0.08
query26	0.26	0.17	0.18
query27	0.08	0.08	0.08
query28	13.18	1.01	1.00
query29	12.59	3.33	3.33
query30	0.24	0.06	0.05
query31	2.86	0.42	0.39
query32	3.24	0.48	0.48
query33	2.97	3.06	3.01
query34	17.12	4.42	4.41
query35	4.52	4.49	4.47
query36	0.66	0.47	0.50
query37	0.18	0.16	0.16
query38	0.16	0.15	0.15
query39	0.05	0.04	0.04
query40	0.16	0.13	0.13
query41	0.10	0.04	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 110.36 s
Total hot run time: 31.96 s

github-actions · 2024-09-12T06:46:14Z

PR approved by anyone and no changes requested.

HappenLee

LGTM

github-actions · 2024-09-12T16:04:42Z

PR approved by at least one committer and no changes requested.

… pad function (#40676) ## Proposed changes this pr #40162 introduced, and have test case in P1, regression-test/suites/query_p1/test_big_pad.groovy

… pad function (apache#40676) ## Proposed changes this pr apache#40162 introduced, and have test case in P1, regression-test/suites/query_p1/test_big_pad.groovy

[Bug](rpad) should check_chars_length avoid exceed max_string_size in…
481c775
… pad function

Mryange approved these changes Sep 12, 2024
View reviewed changes

github-actionsBot added the reviewed label Sep 12, 2024

HappenLee approved these changes Sep 12, 2024
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 12, 2024

zhangstar333 merged commit 72ce469 into apache:masterSep 13, 2024

dataroaring added the dev/3.0.3-merged label Oct 13, 2024

Navigation Menu

Uh oh!

[Bug](rpad) should check_chars_length avoid exceed max_string_size in pad function - #40676

[Bug](rpad) should check_chars_length avoid exceed max_string_size in pad function#40676
zhangstar333 merged 1 commit into
apache:masterfrom
zhangstar333:rpad

zhangstar333 commented Sep 11, 2024

Uh oh!

doris-robot commented Sep 11, 2024

Uh oh!

zhangstar333 commented Sep 11, 2024

Uh oh!

doris-robot commented Sep 11, 2024

Uh oh!

doris-robot commented Sep 11, 2024

Uh oh!

zhangstar333 commented Sep 11, 2024

Uh oh!

doris-robot commented Sep 11, 2024

Uh oh!

doris-robot commented Sep 11, 2024

Uh oh!

doris-robot commented Sep 11, 2024

Uh oh!

doris-robot commented Sep 11, 2024

Uh oh!

github-actionsBot commented Sep 12, 2024

Uh oh!

HappenLee left a comment

Uh oh!

github-actionsBot commented Sep 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

zhangstar333 commented Sep 11, 2024

Proposed changes

Uh oh!

doris-robot commented Sep 11, 2024

Uh oh!

zhangstar333 commented Sep 11, 2024

Uh oh!

doris-robot commented Sep 11, 2024

Uh oh!

doris-robot commented Sep 11, 2024

Uh oh!

zhangstar333 commented Sep 11, 2024

Uh oh!

doris-robot commented Sep 11, 2024

Uh oh!

doris-robot commented Sep 11, 2024

Uh oh!

doris-robot commented Sep 11, 2024

Uh oh!

doris-robot commented Sep 11, 2024

Uh oh!

github-actionsBot commented Sep 12, 2024

Uh oh!

HappenLee left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Sep 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants